danfengliu
275a917dbf
add Capture Page Screenshot in retry keyword ( #6897 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-02-13 14:48:09 +08:00
wang yan
c77b387c53
Upgrade registry binary to v2.7.0
...
Signed-off-by: wang yan <wangyan@vmware.com>
2019-02-13 10:24:08 +08:00
yeya24
628b94db19
fix some typos
...
Signed-off-by: yeya24 <ben.ye@daocloud.io>
2019-02-05 12:03:52 +08:00
jwangyangls
3d726219e5
Merge pull request #6758 from jwangyangls/privilege_escalation
...
user permission change and add master role
2019-01-31 18:57:22 +08:00
System Administrator
1a551690d3
promission reset
...
Signed-off-by: Yogi_Wang <wang1084@126.com>
2019-01-31 18:06:49 +08:00
danfengliu
47530cd62e
remove some sleep and add retry common keyword ( #6875 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-31 17:58:05 +08:00
danfengliu
e5efbfe490
add retry keyword for docker pull and push image command. ( #6857 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-31 16:08:58 +08:00
danfengliu
e12fd13c56
Encapsulate keyword <element click> and add it into keyword <Go Back To Versions And Delete>, this porblem caused case failure of <List Helm Charts> randomly. ( #6834 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-30 14:22:31 +08:00
Daniel Jiang
bf663df0e7
Merge pull request #6820 from wy65701436/robot-service
...
Add robot account authn & authz implementation
2019-01-29 16:08:25 +08:00
He Weiwei
1da0a66fe5
Merge pull request #6781 from heww/user-permissions-api
...
Implement api for get current user permissions
2019-01-29 01:58:51 +08:00
He Weiwei
8b5e68073d
Implement api for get current user permissions
...
Signed-off-by: He Weiwei <hweiwei@vmware.com>
2019-01-28 18:06:52 +08:00
Yan
71f37fb820
* Add robot account authn & authz implementation.
...
This commit is to add the jwt token service, and do the authn & authz for robot account.
Signed-off-by: wang yan <wangyan@vmware.com>
2019-01-28 17:39:57 +08:00
danfengliu
9aeb626fe3
The former way to verify project creation is by API calling, but it's not a GUI operation, which is not a goal for operator, so I replace it with GUI verification ( #6816 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-28 16:32:45 +08:00
danfengliu
923432a172
resort test case, 2 test cases failed due to unfinish chart data preparation, so resort the test cases, move the verification test case ahead of the 2 failed cases. ( #6818 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-25 10:26:14 +08:00
danfengliu
b0c1adab8d
add retry for make swagger client ( #6813 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-24 17:09:32 +08:00
danfengliu
257eebfebe
Add space adaptor for regexp when create a new project, we loose the criteria to match the project name because the return json datat may be shown in different lines . ( #6768 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-24 09:38:46 +08:00
danfengliu
f29960628a
Keyword <Go Into Project> has modified, but verify.robot didn't adapt this keyword.
...
Modifications:
1.Add paramenter hasimage in data.json
2.Modify Harbor-Pages\Verify.robot to pass it to <Go Into Project>
3.Add loop and exception-catch in <Go Into Project> to prevent using Sleep and failure by exception(this exception was caused by short time of paga loading)
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-17 17:46:17 +08:00
danfengliu
fd5e109583
add wait until in keyword <Create An New Project>
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-15 17:46:46 +08:00
Wenkai Yin
60425676ac
Merge pull request #6733 from danfengliu/Add-WaitUntil-In-Keywords-Stage2
...
Add wait until in <Multi-delete Object> and <Project Should Display>
2019-01-14 17:22:39 +08:00
danfengliu
73b9e95464
Add wait until in <Multi-delete Object> and <Project Should Display>
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-14 15:19:30 +08:00
danfengliu
de30438d01
modify a code error by copy mistake ( #6736 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-14 11:02:11 +08:00
Daniel Jiang
a1d4bfd332
Merge pull request #6344 from reasonerjt/bump-up-golang
...
Bump up golang to 1.11.2
2019-01-11 16:15:59 +08:00
Daniel Jiang
5d59d6fab8
Bump up golang to 1.11.2
...
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2019-01-11 14:44:32 +08:00
danfengliu
0b27037e34
Two modifications in PR:1. Due to GUI change on position of "project creation" configuration, script must be adjust with the corresponding change; 2. Fixed a issue of no exception caught when http request has error, all the system config will be set by a common request function. ( #6715 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-11 13:40:08 +08:00
System Administrator
27c180bf20
fix_bug
...
Signed-off-by: Yogi_Wang <wang1084@126.com>
2019-01-11 11:00:46 +08:00
Wenkai Yin
60a58cba11
Merge pull request #6619 from danfengliu/robot-script-refector-of-sign-in-harbor
...
Robot script refactor for keyword sign-in-harbor
2019-01-10 13:42:15 +08:00
jwangyangls
07ad9d1dd5
Merge pull request #6701 from jwangyangls/upgrade_clr_1.0.3_issue
...
Upgrade clr 1.0.0 issue
2019-01-08 14:17:17 +08:00
danfengliu
d853adce46
Robot scripts refactor for keyword sign-in-harbor and other few keywords, mainly on replacing 'sleep' to 'wait until', and also add a checkpoint in "Go Into Project" keyword to verify the result of loading a project page.
...
Modify Switch To Log and Back To projects
Signed-off-by: danfengliu <danfengl@vmware.com>
2019-01-08 13:44:14 +08:00
Yogi_Wang
10d74eabd7
upgrade clarity components to 1.0 and fix issue
...
Signed-off-by: Yogi_Wang <Yogiwang@Yogi-WangdeMacBook-Pro.local>
2019-01-08 12:50:26 +08:00
FangyuanCheng
55e868bd9f
fix test case for project link
...
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2019-01-08 11:28:03 +08:00
Yogi_Wang
aee07fff96
upgrade clarity components to 1.0
...
Signed-off-by: Yogi_Wang <Yogiwang@Yogi-WangdeMacBook-Pro.local>
2019-01-03 10:32:52 +08:00
FangyuanCheng
9a52059e89
fix nightly test of retag
...
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2018-12-21 17:34:15 +08:00
danfengliu
70016cc0eb
Change a small docker image to pull and make timeout value longer ( #6543 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-12-18 10:21:03 +08:00
James Zabala
6ac0c4b882
Merge pull request #6416 from danfengliu/Modify-Test-Script-Project-Level-Policy-Content-Trust
...
Remove redundant functions
2018-12-12 11:19:35 -05:00
Mia ZHOU
06eec7b3ed
Merge pull request #6479 from zhoumeina/fix_scan_log_nightly
...
quick fix for scan log
2018-12-07 14:39:29 +08:00
Meina Zhou
7827f19671
quick fix for scan log
...
This is a quick fix
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-12-07 12:29:15 +08:00
wang yan
109350a8c3
Fix robot framework version to 3.0.4
...
As pip will always install the latest version, to avoid any break change,
just fix the framework to 3.0.4
Signed-off-by: wang yan <wangyan@vmware.com>
2018-12-07 11:45:57 +08:00
danfengliu
7c57864c99
Remove 2 redundant functions, pull_harbor_image_successfully and pull_harbor_image_unsuccessfully.
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-12-04 13:46:07 +08:00
danfengliu
3356368bff
Add API test case assign system admin role. ( #6413 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-12-04 12:26:12 +08:00
Qian Deng
7d4de8743b
Fix: Rebotcase failure in upload chart ( #6411 )
...
Fix testcase because of wrong keyword
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-12-03 18:49:07 +08:00
danfengliu
b4c7663f5f
Add API test case scan all images and test case API test case list helm charts. ( #6388 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-12-03 17:05:06 +08:00
Mia ZHOU
a90fb5219c
Merge pull request #6394 from ninjadq/fix_robot_cases_for_global_search
...
Fix xpath in go to project robot case
2018-11-30 16:43:55 +08:00
Qian Deng
9dd509e0eb
Fix xpath in go to project robot case
...
Global search bug fix introduced test case failure, fix it by edit xpath
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-11-30 15:33:14 +08:00
Wenkai Yin
9d5cf57373
Check the existence of name when creating replication rule and fix bugs in testing library ( #6381 )
...
1. Fix #5102 by checking the existence of name when creating/editing replication rule
2. Add unique constraint to the name of replication policy and target
3. Fix bugs of testing library
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-11-30 13:32:20 +08:00
danfengliu
04fd4d444d
Add API test case for user view logs. ( #6370 )
...
Add API test case for user view logs.
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-29 18:27:53 +08:00
Mia ZHOU
3c000f10a0
Merge pull request #6338 from ninjadq/fix_chart_ui_related_issues
...
Fix chart ui related issues
2018-11-29 10:11:44 +08:00
danfengliu
c4bf65162c
add api test case for garbage collection ( #6366 )
...
Add API test case for garbage collection, and add swagger.yaml, GC and chart feature were updated in swagger.yaml.
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-27 19:17:41 +08:00
Qian Deng
8ca917291e
Fix: upload chart version testcase failure in nightly
...
This is because after 2 seconds the modal still exist
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-11-23 17:03:15 +08:00
danfengliu
ad77098acf
add test case project level policy content trust. ( #6309 )
...
Add test case project level policy content trust.
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-21 12:19:28 +08:00
Mia ZHOU
88cab5bc35
Merge pull request #6306 from pureshine/fy-test
...
Add E2E test for build history
2018-11-21 10:24:57 +08:00
danfengliu
5ceebcbb10
Add tese case of manage project memebers and modify ( #6304 )
...
Move admin_client to testutil.py as global parameter.
Change create_repository function name to push_image_to_project to make it reasonable.
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-20 14:24:13 +08:00
FangyuanCheng
e7b8fb8f04
Add E2E test for build history
...
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2018-11-20 13:39:57 +08:00
danfengliu
9a46d6b3ac
Add elif to if condition to make if condition as one sentence, so return code is accurate for each sentence. ( #6291 )
...
Remove a space.
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-19 13:11:44 +08:00
Fangyuan Cheng
bbee74eba4
Merge pull request #6298 from pureshine/retag-test
...
Add E2E test for retag
2018-11-19 12:52:48 +08:00
FangyuanCheng
34dee765ec
Add E2E test for retag
...
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
2018-11-19 12:20:19 +08:00
danfengliu
dcd34a37a9
add test case scan a not scanned image
...
Modify for codacy issues.
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-16 15:35:15 +08:00
Qian Deng
c716ebba59
Fix testcase of helm chart delete
...
Fix delete helm chart testcase
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-11-15 11:11:14 +08:00
danfengliu
1cc04183cb
add test case for edit project creation;
...
fixed some space and import issues coddcy;
remove a lib;
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-15 10:32:21 +08:00
Qian Deng
6d1163f592
Fix: Nightly test fail from time to time
...
Sometimes the time span of back to helm chart list is longer then 2 seconds.
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-11-13 17:22:12 +08:00
danfengliu
90fda71e4a
Recovery repository.py for calling wrong create function ( #6268 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-13 12:53:46 +08:00
danfengliu
6289275118
Modify script call create project ( #6263 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-12 23:39:16 +08:00
danfengliu
205a658afb
Only modify lib-project for seq of return ( #6261 )
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-12 16:59:55 +08:00
Mia ZHOU
08081d38fa
modify test ldap button xpath ( #6236 )
...
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-11-08 13:44:13 +08:00
danfengliu
7494050534
add test case name in API_DB
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-08 10:33:14 +08:00
danfengliu
ce8a585858
modfiy repo
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-08 10:33:14 +08:00
danfengliu
9265754936
modify codacy errors in target
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-08 10:33:14 +08:00
danfengliu
a6151175e3
add lib for target
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-08 10:33:14 +08:00
danfengliu
e6f5f62c53
Modify for codacy again
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-08 10:33:14 +08:00
danfengliu
0b84ec84d9
Modify for codacy
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-08 10:33:14 +08:00
danfengliu
660bfdf677
add test case of add a replication rule
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-08 10:33:14 +08:00
Wenkai Yin
55c609b1a7
Update automation test case ( #6221 )
...
1. Add "Wait Until ..." to "Change User Role In Project"
2. Rename case name to "Scan Image On Push"
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-11-07 13:08:32 +08:00
Wenkai Yin
8c376ac55a
Merge pull request #6205 from ywk253100/181102_case
...
Check the vul data before running scan-on-push case
2018-11-05 21:09:26 +08:00
danfengliu
342a1051db
Merge pull request #6197 from danfengliu/add-tc-del-label
...
Add test cases <add global label to a image> and <delete repository>.
2018-11-02 18:46:19 +08:00
Wenkai Yin
40f8f4bc5d
Check the vul data before running scan-on-push case
...
Update the automation case to wait until the vul data is ready before running the scan-on-push case
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-11-02 17:54:47 +08:00
danfengliu
1979d17550
add tc add-sys-label-to-tag and del-repo
...
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-11-02 17:16:43 +08:00
Mia ZHOU
c920b025fa
fix the typpo error in nightly test case ( #6200 )
...
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-11-02 09:14:57 +08:00
Meina Zhou
0ba9856c66
fix nightly test
...
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-11-01 14:07:55 +08:00
danfengliu
894e0591bb
add new api tests ( #6127 )
...
Add API test libraries which were based on swagger doc,
it's including user and project , also add one scenario
test case which is test_add_member_to_private_project to
verify a user can see a project when the uesr is the member of it.
Delete 2 old test case.Delete a quota.
Signed-off-by: danfengliu <danfengl@vmware.com>
2018-10-31 13:13:31 +08:00
wang yan
2ef11c396a
Fix failure on GC test case
...
As the changes on scan all, the default schedule was removed from source code,
hence the gc job should be the first admin job, to change to job id to 1.
Signed-off-by: wang yan <wangyan@vmware.com>
2018-10-29 14:15:06 +08:00
Meina Zhou
b68dd47a20
modify test case since replication log change to popup a new page
...
Signed-off-by: Meina Zhou <meinaz@vmware.com>
2018-10-26 16:20:00 +08:00
Wenkai Yin
6c033574fa
Update automation test case "Delete Multi Project" ( #6116 )
...
Add "Wait Until xxx" to wait the expected page appear before the next step to avoid the case failure
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-24 15:37:36 +08:00
Wenkai Yin
f5166431be
Update automation test case "Delete Repo" ( #6087 )
...
Replace the "Sleep x seconds" with "Wait Until xxx" in the "Delete Repo" case
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-23 09:08:54 +08:00
Wenkai Yin
96d260a379
Add debug info to automation test case ( #6092 )
...
Add "Capture Page Screenshot" to help debug the case failure
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-23 09:08:33 +08:00
Mia ZHOU
c13a0bfaae
Merge pull request #6088 from pureshine/fixed_bug
...
Vulnerability scan cancel editing to make UI into orginal status
2018-10-23 08:39:32 +08:00
Cheng Fangyuan
8b6e72e56e
Vulnerability scan cancel editing to make UI into orginal status
...
Signed-off-by: Cheng Fangyuan <fangyuanc@fangyuanc-a01.vmware.com>
2018-10-19 13:14:43 +08:00
Daniel Jiang
1b8dd0cb56
Merge pull request #6006 from wy65701436/upload-logs
...
Add step to upload travis logs into GCR
2018-10-19 12:52:10 +08:00
Steven Zou
db24cbe25a
Merge pull request #5779 from cd1989/images-retag
...
Merge Images retag
2018-10-19 11:04:48 +08:00
陈德
a1b4729aa7
Add more unit tests
...
Signed-off-by: 陈德 <chende@caicloud.io>
2018-10-18 00:26:25 +08:00
wang yan
f44ff2e4c3
Remove the env GODEBUG=netdns=cgo
...
This env is the workaroud of dns resolver on golang 1.7.3.
Remove it is bacause of harbor is using golang 1.9.2, the bug
has already been fixed.
Signed-off-by: wang yan <wangyan@vmware.com>
2018-10-17 16:11:25 +08:00
Wenkai Yin
69825093b0
Update CI script run in Drone ( #6053 )
...
Publish images to docker hub with dev tag only for master branch changes
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-16 17:37:13 +08:00
Wenkai Yin
20a6a8738e
Merge pull request #6030 from wy65701436/add-gc-e2e
...
add gc e2e test case
2018-10-16 15:43:35 +08:00
wang yan
3ef52cafd4
Add gc e2e test case
...
Signed-off-by: wang yan <wangyan@vmware.com>
2018-10-16 14:31:57 +08:00
Wenkai Yin
16c9ffad2c
Update automation test case "Project Level Image Serverity Policy" ( #6037 )
...
Currently, the case "Project Level Image Serverity Policy" uses the project library as the target project, but the project library has been set to scan image automatically when images are pushing, this will cause case failure. This commit creates a new project in the case to aviod the failure.
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-16 09:01:23 +08:00
Wenkai Yin
b650bf0d04
Update automation test case "Make Project Public/Private" ( #6028 )
...
Add "Wait Until" to ensure the "Save" button is clicked
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-12 18:29:38 +08:00
Daniel Jiang
05e5105c46
Merge pull request #6024 from ywk253100/181012_case
...
Update scan automation test case
2018-10-12 16:44:11 +08:00
Wenkai Yin
4e8506de34
Update golint repository used in travis
...
The golint repository is updated, this commit changes it with the latest version
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-12 14:11:35 +08:00
Wenkai Yin
7e3ae5cb11
Update scan automation test case
...
Replace image hello-world with busybox as the hello-world has been scaned in the last case
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-12 11:22:43 +08:00
Wenkai Yin
00acb507ba
Update automation test cases
...
Update the case to pass nightly testing for Harbor chart
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-11 15:29:43 +08:00
Wenkai Yin
32c4392b3b
Update test cases ( #6011 )
...
Update the automation test cases to pass the nightly testing
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-11 10:39:25 +08:00
wang yan
d86692d61c
Add step to upload travis logs into GCR
...
Signed-off-by: wang yan <wangyan@vmware.com>
2018-10-10 19:03:19 +08:00
Wenkai Yin
d1981d23b1
Update automation test cases ( #5991 )
...
Longer the wait time to pass the nightly testing
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-10-10 10:38:48 +08:00
Steven Zou
bb73e64f5d
Revert the changes to the travis pipeline to fix the build failure
...
Signed-off-by: Steven Zou <szou@vmware.com>
2018-09-27 15:11:20 +08:00
Yan
6c00747390
Enable travis to update logs to GSR ( #5949 )
...
1, add encrypt file to store gsutil keys.
2, add function to call gsutil to update logs into harbor log bucket.
Signed-off-by: wangyan <wy65701436@gmail.com>
2018-09-27 08:54:56 +08:00
De Chen
e3b061c415
Fix the Makefile for MacOS to run harbor locally for dev ( #5502 )
...
* fix sed -i in MacOS, BSD sed and Linux sed are different, use sed -i -e instead
* change target name from version to ui_version
* fix cleandockercomposefile target to clean all generated docker-compose files
Signed-off-by: 陈德 <chende@caicloud.io>
2018-09-25 15:12:43 +08:00
Cheng
9250b1b351
../../tests/resources/Harbor-Pages/Configuration.robot
...
Signed-off-by: Cheng <1309173081@qq.com>
2018-09-25 13:40:17 +08:00
wang yan
18411349b5
Add installer pipeline in travis
...
Signed-off-by: wang yan <wangyan@vmware.com>
2018-09-21 17:20:54 +08:00
Wenkai Yin
978f8721e6
Merge pull request #5927 from steven-zou/return_labels_in_chart_api
...
Refactor the chart service implementation to provide more extending flexibilities
2018-09-21 15:59:53 +08:00
Qian Deng
0cb430d463
Merge pull request #5932 from ninjadq/refactor_auth_api
...
Refactor backend api for authrization
2018-09-21 15:59:07 +08:00
Qian Deng
88bb461314
Reactor backend api for authrization
...
1. Change backend api
2. Change frontend api
3. Change the proxy config file
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-09-21 14:03:17 +08:00
Daniel Jiang
6c84a3dc4f
Merge pull request #5690 from goharbor/clouderati-copyright-update
...
Updating copyright notices
2018-09-20 19:38:26 +08:00
Steven Zou
d4c423ea8e
Merge branch 'master' into return_labels_in_chart_api
2018-09-20 17:55:48 +08:00
Steven Zou
24c0be789d
Add more UT cases for changed chart API
...
- add more cases in the ChartRepositoryAPI controller
- move chart utility testing functions to a separate go file under testing
- ignore testing coverage for testing folder
- update other UT cases to reflect the change of adding chart testing utility functions
Signed-off-by: Steven Zou <szou@vmware.com>
2018-09-20 17:51:27 +08:00
Yan
650449d5e0
Fix error on packaging offline installer with Drone ( #5931 )
...
Signed-off-by: wang yan <wangyan@vmware.com>
2018-09-20 14:53:28 +08:00
clouderati
587459df15
Replacing copyright notices with "Copyright Project Harbor Authors".
...
Signed-off-by: clouderati <35942204+clouderati@users.noreply.github.com>
2018-09-19 16:59:36 +00:00
Yan
002e5a2b70
Enable api tests in travis ( #5900 )
...
This commit is to enable parallel run jobs with travis, and add API for DB and API for LDAP in travis.
Signed-off-by: wang yan <wangyan@vmware.com>
2018-09-19 17:49:43 +08:00
Yan
e77a116e1d
Decrepate tests from drone ci ( #5919 )
...
This commit is to remove tests from drone CI server, and leave drone
as the build system only for harbor. Harbor system admin will remove
the webhook from harbor repo, then any pull request will not trigger
drone job.
Signed-off-by: wang yan <wangyan@vmware.com>
2018-09-19 16:54:15 +08:00
Qian Deng
7873a0312a
Rename harbor-ui to harbor-core
...
1. Update the nginx.conf
2. Update Makefile
3. Update docker-compose
4. Update image name
5. Rename folder ui to core
6. Change the harbor-ui's package name to core
7. Remove unused static file on harbor-core
8. Remove unused code for harbor-portal
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-09-19 16:35:13 +08:00
Qian Deng
dfeb1924c6
Fix xpath in robot case
...
1. Fix xpath of Upload button
2. Fix xpath of status span
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-09-10 17:24:28 +08:00
Qian Deng
ac6c9d79ba
Remove nodeclarity
...
Remove the nodeclarity container related code and ui_builder parameter no longer needed when build clarity
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-09-08 20:33:21 +08:00
Daniel Jiang
abf67c8de0
Merge pull request #5789 from wy65701436/make-clean
...
Clean make file unused code and unify docker build method (#59 )
2018-09-05 19:54:56 +08:00
Yan
4eba01fc31
Clean make file unused code and unify docker build method ( #59 )
...
Signed-off-by: Yan <wangyan@vmware.com>
2018-09-04 17:18:15 +08:00
Qian Deng
4d601292d1
Add E2E test for helmchart ( #5746 )
...
Add E2E test for helmchart repo
Signed-off-by: Qian Deng <dengq@vmware.com>
2018-09-04 15:08:51 +08:00
wang yan
f8b964d8cf
Extend configuration length to 1024 in DB
...
Signed-off-by: wang yan <wangyan@vmware.com>
2018-08-31 13:42:24 +08:00
wang yan
470000a9ec
Deprecate unused robot cases
...
Signed-off-by: wang yan <wangyan@vmware.com>
2018-08-27 10:17:06 +08:00
Daniel Jiang
1d4f991901
Merge pull request #5640 from wy65701436/deprecate-ova
...
deprecate ova for harbor repository
2018-08-24 13:38:42 +08:00
wang yan
aacbf229d6
deprecate ova for harbor repository
...
This commit is to remove the document/tests of ova from harbor repository as decide to deprecate
ova installer in the future release.
Signed-off-by: wang yan <wangyan@vmware.com>
2018-08-24 13:05:01 +08:00
Daniel Jiang
dcf4e2ee78
Update import path in go code
...
vmware -> goharbor
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2018-08-23 17:50:53 +08:00
Wenkai Yin
f71f02deee
Fix module not found error in API test ( #5647 )
...
Reload the python path to fix the module not found error in API E2E test
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-08-17 10:55:19 +08:00
Wenkai Yin
95c0c259ec
Add E2E API test cases for replication based on labels ( #5639 )
...
This commit creates a new E2E API test case to verify the replication based on label
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-08-16 18:36:27 +08:00
wangyan
397172e56a
This is my commit message
...
Signed-off-by: wangyan <wangyan@vmware.com>
Update the verify case to use data.json instead of testdata.json
2018-08-12 19:07:36 -07:00
stonezdj
94f852b826
Fix testcase related to LDAP user can not see any logs
2018-08-10 16:17:18 +08:00
Daniel Jiang
d5024bfcd4
Merge pull request #5578 from wy65701436/move-docker-images-2-goharbor
...
Batch update docker image namespace to goharbor
2018-08-10 16:06:08 +08:00
wangyan
7713764aec
Batch update docker image namespace to goharbor
...
This commit is to move all the images of harbor from vmware to goharbor
2018-08-09 23:24:21 -07:00
Wenkai Yin
0561280411
Update robot case to debug the issue got in nightly test ( #5576 )
...
This commit updates the "Sign In Harbor" robot case by adding debug information when it failed
2018-08-10 13:53:48 +08:00
Yan
9c86d0b86f
Update ldap user pwd for nightly ( #5571 )
2018-08-09 16:38:27 +08:00
Zach Shepherd
f387da0a9d
Refer to goharbor/harbor in the integration logic
...
An incomplete update to the integration testing logic to replace some
instances of vmware/harbor with goharbor/harbor to get CI working.
2018-08-08 18:18:36 -07:00
Daniel Jiang
0f9a6d0224
Merge pull request #5530 from wy65701436/add-gas-report
...
Add secure go result into CI pipeline
2018-08-08 15:58:44 +08:00
Mia ZHOU
872b19f370
Merge pull request #5553 from zhoumeina/pr/fix_ui_e2e
...
fix nightly test fail for project creation moved to system config
2018-08-08 11:18:44 +08:00
Mia ZHOU
235a13fa74
fix nightly test fail for project creation moved to system config
...
fix nightly test fail for project creation moved to system config
2018-08-08 10:48:21 +08:00
stonezdj(Daojun Zhang)
ecdfb8034f
Add API Test setup and fix Add Member button verify ( #5548 )
2018-08-08 10:40:35 +08:00
stonezdj(Daojun Zhang)
1f65f9304f
Merge pull request #5281 from stonezdj/testcase_ldap_group_admin
...
Add testcase for define harbor admin by LDAP group DN
2018-08-07 16:28:49 +08:00
wangyan
1c8d77a446
Add secure go result into CI pipeline
2018-08-06 23:53:31 -07:00
Daniel Jiang
3cf93e62aa
Merge pull request #5543 from stonezdj/api2nightly
...
Add API test to LDAP nightly test
2018-08-07 12:17:44 +08:00
stonezdj
af85522a05
Add API test to LDAP nightly test
2018-08-07 11:00:46 +08:00
Mia ZHOU
5d76b28a5c
Fix e2e test after project creation moved to system config ( #5536 )
...
Fix test project creation for e2e.
2018-08-07 10:32:23 +08:00
stonezdj
78d7ba911a
Add testcase for define harbor admin by LDAP group DN
2018-08-06 18:56:13 +08:00
Daniel Jiang
0a07f0e039
Merge pull request #5402 from stonezdj/api_test
...
Add harbor API test
2018-08-06 17:30:07 +08:00
wangyan
b57a9db22a
Update member locater according to UI changes
2018-08-02 18:24:05 -07:00
Daniel Jiang
c5a79fb55b
Add UAA e2e test cases ( #5460 )
...
This commit adds basic test cases to perform when Harbor is configured as
uaa_auth. It has dependency on an internal UAA server.
2018-08-01 21:30:05 +08:00
Deng, Qian
8feb49c64e
Feature of helm chart UI
...
1. Add Charts list view
2. Add Charts card view
3. Add Chart version list view
4. Add chart version card view
5. Add Chart Detail Summary
6. Add Chart Detail Value
6. Add Chart Detail Deps
7. Update nodeclarity Dockerfile
8. Add markdown support
9. Add package-lock file to src
2018-08-01 13:20:06 +08:00
stonezdj
edcb2fbf05
Add Harbor API Test based on python API
...
Correct swagger.yaml format
Add make task swagger_client to gen and install python client.
Add LDAP related Test
2018-08-01 10:43:23 +08:00
wangyan
5edd408d07
Add scripts to verify Harbor DB migration
2018-07-30 04:54:33 -07:00
wangyan
c3c56ada9a
Add Notary server endpoint as a parameter for the CI test cases
2018-07-29 19:45:28 -07:00
Yan
602bcdfa5b
remove publish npm package step in the ci flow and set the ( #5391 )
...
env for admin and pwd for ci, make it same as nightly test.
2018-07-25 17:20:40 +08:00
Steven Zou
bb380e6dbc
Merge pull request #5314 from steven-zou/chart_repo_supporting
...
Refactor chart API endpoints
2018-07-20 20:43:55 +08:00
Steven Zou
0227a1315a
Keep the chart server related configurations in adminserver
...
append chart server related config options to the supporting list of adminserver
provide chart server related config access method in the API layer
update prepare script and ui env template file to enable cache driver config for chart server API
append flag info in the systeminfo API to indicate if chart server is deployed with Harbor
refactor the response rewriting logic to return structual error object
add api init method to initilizing objects required in API handlers
chage owner of the storage folder
update offline/online package scripts in Harbor-Util.robot
2018-07-20 19:40:33 +08:00
Yan
efdb57548f
add admin job api ( #5344 )
...
It supports Harbor admin to trigger job either manual or
schedule. The job will be populated to job service to execute.
The api includes:
1. POST /api/system/gc
2, GET /api/system/gc/:id
3, GET /api/system/gc/:id/log
4, PUT/GET/POST /api/system/gc/schedule
2018-07-20 19:22:37 +08:00
Yan
85ded71816
Update e2e cases
...
refactor e2e test cases to support new CI pipeline
fix issues caused by recently UI change
2018-07-19 02:22:03 -07:00
Wenkai Yin
fd5c17bced
Publish images to Docker Hub ( #5264 )
...
This commit enables the images publishing to Docker Hub in Drone CI. Every pull request merging will trigger this process.
2018-07-09 11:03:51 +08:00
Yan
d366134fe8
Fix bug of packaging offline installer ( #5245 )
...
The init sql script name nad path was changed by PR #5197 , this
commit is to update these and log the package command to console,
make it more easy to debug in future. Also remove the action to
pull migrator as it will built each time locally.
2018-07-04 20:03:44 +08:00
wangyan
28a13db29a
Fix CI pipeline bug on packaging offline installer
2018-07-03 08:42:26 -07:00
Deng, Qian
72dfdd552f
Add ldap serach
...
1. Add group management
2. Add rewrite import user to member ui
3. Add import group to member
4. Add new items in configuration page
2018-07-03 14:00:59 +08:00
sigsbee
889b36a944
Add data verify robot case after upgrade ( #5207 )
...
Add data verify e2e case after upgrade
2018-06-29 15:01:26 +08:00
Daniel Jiang
aef3213dfa
Merge pull request #5190 from stonezdj/reload_config
...
Fix issue that harbor tile can not save customized settings
2018-06-29 13:04:36 +08:00
sigsbee
673c1dac01
Add upgrade test scripts ( #5119 )
...
Add upgrade test data generate script and example data
2018-06-29 10:09:10 +08:00
stonezdj
72e9b22e10
Fix issue that harbor tile can not save customized settings
2018-06-28 16:20:10 +08:00
sigsbee
7d6f8f94c4
Change create project verify method ( #5184 )
...
Update create project keyword to avoid created project on the second page caused verify fail
2018-06-27 11:27:03 +08:00
myufei
31bdc3e894
Add ldap user and group
...
update ldap_test.ldif to add more user and group to ldap environment
2018-06-14 14:16:50 +08:00
sigsbee
a6f14c6d89
Update test case to increase passrate ( #5083 )
...
Update test case order to avoid scan on push fail
Add sleep time to avoid view scan results fail
Change keyword to wait unitl avoid delete operation fail
Change delete rule and repicate manual confirm to mouse down and up
2018-06-05 18:51:11 +08:00
sigsbee
0d4aaccd13
Add get version to LDAP and replication test group( #5076 )
...
Add get harbor version test case to LDAP and replication test group
2018-06-04 14:24:47 +08:00
sigsbee
a0bf7196e6
Fix label test case and replicate case ( #5075 )
...
Fix label test case fail for new UI change
Fix replicate manual keyword to avoid case fail
2018-06-02 01:34:33 +08:00
sigsbee
a07a0d09f8
Add get harbor version case ( #5039 )
...
Add get harbor version case
2018-06-01 14:38:10 +08:00
stonezdj(Daojun Zhang)
b308c6e4fc
Merge pull request #5024 from stonezdj/add_testcase
...
Add testcase for assign role to LDAP group.
2018-05-31 01:17:33 +08:00
sigsbee
8d12960494
Fix robot keywords align with UI changes ( #5036 )
...
Fix robot keywords align with UI changes
fix replication case for new delete progress
2018-05-24 19:53:23 +08:00
sigsbee
8b6963f397
Update testcase for task progress ( #4987 )
...
update multi delete testcase for new delete progress
2018-05-24 13:07:19 +08:00
Steven Zou
9943c0cd07
Merge pull request #5021 from pengpengshui/asynctask
...
Add async task progress and delete dialog task progress #4371
2018-05-23 15:20:13 +08:00
stonezdj
ab20642f0d
Add testcase for assign role to LDAP group.
...
Including
1. LDAP group configure settings
2. Assign role to LDAP user group.
3. Manage user group
2018-05-22 19:17:45 +08:00
pfh
1121c8a76b
Add async task progress and delete dialog task progress #4371
...
norm code
2018-05-22 14:42:06 +08:00
sigsbee
b72209fb08
Add sleep to avoid test fail ( #5005 )
...
Add sleep to avoid test fail in delete replication rule case
2018-05-21 19:04:02 +08:00
Steven Zou
1f7a4f18e5
Merge pull request #4963 from ninjadq/fix_tslint_warning
...
Fix tslint warning
2018-05-15 18:41:15 +08:00
Deng, Qian
43c8e9f589
Fix all tslint warnings
...
1. Fix tslint warnings
2. Add tslint to travis
2018-05-15 16:28:23 +08:00
sigsbee
8cca04f439
Add project level content trust case ( #4964 )
...
Add project level content trust testcase
2018-05-14 08:36:12 -07:00
Deng, Qian
282a63f57f
Fix legacy issues that html and css file are written on ts file.
...
Currently, our html and css files are written as string on .ts file. This pr is to solve the legacy issue.
2018-05-10 18:39:48 +08:00
sigsbee
b4b148e923
Update click method to fix replication rule auto case ( #4908 )
...
As the click may fail with method click element, update it to move the element and click.
2018-05-10 00:07:02 -07:00
Deng, Qian
2ef1a92a93
Add ng-packagr to packaging harbor-ui npm repo
...
Using ng-packagr to build and publish npm repo
2018-05-09 10:59:22 +08:00
Qian Deng
5420f7ff0e
Merge pull request #4872 from pengpengshui/fixIssues
...
rewrite layout about filter by label and tesecase #4809
2018-05-08 13:34:40 +08:00
pfh
2f6dcce0d5
rewrite layout about filter by label and tesecase #4809
2018-05-08 12:10:24 +08:00
sigsbee
981743ada9
Fix nightly failures bases on latest UI change ( #4870 )
...
Fix up project level policy public
Change text to fix up pro replication rules add
2018-05-07 03:30:08 -07:00
pfh
5006693fd6
Modify global search project and adjust selected label position
2018-05-04 10:27:40 +08:00
stone
e6a52f49a4
Merge pull request #4722 from stonezdj/security_context_for_group3
...
Update security context for assign role to project group member
2018-05-03 17:17:41 +08:00
stonezdj
b8a48d0326
Update security context for assign role to project group member
...
The project list will contain all public projects, user is a member of this project, or user is in the group which is a member of this projects.
Change the behaviour of user roles, if the user is not a member of this project, then return the user's groups role of current project
2018-05-03 16:49:16 +08:00
wangyan
9715743b37
Dump log of shutting down harbor in CI
2018-05-02 08:42:42 -07:00
Yan
30152b19c1
Modify harbor log files name to align with latest change ( #4846 )
2018-05-02 04:58:24 -07:00
Yan
ae257433cc
Fully migrate harbor db to postgresql ( #4689 )
...
* Merge harbor db to postgres
2018-04-27 02:27:12 -07:00
sigsbee
c91334397a
Fix up keyword add label ( #4794 )
...
Fixup create new labels keyword to fix failed testcase
2018-04-27 17:14:44 +08:00
sigsbee
9bf38c2486
Add autotest case ( #4603 )
...
Add test case large image replicate
Add test case Download CA
Add test case repo description
Add test case project level replication
Add test case repo size
Add test case statistics info
2018-04-25 16:24:11 +08:00
Tan Jiang
1fc4142e1a
Do not call chown
to config files
...
This commit fixes a recently discovered issue on Kubernetes #4496
It make necessary to avoid calling `chown` to config files during the
bootstrap of the containers.
2018-04-20 13:44:21 +08:00
Steven Zou
a8eb969e2d
Merge pull request #4703 from wy65701436/update-ui-builder
...
Update ui clarity builder version to 1.4.0
2018-04-19 17:12:23 +08:00
sigsbee
5bd9a99984
Fix up card view keyword ( #4718 )
...
Fix up card view keyword and failed test case
2018-04-19 10:07:55 +08:00
wangyan
2439cbfe55
Update ui clarity builder version to 1.4.0
2018-04-17 22:38:01 -07:00
pfh
e9052dd42a
Merge remote-tracking branch 'upstream/master' into fixIssue
2018-04-17 10:19:16 +08:00
pfh
bd28eb4541
Add Filter Label about imgs
2018-04-17 10:08:19 +08:00
Steven Zou
bb292aab96
Fix the failure api test cases because API implementation changed
2018-04-16 15:39:19 +08:00
pfh
c67e1a2e4b
Merge branch 'master' of https://github.com/vmware/harbor into fixIssue
2018-04-16 11:35:33 +08:00
Qian Deng
e12826ef42
Merge pull request #4643 from ninjadq/add_test_case_and_doc
...
Add testcase and doc for cardview
2018-04-16 10:28:49 +08:00
pfh
c99e43674d
add Filter Label about imgs
2018-04-16 09:54:27 +08:00
wangyan
04816222c0
Update ci test images to busybox
2018-04-12 18:21:20 -07:00
Deng, Qian
ddb5298ae6
Add testcase and doc for cardview
2018-04-12 19:55:46 +08:00
sigsbee
75e6b5d91c
Fix up keyword and test case ( #4629 )
...
Fix up keyword: push image with tag
Fix up case: Project Admin Add Labels To Repo
Fix up case: Proj Replication Jobs Log View
2018-04-12 11:42:54 +08:00
sigsbee
efb3759d14
Update test keyword ( #4599 )
2018-04-10 04:41:48 -07:00
pfh
a9c7b34de9
Add case about project label
2018-04-09 16:10:07 +08:00
stone
df63a73fd4
Merge pull request #4483 from stonezdj/api4assign_role_to_group4
...
Add REST API for assign role to group
2018-04-04 16:19:37 +08:00
stonezdj
9bcfaedc0e
Add REST API for assign role to group
2018-04-04 13:39:42 +08:00
Steven Zou
44808650be
Merge branch 'master' into job_service
2018-04-03 16:28:26 +08:00
pengpengshui
73e32d1735
Merge pull request #4562 from pengpengshui/label
...
Modify label filter issue and add stick label to image case
2018-04-03 09:39:05 +08:00
Wenkai Yin
1072666a31
Merge pull request #4549 from ywk253100/180330_label_case
...
Add manual test cases for label
2018-04-02 19:41:37 +08:00
Wenkai Yin
2e6202f276
Add manual test cases for label
2018-04-02 16:53:50 +08:00
pfh
e5a757d78d
Modify label filter issue and add stick label to image case
2018-04-02 14:45:52 +08:00
pengpengshui
6a1af52949
Merge pull request #4542 from pengpengshui/tagdetail
...
Add repo read only
2018-04-02 13:41:46 +08:00
sigsbee
8b32f56b64
Fix up ldap testcase ( #4548 )
2018-04-02 12:08:04 +08:00
pfh
a43451c7ea
Add repo read only and modify label issue
2018-03-30 11:38:45 +08:00
Steven Zou
d1899c840d
Merge branch 'master' into job_service
2018-03-29 23:25:20 +08:00
sigsbee
9baee6b88c
Add LDAP case and add delay to project config to avoid case fail ( #4486 )
...
* Add LDAP case and add delay to project config to avoid case fail
2018-03-28 16:45:49 +08:00
Steven Zou
d3909bb633
Add UT cases for package opm (update travis yaml to start redis container)
...
Fix data race issue in opm package
2018-03-28 15:28:34 +08:00
Daniel Jiang
14e24267c0
Merge pull request #4478 from wy65701436/add-readonly-tc
...
add read only case
2018-03-27 13:17:11 +08:00
sigsbee
0c95bd6ffa
Update project detail xpath ( #4482 )
2018-03-26 16:27:07 +08:00
wangyan
3ea42fd62c
add read only case
2018-03-25 18:22:35 -07:00
Yan
2095fb0c0a
Update harbor build naming convention ( #4461 )
2018-03-23 02:56:29 -07:00
sigsbee
8b739dcbbb
Fix scan repo keyword and delete multi tag case ( #4448 )
2018-03-21 03:37:52 -07:00
Yan
5edbd00318
Revise harbor build version ( #4445 )
2018-03-21 13:03:49 +08:00
sigsbee
340080f9a2
Fix view log test case ( #4438 )
2018-03-20 18:11:39 +08:00
sigsbee
80e39c39d3
Add replication autotest ( #4406 )
2018-03-20 13:25:03 +08:00
Yan
3215d328aa
fix run replication bug in nightly ( #4402 )
2018-03-13 19:21:35 +08:00
sigsbee
4ccd7e7cdf
Add vulneraibility case and add a testcase doc. ( #4378 )
...
Add disable schedule
vulnerability data not ready
can as an unprivileged user
scan image with empty vul
manual scan all
project level image serverity policy
scan on push
2018-03-12 14:20:37 +08:00
Yan
8bf4f1314e
fix nightly bug for notary case in replication env ( #4355 )
2018-03-07 15:19:09 +08:00
wangyan
29bdcfe454
Add replication support for LDAP in nightly
2018-03-04 19:38:26 -08:00
Qian Deng
c2d9f8cc56
Bump ui builder version ( #4298 )
2018-03-05 10:30:11 +08:00
Daniel Jiang
e2efe80de5
Merge pull request #4338 from wy65701436/debut-new-drone
...
Update drone to 0.8
2018-03-05 10:22:45 +08:00
wangyan
5982c23162
Update drone to 0.8
2018-03-03 11:08:35 -08:00
Daniel Jiang
4752de1584
Merge pull request #4315 from wy65701436/add-e2e-dockerfile
...
Add docker file for e2e infrastructure
2018-03-01 13:54:46 +08:00
wangyan
546c4fa3ac
Add docker file for e2e infrastructure
2018-02-28 07:56:04 -08:00
Yan
c37b3748b9
Support replication test in nightly infrastructure ( #4302 )
2018-02-28 19:37:25 +08:00
sigsbee
15f4315b74
Modify test step to avoid an autotest bug ( #4301 )
2018-02-28 19:36:58 +08:00
Tan Jiang
f83c65bcc5
Reduce the output of build.
...
The following are done to avoid travis-ci failing due to too much log
size.
1) Update Makefile and scripts to make go build less verbose.
2) Make tdnf less verbose
2018-02-27 20:54:52 +08:00
Daniel Jiang
b2eff8b7a3
Merge pull request #4234 from wy65701436/check-ldap-out
...
Upgrade docker to latest and check for docker login fail
2018-02-27 11:28:11 +08:00
wangyan
d12ad7fa94
Upgrade docker to latest and check for docker login fail
2018-02-05 20:42:41 -08:00
Daniel Jiang
87ca267b0f
Merge pull request #4221 from ywk253100/180131_beego_1.9.2
...
Upgrade beego 1.6.1 to 1.9.0
2018-02-05 19:17:44 +08:00
Wenkai Yin
10f56d26fe
Change codes to make everything OK after upgrading to beego 1.9.0
2018-02-05 13:07:52 +08:00
sigsbee
9b9a44172f
Use two different tags in bat delete to avoid 500 error ( #4216 )
2018-02-02 17:43:11 +08:00
sigsbee
c436630f11
Fix failed auto test case ( #4197 )
2018-01-31 00:45:14 -08:00