ljacqu
2a4bb483a3
#727 finalization - minor javadoc changes
2016-06-04 21:57:31 +02:00
ljacqu
91111ca476
#727 Remove CommandService being passed as parameter to other methods
...
- No longer need to pass as param to other methods since CommandService is now an injected field
2016-06-04 21:16:58 +02:00
ljacqu
26ac466035
#727 Instantiate ExecutableCommand objects in CommandHandler
...
- Change CommandDescription to contain a reference to ExecutableCommand class only
- Instantiate the actual ExecutableCommand objects in CommandHandler
2016-06-04 21:13:38 +02:00
ljacqu
c6778b566d
#727 Remove CommandService from ExecutableCommand interface
...
(work in progress)
- Inject CommandService like other classes instead of passing it as method parameter
- Not solved: cyclic dependency CommandInitializer > ExecutableCommand > CommandService > CommandInitializer...
2016-06-04 11:02:15 +02:00
ljacqu
40ce01f65e
#601 Increase captcha count on login start
...
- Increase login count at start of the login process (as done previously) and not only when login has failed AND player is still online
- Add missing javadoc to CaptchaManager
2016-06-04 10:44:34 +02:00
ljacqu
12703d1613
#601 Integrate plugin manager
...
- Encapsulate captcha functionality into a class instead of two public fields on the AuthMe main class(!)
- Let CaptchaManager worry about whether it is enabled or not -> no need to check on the outside
- Implement full reloading support to enable/disable captchas + parameters
- Add unit tests
2016-06-03 22:47:17 +02:00
ljacqu
1f2a823f99
Add tests for PluginHooks - Multiverse interactions
2016-06-03 13:36:33 +02:00
ljacqu
e8717ba076
Update verification notes in messages files + add entry for #743 invalid chars in password
2016-06-03 12:52:47 +02:00
ljacqu
55f7e8097a
#743 Add proper error message for "invalid chars in password"
...
- Change password validation to return a ValidationResult object for passing message arguments
- Remove wrapping methods in ProcessService and CommandService and use ValidationService directly
2016-06-03 12:51:49 +02:00
Gabriele C
6549ebbf5e
Should fix #731
2016-06-03 01:18:54 +02:00
Gabriele C
ca2e75651c
Fix #734
...
It should run before the password check
2016-06-03 00:53:24 +02:00
Gabriele C
6c0dec887a
try to fix javadoc
2016-06-03 00:27:06 +02:00
Gabriele C
eafb3b6653
cleanup
2016-06-03 00:07:25 +02:00
ljacqu
6d2597a980
#739 Fix command unit tests; adjust default handling
...
(cherry picked from commit 61c119b)
2016-06-02 23:12:01 +02:00
Gnat008
73272b5931
Remove all but one hasPermission() method in the PermissionsManager
...
#739 (cherry picked from commit 65f3347)
2016-06-02 23:11:47 +02:00
EbonJaguar
c3d07cb9a4
#739 Cleanup on PermissionsManager
...
(cherry picked from commit d9ad12b)
2016-06-02 23:10:37 +02:00
ljacqu
9b5009eb8c
#742 Create test that plugin.yml corresponds to command definitions
...
- Create test
- Fix definitions to correspond
2016-06-02 15:49:21 +02:00
ljacqu
e75cff5fb8
Remove static injections in ListenerService
...
- Get other classes via Inject annotation
- Remove no longer needed Utils methods (relates to #736 )
- Create tests for ListenerService and AuthMeBlockListener
- Performance improvement: keep unrestricted names as Set instead of List for faster contains() method
2016-06-02 12:46:54 +02:00
DNx
2581b95afb
Fix NPE on server stop #740
...
- not the best, because we will miss that 3 log inside authme.log.
2016-06-02 11:07:37 +07:00
DNx
e06c5e7309
Fix NPE from ConsoleLogger
...
if plugin could not load configuration.
2016-06-02 05:23:16 +07:00
ljacqu
408e8dd0dd
#739 Create unit tests for PermissionsManager#hasPermission
2016-06-02 00:03:02 +02:00
ljacqu
7fd1ac0856
Merge branch '314-permissions-manager-refactor' of https://github.com/AuthMe-Team/AuthMeReloaded
2016-06-01 23:39:14 +02:00
ljacqu
38db2ef0bd
Minor code householding
...
- Add removed property to migration service
- Log exception with appropriate logger method
2016-06-01 23:24:48 +02:00
ljacqu
95343e366b
#314 Evaluate default permission on enum, remove default from handler interface
...
- Evaluate permission for DefaultPermission on the enum itself
- Remove boolean default from PermissionHandler for hasPermission()
- Remove some unused / intermediary hasPermission() flavors in PermissionsManager
2016-06-01 21:56:57 +02:00
EbonJaguar
fdb9227ec1
Properly unhook the current system when unhook() is called
2016-06-01 14:09:30 -04:00
EbonJaguar
e99d9414b8
Add and implement handlers for each individual permissions plugin, instead of doing everything in the PermissionsManager - see #314
2016-06-01 14:00:27 -04:00
games647
1cbd11a753
Fix the issue reference for removing the exception stacktrace logging
2016-06-01 18:30:46 +02:00
games647
71a9abdad9
Remove redundant isLoggable check. It's always level ALL
...
Looks like the java logger does not reflect the log4j level settings
:(
2016-06-01 18:28:22 +02:00
games647
351fe3aa5a
Add thread name and stacktrace to the debug logging (Related to #419 )
...
It's only visible to user who enabled debug logging in their spigot
configuration.
2016-06-01 18:04:43 +02:00
ljacqu
e59bbbf10e
#738 Add check that shooter is of type Player in ProjectileLaunchEvent
...
- Use reflection the opposite way: if it is an old version (getShooter() returns LivingEntity), use reflection; otherwise, call the method directly
- Add missing instanceof Player check
2016-06-01 14:06:36 +02:00
Gabriele C
58a6b6060f
Log an error if the plugin is unable to create the log file.
2016-06-01 11:40:50 +02:00
Gabriele C
e6f2eb487d
Merge pull request #136 from AuthMe-Team/writelog
...
better method to write the messages
2016-06-01 11:37:37 +02:00
DNx5
3d1f735c1b
Use FileWriter to write the messages.
2016-06-01 06:12:22 +07:00
DNx5
5c690d722a
- do the check for old GeoLite data correctly.
2016-06-01 05:23:40 +07:00
ljacqu
0977558924
#736 Remove use of service getters and deprecate them
2016-05-31 11:14:03 +02:00
Gabriele C
be4b3a8605
Update messages_hu.yml
2016-05-31 10:29:35 +02:00
ljacqu
3b6677ce99
Merge branch '604-default-permissions-on-nodes' of https://github.com/AuthMe-Team/AuthMeReloaded
2016-05-31 09:15:36 +02:00
ljacqu
30b72bec4c
#604 Fix HelpProvider tests
2016-05-30 23:49:59 +02:00
EbonJaguar
3ad00a45f9
Move default permissions out of Commands and into PermissionNode - fixes #606
2016-05-30 16:47:48 -04:00
ljacqu
4db5062935
Merge branch 'playerjoin-listener-cleanup' of https://github.com/AuthMe-Team/AuthMeReloaded
2016-05-30 21:13:36 +02:00
ljacqu
18ff5d5331
Remove todo comment associated to #602
2016-05-30 20:02:07 +02:00
ljacqu
f5b4071abf
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into playerjoin-listener-cleanup
2016-05-30 17:53:42 +02:00
Gabriele C
8a0655e333
Merge pull request #134 from Gnat008/602-create-lowercase-string-list-propertytype
...
Add a lowercase String list property - fixes #602
2016-05-30 17:53:14 +02:00
ljacqu
cc67624a46
Throwing snowball still possible when unlogged
2016-05-30 17:09:10 +02:00
EbonJaguar
f94f4643cf
Add a lowercase String list property - fixes #602
2016-05-30 11:08:01 -04:00
ljacqu
9b1ee86b2f
Trivial code householding
...
- Replace `if (!x) ... else ...` with `if(x) ... else ...`
- Avoid throwing RuntimeException; use children
2016-05-30 12:18:55 +02:00
ljacqu
4c51b33b22
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into playerjoin-listener-cleanup
2016-05-30 07:52:40 +02:00
ljacqu
9349993faf
Merge pull request #133 from Gnat008/612-add-PermissionsSystemType-method
...
Add isPermissionsSystem method to PermissionsSystemType enum - fixes …
2016-05-30 07:51:14 +02:00
EbonJaguar
428b27943b
Add isPermissionsSystem method to PermissionsSystemType enum - fixes #612
2016-05-29 18:29:19 -04:00
Gabriele C
30aace06d4
Remove unknown config entry
2016-05-29 21:47:54 +02:00
Gabriele C
bf91e7754e
Remove unused imports
2016-05-29 21:43:28 +02:00
DNx5
10e5ae08e2
remove write log for info message.
...
In case we don't have better log writing method yet.
2016-05-29 23:15:00 +07:00
Gabriele C
be6ed07802
Fix #568
2016-05-29 17:36:36 +02:00
Gabriele C
f5b7246d1d
remove useless stuff from the player listener
2016-05-29 17:10:33 +02:00
Gabriele C
52c0c7dd64
playerlistener cleanup
2016-05-29 16:34:03 +02:00
ljacqu
64aacb12db
Unit test verifications done on joining
...
- Write unit tests for checks done when a player joins
- Move join event handler methods back to PlayerListener; move join check logic to new separate class
2016-05-29 15:00:16 +02:00
ljacqu
39d8a88142
Structure checks done in PlayerJoinListener as individual methods
2016-05-29 11:45:12 +02:00
ljacqu
2c92a8b52f
Move logic for join events in its own listener
2016-05-28 22:32:45 +02:00
ljacqu
a854d4e0e0
Register entity listener again
2016-05-28 22:29:49 +02:00
ljacqu
25f5fdb45c
Code householding (PlayerListener / Settings)
...
- Use field on PlayerListener for storing nickname pattern -> repeatedly parsing pattern is expensive
- Remove unused legacy setting fields
- ForceFlatToSqlite cannot be run from converter command -> remove Converter interface to create more natural method signatures
2016-05-28 22:04:55 +02:00
ljacqu
b48e080324
Minor code householding
...
- Fix Javadoc errors reported during Jenkins build
- Use Guava methods in NewSetting where possible
2016-05-28 07:56:26 +02:00
ljacqu
eee06dad50
Dependency graph - allow to summarize dependencies by super type
2016-05-27 23:25:11 +02:00
ljacqu
107441746e
Merge remote-tracking branch 'origin/master'
2016-05-27 23:05:40 +02:00
ljacqu
cb10854612
Minor - fix failing build (cannot use method from Java 8)
2016-05-27 23:05:03 +02:00
ljacqu
87331d116c
Revise converter architecture + add integration test for CrazyLogin converter
2016-05-27 23:00:44 +02:00
games647
466fb8cab9
Run explicit non-thread-safe setGameMode sync
2016-05-26 10:52:49 +02:00
Gabriele C
41bad6189e
Update messages_tr.yml
...
#621
2016-05-25 19:52:21 +02:00
ljacqu
67511e3b45
Create task which draws AuthMe dependency graph
2016-05-25 19:24:12 +02:00
ljacqu
3643b88798
#712 Add changes to fr messages by Jeje2201
2016-05-25 17:37:15 +02:00
ljacqu
6341d00df0
Code householding - remove legacy settings and TODO messages
...
- Remove fields in legacy settings that are now unused
- Remove various irrelevant todo messages
- Reduce visibility on some elements
2016-05-24 18:59:01 +02:00
ljacqu
e54cd526de
Add verification remarks in message files
...
- Result from automatic task which checks message files for missing messages or tags
2016-05-24 18:37:58 +02:00
ljacqu
8de1897412
Minor - Use explicit dependencies in ProcessService
...
- Replace AuthMe in favor of PermissionsManager
- Create missing tests for ProcessService
2016-05-24 18:25:38 +02:00
Gabriele C
a7d3e60abe
Remove unused imports
2016-05-24 17:00:23 +02:00
Gabriele C
2a3ed384d5
Fix #720 invalid HU lang file
2016-05-24 16:51:03 +02:00
Gabriele C
55cc882002
Remove scheduler methods from the ProcessService
...
@ljacqu it's ok now? ;)
2016-05-24 16:07:03 +02:00
Gabriele C
5007ca45f0
Update HU language #720
...
Thanks to @rErEaT
2016-05-24 15:55:09 +02:00
Gabriele C
dbae4953cc
Can't cancel sync player chat #722
2016-05-24 15:50:28 +02:00
Gabriele C
740b44ca36
cleanup
2016-05-23 23:49:56 +02:00
Gabriele C
da6431b4fc
Suppress injection test warnings
2016-05-23 23:16:40 +02:00
ljacqu
30f62547d8
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 707-process-as-service
2016-05-23 21:41:41 +02:00
Gabriele C
7865d7dc2c
Remove synchronized methods from the Cache (please check)
...
@Xephi @ljacqu @games647
2016-05-23 21:18:31 +02:00
Gabriele C
97e96ab16b
Remove unused imports
2016-05-23 21:16:11 +02:00
Gabriele C
b3f184da78
stupid conflict
2016-05-23 21:12:12 +02:00
Gabriele C
22f54c1f3e
Fix Chat Hider #719
2016-05-23 21:05:18 +02:00
Xephi
c0e8650c6f
Move to antibot class
2016-05-23 10:10:01 +02:00
Xephi
37b6a2f96f
Enable antibot automatically and check for bot into AsyncPreLogin #719
2016-05-23 10:03:10 +02:00
ljacqu
11350ec43a
Iterate over all chat recipients
2016-05-22 10:52:34 +02:00
Gabriele C
dd5fb49065
Whoops forgot to commit this #719
2016-05-21 18:08:26 +02:00
Gabriele C
e0ef0e40c7
Add denied chat message #719
2016-05-21 18:01:21 +02:00
Gabriele C
fb6303bf4a
Cleanup
2016-05-21 15:37:54 +02:00
Gabriele C
410d07a64c
Remove commented code
2016-05-21 15:08:40 +02:00
Gabriele C
b2b65710b1
Also for SQLITE #719
2016-05-21 15:00:48 +02:00
Gabriele C
7a21294581
Don't use synchronized methods #719
2016-05-21 14:58:57 +02:00
Gabriele C
7ad39e2a5d
Use default Hikari pool parameters
2016-05-21 14:54:03 +02:00
Gabriele C
4d06b63e64
Try to fix spambot resource leak #719
2016-05-21 14:18:31 +02:00
ljacqu
53043ddc0d
Create tool task that checks Mock fields of test classes
2016-05-21 11:54:54 +02:00
Gabriele C
6af65e6cd4
Fix wrong logic (my fault)
2016-05-20 22:02:26 +02:00
Gabriele C
6285a2137f
Revert "Idk why, but it doesn't work!"
...
This reverts commit 0c2ee34db3
.
2016-05-20 22:00:52 +02:00
Gabriele C
0c2ee34db3
Idk why, but it doesn't work!
2016-05-20 21:27:47 +02:00
ljacqu
c1885a381b
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 707-process-as-service
...
Conflicts:
src/main/java/fr/xephi/authme/process/join/AsynchronousJoin.java
src/main/java/fr/xephi/authme/process/login/AsynchronousLogin.java
2016-05-20 19:48:41 +02:00