Upstream/MobArena
1
0
Fork 0
mirror of https://github.com/garbagemule/MobArena.git synced 2025-02-16 12:31:57 +01:00
Code Issues Projects Releases Wiki Activity
MobArena plugin for Minecraft
1,037 Commits 8 Branches 23 Tags 33 MiB
Java 99.4%
Python 0.6%
784-infinite-effects
Go to file
Andreas Troelsen a64fc3cb3a Use -1 as default potion effect duration. 
NOTE: It might be worth exploring the idea of allowing -1 as a valid
duration value instead. Another option is to actually clean up the whole
potion effect parser portion of the code base and inject a default value
resolved at load-time by checking the Minecraft version.

Minecraft 1.19.4 introduces "true infinite" potion effect durations, and
these are represented in the Bukkit API by the sentinel value -1 [1][2],
which means all we need to do is change the default duration value.

This change makes 1.94.4 _mandatory_, as potion effects with a negative
duration result in an error from the Bukkit API in earlier versions, so
this little change effectively removes backwards compatibility from the
plugin even though the rest of it works fine.

Closes #784

---

[1] https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/potion/PotionEffect.java#27
[2] https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/potion/PotionEffect.java#209-211
2023-12-27 18:01:32 +01:00
.github Convert to Gradle. 2023-12-09 21:08:09 +01:00
gradle/wrapper Convert to Gradle. 2023-12-09 21:08:09 +01:00
src Use -1 as default potion effect duration. 2023-12-27 18:01:32 +01:00
.gitignore Convert to Gradle. 2023-12-09 21:08:09 +01:00
build.gradle.kts Convert to Gradle. 2023-12-09 21:08:09 +01:00
changelog.md Add per-arena setting monster-teleporting. 2023-11-13 16:29:51 +01:00
gradlew Convert to Gradle. 2023-12-09 21:08:09 +01:00
gradlew.bat Convert to Gradle. 2023-12-09 21:08:09 +01:00
LICENSE Add LICENSE 2018-04-27 16:32:02 +02:00
README.md Add Hangar link to README. 2023-11-13 12:21:40 +01:00
settings.gradle.kts Convert to Gradle. 2023-12-09 21:08:09 +01:00

README.md

MobArena Build Status

MobArena is an arena-style minigame for Spigot-based Minecraft servers

Getting Started

If you don't want to compile the plugin yourself, grab a release artifact from one of these two sites:

The wiki here on Github should have all the information you need to get started using the plugin.

Getting Help

If you run into problems or need help with something, feel free to hop on the MobArena Discord server to have a chat: Instant Invite

Remember, though, that this communication channel is idle chat, which means you likely won't get a response immediately. It could take anything from a couple of seconds to a day, but your message will be seen.

Contributing

Found a bug, got a suggestion, or want to dig into the code base? There are many ways to contribute to the project!

Get started here: Contributing