Commit Graph

482 Commits

Author SHA1 Message Date
Nassim Jahnke
502755d55a Updated Upstream (Bukkit/CraftBukkit/Spigot) (#6457)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
c9a46ebf #653: Add World#spawn with randomizeData parameter
e49c2e3a Damageable should extend ItemMeta
01ff04f4 SPIGOT-5880, SPIGOT-5567: New ChunkGenerator API
ca5b4b1a SPIGOT-6697: Deprecate generateTree with BlockChangeDelegate as it does not handle tiles

CraftBukkit Changes:
7c8bbcbe SPIGOT-6716: Preserve the order of stored enchantments of enchanted books.
18027d02 #914: Add World#spawn with randomizeData parameter
3cad0316 SPIGOT-6714: Don't fire PlayerBucketEvent when empty
8c6d60cf Fix server crash with BlockPopulator when entities are at a negative chunk border
4f6bcc84 SPIGOT-5880, SPIGOT-5567: New ChunkGenerator API
78d5b35b SPIGOT-6697: Restore generateTree with BlockChangeDelegate behaviour
15792f0d Rebuild patch
c949675e SPIGOT-6713: Cancelling EntityTransformEvent Causes Deceased Slimes To Not Despawn
a955f15c Fix issues with new ChunkGenerator API
a0a37f41 SPIGOT-6630: Replacing an enchantment on an item creates a conflict error

Spigot Changes:
b166a49b Rebuild patches
3c1fc60a SPIGOT-6693: Composters only take in one item at custom hopper speeds
2021-08-25 09:59:26 +02:00
Jake Potrebic
f53cb1b3fe Add BlockBreakBlockEvent (#4989) 2021-08-24 18:42:23 -07:00
Jason Penilla
dd35ae9fec Squash "Clear SyncLoadInfo" into "Add debug for sync chunk loads" and add tab completion for the clear argument (#6483) 2021-08-24 18:45:40 -05:00
Jake Potrebic
73b4c45a4a [ci skip] clean up diff from 1.17 update (#6462) 2021-08-24 16:30:26 -07:00
Pedro
6e492e1b1c Fix bed explosions in custom worlds (#6345) 2021-08-24 16:03:58 -04:00
Jake Potrebic
78d3eda3db Fix CB lib relocation (#6454) 2021-08-22 10:22:57 -07:00
Jake Potrebic
7b08aa27ab Add API to change EnderEye target without other nonsense (#6460) 2021-08-22 08:19:42 -07:00
Jake Potrebic
b9871610d1 Prevent NPE when removing enchantment with no ItemMeta (#6459) 2021-08-22 08:13:51 -07:00
Jake Potrebic
9169cf73cc Better docs for PlayerGameModeChangeEvent (#6461) 2021-08-22 08:10:33 -07:00
Maddy Miller
92d1ace250 Fix BlockPistonRetractEvent firing multiple times (#6467) 2021-08-22 23:54:55 +10:00
MiniDigger | Martin
aa487a3e4c Fix Mob Goal Leak (#6394) 2021-08-22 06:19:45 +02:00
Octavia Togami
1291aa829a Replace ThreadLocal with ConcurrentHashMap in CommandSourceStack (#6325)
This object is created so often that it likely creates problems with the
ThreadLocalMap because the weak references can't be cleaned up fast
enough. This has manifest as lag seemingly caused by WorldEdit:
https://github.com/EngineHub/WorldEdit/issues/1668
2021-08-21 20:45:40 -07:00
Mariell Hoversholm
889718222e Add timeout & interval to sysout catcher (#6383) 2021-08-21 17:01:42 +02:00
Bjarne Koll
b868339208 Add deepslate as xray engine 2 replacement default (#6362)
Fixes: #6350
2021-08-21 14:34:58 +00:00
Noah van der Aa
7e5a053742 Respect despawn rate in merge check (#6428) 2021-08-21 16:32:07 +02:00
Jake Potrebic
b3c84b4e7d Add API to send game events (#6444) 2021-08-21 07:26:42 -07:00
petersv5
ebb3c9b96a Fix entities glitching through blocks pushed by pistons (#6308)
Fixes #5189
2021-08-21 16:15:29 +02:00
Jason Penilla
5fb95dd824 Set AsyncAppender dispatch thread to be a daemon thread (#6424) 2021-08-18 13:47:29 -05:00
Jason Penilla
6216cdc4c2 Setup dev bundle publishing (#6163) 2021-08-17 17:11:04 -05:00
Shane Freeder
972fbb74c9 Do not fire PlayerBucketFillEvent when no fluid (Fixes #4611) 2021-08-17 15:43:01 +01:00
Jake Potrebic
5da877975c Fix yaw on player spawn (#6409) 2021-08-16 14:46:25 -07:00
Noah van der Aa
f9143cf9ec Don't fire entitymovevent for players. (#6402) 2021-08-15 19:37:42 +02:00
Jake Potrebic
f217b15bbf Fix possible divide by 0 error with cursor updates (#6398) 2021-08-14 10:44:31 -07:00
Shane Freeder
746d5cb8fb Revert "Revert "Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)""
This reverts commit d2f7432e32.
2021-08-14 15:24:53 +01:00
Shane Freeder
d2f7432e32 Revert "Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)"
This reverts commit 701cceb170.
2021-08-14 15:22:21 +01:00
Shane Freeder
701cceb170 Remove "Implement-Chunk-Priority-Urgency-System-for-Chunks" (Fixes #5980)
Mojang made some changes to priorities in 1.17 and it seems that these changes
conflict with the changes made in this patch, which in some cases appears to
cause excessive rescheduling of tasks.

This, however, is not confirmed as such but seems to be the behavior that we're
seeing to cause this issue, if mojang has adopted the changes we suggested,
then a good chunk of this patch may be unneeded, but, this needs a much better
look than I'm currently able to do
2021-08-14 14:55:55 +01:00
Jason Penilla
92222b3c9d [ci skip] Add some helper methods to the ObfHelper util class (#6374) 2021-08-14 03:06:17 -07:00
Jason Penilla
f5dd603274 [ci skip] Drop "Fix CME on adding a passenger in CreatureSpawnEvent" (#6384)
This is no longer needed as Entity#passengers is an ImmutableList as of 1.17
2021-08-14 03:01:07 -07:00
Jake Potrebic
b230147e18 Clear bucket NBT after dispense (#6391) 2021-08-14 02:51:03 -07:00
Jake Potrebic
112c19b45e Implement Translatable in appropriate places (#6248) 2021-08-13 21:11:12 -07:00
Jason Penilla
18178d7c9a Add config migration for named entity death logging option (#6390) 2021-08-13 13:24:25 -07:00
Warrior
7b05942bcc Configurable item frame map cursor interval (#6385) 2021-08-13 21:14:44 +02:00
Jake Potrebic
85195961ea Make EntityUnleashEvent cancellable (#4993) 2021-08-13 11:15:43 -07:00
Jake Potrebic
037884fc65 Updated Upstream (Bukkit/CraftBukkit/Spigot) (#6379)
Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
2021-08-13 10:08:34 -07:00
Jason Penilla
6b4f50a1cb Fix block drops position losing precision millions of blocks out (#6387) 2021-08-12 21:46:55 -07:00
Andrew Steinborn
6a9023862c Optimize indirect passenger iteration (#6366) 2021-08-12 22:55:41 +00:00
Jason Penilla
1093b2f26a Use AsyncAppender instead of AsyncLoggerContextSelector to keep loggging IO off main thread (#6381) 2021-08-12 10:55:20 -07:00
Mariell Hoversholm
7df3240f80 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
e0598aa2 SPIGOT-6692: Add sendSignChange overload with a hasGlowingText parameter

CraftBukkit Changes:
2cdc6b1e4 SPIGOT-6692: Add sendSignChange overload with a hasGlowingText parameter
2021-08-05 21:53:50 +02:00
Jake Potrebic
ecbd399610 Added EntityItemDamageEvent (#4928) 2021-08-09 22:04:44 -07:00
Jason Penilla
c3a36117a8 Config option for Piglins guarding chests (#4829) 2021-08-09 19:13:58 -07:00
Andrew Steinborn
3a2986e746 Optimize entity tracker passenger checks (#6361)
When a ServerEntity instance is first constructed, it uses a pre-Java 9 empty collection,
but passengers use Guava ImmutableList. When comparing the two collections via Object#equals
we miss out on an opportunity to reduce the check to little more than a reference equality
check (which is very fast).
2021-08-09 18:36:45 +00:00
Bjarne Koll
68db0c9853 Support complex components in written book builder (#6337)
The previously existing toBuilder method defined on the CraftMetaBook
would, no matter if called on a writable or written book, return a
builder targetting a writable book, in which complex components, such as
hover or click text are not allowed.

The builer hence serializes the page components using LEGACY_UXRC to
ensure only colour may be passed. While this works as intented for
writable books, the builder fails to fully support the complex
components that may be used in a written book.

This commit implemements a child class of the CraftMetaBookBuilder, the
CraftMetaBookSignedBuilder, which builds to a CraftMetaBookSigned
instance and hence serializes the pages to json.
This builder instance is automatically supplied when calling toBuilder
on a CraftMetaBookSigned instance.

Resolves: #6296
2021-08-09 00:57:20 +02:00
Jake Potrebic
835479f878 clone itemstack to return remaining stack (#6353) 2021-08-06 23:55:16 -07:00
Jake Potrebic
77aea984df Add missing DamageCause for EntityDamageByBlockEvent (#6352) 2021-08-06 23:03:50 -07:00
Jake Potrebic
6b7f31b6ea Make hoppers respect inventory max stack size (#4838) 2021-08-06 17:35:42 -07:00
Kacper Płażewski
b7d13d69f9 [ci skip] add vs code files to .gitignore (#5663) 2021-08-07 02:27:45 +02:00
Jake Potrebic
c5487cc115 call EntityDamageByBlockEvent for campfires (#6244) 2021-08-06 17:20:39 -07:00
Jake Potrebic
299284be1d Add PlayerSetSpawnEvent (#5690) 2021-08-06 13:37:38 -07:00
thamid-gamer
973d5bf77b Fix Incorrectly Typed Goals (#6200) 2021-08-06 13:05:53 -04:00
Noah van der Aa
5aeb8c87e7 Fix ITEM_DROPPED stat not working properly (#6331) 2021-08-06 18:46:25 +02:00
Shane Freeder
c45970a2c1 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
75a0ee4f SPIGOT-6691: Material.LAVA_CAULDRON is not Levelled

CraftBukkit Changes:
e1c96e50 SPIGOT-6682: Blocking with shield not reset after die
97f629b6 SPIGOT-6220: Structures in the world with custom generator not work
85379258 Increase outdated build delay
f7f8dce4 SPIGOT-6552: Some inventory types reset cursor on switch
2021-08-04 16:26:56 +01:00
Prof-Bloodstone
5d201168ef Fix writing server.properties with wrong encoding (#6322)
Fixes #6321
2021-08-04 09:48:15 +02:00
Shane Freeder
06a831d477 Fix SysoutCatcher when plugins log before initialisation (Fixes #6323) 2021-08-04 04:04:12 +01:00
Mariell Hoversholm
9ff41ed426 fix: boats' bounding boxes must be deflated, not inflated (#6314)
Fixes GH-6312.

Signed-off-by: Mariell Hoversholm <proximyst@proximyst.com>
2021-08-03 12:13:43 +02:00
Emilia Dreamer
e51f909450 Fix incorrect colors in ConsoleCommandSender messages with TranslatableComponents (#6287) 2021-08-03 10:48:34 +03:00
Prof-Bloodstone
cdd278225c Allow skipping writing of comments to server.properties (#6251)
Makes less git noise, as it won't update the date every single time

Use -DPaper.skipServerPropertiesComments=true flag to disable writing it
2021-08-03 09:35:02 +02:00
Noah van der Aa
f8261096c8 Prevent AFK kick while watching end credits (#6239). (#6265) 2021-08-02 10:43:56 +02:00
Hannes Greule
d891837b28 Rewrite LogEvents to contain information about the source jar of stacktrace elements (#6142) 2021-08-02 10:32:53 +02:00
Nassim Jahnke
243cfdf6b5 Don't not shuffle visible chunks (#6283) 2021-08-02 10:00:31 +02:00
Underscore11
fbc4b4ca6d Add System.out.println catcher (#6278) 2021-08-02 00:07:48 -07:00
Shane Freeder
b3f290d877 Fix some inconsistency issues with empty map items (#6304) 2021-08-01 16:55:25 +01:00
Shane Freeder
3a17437d6f Mark sensor and behavior timings as verbose 2021-08-01 10:22:55 +01:00
PaulBGD
1c0ded9f9b Correct handling of invalid maps (#6302) 2021-07-31 15:47:01 -05:00
Nassim Jahnke
722c7ccb57 Fix closeInventory shenanigans (#6292) 2021-07-30 11:37:11 +02:00
Owen1212055
23470be165 Add bee stinger API (#5962) 2021-07-28 20:36:53 -04:00
Nassim Jahnke
15031fa7d7 Updated Upstream (CraftBukkit) (#6279)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
6788550f SPIGOT-6678: ChunkSnapshot#isSectionEmpty() not working as intended.
3ad0fb1c #901: Fix PlayerStatisticIncrementEvent spam
2021-07-28 09:39:14 +02:00
Jason Penilla
e2a638ce6d Call EntityKnockbackByEntityEvent for RamTarget Behavior (#6273) 2021-07-26 09:41:26 -07:00
MeFisto94
7dc5d71367 Move "use-display-name-in-quit-message" to settings namespace (#6257) 2021-07-26 01:11:44 +02:00
Max Lee
b7ac1102ba Add config option to specify timings url (#6256) 2021-07-25 08:10:30 +01:00
TwoLeggedCat
8b32eebc95 Add fireball to default max load config (#6252) 2021-07-25 02:00:54 -05:00
Max Lee
0f090e7328 Add the default tick rate of the sensor to the timings (#6242) 2021-07-25 07:50:36 +01:00
Jake Potrebic
7b87553d96 Updated Upstream (CraftBukkit) (#6260) 2021-07-23 19:33:05 -07:00
Jake Potrebic
eaaca77f42 Fix flat bedrock (#6255) 2021-07-23 14:18:10 -07:00
Jake Potrebic
d58099f73b Updated Upstream (Bukkit/CraftBukkit/Spigot) (#6245)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
e7b0f8d6 #642: Add Crafting methods to API
9e58831e SPIGOT-6641: Use varargs in sendMessage
e409fe49 SPIGOT-6545: Unable to set Guardian target via API while awareness is disabled
6997c726 SPIGOT-6661: Fix missing radius from GenericGameEvent
02d03f35 SPIGOT-6369: Add ItemStack to HangingPlaceEvent

CraftBukkit Changes:
0abf420c SPIGOT-6665: Shearing a Snowman does not drop a carved pumpkin
e8e3cbcc #893: Add Crafting methods to API
879acfee Fix missing varargs from previous commit
6572b9c3 SPIGOT-6641: Use varargs in sendMessage
9e06bb2a SPIGOT-6663: Chicken Jockeys chickens don't despawn
699f2d36 SPIGOT-6545: Unable to set Guardian target via API while awareness is disabled
8ffa54ba SPIGOT-6369: Add ItemStack to HangingPlaceEvent
c851639c SPIGOT-6645: Call EntityChangeBlockEvent before PlayerHarvestBlockEvent
8d244b0b SPIGOT-3725, SPIGOT-6638, MC-136917: Properly clear tile entities before replacing

Spigot Changes:
18c71bf4 Rebuild patches
2021-07-22 11:11:56 -07:00
Jake Potrebic
e00202c42a Add ItemRarity test (#6247) 2021-07-21 21:48:24 -07:00
Jake Potrebic
012cb6b015 Fix various mob drops being captured as death drops (#5675) 2021-07-21 19:58:24 -07:00
Jake Potrebic
7eab7227cb Drop unneeded patch (#6240) 2021-07-21 11:18:54 -07:00
Nassim Jahnke
985e42705e Fix PaperTickList (#6241)
Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
2021-07-21 19:12:24 +02:00
Jason Penilla
4ca56ff079 [ci skip] Put mappings util in a separate class to the stacktrace deobfuscator (#6230) 2021-07-19 19:22:18 -07:00
Kyle Wood
d3ba412286 Update email & name (DenWav)
Also I think I prefer my few tiny patches to be GPL.
2021-07-19 21:07:53 -05:00
zml
fc90f774bc Fix book title and author being improperly serialized as components (#6190)
They are kept as plain strings
Additional validation has been added to prevent invalid books from being
sent to the client.
2021-07-19 16:11:06 -07:00
Nassim Jahnke
ba64307307 Don't expose ASM in API (#6229)
ASM was not meant to exposed to API consumers in the first place, and for the duration of time it has been exposed, it has also been relocated.

Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
2021-07-20 00:58:48 +02:00
Nassim Jahnke
e2ed8e9e86 Use mapped names for sensor and behavior timings/config (#6228) 2021-07-19 13:07:49 +02:00
Max Lee
3051846c73 Add rate options and timings for sensors and behaviors (#6027) 2021-07-19 10:47:33 +01:00
Max Lee
93634e1897 Don't apply cramming damage to players (#5903) 2021-07-19 10:31:03 +01:00
thamid-gamer
48f55186f1 Fix MerchantOffer BuyB Only AssertionError (#6206) 2021-07-19 05:16:53 -04:00
Jason Penilla
3626a2c62b Updated Upstream (Bukkit/CraftBukkit/Spigot) (#6222)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
eec4aab0 SPIGOT-6657: Add getPlayer to SheepDyeWoolEvent
205213c6 SPIGOT-6656: CauldronLevelChangeEvent is not fired correctly when dripstone fills the cauldron

CraftBukkit Changes:
b8c522d5 SPIGOT-6657: Add getPlayer to SheepDyeWoolEvent
f04a77dc SPIGOT-6656: CauldronLevelChangeEvent is not fired correctly when dripstone fills the cauldron
d1dbcebc SPIGOT-6653: Canceling snow bucket placement removes snow from bucket
4f34a67b #891: Fix scheduler task ID overflow and duplication issues

Spigot Changes:
d03d7f12 BUILDTOOLS-604: Rebuild patches
2021-07-18 00:41:53 -07:00
Nassim Jahnke
039952aa5e Revert "Fix PaperTickList" (#6216)
This commit reverts b166af8801
2021-07-17 21:57:00 +02:00
Nassim Jahnke
95ff18dca7 Fix block action handling (#6213) 2021-07-17 14:46:46 +02:00
Jake Potrebic
6cb42c485b Updated Upstream (Bukkit/CraftBukkit/Spigot) (#6209) 2021-07-16 18:48:27 -07:00
Jake Potrebic
b166af8801 Fix PaperTickList (#6191) 2021-07-16 09:18:04 -07:00
Jake Potrebic
186cf8842e Fix distanceSq check on block breaking (#6195) 2021-07-15 20:01:48 -07:00
Jake Potrebic
6602dc655e Catch desynced block breaks (#6193) 2021-07-15 16:00:58 -07:00
Jake Potrebic
83db66562f Use cause and cancel component in PlayerGameModeChanteEvent (#6192) 2021-07-15 14:44:59 -07:00
LemonCaramel
6ac1befa7b Fix Stonecutter #6180 issue (#6181) 2021-07-15 00:37:22 +09:00
sulu5890
22ac08c412 Fix incorrect message for outdated clients (#6160) 2021-07-13 21:49:38 -05:00
Shane Freeder
4ca03426b0 Expand resource pack API 2021-07-12 20:42:17 +01:00
Jason Penilla
713b774a85 [ci skip] Use commit timestamp instead of build time in manifest (#6161) 2021-07-11 23:24:48 -07:00
Jake Potrebic
67e2594825 Fix command signs (#6139) 2021-07-11 11:06:49 -07:00
Jake Potrebic
5ce2cd8c05 Updated Upstream (Bukkit/CraftBukkit/Spigot) (#6149)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
17c35d6e SPIGOT-6637: Revert "#636: Add FurnaceStartSmeltEvent"
4b27230b SPIGOT-6623: Missing API reasons for entity freezing
e1528c85 #636: Add FurnaceStartSmeltEvent

CraftBukkit Changes:
a6292cc3 SPIGOT-6637: Revert "#874: Add FurnaceStartSmeltEvent"
f4066854 SPIGOT-6579: DragonFireBall movement with setDirection jumps around a lot
9add952b SPIGOT-6623: Missing API reasons for entity freezing
2ea359f1 #874: Add FurnaceStartSmeltEvent
be8d625e SPIGOT-5560, SPIGOT-6574, SPIGOT-6632: Remove no longer needed tile entity fix

Spigot Changes:
eac3cd96 Rebuild patches
2021-07-11 00:01:29 -07:00
Jake Potrebic
f359da1843 Fix NPE from using wrong ProtoChunk ctor (#6147) 2021-07-10 13:17:47 -07:00
Jake Potrebic
dcdec7d59c Add config for mobs immune to default effects (#4835) 2021-07-09 21:49:49 -07:00
Jake Potrebic
ee11682d4d fixed kick event leave message (#4766) 2021-07-09 12:03:28 -07:00
Nassim Jahnke
081a882f94 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
b5d7883a SPIGOT-6634: Override needed method
99561c21 SPIGOT-6624: Explosions do not destroy blocks out of vanilla heights in custom dimensions
2021-07-09 16:08:42 +02:00
Jake Potrebic
fc955009ca Add PlayerArmSwingEvent (#5353) 2021-07-09 06:56:30 -07:00
Xemorr
d81fd123ce Swapped out Vec3#distanceTo call with a Vec3#distanceToSqr call to remove calls to Math.sqrt 2021-07-07 20:58:54 +01:00
Jake Potrebic
2c55fce23e Fix collisions during world generation (#6129) 2021-07-09 03:16:57 -07:00
Jason Penilla
5fe7fbd769 [ci skip] Add a test plugin (#6133) 2021-07-09 03:04:33 -07:00
Jason Penilla
43e9be4586 [ci skip] Remove extra newlines at EOF (#6127) 2021-07-08 18:40:24 -07:00
Bjarne Koll
fc1a197de2 Ensure shulker bounding box is updated (#6010)
Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2021-07-09 03:18:32 +02:00
Jake Potrebic
9d46f898d9 Fix cancelling EntityPickupItemEvent for villagers (#6091)
Remove's Billy's fix as upstream implemented a (broken) fix and then fixed their fix
2021-07-07 11:07:38 -07:00
Nassim Jahnke
2689c8d04f Drop no longer needed patch (#6115) 2021-07-07 19:18:05 +02:00
MD
aeb072c35d Route sign run_command click events through normal chat logic (#6109)
This patch changes sign command logic so that `run_command` click events are routed through the standard chat/command
logic used for inbound chat messages.

This fixes numerous issues related to sign click commands:
  - Signs with a `run_command` value of "/<plugin command>" would fail and show the "Unknown command" warning. This
    prevents usage of commands like `//wand` from WorldEdit in sign click events entirely and requires users to drop
    the leading slash from other plugins' commands. This patch now executes the plugin commands as would be expected,
    adding a leading slash if necessary.
  - Signs with a `run_command` value that doesn't match an existing command could fail silently. This patch causes
    these to *always* show "Unknown command" instead.
  - Plugins listening to `PlayerCommandPreprocessEvent` would not be able to intercept any command executions from
    sign click events. This patch allows plugins to intercept player commands when fired by a click event, in the same
    manner as commands executed by the player typing or clicking on a chat message.
  - Commands executed from signs would not be logged to the console. This patch fixes this.

This patch also prepends a leading slash if the `run_command` value lacks one, which matches vanilla behaviour (old
code would strip this slash away) while also ensuring `PlayerCommandPreprocessEvent#getMessage` remains consistent
with other command executions from chat (which always include the leading slash).
2021-07-07 16:12:58 +01:00
Jason Penilla
737c162fe2 [ci skip] Use Java toolchain for run tasks (#6108) 2021-07-07 06:18:02 -07:00
Malfrador
fa7bf2d3dc Add option for logging named entity deaths (#6107) 2021-07-07 15:15:17 +02:00
dfsek
6a93c5c949 Add methods to ProtoWorld for working with BlockStates (#5929) 2021-07-07 03:23:16 -07:00
Jason Penilla
0b90741c3f Move log message for named entity deaths into correct location (#6105) 2021-07-07 03:04:34 -07:00
Jason Penilla
8a664e6bbc Deobfuscate stacktraces in sync load info (#6103) 2021-07-07 00:19:08 -07:00
Nassim Jahnke
7037cd401f Update to Minecraft 1.17.1 (#6097) 2021-07-07 08:52:40 +02:00
Jake Potrebic
43f52d9c13 add Optimize Light Engine patch (#5863) 2021-07-05 21:30:39 -07:00
chickeneer
d61d127882 AbstractSkeleton should extend RangedEntity (#6087)
This includes Strays and matches the mojang RangedAttackMob
2021-07-05 22:48:08 -05:00
Jason Penilla
cad0a49123 Fix incorrect variable usage in per-player mob spawning patch (#6077) 2021-07-04 09:30:59 -07:00
Jason Penilla
08033a4fc0 Also deobfuscate secondary stacktraces in crash reports (#6078) 2021-07-04 03:20:11 -07:00
Jason Penilla
1d6b275814 Fix Bossbar updating (closes #6061) (#6076) 2021-07-03 16:26:13 -07:00
Jake Potrebic
42714f234c fix custom beacon ranges (#6067) 2021-07-02 12:51:49 -07:00
PaulBGD
88029f0e8a Readd "Use getChunkIfLoadedImmediately in places" (#6047)
* Readd "Use getChunkIfLoadedImmediately in places"

* Formatting

* Fix var names
2021-07-02 14:04:29 -05:00
BillyGalbreath
42293b52e2 Honor spigot.yml setting log-villager-deaths (#6057)
cat note: giggity.
2021-07-01 22:28:31 -05:00
Shane Freeder
2143a948be Fix NPE when completing skull lookups without a real owner (Fixes #6052)
This looks like mojang introduced an NPE however it was previously being
supressed by the future used by the server, we'll just stick to the legacy
behavior of retainining the existing profile of earlier versions
2021-07-01 00:10:28 +01:00
Shane Freeder
0641643c4a Backport MC-229191 ore distribution changes 2021-06-30 22:11:40 +01:00
Shane Freeder
5a5d27f6a1 Fix NPE when using broadcast as players are joining 2021-06-29 22:21:42 +01:00
Shane Freeder
0e2c1c7288 [ci skip] patch-ception 2021-06-29 17:39:17 +01:00
Shane Freeder
73d13c8c88 Don't complete skull lookups on main thread (MC-227435) 2021-06-29 17:34:20 +01:00
Jason Penilla
d0c06257f1 [ci-skip] Fix description of add-plugin command line option (#6031) 2021-06-29 02:09:02 -07:00
stonar96
c7e9c0260f Optimize Anti-Xray (#5991) 2021-06-29 11:01:47 +02:00
Jason Penilla
85ba428029 Fix return value of Block#applyBoneMeal always being false (#6030) 2021-06-28 18:37:44 -07:00
Shane Freeder
f3e872c626 Fix players not being added to collide rule (Fixes #6024) 2021-06-28 22:16:46 +01:00
Jake Potrebic
cecb38e6ed Improve horrible CraftChunk#getEntities performance (#5999)
Thanks Spigot, very cool.
2021-06-28 05:53:28 -07:00
Kyle Wood
4c515198bb Trim whitspace off of git hash (oops) 2021-06-26 23:51:03 -05:00
Kyle Wood
16030c824f Update task dependency for includeMappings so the new task isn't skipped
The new task fixJarForReobf was added after shadowJar, but since
reobfJar's input is changed in this patch, that new task needs to be
referenced instead of shadowJar.
2021-06-26 22:26:17 -05:00
Kyle Wood
0b0461e997 Remove now unneeded patch due to paperweight 1.1.7 2021-06-26 22:22:05 -05:00
Kyle Wood
99bb2c025c Get short commit ref using a more proper method 2021-06-26 22:15:13 -05:00
Shane Freeder
65c6d7f38f Drop codec spam fix (Fixes #5936)
having spoken to mojang about this the general issue is data which shouldn't
have been saved in the first place, so if we lose this data it's not really
an issue, bar being annoying spammy. if the spam gets on your nerves, shamefully,
all you can really do is forceUpgrade to get the conversions of the way.

Dropping as this breaks other aspects of the server and bar being spammy
seems to have no other real negative outcomes
2021-06-26 12:56:06 +01:00
Nassim Jahnke
f800d80c45 Fix chicken jockey chicken persistence (#6005) 2021-06-26 10:54:24 +02:00
Jake Potrebic
28e57942d7 Fix use of universe flag and forceUpgrade 2021-06-25 18:56:12 -07:00
Jason Penilla
254ac170de Do not cancel chunk load on ticket level change (#5978)
New chunk system doesn't do cancellations anymore.

Co-authored-by: Spottedleaf <spottedleaf@users.noreply.github.com>
2021-06-24 02:12:47 -07:00
Shane Freeder
65a6e249ea Allow explosions under 0 height (Fixes #5974)
Upstream forgot to update the check here which prevents explosions
occuring under 0 height, however, vanilla already checks that we
are in bounds of the world above this, so this call is entirely
redundant.
2021-06-24 01:44:23 +01:00
Prof-Bloodstone
5126271b6c Make gradle take build number from env vars and add git build info (#5890)
* Make gradle take build number from env vars

* Add git information to manifest and version command/log

* trim

* Fix tests by adding NotNull annotations

* rebase

* Apply suggestions from kashike

Co-authored-by: Riley Park <rileysebastianpark@gmail.com>

* Not always show branch

* Why can't everything be NotNull by default?

* Rebase

Co-authored-by: Riley Park <rileysebastianpark@gmail.com>
2021-06-23 19:19:44 +02:00
stonar96
c00618d009 Refactor Anti-Xray and make some fixes to it (#5938) 2021-06-23 10:39:02 +02:00
Jake Potrebic
2c17a86e82 Fix mobs not burning from summon command (#5961) 2021-06-23 01:07:59 -07:00
Jake Potrebic
7c2140bc63 Fix NPE when setting cook multiplier (#5956) 2021-06-22 12:26:03 -07:00
Shane Freeder
5b8a29a0cc Ensure disconnect for book edit is called on main 2021-06-22 20:00:11 +01:00
Jake Potrebic
ce3e8e8708 remove calling expensive method (#5955) 2021-06-22 11:52:45 -07:00
Shane Freeder
4ad15af215 Fix kick event being fired off main thread 2021-06-22 19:35:35 +01:00
Nassim Jahnke
b7605a2231 Fix player collision patch cleanup (#5947) 2021-06-22 15:58:20 +02:00
Shane Freeder
1599ffc11d Try even harder to get an origin world and avoid NPEs (Fixes #5931) 2021-06-22 11:54:49 +01:00
Owen1212055
4a7d7decce Add more fox API (#5743) 2021-06-22 03:44:02 -04:00
Jason Penilla
ed04368157 Expand where stacktraces can be deobfuscated (#5944)
Also load the mappings from the correct location
2021-06-21 21:12:07 -07:00
BillyGalbreath
83bbb318a6 [ci skip] Very important bug fix :O (#5934) 2021-06-21 09:36:53 -05:00
Shane Freeder
58c3edcb08 Try to prevent an NPE from origin data (Fixes #5905) 2021-06-21 10:04:18 +01:00
Shane Freeder
1763250105 Fix early load perms patch (Fixes #5917) 2021-06-21 09:41:00 +01:00
Jason Penilla
5f20f9bf95 Deobfuscate stacktraces in log messages using a RewriteAppender and a custom RewritePolicy (#5926)
Also replace a couple calls to `System.err` with logger usages, as traces printed with the former do not get deobfuscated.
2021-06-21 01:09:18 -07:00
Jason Penilla
6922070800 Fix PlayerDropItemEvent using wrong item (#5924)
Co-authored-by: Spottedleaf <spottedleaf@users.noreply.github.com>
2021-06-20 22:12:04 -07:00
lexikiq
c10499bc4d Fix "Don't ignore result of PlayerEditBookEvent" (#5923) 2021-06-21 00:29:59 -04:00
Nassim Jahnke
41acf2c279 Updated Upstream (Bukkit/CraftBukkit/Spigot) (#5904)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
70d24eb8 SPIGOT-6587: Update documentation/error of drop chance API

CraftBukkit Changes:
470050ad SPIGOT-6587: Update documentation/error of drop chance API
1c39efa3 Fix Inventory#getViewers on the player inventory not returning the player first time their inventory is opened
d161627d Fix PrepareItemCraftEvent#isRepair
aa1fae73 SPIGOT-6586: EntityChangeBlockEvent for falling block does not cancel properly
8a04072e SPIGOT-6583: Throwing eggs doesn't make sounds

Spigot Changes:
f773da84 Remove redundant patch
cd367234 Rebuild patches
2021-06-20 21:25:59 +02:00
Shane Freeder
e6193a1630 Add invalid player data to misc debug dumps 2021-06-20 15:06:37 +01:00
Spottedleaf
4bfd5dbc06 Fix Codec log spam
Mojang did NOT add dataconverters for world gen configurations
that they CHANGED. So, the codec fails to parse old data.

This fixes two instances:
- IntProvider is new and Mojang did not account for old data.
  Thankfully, only ColumnPlace needed to be special cased.
- TreeConfiguration had changes. Thankfully, they were
  only renames for one value and thankfully defaults could
  be provided for two new values (WITHOUT changing behavior).
2021-06-20 12:58:35 +01:00
Jason Penilla
c0ee8ae35e Rename package from io.papermc.paper.world.gen to io.papermc.paper.world.generation (#5894) 2021-06-19 22:02:27 -07:00
dfsek
cba64693c4 Worldgen Feature API (#5727) 2021-06-19 21:48:30 -07:00
Riley Park
892f1ec052 Fix GS4 querying 2021-06-19 18:27:04 -07:00
Nassim Jahnke
eac2ccfb3a Fix startup delay and warning caused by oshi 2021-06-19 09:57:56 +02:00
Nassim Jahnke
601c40df88 Updated Upstream (CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

CraftBukkit Changes:
68d40318 SPIGOT-6580: Cancelling SlimeSplitEvent Causes Infinite Loop
78d93f77 SPIGOT-6576: BlockExpEvent does not show XP when breaking a furnace
2021-06-19 09:06:28 +02:00
Jake Potrebic
91e39ea5ac add back optimizing ServerLevel chunk checking methods 2021-06-17 22:51:04 -07:00
Jason Penilla
7606788417 Save BlockEntities on main for async chunk saves
Closes #5854
2021-06-18 21:38:44 -07:00
Jason Penilla
166760a713 Remove chat event APIs marked as deprecated for removal with 1.17 2021-06-18 15:47:40 -07:00
Kyle Wood
c34b6734a2 Move package version to server project 2021-06-18 00:25:16 -05:00
Riley Park
c867b69e41 Thanks for joining us for the magic show tonight 2021-06-17 20:38:22 -07:00
djytw
5e9ba09e6d Fix #5856 Entity origin (#5861) 2021-06-18 03:37:23 +00:00
Riley Park
1942e47836 Don't include log4j 2021-06-17 18:42:17 -07:00
Jake Potrebic
570006ab1e remove more obfhelpers 2021-06-17 14:39:36 -07:00
MiniDigger | Martin
6c9cd70194 fix build 2021-06-17 22:25:52 +02:00
MiniDigger | Martin
4ac379cbd0 death to more obfhelpers 2021-06-17 22:20:03 +02:00
MiniDigger | Martin
62fabeca0c deprecate all obfhelpers 2021-06-17 21:52:26 +02:00
MiniDigger | Martin
a486d2eccf nuke a few more obfhelpers 2021-06-17 21:37:37 +02:00
MiniDigger | Martin
8d5fa8c53b remove system property for book size limits
"It was from a different time before books were as jank as they are now. As time has gone on they've only proven to be worse and worse."
2021-06-17 21:12:40 +02:00
MiniDigger | Martin
a716afea03 check if sender is a player in paper dumpitem command, closes #5858 2021-06-17 20:13:55 +02:00
Jake Potrebic
6d848fc4bf remove remaining POMs 2021-06-17 10:11:00 -07:00
Nassim Jahnke
36b107516b Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
2dbec584 SPIGOT-6570: Missing InventoryType: COMPOSTER
e9ce88b9 SPIGOT-6562: Add more specific sculk sensor event

CraftBukkit Changes:
9122f5a6 #869: Fix BossBar setColor and setStyle updates
96a15d7a Incrase outdated build delay
ded19075 SPIGOT-6570: Missing InventoryType: COMPOSTER
d7ef1e91 SPIGOT-6558: Attempt to improve SkullMeta
e7a63287 SPIGOT-6562: Add more specific sculk sensor event

Spigot Changes:
101ebb63 SPIGOT-6573: Berry Bushes deal damage when not moving
2021-06-17 14:50:16 +02:00
Jason Penilla
1ffd69b7cc Update incremental chunk saving 2021-06-17 01:37:27 -07:00
Jason Penilla
5eb7d40379 Update Entity load/save limit per chunk 2021-06-16 21:00:32 -07:00
Kyle Wood
3dc0a3fafc Relocate other libraries Spigot added and relocates in 1.17 2021-06-16 20:56:44 -05:00
Kyle Wood
c7a0195cdd Add a note about deleting pom.xml in first patch 2021-06-16 20:46:15 -05:00
Kyle Wood
b2cab70594 Minor patch cleanup 2021-06-16 20:43:30 -05:00
Jason Penilla
48c1ea17c3 Fix artifact ids 2021-06-16 16:23:02 -07:00
Jake Potrebic
7de25fd330 update to Adventure 4.8.1 2021-06-16 15:57:49 -07:00
Jake Potrebic
4d67d89033 remove some more obf helpers 2021-06-16 10:48:25 -07:00
Nassim Jahnke
15c337032b Enable chunk load for feature search by default 2021-06-16 22:42:48 +02:00
Jake Potrebic
06d10601a7 fixes issue with chunk saving
fixes #5854
2021-06-16 13:34:49 -07:00
Nassim Jahnke
79da41d557 Fix entity death sounds 2021-06-16 22:17:53 +02:00
Jake Potrebic
f2f6f697bc remove optimise random tick patch for now 2021-06-16 13:12:05 -07:00
Nassim Jahnke
a483019516 Port improve chunk status transition speed 2021-06-16 15:47:07 +02:00