Commit Graph

2126 Commits

Author SHA1 Message Date
Rsl1122
b80198ef51 [Debt] Removed some static ServerInfo methods
serverUUID method will require a separate working, as it has 40 usages.
2018-09-18 18:25:12 +03:00
Rsl1122
57377ece82 [Debt] RecentLoginList construction, add Formatter
Added Formatter<Long> to RecentLoginList constructor.
2018-09-18 18:21:23 +03:00
Rsl1122
f26294d9dd [Debt] Turned GeolocationCache methods non-static
getInstance is not necessary as GeolocationCache can be injected
everywhere where it is required (Mostly at gathering layer)
Discovered old GeolocationCacheTest that was removed.
2018-09-18 18:18:52 +03:00
Rsl1122
654d7ca03c [Debt] Removed static methods WorldAliasSettings
Usage in Session is in a deprecated method, needs to be sorted - TODO
Other usages injected WorldAliasSettings
2018-09-18 18:04:22 +03:00
Rsl1122
aff935bfc1 [Debt] Removed HookHandler.getInstance() method.
This method was in use for generating different PluginData related
things: Bans, Analysis page & Inspect page plugins tabs.

- Bans: Removed BanData related analysis objects as it is deprecated.
Plugins will not be asked if a player is banned in the future, and
will rely on server OfflinePlayer#isBanned instead.

- Analysis Page: Generation tool is still static, on the TODO list.

- Inspect Page: Added HookHandler as injected dependency
2018-09-18 17:58:01 +03:00
Rsl1122
2b4e6fe9cb [Debt] Removed SessionCache.getInstance() method 2018-09-18 17:34:42 +03:00
Rsl1122
7b09f588fe [Debt] Removed ConfigSystem.getInstance method
Related methods (getConfig_Old, getThemeSystem) were also removed.

Affected issues: none
2018-09-18 17:33:22 +03:00
Rsl1122
fca93578af [Debt] Removed Settings#setTemporaryValue method.
This method was used in tests, but is not the optimal way of performing
temporary test values as APF supports in memory configuration object.

Old usages were commented in order to preserve assumed temporary values.

Affected issues: none
2018-09-18 17:30:57 +03:00
Rsl1122
2b1cf4b3cb [Debt] Removed Settings getNumber method
Some threshold values are needed in mutators and tasks, but they are not
yet available in the classes they are used. TODO was added.

ActivityIndexTest was removed as it does not test proper stuff.

Affected issues: none
2018-09-18 16:01:06 +03:00
Rsl1122
b6cc713c01 [Debt] Removed Settings isTrue method.
Moved MiscUtils.getTimeZoneOffsetHours to PlanConfig as non static.

Affected issues: none
2018-09-18 15:46:41 +03:00
Rsl1122
bff365de20 [Debt] Removed MiscUtils.getPlanVersion() method.
This method was dependent on PlanPlugin.getInstance() which is being
removed.
Also removed use of Settings in MiscUtils.close methods.

Affected issues: none
2018-09-18 15:39:50 +03:00
Rsl1122
54e3528a59 [Debt] Removed Theme replaceColors method.
All static methods removed now from Theme.
Delegated Theme and Locale html modifications to Response#send method.

Affected issues: none
2018-09-18 15:16:00 +03:00
Rsl1122
35be0a2afb [Debt] Removed static Theme getValue method
Theme depends on a configuration file, so it should not be static.

Affected issues: none
2018-09-18 14:55:09 +03:00
Rsl1122
275bfe64b4 [Debt] Removed some deprecated Settings methods.
Removed methods: toString(), getStringList() & set(Object).

Affected issues: none
2018-09-18 12:18:55 +03:00
Rsl1122
f92c9e2b89 [Docs] Added javadoc titles for Formatter classes
Affected issues: none
2018-09-18 12:07:38 +03:00
Rsl1122
b4f7053936 [Debt] Created HtmlTable factory for Table creation
Inject HtmlTables to access the factory.
Abstracted away details of TableContainer creation in the factory.
Each table class is now package private, and present as TableContainers.

Removed MapComparator as it became obsolete.

Affected issues: none
2018-09-18 11:53:07 +03:00
Rsl1122
fac06e7d80 [Debt] Removed FormatUtils class.
Added instance variables for different Formatter objects with a TODO to
accompany the additions where dagger injection was not yet possible.

Moved formatIP to GeoInfo
Moved getStackTrace to PromptAuthorizationResponse

Affected issues: none
2018-09-17 23:39:21 +03:00
Rsl1122
8d36b08acb [Debt] Removed static methods in Formatters class.
Added instance variables for different Formatter objects with a TODO to
accompany the additions where dagger injection was not yet possible.

Affected issues: none
2018-09-17 23:12:27 +03:00
Rsl1122
b104e8ca03 Made Graph Factories that use Dagger to initialize new Graphs.
Inject Graphs to access these factories.
Moved WorldTimes Alias playtime calculations to WorldAliasSettings

Renamed some Graphs to be shorter and unambiguous:
AbstractLineGraph -> LineGraph
AbstractPieChart -> Pie
AbstractPieChartWithDrilldown -> PieWithDrilldown
AbstractStackGraph -> StackGraph

Abstracted away some details and made some graph classes package private

Fixed tests for Line graphs, removed Stack graph test for now
2018-09-16 17:23:21 +03:00
Rsl1122
cb351c80f1 Removed many deprecated Log & BenchMark usages
Where possible replaced with PluginLogger or ErrorHandler calls,
some places removed a catch clause and added throws,
some places removed the log or benchmark completely.

Some places still need to be modified so that the required dependencies
can be injected.
2018-09-13 19:44:45 +03:00
Rsl1122
c67f0475a0 Removed DataCache#getInstance method 2018-09-13 19:18:33 +03:00
Rsl1122
abc1bc3bc4 Turned Formatters class non static, usages still exist 2018-09-09 17:54:13 +03:00
Rsl1122
273050f1b2 Reduced usage of static Settings accessors 2018-09-09 15:30:20 +03:00
Rsl1122
3a7b94a94f Fixed StackOverflowExceptions on enable caused by dependency cycles
Registered pages on ResponseHandler separately
Registered commands in PlanCommand and PlanBungeeCommand separately

Made WebServer Lazy in InfoSystems and ConnectionSystems
2018-09-09 14:53:41 +03:00
Rsl1122
db69d07100 Refactored ImportManager into ImportSystem that is not static.
Moved Import data objects to system.importing.data
Moved Importer classes to system.importing.importers

Bound ImportSystem instances in SuperClassBindingModules

Added ImportSystem as injected parameter to PlanSystem
Injected ImportSystem to ManageImportCommand

Removed old references to ImporterManager and removed the class
Moved ImportBuilderTest to system.importing.data
2018-09-09 14:26:02 +03:00
Rsl1122
d9cb158e3c Updated pom version to 4.5.0-SNAPSHOT 2018-09-02 15:44:01 +03:00
Rsl1122
f9f82315e0 Processors (ProcessorFactory), KillProcessors simplified 2018-09-02 12:30:37 +03:00
Rsl1122
8c75e936d6 Spacing 2018-08-30 15:51:42 +03:00
Rsl1122
17e8bc105e Removed static uses in database package and Database.getActive 2018-08-29 16:56:11 +03:00
Rsl1122
23f679802e Made Processing non static and initialized by Dagger 2018-08-29 10:58:29 +03:00
Rsl1122
c0f1dfc8c5 Removed all getInstance method calls related to InfoSystem. 2018-08-29 10:13:37 +03:00
Rsl1122
ff02eefb20 WorldAliasSettings initialized by Dagger, ConnectionLog changes 2018-08-28 12:00:03 +03:00
Rsl1122
ed40c916fb Missing singleton annotations 2018-08-28 10:53:10 +03:00
Rsl1122
90b3e55dc7 InfoRequestFactory, InfoRequestHandlerFactory, initialized by Dagger 2018-08-27 22:36:23 +03:00
Rsl1122
bcd20f4390 PageHandlers initialized by Dagger, ResponseFactory, PageFactory 2018-08-27 17:18:17 +03:00
Rsl1122
93aa208472 Theme and Config related things initialized by Dagger, module cleanup 2018-08-23 13:56:24 +03:00
Rsl1122
63b1419b12 Export initialized by Dagger, added more Singleton annotations, fixes 2018-08-23 10:53:07 +03:00
Rsl1122
c6b9058bb0 Tasks, BungeeTaskSystem initialized by Dagger 2018-08-23 09:49:17 +03:00
Rsl1122
8d28169c6c BungeeInfoSystem initialized by Dagger 2018-08-23 09:18:04 +03:00
Rsl1122
20b651f909 WebServer initialized by Dagger 2018-08-22 10:19:52 +03:00
Rsl1122
81a6ed7365 UUIDUtility & PlanAPI initialized by Dagger - needs singleton 2018-08-21 18:33:40 +03:00
Rsl1122
6700d6918c Made Dagger initialize Database & Config Systems 2018-08-21 16:26:37 +03:00
Rsl1122
6992aedc4b Stopped tests failing with an Assume and @Ingore annotations 2018-08-20 18:32:51 +03:00
Rsl1122
251f0414e9 Prevented compile errors from different tests by assigning null values 2018-08-20 18:26:37 +03:00
Rsl1122
b66033f589 Sponge Listener + Task Systems now initialized by Dagger 2018-08-20 18:15:24 +03:00
Rsl1122
604496fb64 Bukkit Listener + Task Systems now initialized by Dagger 2018-08-20 18:07:22 +03:00
Rsl1122
86ba26e50e Bukkit + Sponge ServerInfo & ShutdownHook now initialized with Dagger 2018-08-20 17:43:55 +03:00
Rsl1122
b48eb26f74 Large changes: (Still compiles, does not function)
- Made all Command related things be initialized by Dagger
- Removed Update stuff since it is incompatible with ConnectionSystem removal
- Deprecated a lot of static methods
2018-08-19 13:22:55 +03:00
Rsl1122
0b56576bb8 Started work on Dagger modules, extremely incomplete - will not run. 2018-08-18 21:53:33 +03:00
Rsl1122
f324541343 Removed use of EnumUtility 2018-08-17 15:32:42 +03:00