Commit Graph

2707 Commits

Author SHA1 Message Date
Rsl1122
fdaefd7e64 Cleaned up ConfigReader code 2019-01-06 11:07:19 +02:00
Rsl1122
0dd3af9a68 ConfigNode copy now preserves the original properly
Fixed a possible future issue where tree up-traversal is broken
if a node in a tree is passed to a copy operation.
This was because the parent node was updated in the process of copy if
no old node was present.

Fixed by creating a new node when copying instead of reusing the
object being copied
2019-01-05 20:21:10 +02:00
Rsl1122
f6384a49a4 Fix typo in query 2019-01-05 18:26:34 +02:00
Rsl1122
ad85bc385a Rewrote foreign key drop code in Patch 2019-01-05 18:21:23 +02:00
Rsl1122
1669e5ca56 [#822] Flipped condition
- "Active Players might be running out of things to do" was flipped due
  to the condition being flipped.
2019-01-05 18:00:24 +02:00
Rsl1122
b1746c5dab [#483] 'Display_options.Open_player_links_in_new_tab'
- Added a config setting for /player links opening in new tab, defaults
  to false. Only exists in case someone wants to have previous behavior
- Changed Player table links to follow the setting, some plugin links
  may still use the "wrong" link
2019-01-05 12:08:26 +02:00
Risto Lahtela
c9e80e31f1
Add checkstyle config file location to build.gradle (#871) 2019-01-04 17:44:59 +02:00
Rsl1122
ea187fadfc Added 'set -e' to test scripts to exit correctly 2019-01-04 17:18:35 +02:00
Rsl1122
7621167407 [#708] Added "back" links
- Added a back link /server -> /network if on a network
- Added a back link /player -> /server if on a server
- Added a back link /player -> /network if on a network
2019-01-04 17:11:49 +02:00
Rsl1122
ff266893d1 More tests against issues found during manual testing
During testing it was found that:
- MySQL patches are still failing if they failed before (test_sessions
  has foreign keys)
- Time.Thresholds.AFK_threshold was empty on fresh install (Leading to
  NPE that was prevented)
2019-01-04 17:09:28 +02:00
dependabot[bot]
3ad9277c99
Bump nucleus-api from 1.8.0-S7.1 to 1.8.1-S7.1 in /PlanPluginBridge (#870) 2019-01-04 13:05:25 +00:00
Rsl1122
2a272f3e6f +2 rules to checkstyle:
- switch statement fall through check
- inner assignment check
2019-01-03 14:43:33 +02:00
Rsl1122
df306b2c41 Merge remote-tracking branch 'origin/development' into development 2019-01-03 14:22:25 +02:00
dependabot[bot]
b7b96d5d37
Bump HikariCP from 3.2.0 to 3.3.0 in /Plan (#869) 2019-01-03 12:22:13 +00:00
Rsl1122
ad61522e89 Flipped equals statements with string literals 2019-01-03 14:04:26 +02:00
Rsl1122
ca52000794 EqualsAvoidNull check to checkstyle 2019-01-03 14:04:04 +02:00
Rsl1122
1bd6bef85d Fixed travis script paths 2019-01-03 13:33:23 +02:00
Rsl1122
7e52646cd2 Fixed travis script paths 2019-01-03 13:28:04 +02:00
Rsl1122
5444c04949 Fixed travis script paths 2019-01-03 13:22:23 +02:00
Rsl1122
63ea5b854e Added travis job for checkstyle 2019-01-03 13:18:57 +02:00
Rsl1122
dd904b84fc Updated missing or outdated license headers 2019-01-03 13:12:19 +02:00
Rsl1122
29f3f6b47b [#866] Added Checkstyle with license header check 2019-01-03 12:52:01 +02:00
Rsl1122
4aafcd1034 Added gradle out/ folder to gitignore 2019-01-03 12:38:37 +02:00
Rsl1122
19dbf232bb Update travis scripts
- Split sonarqube goal into its own script. Now sonar runs only
  after unit tests succeed.
2019-01-03 12:38:25 +02:00
Rsl1122
ea2bc982f2 Moved HTTPWebServerAuthTest from 'plugin' to 'common' module 2019-01-02 17:11:46 +02:00
Rsl1122
31986644f9 Fixed HTTPSWebServerAuthTest 2019-01-02 17:08:53 +02:00
Rsl1122
6dcc02ebb6 Moved database tests from 'plugin' to 'common' module 2019-01-02 16:58:23 +02:00
Rsl1122
1773dd6b97 Fixed BungeeSystemTest on systems with mysql installed 2019-01-02 16:55:37 +02:00
Rsl1122
722e28005d Made CommonDBTest use PluginComponentMocker instead
- Added H2 to PluginComponent databases
2019-01-02 16:55:19 +02:00
Risto Lahtela
6c5355369a
[#860] Fixed MySQL Patch application (#867)
* Patch#dropTable no longer swallows exceptions

* Made TestRunnableFactory not run anything

* Drop some foreign keys during WorldsOptimization and SessionsOptimization patches (This is the fix)
2019-01-01 23:01:37 +02:00
Rsl1122
b540786010 More detailed check for patch failings 2019-01-01 12:36:39 +02:00
Rsl1122
f8391305dc Additional assertions to patch regression tests
- Check that the patches have been properly applied
- Check that removal works
2019-01-01 12:25:31 +02:00
Risto Lahtela
f333ae7cc9
Mysql patching test fix (#865)
* Added MySQL to PluginComponentMocker DBSystem

* Enabled the full system on MySQLPatchRegressionTest

* Dropped the database on for each mysql test class to make the
  tests independent on each other
2019-01-01 12:05:33 +02:00
Rsl1122
d59eed039b MySQL Patch Regression Test for 4.5.2 2018-12-31 19:12:27 +02:00
Rsl1122
b0d1c442f3 Fixed issue with rename table in H2 for patches 2018-12-31 19:12:06 +02:00
Rsl1122
bd4613339b H2 Patch Regression Test for 4.5.2 2018-12-31 19:11:40 +02:00
Rsl1122
10756185d6 Split SQLitePatchRegressionTest to 2 classes 2018-12-31 19:11:09 +02:00
Rsl1122
470c5e45e6 Fixed IPAnonPatch failing after 4.6.0 patches 2018-12-31 17:17:07 +02:00
Rsl1122
7b368a907f Moved database tests to proper package 2018-12-31 17:12:15 +02:00
Rsl1122
844fe2178f 4.5.2 SQLite Patch test 2018-12-31 17:09:45 +02:00
Rsl1122
33b97b0745 Replaced init call with createTables in CommonDBTest#Before 2018-12-27 21:47:34 +02:00
Rsl1122
232ead5f1f Fixed database tests (dropped tables depending on ids) 2018-12-27 21:37:59 +02:00
Risto Lahtela
ac6ae09a05
Ci selenium fix (#863)
* Added --no-sandbox argument to chrome on travis
* Added xvfb screen display settings
* Updated chromedriver version
2018-12-27 21:06:10 +02:00
Risto Lahtela
94e62cb63c
Update prepareTestEnv.sh
Added permissions for the chrome folders in an attempt to fix 
org.openqa.selenium.WebDriverException: unknown error: Chrome failed to start: exited abnormally
2018-12-27 19:55:11 +02:00
Rsl1122
0d587f527e Fixed BungeeSystemTest#testEnableNoMySQL:
- Moved the condition to the correct place this time
2018-12-27 19:13:53 +02:00
Rsl1122
e5a0dabc80 Changed invalid webdriver environment variable name 2018-12-27 19:08:06 +02:00
Rsl1122
26c706a411 Fixed BungeeSystemTest#testEnableNoMySQL
Test was failing because travis runs MySQL on 3306 port with root user,
these were default Plan settings. Fixed by removing message expectation
on travis
2018-12-27 19:05:56 +02:00
Rsl1122
4641c7a4fd Fixed BungeeSystemTest#testEnableNoMySQL
Test was failing because travis runs MySQL on 3306 port with root user,
these were default Plan settings. Fixed by changing port to 6000 in the
test
2018-12-27 19:00:42 +02:00
Rsl1122
3d65e8c745 Unignored 2 BungeeSystem tests
- Caught a PoolInitializationException in MySQL to throw EnableException
  properly.
2018-12-27 18:51:11 +02:00
Rsl1122
217867ab52 Try to fix MySQL Tests
The tests were failing due to missing Session in the database.
The foreign key checks were not enforced on SQLite so the session was
not being saved previously.

- Session now saved in the 3 tests dependending on it
- Removed empty ignored test method
- Flipped an equals in WorldTimes
2018-12-27 18:39:36 +02:00