1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-05 09:10:53 +01:00
Commit Graph

1622 Commits

Author SHA1 Message Date
Thomas Rittson
5fad7c666f
Add StateVersion.Three to fix premium migration (#666)
* Add StateVersion.Three to fix premium migration
2022-02-11 13:40:13 +10:00
Justin Baur
52f77c0277
Fix new device login (#664)
* Store appId in localStorage

* Save to local as well
2022-02-10 21:22:18 -05:00
Robyn MacCallum
99f70bea8d
Individually await saving of orgs and providers (#663) 2022-02-10 18:03:55 -05:00
Robyn MacCallum
47399bb583
Move providers to profile and save to disk (#662)
* Move providers to profile and save to disk

* Move providers back to AccountData
2022-02-10 13:55:36 -05:00
Addison Beck
b7bb16c18a
[bug] Toggle tokens appropriatly based on timeout action (#661) 2022-02-09 23:01:43 +01:00
Addison Beck
c282ef8575
[bug] Fix logout timeout action for inactive accounts (#660)
* [bug] Fix logout timeout action for inactive accounts

* Pass userId in to the logout callback parameter to the vaultTimeoutService. The message handle in desktop already expects this.
* Set lastActive on account login, and null it on account deauthentication. This prevents an issue where newly logged in accounts immediatly time out due to inactivity.

* Add userId to locked callbacks

* Add userId to log out callback
2022-02-09 12:15:20 -05:00
Vincent Salucci
8cb029947b
[Help] Update links to new pattern (#658)
* [Help] Updated urls to current pattern

* Rotate key update
2022-02-08 17:35:29 -06:00
Oscar Hinton
8130fce404
Add headers for client type and client version (#651) 2022-02-08 11:18:10 +01:00
Thomas Rittson
6b8508579f
Make husky pre-commit hook executable (#655) 2022-02-08 08:29:50 +10:00
Addison Beck
6c08b40847
[bug] Make activity a top level storage key (#656)
* [bug] Make activity a top level storage key

* [bug] use correct index for migration

* [bug] use correct index for migration part 2
2022-02-07 11:36:53 -05:00
Addison Beck
0760b53296
[bug] Default the state version check function to 1 (#657) 2022-02-07 11:08:07 -05:00
Matt Gibson
7afb748791
Feature/password protected export (#612)
* Add password protected export

* Run prettier

* Test password protected export service

* Create type for known import type strings

* Test import service changes

* Test bitwarden password importer

* Run prettier

* Remove unnecessary class properties

* Run prettier

* Tslint fixes

* Add KdfType to password protected export

* Linter fixes

* run prettier
2022-02-07 09:33:10 -06:00
Thomas Rittson
9caea70ea2
[authService refactor] Fix browser by not using instanceof (#647)
* use authenticationType enum instead of instanceof
2022-02-07 07:33:19 +10:00
Matt Gibson
380a7c7ee5
Use Identity server routes (#649)
* Use Identity server routes

We've moved `prelogin` and `register` endpoints to the Indentity project
Reflecting that change here

* Only update path for dev environment
2022-02-04 08:22:19 -06:00
Jake Howard
4252501620
Add lazy loading and decoding to images (#591)
The lazy loading will work in addition to any already being done, rather
than conflicting with it.

Co-authored-by: Daniel James Smith <djsmith@web.de>
2022-02-04 12:38:56 +01:00
Thomas Rittson
ec9559520b
Fix bug where no passwords recorded in history (#650) 2022-02-04 07:59:55 +10:00
Daniel James Smith
f6ba252139
Temporarily remove keeper json import for the Feb release (#654) 2022-02-03 22:24:22 +01:00
Oscar Hinton
9dccd3198f
Fix avatar error when src is undefined (#652) 2022-02-03 19:37:51 +01:00
Addison Beck
067cd1e0e1
[bug] Assign client specific account settings during migration (#653)
* [bug] Assign client specific account settings during migration

* [refactor] Write State type arguements in consistent order

* [style] Ran prettier
2022-02-03 13:32:42 -05:00
Jake Fink
ca5c6a9c32
Master password policy is not checked when accepting invite from an existing account (#597)
* create update-password component

* linting and prettier
2022-02-02 23:31:37 -05:00
Thomas Rittson
aa2bdd00be
[Tech debt] Refactor authService and remove LogInHelper (#588)
* Use different strategy classes for different types of login
* General refactor and cleanup of auth logic
* Create subclasses for different types of login credentials
* Create subclasses for different types of tokenRequests
* Create TwoFactorService, move code out of authService
* refactor base CLI commands to use new interface
2022-02-01 09:51:32 +10:00
Addison Beck
92a65b7b36
[bug] Allow for GlobalState to be extended and modified in clients (#646)
Some clients have unique global setting defaults (and unique global settings)
For example: the web vault defaults to light theme, but most clients with theme support default to system theme.

The current way we handle GlobalState is buried in jslib and not easily extendible in clients.

To fix this, we need to treat GlobalState as a generic in the StateService and StateMigration service and allow for its extension in those methods and anywhere GlobalState is inited.
2022-01-31 14:33:31 -05:00
Addison Beck
e372bf242b
[cleanup] Adjust type to match abstraction (#643) 2022-01-28 08:18:39 -05:00
Addison Beck
6c61f53d8b
[bug] Always save environmentUrls passed to setUrls (#641)
* [bug] Always save environmentUrls passed to setUrls

* [bug] Remove parameter from abstraction as well

* [bug] Correct type in abstraction
2022-01-28 08:15:02 -05:00
Addison Beck
ca5b057b43
[refactor] Use ThemeType enum instead of string (#642) 2022-01-28 11:28:36 +01:00
Oscar Hinton
6b4ed5fcce
Icon fixes for callouts and verify mp (#640) 2022-01-27 17:40:58 +01:00
Oscar Hinton
5249e55522
Update the fallback icon name (#639) 2022-01-27 16:48:50 +01:00
Addison Beck
83305313f9
[bug] Properly define stored window state (#638) 2022-01-27 10:44:09 -05:00
Oscar Hinton
0186610ca4
Change the icon baseline to 14% (#637) 2022-01-27 15:31:13 +01:00
Vincent Salucci
0a2ebf6e50
[Icons] Fix source paths (#636)
Co-authored-by: Hinton <oscar@oscarhinton.com>
2022-01-27 11:21:32 +01:00
Daniel James Smith
5353cf03b5
BEEEP: Add importer for Keeper in json format (#608)
* Add testdata, create types for keeperjson import

* Create keeperjson importer and tests

* Register, Create instance of keeperjson importer

* Move keeperCsvImporter to keeperImporters folder

* Fixed import of BaseImporter

* Removed unnecessary check for key

* Move instantiation of importer into beforeEach

* Fixed the second import with a wrong path

* Adjust types based on new test export

* Add test case for empty notes and custom fields

* Implement logic for failed test case

* Removed test expectation
2022-01-26 23:04:55 +01:00
Addison Beck
4722a287ec
[bug] Ensure clients that always remember emails have an avenue to do so (#635) 2022-01-25 12:34:11 -05:00
Vincent Salucci
946fc20674
[Icons] Global variable update (#632)
* [Icons] Global variable update

* Reverted to base class in order to reduce redundant css

* Adjusted comment
2022-01-25 09:58:53 -06:00
Oscar Hinton
e1d4c4c903
Expose getKeyFromStorage with userId (#633) 2022-01-25 15:45:02 +01:00
Vincent Salucci
a985621bb9
[Icons] Update font sheet (#582)
* Initial commit for icon update

* Updated lg to reflect current usage

* Created BitwardenIconsService

* Prettier updates

* More prettier updates

* Updated font

* Prettier

* Added new icons to service map

* Removed variables and converted css to use scss maps and exported list

* Updated font sheet (130)

* Removed base class and replaced bolt icon

* Added 3x icon size

* Added sm text size helper

* Added rotate 270 helper

* Prettier

* Updated font sheet

* Requested Changes

* Removed BitwardenIcons Util - obsolete
2022-01-24 15:40:04 -06:00
Daniel James Smith
af7da0e942
Ensure that initialization and migration only run once (#631) 2022-01-24 20:37:52 +01:00
Addison Beck
e5cc3de46d
[bug] Move enableBrowserIntegration to global state (#630) 2022-01-24 10:47:41 -05:00
Addison Beck
4436e5fb60
[bug] Ensure globals set before migration is run are not lost (#629)
* [bug] Ensure globals set before migration is run are not lost

Some fields, like biometrics, are set before we can run the state migration
For some use cases, like initial install, this can lead to migration clearing those fields when it doesn't find them in storage.
This commit sets up an order of checks for migrating globals that considers fields that may already have been set.

* [style] Ran prettier
2022-01-24 08:22:21 -05:00
Addison Beck
1747f4d9e7
[bug] Set all urls when setting urls from storage (#628) 2022-01-24 07:28:51 -05:00
Addison Beck
074f1ee7b7
[bug] Set envUrls after assigning defaults during scaffolding (#627) 2022-01-21 13:35:14 -05:00
Addison Beck
9b0e5ae456
[bug] Address existing data & defaults when migrating from an unauthenticated state (#626) 2022-01-21 12:41:15 -05:00
Addison Beck
69fe7b8339
[bug] Always set environementUrls from client when scaffolding an account (#624)
There is a use case that overrides locally set environmentUrls: an initial boot of a logged out application.
We override environmentUrls with whatever the tempory settings store has, even if different urls are added before authenticating.
This commit ensures we always use input environmentUrls.
2022-01-21 11:14:34 -05:00
Matt Gibson
e1bdd2a95c
watch ts files and source directly (#623) 2022-01-21 10:11:00 -06:00
Addison Beck
025a4a5e38
[bug] Index search service when setting decrypted ciphers (#620)
With the move to a central StateService we erroniously cut out search indexing from the process of setting decrypted ciphers to memory.
This commit calls the method responsible for setting decrypted ciphers and indexing when decrypting, instead of setting decrypted ciphers directly.
2022-01-20 16:25:04 -05:00
Matt Gibson
19bf7c75a3
Use node-ts and jasmine-ts to run tests (#621)
* Use node-ts and jasmine-ts to run tests

* prettier

* Add tsconf-paths module
2022-01-20 14:07:13 -06:00
Addison Beck
cf1e483c7f
[bug] Account for entityId as a userId alternative during state migration (#622)
Some clients, like Directory Connector, use different key for their user identifier: entityId
We currently only check for userId in the migration service, but need to account for both.
2022-01-20 14:00:58 -05:00
Addison Beck
7300db703c
[Bug] Change method scope for internal StateMigrationService methods (#619)
A couple of helper methods were recently added to the StateMigrationService, but they were set to private and can't be used in children.
Some clients, like the Directory Connector, extend the StateMigrationService and need access to these methods.
2022-01-20 10:30:01 -05:00
Addison Beck
54c6a4b3c3
[bug] Correct scope for several data points (#618)
The following data points are currently scoped to an account but are made global with this commit:
* Enable Menu Bar Icon
* Minimize To Menu Bar
* Close To Menu Bar
* Start To Menu Bar

Note: these are all electron specific fields
2022-01-20 09:03:31 -05:00
Addison Beck
57351d29a2
[bug] Migrate state even if there is not a user logged in (#615)
Currently the StateMigrationService depends on a userId key for running migrations, but if there is not an authenticated user saved to storage that userId is not present.
These changes allow for migrating state data even without an active user. For account specific settings like clearClipboard we now temporarily store those values together in disk state until an account is authed that they can be added to. Temp account state is then cleared.

Some notes:
* In order for this to work we need GlobalState.stateVersion to have a default value of StateVersion.One instead of StateVersion.Latest. Defaulting it to latest was causing migrations to not run on some clients (like desktop) that try to access storage before migrations have been run but save a version as if migrations did run.
* I also noticed we aren't clearing old state items from before migrating, and added a case for this to the migrator.
* I extracted a few bits of reused code into private methods in the stateMigration service. Things like get/set from storage, default options, etc.
2022-01-20 08:30:00 -05:00
Thomas Rittson
11e7133aef
Save usesKeyConnector using defaultOnDiskOptions (#617) 2022-01-20 19:32:44 +10:00