1
0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-03 23:21:29 +01:00
Commit Graph

1429 Commits

Author SHA1 Message Date
Shane Melton
6687ef5978
[PM-7683] Fix dynamic item defects (#9575)
* [PM-8639] Add data-testid attribute for test automation

* [PM-8669] Add autofill aria label

* [PM-8674] Show autofill menu options for card/identities when not in the autofill suggestion list

* [PM-8635] Hide menu items when copy cipher field directive is disabled

* [PM-8636] Disable copy menu dropdown when no items available to copy

* [CL-309] Add title override to bitBadge

* [PM-8669] Update menu-item directive disabled input

* [PM-7683] Fix race condition for remainingCiphers$

* [PM-7683] Use strict equality check
2024-06-12 14:33:18 -07:00
Cesar Gonzalez
b857e4943a
[PM-5189] Implementing a set threshold for the maximum depth for which we are willing to calculate sub frame offsets 2024-06-12 16:29:55 -05:00
Cesar Gonzalez
b1e75ad7b5
[PM-5189] Fixing an issue with how scroll events trigger a reposition of the inline menu when the field is not focused; 2024-06-12 13:32:20 -05:00
Cesar Gonzalez
c69a82a304
[PM-5189] Removing unnecessary property 2024-06-12 13:01:40 -05:00
Cesar Gonzalez
722ec9c769
Merge branch 'main' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes 2024-06-12 12:59:43 -05:00
Cesar Gonzalez
ecd5558550
[PM-5189] Removing unnecessary property 2024-06-12 12:59:12 -05:00
Jake Fink
c1d3659a28
initialize subscription after setting initial values (#9579) 2024-06-12 11:50:23 -04:00
Cesar Gonzalez
42080a7377
[PM-5189] Fixing an issue with how we handle closing the inline menu after a programmtic redirection 2024-06-12 06:01:18 -05:00
Cesar Gonzalez
72a77aa017
[PM-5189] Increasing the time we delay the closure of the inline menu 2024-06-11 16:37:15 -05:00
Cesar Gonzalez
2134dc9954
[PM-5189] Removing TODO message 2024-06-11 16:12:35 -05:00
Cesar Gonzalez
4ea14070d1
[PM-5189] Refactoring implementation 2024-06-11 16:10:50 -05:00
Cesar Gonzalez
a599679563
[PM-5189] Refactoring implementation 2024-06-11 16:07:22 -05:00
Cesar Gonzalez
535a374597
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-11 15:50:57 -05:00
Cesar Gonzalez
3b0005b48c
[PM-8518] Autofill scripts do not inject into sub frames on install (#9459)
* [PM-8518] Autofill scripts do not inject into sub-frames on install

* [PM-8518] Implementing jest tests for added BrowserApi methods

* [PM-8518] Adding generic typing to tabSendMessage call
2024-06-11 15:50:03 -05:00
Cesar Gonzalez
c4ca71337a
[PM-5189] Refactoring implementation 2024-06-11 15:48:18 -05:00
Cesar Gonzalez
12077a2273
[PM-5189] Refactoring implementation 2024-06-11 15:42:08 -05:00
Cesar Gonzalez
ba74a1cd36
[PM-5189] Refactoring implementation 2024-06-11 15:35:32 -05:00
Cesar Gonzalez
cff56fc7c3
[PM-5189] Merging changes from main into branch 2024-06-11 15:13:58 -05:00
Cesar Gonzalez
9418be6840
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-11 15:01:25 -05:00
Cesar Gonzalez
ae73a3d980
Merge branch 'main' into autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install 2024-06-11 15:01:21 -05:00
Cesar Gonzalez
fe82dbe2b9
[PM-8510] Implement collect page details observable (#9452)
* Working through a POC of a collectPageDetails observable

* Implementing collect page details observable

* [PM-8510] Implement collectPageDetails observable

* [PM-8510] Adding documentation to newly created collectPageDetailsFromTab method

* [PM-8510] Removing unnecessary file

* [PM-8510] Implementing Jest tests for the collectPageDetailsFromTab$ method

* [PM-8510] Implementing Jest tests for the collectPageDetailsFromTab$ method

* [PM-8510] Implementing Jest tests for the collectPageDetailsFromTab$ method

* [PM-8510] Implementing Jest tests for the collectPageDetailsFromTab$ method

* [PM-8510] Removing unnecessary property

* [PM-8510] Adding subscription reference to current tab component

* [PM-8510] Fixing jest tests
2024-06-11 20:00:05 +00:00
Cesar Gonzalez
ae5e73b0ae
[PM-5189] Fixing an issue found with iframe service 2024-06-11 14:02:46 -05:00
Cesar Gonzalez
644dbe251b
[PM-5189] Implementing jest tests for AutofillInlineMenuContentService 2024-06-11 13:35:19 -05:00
Cesar Gonzalez
eaeb4e46e9
[PM-5189] Implementing jest tests for AutofillInlineMenuContentService 2024-06-11 13:30:32 -05:00
Cesar Gonzalez
8cea459d44
[PM-5189] Implementing jest tests for AutofillInlineMenuContentService 2024-06-11 12:09:48 -05:00
Cesar Gonzalez
7832784be6
[PM-5189] Implementing jest tests for AutofillInlineMenuContentService 2024-06-11 11:55:06 -05:00
Cesar Gonzalez
c2e62940e0
[PM-5189] Implementing jest tests for AutofillInlineMenuContentService 2024-06-11 11:44:24 -05:00
Cesar Gonzalez
0c786eafa6
[PM-5189] Implementing jest tests for AutofillInlineMenuContentService 2024-06-11 11:00:37 -05:00
Cesar Gonzalez
c8c64d2923
[PM-5189] Implementing jest tests for AutofillInlineMenuContentService 2024-06-11 10:19:26 -05:00
Cesar Gonzalez
e0ee50f43c
[PM-5189] Refactoring implementation 2024-06-11 10:07:01 -05:00
Cesar Gonzalez
3a8b13917b
[PM-5189] Refactoring implementation 2024-06-11 10:03:30 -05:00
Cesar Gonzalez
710475d1c4
[PM-5189] Refactoring implementation0 2024-06-11 09:52:25 -05:00
Cesar Gonzalez
927de0fc75
[PM-5189] Refactoring implementation 2024-06-11 09:41:08 -05:00
Cesar Gonzalez
6ec6310bb4
[PM-5189] Refactoring implementation 2024-06-11 09:33:28 -05:00
Cesar Gonzalez
d43b5359c9
[PM-5189] Refactoring implementation 2024-06-11 09:31:08 -05:00
Cesar Gonzalez
87cccdb52a
[PM-5189] Fixing some typos 2024-06-11 09:25:16 -05:00
Cesar Gonzalez
8bfa02eeea
[PM-5189] Correcting typing information 2024-06-11 08:55:59 -05:00
Cesar Gonzalez
fa6bbbd252
[PM-5189] Fixing a typo 2024-06-11 08:44:52 -05:00
Cesar Gonzalez
f7e2d7cd02
[PM-5189] Fixing a typo 2024-06-11 08:42:04 -05:00
Cesar Gonzalez
856851c5e9
Merge branch 'autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes 2024-06-11 08:35:45 -05:00
Cesar Gonzalez
f9aa60c249
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-11 08:35:38 -05:00
Cesar Gonzalez
807831becc
Merge branch 'main' into autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install 2024-06-11 08:35:30 -05:00
Cesar Gonzalez
d3636eb96d
[PM-5189] Implementing jest tests for AutofillInlineMenuIframeServce 2024-06-11 08:31:58 -05:00
Nick Krantz
cbc34950fb
add check for PersonalOwnershipPolicy in vault filters (#9570) 2024-06-10 14:25:21 -05:00
Jason Ng
841edc1058
[PM-7102] Create Add/Edit container for Item v2 work (#9541)
* set up new add-edit-v2 component
2024-06-10 14:23:29 -04:00
Shane Melton
19f2d2aefc
[PM-8379] Update vault popup items service to track loading state (#9528) 2024-06-10 09:55:12 -07:00
Cesar Gonzalez
17fa4f57f9
[PM-5189] Working through jest tests for the AutofillOverlayContentService 2024-06-07 15:14:08 -05:00
Cesar Gonzalez
c5169c96ee
[PM-5189] Working through jest tests for the AutofillOverlayContentService 2024-06-07 14:31:19 -05:00
Cesar Gonzalez
e3510a9a05
[PM-5189] Working through jest tests for the AutofillOverlayContentService 2024-06-07 14:14:55 -05:00
Cesar Gonzalez
191797e6c2
[PM-5189] Working through jest tests for the AutofillOverlayContentService 2024-06-07 14:11:01 -05:00
Cesar Gonzalez
794808529b
[PM-5189] Working through jest tests for the AutofillOverlayContentService 2024-06-07 13:37:09 -05:00
Cesar Gonzalez
025327e141
[PM-5189] Implementing jest tests for the AutofillOverlayContentService 2024-06-07 12:55:08 -05:00
Cesar Gonzalez
938cb74e6e
[PM-5189] Implementing jest tests for the CollectAutofillContentService 2024-06-07 12:10:02 -05:00
Cesar Gonzalez
5bcb9aeb68
[PM-5189] Refactoring implementation 2024-06-07 12:04:05 -05:00
Cesar Gonzalez
873cfa51cd
[PM-5189] Adding jest tests for added methods in AutofillInit 2024-06-07 11:38:09 -05:00
Cesar Gonzalez
4b241fe47f
[PM-5189] Refactoring implementation 2024-06-07 10:38:58 -05:00
Cesar Gonzalez
78911732fb
[PM-5189] Refactoring implementation 2024-06-07 10:32:33 -05:00
Cesar Gonzalez
a20af5b28b
[PM-5189] Refactoring implementation 2024-06-07 10:28:58 -05:00
Cesar Gonzalez
356861a100
[PM-5189] Refactoring implementation 2024-06-07 09:42:05 -05:00
Cesar Gonzalez
0e33b9c215
[PM-5189] Refactoring implementation 2024-06-07 09:29:25 -05:00
Cesar Gonzalez
f34fbc217c
[PM-5189] Refactoring implementation 2024-06-07 09:17:44 -05:00
Cesar Gonzalez
ed11a4071b
Merge branch 'autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes 2024-06-07 08:50:22 -05:00
Cesar Gonzalez
df3ee0a3d2
Merge branch 'main' into autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install 2024-06-07 08:50:13 -05:00
Cesar Gonzalez
0133d5cf53
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-07 08:50:07 -05:00
Cesar Gonzalez
d30b947dd7
[PM-8498] Moving content script-specific FIDO2 code from Vault to Autofill ownership (#9431)
* [PM-8498] Moving content script-specific FIDO2 code from Vault to Autofill ownership

* [PM-8498] Adjusting jest test reference for webauth-utils
2024-06-07 08:47:38 -05:00
Daniel James Smith
28e8f8f364
[PM-7240] Create new export component [UI changes] (#9285)
* Move/replace submit and userVerification logic from web into the BaseExportComponent

Add "@bitwarden/auth" as dependency to the vault-export-ui package
New submit logic also checks for password-encrypted exports which will be need for future UI updates on browser and desktop

* Move/replace submit and userVerification logic from web into the BaseExportComponent

Add "@bitwarden/auth" as dependency to the vault-export-ui package
New submit logic also checks for password-encrypted exports which will be need for future UI updates on browser and desktop

* Create export-browser-v2 component

Copy existing `export-browser`-component
Add `popup-page` and -`header` and -`footer`
Add missing imports as page is marked as standalone
Route to new page when feature flag enabled

* Remove duplicate verifyUser methods

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-06-07 09:17:00 -04:00
Cesar Gonzalez
adf3837243
[PM-8027] Incorporating a feature flag to allow us to fallback to the basic inline menu fielld qualification method if needed 2024-06-07 07:46:15 -05:00
Cesar Gonzalez
8fda52ef7e
[PM-8027] Incorporating a feature flag to allow us to fallback to the basic inline menu fielld qualification method if needed 2024-06-07 07:24:35 -05:00
Cesar Gonzalez
a898fa4386
[PM-8027] Fixing a typo 2024-06-07 06:57:06 -05:00
Cesar Gonzalez
3e4525a6ba
Merge branch 'autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes 2024-06-07 05:39:13 -05:00
Cesar Gonzalez
4185e49a86
Merge branch 'main' into autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install 2024-06-07 05:39:05 -05:00
Cesar Gonzalez
a91526c259
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-07 05:38:51 -05:00
github-actions[bot]
8361c0bd29
Autosync the updated translations (#9543)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-06-07 10:21:13 +00:00
Shane Melton
c8b2807487
[PM-8665] Show toast when favorite is toggled (#9537) 2024-06-06 14:25:23 -07:00
Nick Krantz
3457941634
show family icon for free orgs in filter chips (#9532) 2024-06-06 15:30:02 -05:00
Nick Krantz
a5591dc4bc
[PM-8592] Deactivated state not showing (#9533)
* refactor vault state observables into a single variable to remove multiple subscriptions

* add clarification comment

* fix comment to be accurate
2024-06-06 15:28:29 -05:00
Cesar Gonzalez
b802f3e7ed
[PM-5189] Fixing a weird side issue that appears when a frame within the page triggers a reposition after the inline menu has been built 2024-06-06 13:29:48 -05:00
Cesar Gonzalez
e2c9fa4b59
[PM-5189] Fixing a weird side issue that appears when a frame within the page triggers a reposition after the inline menu has been built 2024-06-06 13:00:47 -05:00
Shane Melton
79968c2d32
[PM-8335] Show autofill suggestion when no autofill login items present (#9521) 2024-06-06 10:43:55 -07:00
Cesar Gonzalez
67db794eda
[PM-5189] Fixing a weird side issue that appears when a frame within the page triggers a reposition after the inline menu has been built 2024-06-06 10:39:25 -05:00
Nick Krantz
a7b45a44e3
[PM-8594] use singular version of the copy for filters (#9509)
* use singular for collection and type

* use singular verbiage for cipher type

* use type translations for singularity
2024-06-06 09:39:21 -05:00
Will Martin
472a7a9d4d
[CL-302] respect bottom padding in scrollable popup-layout (#9514) 2024-06-05 17:17:24 -04:00
Cesar Gonzalez
5b29d12b04
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-05 15:17:15 -05:00
Cesar Gonzalez
9fe7c2f643
[PM-5189] Merging work done for pm-8518 2024-06-05 15:16:24 -05:00
Cesar Gonzalez
39759bfeab
Merge branch 'main' into autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install 2024-06-05 15:14:50 -05:00
Cesar Gonzalez
ce69b25d54
[PM-8519] Inline menu fails to update credentials after saving credentials when unlocking extension (#9462)
* Add Back Foreground & Background Derived State

* Do Dependency Injection

* Defend `map` Calls

* Remove Folder Change

* Add Helper For Preparing a Record For Use in `forkJoin`

* Update & Test CryptoService Changes

* Delete Unused Code

* Update DeviceTrustService

* Update CipherService

* Make `userPublicKey$` Public

* Rename convertValues File

* Switch to `MonoTypeOperatorFunction`

* Remove Unnecessary `async`

* Remove Unnecessary Mock

* Update libs/common/src/platform/abstractions/crypto.service.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Add `convertValues` Tests

* Add Doc Comments

* Convert to `function`'s

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Fix Test Typos

* Add param doc

* Update Test Name

* Add `@throws` Docs

* [PM-8519] Inline Menu fails to Update Credentials After Saving New Cipher When Unlocking Extension

* Revert "Merge branch 'reintroduce-foreground-background-derived' into autofill/pm-8519-inline-menu-fails-to-update-credentials-after-saving-credentials-when-unlocking-extension"

This reverts commit 53b060dac1, reversing
changes made to 15b9a237b8.

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
2024-06-05 15:14:34 -05:00
Cesar Gonzalez
5e70d042b4
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 15:04:43 -05:00
Victoria League
d3f1992ad5
[CL-294] Make section-header work across clients (#9386) 2024-06-05 15:07:00 -04:00
Cesar Gonzalez
2efbc5ce51
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 13:57:02 -05:00
Cesar Gonzalez
df30a205b0
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 13:49:15 -05:00
Cesar Gonzalez
ddc95ee0ec
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 13:48:01 -05:00
Cesar Gonzalez
a743a969e0
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-05 13:24:33 -05:00
Cesar Gonzalez
6c5a1a5748
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 13:04:37 -05:00
Cesar Gonzalez
055925e84c
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 12:37:17 -05:00
Cesar Gonzalez
b51586f362
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 11:46:28 -05:00
Cesar Gonzalez
d3ba598a45
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 10:24:20 -05:00
Shane Melton
1cfbcf4ee0
[PM-8334] Sort ciphers after autofill (#9511)
* [PM-8334] Add localData$ to CipherService and watch it for updates

* Fix leftover tw-fixed class

* [PM-8334] Fix tests
2024-06-05 08:10:36 -07:00
Justin Baur
1aaa88a64d
[PM-7837] Move SyncService to Platform Ownership (#9055)
* Move

* Update  References In Unowned Files

* Update  References In Vault Files

* Update Web AppComponent

* Add Import
2024-06-05 10:48:12 -04:00
Cesar Gonzalez
81e2cd3e1f
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 09:34:13 -05:00
Jason Ng
cb0927ac5d
[PM-8553] browser v2 search bar defects (#9506)
* update no results icon and no results scrolling
* update v2 search so the term persist when the user clicks into an item and exits the item
2024-06-05 10:06:52 -04:00
Cesar Gonzalez
4a6853bdaf
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-05 08:30:18 -05:00
Cesar Gonzalez
4477b9b34f
[PM-5189] Adjusting how we handle fade out of the inline menu element 2024-06-05 05:09:54 -05:00
Cesar Gonzalez
5a1e061778
[PM-5189] Fixing issue with programmatic redirection of the inlne menu 2024-06-05 05:02:12 -05:00
Cesar Gonzalez
b2ab42e1a4
[PM-5189] Fixing issue with programmatic redirection of the inlne menu 2024-06-05 04:38:27 -05:00
Cesar Gonzalez
ce593e024d
[PM-5189] Fixing issue with how we remove the inline menu when a field is populated 2024-06-05 02:33:33 -05:00
Cesar Gonzalez
27066c4a08
[PM-5189] Reworking how we handle updating ciphers on unlock and updating reference to auth status to use observable 2024-06-04 17:58:38 -05:00
Cesar Gonzalez
02bbb41148
Merge branch 'autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes 2024-06-04 17:48:22 -05:00
Cesar Gonzalez
a47e108533
Merge branch 'main' into autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install 2024-06-04 17:48:12 -05:00
Cesar Gonzalez
5853f9f1a9
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-04 17:48:00 -05:00
Cesar Gonzalez
4ecbfb3d49
[PM-5189] Working through jest tests for OverlayBackground 2024-06-04 17:47:04 -05:00
Cesar Gonzalez
07713511e4
[PM-5189] Working through jest tests for OverlayBackground 2024-06-04 16:54:14 -05:00
Shane Melton
f059d136b2
[PM-8485] [PM-7683] Dynamic list items - Org Details (#9466)
* [PM-7683] Add fullAddressForCopy helper to identity.view

* [PM-7683] Introduce CopyCipherFieldService to the Vault library

- A new CopyCipherFieldService that can be used to copy a cipher's field to the user clipboard
- A new appCopyField directive to make it easy to copy a cipher's fields in templates
- Tests for the CopyCipherFieldService

* [PM-7683] Introduce item-copy-actions.component

* [PM-7683] Fix username value in copy cipher directive

* [PM-7683] Add title to View item link

* [PM-8456] Introduce initial item-more-options.component

* [PM-8456] Add logic to show/hide login menu options

* [PM-8456] Implement favorite/unfavorite menu option

* [PM-8456] Implement clone menu option

* [PM-8456] Hide launch website instead of disabling it

* [PM-8456] Ensure cipherList observable updates on cipher changes

* [PM-7683] Move disabled logic into own method

* [PM-8456] Cleanup spec file to use Angular testbed

* [PM-8456] Fix more options tooltip

* [PM-8485] Introduce new PopupCipherView

* [PM-8485] Use new PopupCipherView in items service

* [PM-8485] Add org icon for items that belong to an organization

* [PM-8485] Fix tests

* [PM-8485] Remove share operator from cipherViews$
2024-06-04 14:34:48 -07:00
Nick Krantz
d0c1325f0c
update icons for folder & collection filters (#9508) 2024-06-04 16:26:39 -05:00
Shane Melton
6eb94078f6
[PM-8456] [PM-7683] Dynamic list items - 3 dot menu (#9422)
* [PM-7683] Add fullAddressForCopy helper to identity.view

* [PM-7683] Introduce CopyCipherFieldService to the Vault library

- A new CopyCipherFieldService that can be used to copy a cipher's field to the user clipboard
- A new appCopyField directive to make it easy to copy a cipher's fields in templates
- Tests for the CopyCipherFieldService

* [PM-7683] Introduce item-copy-actions.component

* [PM-7683] Fix username value in copy cipher directive

* [PM-7683] Add title to View item link

* [PM-8456] Introduce initial item-more-options.component

* [PM-8456] Add logic to show/hide login menu options

* [PM-8456] Implement favorite/unfavorite menu option

* [PM-8456] Implement clone menu option

* [PM-8456] Hide launch website instead of disabling it

* [PM-8456] Ensure cipherList observable updates on cipher changes

* [PM-7683] Move disabled logic into own method

* [PM-8456] Cleanup spec file to use Angular testbed

* [PM-8456] Fix more options tooltip
2024-06-04 14:21:14 -07:00
Shane Melton
d1a9d6f613
[PM-8455] [PM-7683] Dynamic list items - Copy Action (#9410)
* [PM-7683] Add fullAddressForCopy helper to identity.view

* [PM-7683] Introduce CopyCipherFieldService to the Vault library

- A new CopyCipherFieldService that can be used to copy a cipher's field to the user clipboard
- A new appCopyField directive to make it easy to copy a cipher's fields in templates
- Tests for the CopyCipherFieldService

* [PM-7683] Introduce item-copy-actions.component

* [PM-7683] Fix username value in copy cipher directive

* [PM-7683] Add title to View item link

* [PM-7683] Move disabled logic into own method
2024-06-04 14:09:09 -07:00
Cesar Gonzalez
b9d257046c
[PM-5189] Implementing jest tests for the OverlayBackground 2024-06-04 12:28:08 -05:00
Cesar Gonzalez
f3c0a24a1d
[PM-5189] Fixing existing jest tests before undergoing larger scale rework of tests 2024-06-04 10:21:58 -05:00
Cesar Gonzalez
d774bc96d9
[PM-5189] Merging work done for pm-8518 2024-06-04 10:00:25 -05:00
Cesar Gonzalez
66873dee95
Merge branch 'main' into autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install 2024-06-04 09:54:00 -05:00
Cesar Gonzalez
fb486b72b7
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-04 09:25:46 -05:00
Cesar Gonzalez
c2653f5376
[PM-8027] Finalization of Jest test for the implementation 2024-06-04 09:24:53 -05:00
Cesar Gonzalez
3397261d55
[PM-8027] Working through jest tests for the InlineMenuFieldQualificationService 2024-06-04 08:54:33 -05:00
Cesar Gonzalez
6199904d73
[PM-8027] Working through jest tests for the InlineMenuFieldQualificationService 2024-06-03 17:35:33 -05:00
Cesar Gonzalez
146cf029c4
[PM-8027] Working through jest tests for the InlineMenuFieldQualificationService 2024-06-03 17:28:11 -05:00
Cesar Gonzalez
5dfadbafba
[PM-8027] Working through jest tests for the InlineMenuFieldQualificationService 2024-06-03 17:15:34 -05:00
Cesar Gonzalez
6dae05a9f3
[PM-8027] Working through jest tests for the InlineMenuFieldQualificationService 2024-06-03 17:08:12 -05:00
Cesar Gonzalez
6b7b6cb303
[PM-8027] Adding jest test to validate new behavior 2024-06-03 16:25:20 -05:00
Cesar Gonzalez
2c1dfc9261
[PM-8027] Removing unnecessary code 2024-06-03 16:20:23 -05:00
Cesar Gonzalez
6d2795dcde
[PM-8027] Removing unnecessary code 2024-06-03 16:10:10 -05:00
Cesar Gonzalez
eb877065e3
[PM-8027] Fixing jest tests for the collectPageDetails method 2024-06-03 16:04:46 -05:00
Cesar Gonzalez
75da1d6556
[PM-8027] Fixing jest tests for the overlay 2024-06-03 15:56:44 -05:00
Cesar Gonzalez
0e85966ee0
[PM-8027] Refining how we identify a username login form field 2024-06-03 15:40:04 -05:00
Cesar Gonzalez
a57c7c4e53
[PM-8027] Refining how we identify a password login form field 2024-06-03 13:25:27 -05:00
Bitwarden DevOps
99639b537f
Bumped client version(s) (#9486) 2024-06-03 18:10:48 +00:00
Cesar Gonzalez
cc4c954664
[PM-8027] Refining how we identify a username login form field 2024-06-03 13:05:21 -05:00
Jared Snider
9d35a8895e
Auth/PM-8367 - Email Verification - Integrate Registration Self Hosted Env Selector + new Self Hosted Env Settings Dialog into Registration Start (#9361)
* PM-8367 - WIP - initial comp creation

* PM-8367 - Majority of new registration self hosted env config dialog working

* PM-8367 - RegistrationEnvSelectorComponent - add method handleSelfHostedEnvConfigDialogResult and add toast for happy path.

* PM-8367 - Add validation TODO

* PM-8367 - RegistrationSelfHostedEnvConfigDialogComponent - Add validator

* PM-8367 - RegEnvSelector - Only show self hosted if the client is browser or desktop since we will be using the selector on web as well.

* PM-8367 - Registration start comp - add env selector

* PM-8367 - Registration start - add proper import for standalone comps.

* PM-8367 - Registration Start - get storybook fixed with registration env selector

* PM-8367 - Add self hosted server to web translations only for storybook

* PM-8367 - Add more storybook examples and update docs (WIP - need to test self hosted selection)

* PM-8367 - Registration Start - update stories

* PM-8367 - Env Selector now emits selected region so that parent comps can listen to it if needed.

* PM-8367 - Registration Start - wire up handler for selectedRegionChange so that the parent comp can successfully track isSelfHost and hide / show the terms / privacy policy checkbox

* PM-8367 - TODO cleanup

* PM-8367 - Registration start docs - stage gate is two words.

* PM-8367 - Per working session with Will, move top level provided services to app level instead of module level to solve dialog null injector errors.

* PM-8367 - Storybook working for self hosted env dialog

* PM-8367 - Add dialog scroll feature to bitDialog and implement in self hosted env dialog.

* PM-8367 - Revert bit dialog changes and scroll implementation.

* PM-8367 - Tweak registration start docs

* PM-8367 - Remove unused changeDetectorRef

* PM-8367 - Add docs per PR feedback
2024-06-03 13:05:27 -04:00
Jared Snider
f691854387
Auth - PM-7392 & PM-7436 - Token Service - Desktop - Add disk fallback for secure storage failures (#8913)
* PM-7392 - EncryptSvc - add new method for detecting if a simple string is an enc string.

* PM-7392 - TokenSvc - add checks when setting and retrieving the access token to improve handling around the access token encryption.

* PM-7392 - (1) Clean up token svc (2) export access token key type for use in tests.

* PM-7392 - Get token svc tests passing; WIP more tests to come for new scenarios.

* PM-7392 - Access token secure storage to disk fallback WIP but mostly functional besides weird logout behavior.

* PM-7392 - Clean up unnecessary comment

* PM-7392 - TokenSvc - refresh token disk storage fallback

* PM-7392 - Fix token service tests in prep for adding tests for new scenarios.

* PM-7392 - TokenSvc tests - Test new setRefreshToken scenarios

* PM-7392 - TokenSvc - getRefreshToken should return null or a value - not undefined.

* PM-7392 - Fix test name.

* PM-7392 - TokenSvc tests - clean up test names that reference removed refresh token migrated flag.

* PM-7392 - getRefreshToken tests done.

* PM-7392 - Fix error quote

* PM-7392 - TokenSvc tests - setAccessToken new scenarios tested.

* PM-7392 - TokenSvc - getAccessToken - if secure storage errors add error to log.

* PM-7392 - TokenSvc tests - getAccessToken - all new scenarios tested

* PM-7392 - EncryptSvc - test new stringIsEncString method

* PM-7392 - Main.ts - fix circ dep issue.

* PM-7392 - Main.ts - remove comment.

* PM-7392 - Don't re-invent the wheel and simply use existing isSerializedEncString static method.

* PM-7392 - Enc String - (1) Add handling for Nan in parseEncryptedString (2) Added null handling to isSerializedEncString. (3) Plan to remove encrypt service implementation

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>

* PM-7392 - Remove encrypt service method

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>

* PM-7392 - Actually fix circ dep issues with Justin. Ty!

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>

* PM-7392 - TokenSvc - update to use EncString instead of EncryptSvc + fix tests.

* PM-7392 - TokenSvc - (1) Remove test code (2) Refactor decryptAccessToken method to accept access token key and error on failure to pass required decryption key to method.

* PM-7392 - Per PR feedback and discussion, do not log the user out if hte refresh token cannot be found. This will allow users to continue to use the app until their access token expires and we will error on trying to refresh it. The app will then still work on a fresh login for 55 min.

* PM-7392 - API service - update doAuthRefresh error to clarify which token cannot be refreshed.

* PM-7392 - Fix SetRefreshToken case where a null input would incorrectly trigger a fallback to disk.

* PM-7392 - If the access token cannot be refreshed due to a missing refresh token or API keys, then surface an error to the user and log it so it isn't a silent failure + we get a log.

* PM-7392  - Fix CLI build errors

* PM-7392 - Per PR feedback, add missing tests (thank you Jake for writing these!)

Co-authored-by: Jake Fink <jfink@bitwarden.com>

* PM-7392 - Per PR feedback, update incorrect comment from 3 releases to 3 months.

* PM-7392 - Per PR feedback, remove links.

* PM-7392 - Per PR feedback, move tests to existing describe.

* PM-7392 - Per PR feedback, adjust all test names to match naming convention.

* PM-7392 - ApiService - refreshIdentityToken - log error before swallowing it so we have a record of it.

* PM-7392 - Fix copy for errorRefreshingAccessToken

* PM-7392 - Per PR feedback, move error handling toast responsibility to client specific app component logic reached via messaging.

* PM-7392 - Swap logout reason from enum to type.

* PM-7392 - ApiService - Stop using messaging to trigger toast to let user know about refresh access token errors; replace with client specific callback logic.

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Co-authored-by: Matt Gibson <mgibson@bitwarden.com>

* PM-7392 - Per PR feedback, adjust enc string changes and tests.

* PM-7392 - Rename file to be type from enum

* PM-7392 - ToastService - we need to await the activeToast.onHidden observable so return the activeToast from the showToast.

* PM-7392 - Desktop AppComp - cleanup messaging

* PM-7392 - Move Logout reason custom type to auth/common

* PM-7392 - WIP - Enhancing logout callback to consider the logout reason + move show toast logic into logout callback

* PM-7392 - Logout callback should simply pass along the LogoutReason instead of handling it - let each client's message listener handle it.

* PM-7392 - More replacements of expired with logoutReason

* PM-7392 - More expired to logoutReason replacements

* PM-7392 - Build new handlers for displaying the logout reason for desktop & web.

* PM-7392 - Revert ToastService changes

* PM-7392 - TokenSvc - Replace messageSender with logout callback per PR feedback.

* PM-7392 - Desktop App comp - replace toast usage with simple dialog to guarantee users will see the reason for them being logged out.

* PM-7392 - Web app comp - fix issue

* PM-7392 - Desktop App comp - don't show cancel btn on simple dialogs.

* PM-7392 - Desktop App comp - Don't open n simple dialogs.

* PM-7392 - Fix browser build

* PM-7392 - Remove logout reason from CLI as each logout call handles messaging on its own.

* PM-7392 - Previously, if a security stamp was invalid, the session was marked as expired. Restore that functionality.

* PM-7392 - Update sync service logoutCallback to include optional user id.

* PM-7392 - Clean up web app comp

* PM-7392 - Web - app comp - only handle actually possible web logout scenarios.

* PM-7392 - Browser Popup app comp - restore done logging out message functionality + add new default logout message

* PM-7392 - Add optional user id to logout callbacks.

* PM-7392 - Main.background.ts - add clarifying comment.

* PM-7392 - Per feedback, use danger simple dialog type for error.

* PM-7392 - Browser Popup - add comment clarifying expectation of seeing toasts.

* PM-7392 - Consolidate invalidSecurityStamp error handling

* PM-7392 - Per PR feedback, REFRESH_ACCESS_TOKEN_ERROR_CALLBACK can be completely sync. + Refactor to method in main.background.

* PM-7392 - Per PR feedback, use a named callback for refreshAccessTokenErrorCallback in CLI

* PM-7392 - Add TODO

* PM-7392 - Re-apply bw.ts changes to new service-container.

* PM-7392 - TokenSvc - tweak error message.

* PM-7392 - Fix test

* PM-7392 - Clean up merge conflict where I duplicated dependencies.

* PM-7392 - Per discussion with product, change default logout toast to be info

* PM-7392 - After merge, add new logout reason to sync service.

* PM-7392 - Remove default logout message per discussion with product since it isn't really visible on desktop or browser.

* PM-7392 - address PR feedback.

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Co-authored-by: Jake Fink <jfink@bitwarden.com>
Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
2024-06-03 12:36:45 -04:00
Nick Krantz
748eb00223
[PM-6826] Vault filter refresh (#9365)
* add initial type filter

- use `bit-select` while the chip component is being developed

* get cipherTypes$ from service

- integrate with user settings

* initial add of folder selection

* initial add of vault selection

* initial add of collections filter

* update `VaultPopupListFilterService` to `VaultPopupListFiltersService`

* integrate hasFilterApplied$

* intermediate commit of integration to the filters component

* do not return the tree when the value is null

* return null when the updated option is null

* update vault-popup-list to conform to the chip select structure

* integration of bit-chip-select

* move "no folder" option to the end of the list

* show danger icon for deactivated organizations

* show deactivated warning when the filtered org is disabled

* update documentation

* use pascal case for constants

* store filter values as full objects rather than just id

- This allows secondary logic to be applied when filters are selected

* move filter form into service to be the source of truth

* fix tests after adding "jest-preset-angular/setup-jest"

* remove logic to have dynamic cipher type filters

* use ProductType enum

* invert conditional for less nesting

* prefer `decryptedCollections$` over getAllDecrypted

* update comments

* use a `filterFunction$` observable rather than having to pass filters back to the service

* fix children testing

* remove check for no folder

* reset filter form when filter component is destroyed

* add takeUntilDestroyed for organization valueChanges

* allow takeUntilDestroyed to use internal destroy ref

- The associated unit tests needed to be configured with TestBed rather than just `new Service()` for this to work

* use controls object for type safety
2024-06-03 09:20:14 -05:00
Cesar Gonzalez
ad4d7b914c
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-06-03 07:57:30 -05:00
github-actions[bot]
f172612b19
Autosync the updated translations (#9470)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-06-02 09:30:49 +00:00
Cesar Gonzalez
820829581d
[PM-8027] Updating how we guard against excessive getPageDetails calls 2024-05-31 16:31:56 -05:00
Cesar Gonzalez
1fac4e3a34
Merge branch 'main' into autofill/pm-8027-inline-menu-appears-within-input-fields-that-do-not-relate-to-user-login 2024-05-31 16:18:21 -05:00
Cesar Gonzalez
d159d97bed
Merge branch 'autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes 2024-05-31 16:16:15 -05:00
Cesar Gonzalez
cc61c67e0c
Merge branch 'main' into autofill/pm-8518-autofill-scripts-do-not-inject-into-sub-frames-on-install 2024-05-31 16:15:35 -05:00
Cesar Gonzalez
52341fb563
[PM-8518] Adding generic typing to tabSendMessage call 2024-05-31 16:15:00 -05:00
Cesar Gonzalez
e6848bd5eb
[PM-8027] Updating update of page details after mutation to act on an idle moment in the browser 2024-05-31 15:42:42 -05:00
Cesar Gonzalez
52db6775e9
[PM-8027] Cleaning up implementation details 2024-05-31 15:17:51 -05:00
Cesar Gonzalez
dafdb43731
[PM-8027] Cleaning up implementation details 2024-05-31 15:10:19 -05:00
Cesar Gonzalez
ff96fc1773
[PM-8027] Cleaning up implementation details 2024-05-31 15:06:46 -05:00
Cesar Gonzalez
f3d41f91aa
[PM-8027] Reworking inline menu to qualify and setup the listeners for each form field after page deatils have been collected 2024-05-31 14:58:21 -05:00