* [PM-5876] Adjust LP Fileless Importer to Suppress Download with DOM Append in Manifest v3
* [PM-5876] Incorporating jest tests for affected logic
* [PM-5876] Fixing jest test that leverages rxjs
* [PM-5876] Updating documentation within BrowserApi.executeScriptInTab
* [PM-5876] Implementing jest tests for the new LP suppress download content scripts
* [PM-5876] Adding a change to webpack to ensure we do not package the mv2 side script for `lp-suppress-import-download.mv2.ts` if building the extension for mv3
* [PM-5876] Implementing changes based on feedback during code review
* [PM-5876] Implementing changes based on feedback during code review
* [PM-5876] Implementing changes based on feedback during code review
* [PM-5876] Implementing changes based on feedback during code review
* [PM-5876] Implementing a configuration to feed the script injection of the Fileless Importer CSV download supression script
* Migrate existing provider data to StateProvider
Migrate existing provider data to StateProvider
* Rework the ProviderService to call StateProvider
* Unit test the ProviderService
* Update DI to reflect ProviderService's new args
* Add ProviderService to logout chains across products
* Remove provider related stateService methods
* Update libs/common/src/state-migrations/migrations/28-move-provider-state-to-state-provider.spec.ts
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
* Cover up a copy/paste job
* Compare equality over entire array in a test
---------
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
* create user notification settings state provider
* replace state service get/set disableAddLoginNotification and disableChangedPasswordNotification with user notification settings service equivalents
* migrate disableAddLoginNotification and disableChangedPasswordNotification global settings to user notification settings state provider
* add content script messaging the background for enableChangedPasswordPrompt setting
* Implementing feedback to provide on PR
* Implementing feedback to provide on PR
* PR suggestions cleanup
---------
Co-authored-by: Cesar Gonzalez <cgonzalez@bitwarden.com>
* Revert "[PM-5277] Migrate Sync Service to State Provider (#7680)"
This reverts commit 78008a9e1e.
Includes a noop migration builder that allows us to bridge over the deleted migration
* Prefer revert migrations to noop
this revert avoids the need to change behavior between released vs unreleased migrations and keeps some dangerous code out of the repo :success:
* Update ordering of badge settings migrator to be consistent with `rc`, which was cut with only up to version 25
* Fix missing type import
* [PM-673] Safari Notification Bar Does Not Show Folders
* [PM-673] Refactoring Context Menu Implementations to Ensure Pages with No Logins Can Dismiss Notification Bar
* [PM-673] Refactoring typing information for the LockedVaultPendingNotificationsItem typing
* [PM-673] Refactoring typing information for notification background
* [PM-673] Finishing out typing for potential extension messages to the notification bar;
* [PM-673] Working through implementation details for the notification background
* [PM-673] Fixing issues present with messaging re-implementation
* [PM-673] Fixing issue with folders not populating within Safari notification bar
* [PM-673] Fixing jest test issues present within implementation
* [PM-673] Fixing issue present with webVaultUrl vulnerability
* [PM-673] Fixing XSS Vulnerability within Notification Bar;
* [PM-5670] Putting together a partial implementation for having messages appear on network error within the notification bar
* [PM-673] Incorporating status update for when user has successfully saved credentials
* [PM-673] Incorporating status update for when user has successfully saved credentials
* [PM-5949] Refactor typing information for notification bar
* [PM-5949] Fix jest tests for overlay background
* [PM-5949] Removing unnused typing data
* [PM-5949] Fixing lint error
* [PM-5949] Adding jest tests for convertAddLoginQueueMessageToCipherView method
* [PM-5949] Fixing jest test for overlay
* [PM-5950] Fix Context Menu Update Race Condition and Refactor Implementation
* [PM-5950] Adding jest test for cipherContextMenu.update method
* [PM-5950] Adding documentation for method within MainContextMenuHandler
* [PM-5950] Adding jest tests for the mainContextMenuHandler
* [PM-673] Stripping unnecessary work for network drop issue
* [PM-673] Stripping unnecessary work for network drop issue
* [PM-2753] Prompt to Save New Login Credentials Silently Drops Data on Network Error
* [PM-673] Stripping out work done for another ticket
* [PM-4566] Fix santization check issue found with webVaulUrl in notification bar
* [PM-4566] Refactoring implementation
* [PM-5950] Removing unnecessary return value from MainContextMenuHandler.create method
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Incorporating addition of green and red borders when success or error events occur
* [PM-4566] Adding jest test to validate changes within the notification background
* [PM-5950] Fixing unawaited context menu promise
* [PM-673] Merging changes in from main and fixing merge conflicts
* [PM-2753] Merging work in from main and resolving merge conflicts
* [PM-6122] Rework `window` call within NotificationBackground to function within content script
* [PM-4566] Incorporating a more fleshed out implementation to remove queryParams from the notification bar url entirely
* [PM-673] Fixing issue where updates to the added login were not triggering correctly
* [PM-673] Merging changes in from main and fixing merge conflicts
* [deps] Tools: Update electron to v28.2.5
* Update version in electron-builder.json
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* Establish biometric unlock enabled in state providers
* Use biometric state service for biometric state values
* Migrate biometricUnlock
* Fixup Dependencies
* linter and import fixes
* Fix injection
* Fix merge
* Use boolean constructor as mapper
* Conform to documented test naming conventions
* Commit documentation suggestion
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
* Fix merge commit
* Fix test names
---------
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
* [deps] Tools: Update electron-builder to v24
* Add ElectronTeamID
* Remove double signing and use the proper extraFiles for safari extension
* Revert "Remove double signing and use the proper extraFiles for safari extension"
This reverts commit 94635dbd02.
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Hinton <hinton@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* create badge settings state provider
* replace state service get/set disableBadgeCounter with badge settings service equivalent
* migrate disableBadgeCounter account setting to badge settings state provider
* cleanup and address PR suggestions
* Sent initiation path for organization and user signups
* Rename organizationQueryParameter > organizationTypeQueryParameter
* Jared's feedback
* Split PM & SM initiation path
* create auth request service
* copy methods from auth crypto service
* register new auth request service
* remove refs to auth request crypto service
* remove auth request crypto service
* remove passwordless login method from login strategy service
* add docs to auth request service
* [PM-6416] Inline autofill menu does not show if notification bar turned off
* [PM-6416] Inline autofill menu does not show if the notification bar has been turned off
* [deps] Tools: Update electron to v28.2.4
* Bump version in electron-builder.json
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* [PM-6352] Autofill functionality not working with re-hydtrated DOM elements
* [PM-6352] Autofill functionality not working with re-hydtrated DOM elements
* [PM-6352] Fixing issue found with chrome.dom.openOrClosedShadowRoot call
* [PM-6352] Implementing jest tests and adding utils methods where appropriate
* [PM-6352] Implementing jest tests and adding utils methods where appropriate
* [PM-5742] Rework Usage of Extension APIs that Cannot be Called with the Background Service Worker
* [PM-5742] Implementing jest tests for the updated BrowserApi methods
* [PM-5742] Implementing jest tests to validate logic within added API calls
* [PM-5742] Implementing jest tests to validate logic within added API calls
* [PM-5742] Fixing broken Jest tests
* [PM-5742] Fixing linter error
* [PM-5881] Adjust usage of the `chrome.extension.getViews` API to ensure expected behavior in manifest v3
* [PM-5881] Reworking how we handle early returns from `reloadOpenWindows`
* [PM-5881] Implementing jest test to validate changes within BrowserApi.reloadOpenWindows
* migrate clearClipboard account setting to autofill settings state provider
* replace state service get/set clearClipboard with autofill settings service equivalents
* PR suggestions cleanup
* [PM-5679] Capture all form data from page when selecting "New item" even if popout is already open
* [PM-5679] Capture all form data from page when selecting "New item" even if popout is already open
* [PM-5697] Fixing floating promise within the handleExtensionMessage method
* [AC-2195] Update canEditAnyCipher permission to make an exception for Custom users with editAnyCollection permission
* [AC-2195] Update V1 FC flag check to include check for an organization's FC status
* [AC-2195] Remove redundant collection management setting check that was hiding the restricted access message for custom users with deleteAnyCollection
* [AC-2195] Ensure users with canEditAnyCollections can edit all collections
* WIP admin console layout
* Update icons
* Migrate more things
* Migrate the last pages
* Move header to web
* Fix story not working
* Convert header component to standalone
* Migrate org layout to standalone
* Enable org switcher
* Add AC to product switcher
* Migrate provider portal to vertical nav
* Migrate PM
* Prettier fixes
* Change AC and PP to use secondary variant layout & update logos
* Remove full width setting
* Remove commented code
* Add header to report pages
* Add provider portal banner
* Fix banner for billing pages
* Move vault title to header
* Prevent scrollbar jumping
* Move send button to header
* Replace search input with bit-search
* Remove unused files and css
* Add banner
* Tweak storage option
* Fix duplicate nav item after merge
* Migrate banner state to state provider framework
* [AC-2078] Fix device approvals header
* [PM-5861] Hide AC from product switcher for users that do not have access
* [PM-5860] Fix Vault and Send page headers
* [AC-2075] Fix missing link on reporting nav group
* [AC-2079] Hide Payment Method and Billing History pages for self-hosted instances
* [AC-2090] Hide reports/event log nav items for users that do not have permission
* [AC-2092] Fix missing provider portal option in product switcher on page load
* Add null check for organization in org layout component
* [AC-2094] Fix missing page header for new client orgs page
* [AC-2093] Update New client button styling
* Fix failing test after merge
* [PM-2087] Use disk-local for web layout banner
* [PM-6041] Update banner copy to read "web app"
* [PM-6094] Update banner link to marketing URL
* [PM-6114] add CL container component to VVR pages (#7802)
* create bit-container component
* add container to all page components
* Fix linting errors after merge with main
* Fix product switcher stories
* Fix web-header stories
* mock org state properly in product switcher stories (#7956)
* refactor: move web layout migration banner logic into a service (#7958)
* make CL codeowner of web header files
* move migration banner logic to service; update stories
* [PM-5862] Ensure a sync has run before hiding navigation links
* Remove leftover banner global state
* Re-add dropped selfHosted ngIf
* Add rel noreferrer
* Remove comment
---------
Co-authored-by: Shane Melton <smelton@bitwarden.com>
Co-authored-by: Will Martin <contact@willmartian.com>
* [PM-673] Safari Notification Bar Does Not Show Folders
* [PM-673] Refactoring Context Menu Implementations to Ensure Pages with No Logins Can Dismiss Notification Bar
* [PM-673] Refactoring typing information for the LockedVaultPendingNotificationsItem typing
* [PM-673] Refactoring typing information for notification background
* [PM-673] Finishing out typing for potential extension messages to the notification bar;
* [PM-673] Working through implementation details for the notification background
* [PM-673] Fixing issues present with messaging re-implementation
* [PM-673] Fixing issue with folders not populating within Safari notification bar
* [PM-673] Fixing jest test issues present within implementation
* [PM-673] Fixing issue present with webVaultUrl vulnerability
* [PM-673] Fixing XSS Vulnerability within Notification Bar;
* [PM-5670] Putting together a partial implementation for having messages appear on network error within the notification bar
* [PM-673] Incorporating status update for when user has successfully saved credentials
* [PM-673] Incorporating status update for when user has successfully saved credentials
* [PM-5949] Refactor typing information for notification bar
* [PM-5949] Fix jest tests for overlay background
* [PM-5949] Removing unnused typing data
* [PM-5949] Fixing lint error
* [PM-5949] Adding jest tests for convertAddLoginQueueMessageToCipherView method
* [PM-5949] Fixing jest test for overlay
* [PM-5950] Fix Context Menu Update Race Condition and Refactor Implementation
* [PM-5950] Adding jest test for cipherContextMenu.update method
* [PM-5950] Adding documentation for method within MainContextMenuHandler
* [PM-5950] Adding jest tests for the mainContextMenuHandler
* [PM-673] Stripping unnecessary work for network drop issue
* [PM-673] Stripping unnecessary work for network drop issue
* [PM-2753] Prompt to Save New Login Credentials Silently Drops Data on Network Error
* [PM-673] Stripping out work done for another ticket
* [PM-5950] Removing unnecessary return value from MainContextMenuHandler.create method
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Incorporating addition of green and red borders when success or error events occur
* [PM-5950] Fixing unawaited context menu promise
* [PM-673] Merging changes in from main and fixing merge conflicts
* [PM-2753] Merging work in from main and resolving merge conflicts
* [PM-673] Fixing issue where updates to the added login were not triggering correctly
* [PM-673] Merging changes in from main and fixing merge conflicts
* Fix nextMock arguments
* Add state for biometric prompts
* Use biometric state for prompts
* Migrate biometric prompt data
* wire up biometric state to logouts
* Add migrator to migrate list
* Remove usages of prompt automatically
Explicitly list non-nulled state as intentional
* `npm run prettier` 🤖
* Fix web lock component
* create key generation service
* replace old key generation service and add references
* use key generation service in key connector service
* use key generation service in send service
* user key generation service in access service
* use key generation service in device trust service
* fix tests
* fix browser
* add createKeyFromMaterial and tests
* create ephemeral key
* fix tests
* rename method and add returns docs
* ignore material in destructure
* modify test
* specify material as key material
* pull out magic strings to properties
* make salt optional and generate if not provided
* fix test
* fix parameters
* update docs to include link to HKDF rfc
* [PM-5741] Reworking usage of `window` object in BrowserApi.reloadExtension method
* [PM-5741] Reworking usage of `window` object in BrowserApi.reloadExtension method
* Move user key memory state to state providers
Note: state service observable change is because these updates are no longer internal to the class, but reporter directly to account service through crypto service on update of a user key
* remove decrypted user key state
Note, we're going to move the encrypted cryptoSymmetric key (and associated master key encrypted user keys) as part of the master key service creation. Crypto service will no longer be responsible for the encrypted forms of user key.
* Deprecate notices belong on abstraction
* Allow for single-direction status updates
This is necessary since we don't want to have to guarantee that the update to logged out occurs after the update to locked.
* Remove deprecated subject
It turns out the set for cryptoMasterKey was also unused 🎉
* [AC-2193] Hide collection access restricted state when there are visible sub-collections
* [AC-2193] Undo change to showCollectionAccessRestricted
* [AC-2193] Update not items and access restricted views to only show if there are both no collections or items available
* [PM-673] Safari Notification Bar Does Not Show Folders
* [PM-673] Refactoring Context Menu Implementations to Ensure Pages with No Logins Can Dismiss Notification Bar
* [PM-673] Refactoring typing information for the LockedVaultPendingNotificationsItem typing
* [PM-673] Refactoring typing information for notification background
* [PM-673] Finishing out typing for potential extension messages to the notification bar;
* [PM-673] Working through implementation details for the notification background
* [PM-673] Fixing issues present with messaging re-implementation
* [PM-673] Fixing issue with folders not populating within Safari notification bar
* [PM-673] Fixing jest test issues present within implementation
* [PM-673] Fixing issue present with webVaultUrl vulnerability
* [PM-673] Fixing XSS Vulnerability within Notification Bar;
* [PM-5670] Putting together a partial implementation for having messages appear on network error within the notification bar
* [PM-673] Incorporating status update for when user has successfully saved credentials
* [PM-673] Incorporating status update for when user has successfully saved credentials
* [PM-5949] Refactor typing information for notification bar
* [PM-5949] Fix jest tests for overlay background
* [PM-5949] Removing unnused typing data
* [PM-5949] Fixing lint error
* [PM-5949] Adding jest tests for convertAddLoginQueueMessageToCipherView method
* [PM-5949] Fixing jest test for overlay
* [PM-5950] Fix Context Menu Update Race Condition and Refactor Implementation
* [PM-5950] Adding jest test for cipherContextMenu.update method
* [PM-5950] Adding documentation for method within MainContextMenuHandler
* [PM-5950] Adding jest tests for the mainContextMenuHandler
* [PM-673] Stripping unnecessary work for network drop issue
* [PM-673] Stripping unnecessary work for network drop issue
* [PM-673] Stripping out work done for another ticket
* [PM-5950] Removing unnecessary return value from MainContextMenuHandler.create method
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-5950] Fixing unawaited context menu promise
* [PM-673] Merging changes in from main and fixing merge conflicts
* [PM-673] Fixing issue where updates to the added login were not triggering correctly
* [PM-673] Merging changes in from main and fixing merge conflicts
* [PM-5949] Refactor typing information for notification bar
* [PM-5949] Fix jest tests for overlay background
* [PM-5949] Removing unnused typing data
* [PM-5949] Fixing lint error
* [PM-5949] Adding jest tests for convertAddLoginQueueMessageToCipherView method
* [PM-5949] Fixing jest test for overlay
* [PM-5950] Fix Context Menu Update Race Condition and Refactor Implementation
* [PM-5950] Adding jest test for cipherContextMenu.update method
* [PM-5950] Adding documentation for method within MainContextMenuHandler
* [PM-5950] Adding jest tests for the mainContextMenuHandler
* [PM-5950] Removing unnecessary return value from MainContextMenuHandler.create method
* [PM-5950] Fixing unawaited context menu promise
* [PM-4756] feat: set BE and BS flags
* [PM-4755] feat: add support for credProps.rk
* [PM-4755] feat: add extension support to page-script object mapping
* Create state for biometric client key halves
* Move enc string util to central utils
* Provide biometric state through service
* Use biometric state to track client key half
* Create migration for client key half
* Ensure client key half is removed on logout
* Remove account data for client key half
* Remove unnecessary key definition likes
* Remove moved state from account
* Fix null-conditional operator failure
* Simplify migration
* Remove lame test
* Fix test type
* Add migrator
* Remove state that is never read.
* Remove unnecessary biometric state
We don't need to determine platform in desktop background, it can be done in the UI at any time.
* Fix merge
* Use platform utils to identify OS desktop type
