In 1.13, the name of the grass block changed from "grass" to "grass_block". This caused no experience to be given while using a shovel on grass. This change was part of something mojang called the flattening and could possibly be the cause of some other experience related issues.
https://minecraft.gamepedia.com/1.13/Flattening
* Updated ItemUtils, added isBlock check to smelt functions
+ added a check in ItemUtils.isSmeltable() and ItemUtils.isSmelted() to make sure the Item type was a block to prevent an error occuring mentioned in https://github.com/mcMMO-Dev/mcMMO/issues/3536
* Fixed Green Thumb replant issue
see https://github.com/mcMMO-Dev/mcMMO/issues/3535
HerbalismManager
= fixed names of netherwart
= fixed handleBlockState, and slightly altered it
StringUtils
= fixed name of netherwart
* Fixes to herbalism skill
Herbalism
= fixed material name for grass in green terra block conversion
= fixed material name for grass in shroom thumb block conversion
EntityListener
= fixed material name for melon in food level change
experience config
= updated name for melon and sugar cane
* Minor Name Updates
experience config
= removed Stone|*
= added Stone, Granite, Adesite, Diorite
MaterialTypes
= updated material reference for wood
* Small fishing change
PlayerListener
= made it so COD, TROPICAL_FISH, and PUFFERFISH are no longer overwritten, so players can now catch these
* [WIP] Replacing MaterialData with Blockdata
* Fixed most block based experience gain
* Removed debug prints
* Updated configs
* [WIP] Replacing MaterialData with Blockdata
* Fixed most block based experience gain & updated wooden_tools
* ACTAULLY removed debug prints
* [WIP] Replacing bukkit treespecies
This feature has been unofficially deprecated, (not yet fixed/marked in bukkit)
Also updated config.yml to match changes
* Updated configs
* [WIP] Replacing MaterialData with Blockdata
* [WIP] Replacing MaterialData with Blockdata
* Fixed most block based experience gain
* Fixed most block based experience gain & updated wooden_tools
* Removed debug prints
* ACTAULLY removed debug prints
* [WIP] Replacing bukkit treespecies
This feature has been unofficially deprecated, (not yet fixed/marked in bukkit)
Also updated config.yml to match changes
* Fixed greenterra
Replaced deprecated features
* Updated configs
* [WIP] Replacing MaterialData with Blockdata
* Fixed most block based experience gain
* Fixed most block based experience gain & updated wooden_tools
* Removed debug prints
Due to flaws the previous changes to the configuration system combined with some bad lines in the experience.config that I mistakenly recommended, herbalism was not granting experience in most cases, as it was marking newly planted crops and such as player placed no exp granting blocks, rather than ignoring them as it should.
block types now are evaluated in 3 steps:
1: Explicit Name i.e. ("Crops|4", "Crops|0"), Which is the material name then data value
2: "friendly name" i.e. ("Crops_Ripe", "Crops_Ungrown"), Which is a typically data valueless name, some of which I make up in mcMMO, but most of which are just the Material name
3: Wildcard name i.e. ("Crops|*") Which is any block with that block value, regardless of data value
In order to be sure herbalism grants exp for you once again, make sure your configuration for herbalism looks similar to this:
https://github.com/mcMMO-Dev/mcMMO/blob/master/src/main/resources/experience.yml#L151
In terms of which blocks are listed there. Specifically, there should be no blocks marked "ungrown"
The child permission has the value set to false. From http://bukkit.gamepedia.com/Plugin_YAML: "a child node of false inherits the inverse parent permission". Having the value set to false grants the permission to reset other players' skills to everyone that doesn't have the mcmmo.skillreset permission, which by default nobody has.
This fixes brewing on the newest Spigot API builds. The Alchemy skill was completely broken due to a change in the Spigot BrewEvent constructor, which this fixes via the changes to FakeBrewEvent.java and AlchemyPotionBrewer.java. This also adds a check in EntityListener.java for armor stands, so that health bars aren't displayed for them. The health bars never really displayed properly (armor stand health acts differently from most entities), and it allowed players to punch invisible armor stands server admins may have been intentionally hiding to temporarily reveal them via a health bar, which is an issue.
If radius is 1 (as it is when called elsewhere in the class), the loop
conditions fail to refresh some of the neighboring chunks, allowing for
ghost blocks to continue to occur on eastern and southern edges of the
chunk the player is in.
This commit fixes the loop conditions.
= Chunk diagram of old behavior =
-----
-RR--
-RP--
-----
-----
= Chunk diagram of new behavior =
-----
-RRR-
-RPR-
-RRR-
-----
= Legend =
P: the chunk the player is in
R and P: chunks that are refreshed
-: chunks that do not get refreshed
The 'NETHER_WARTS' material enum should be 'NETHER_STALK' to represent the actual item.
Adds Dragon's Breath as Tier 1 Ingredient so lingering potions are actually validated as an mcMMO brew.
Adds second type of Potion of Water to support water potions that are spawned in via commands or other plugins.
My fix for the central spawn points of various block-based item drops
moved them from the low corner of the block to the center of the block.
In the case of the salvaged materials, this moved the central spawn
point from the low corner of the top face of the anvil block to the
center of the block above the anvil block. This felt unnatural, so the
point has been moved to the center of the top face of the anvil block.
Fixed a glitch that let players remove the ingredient of a custom potion
from the brewing stand without cancelling the brewing task (this doesn't
seem to have caused any duplicates, once the task finished nothing
happened).
