Commit Graph

648 Commits

Author SHA1 Message Date
DNx5
cbd9add1b7 Removed a test for antibot service. 2016-10-18 03:46:15 +07:00
DNx5
b55805ff87 - Added Test for '/email show' command.
- Update javadoc & cleanup.
2016-10-17 23:29:45 +07:00
ljacqu
ed6c7043ae Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 768-update-messages-cmd 2016-10-16 20:39:18 +02:00
ljacqu
995d4acda2 Upgrade to ConfigMe 0.2 2016-10-16 20:08:52 +02:00
ljacqu
252813197f Test simple event cancellation with method references instead of reflection 2016-10-16 11:19:54 +02:00
ljacqu
755f3df33e #768 Create command for updating messages file 2016-10-10 22:36:14 +02:00
Gabriele C
700ab5f3e4 Cleanup 2016-10-09 23:46:07 +02:00
ljacqu
87f88cb32a #293 Fix localized command losing its children 2016-10-09 16:23:18 +02:00
ljacqu
76e6d757da Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 293-translate-help-messages 2016-10-09 15:39:50 +02:00
ljacqu
5928aee097 #293 Add comments to help file, migrate header setting, write tests 2016-10-09 14:53:10 +02:00
ljacqu
fc08e9dbd1 #976 Link messages file in doc, #836 update Hungarian messages 2016-10-09 09:52:07 +02:00
ljacqu
edfd833198 #293 Improve handling of disabled sections 2016-10-09 00:50:03 +02:00
ljacqu
93c61a0511 #976 Create translations doc page 2016-10-08 23:00:26 +02:00
ljacqu
a8d5b19807 Move all doc generating tasks into docs package 2016-10-08 14:58:06 +02:00
ljacqu
f453a5b4f5 #293 Skip help sections if translation is empty 2016-10-08 14:25:42 +02:00
ljacqu
dd9312f581 Minor improvements in tool tasks
- Use java 8 types in UpdateDocsTask
- Simplify permissions page writing task to write to the file without any options
- Various minor simplifications (Java 8) to avoid casting etc.
2016-10-08 00:39:11 +02:00
ljacqu
6b1112438a #293 Fix tests and create consistency test for English help file 2016-10-07 23:44:36 +02:00
ljacqu
26716b0f79 #293 Create class for handling messages from file with fallback
- Move logic for loading a messages file with a default fallback into one class
- Remove message-specific handling from Settings class
2016-10-07 23:38:30 +02:00
ljacqu
d78b7cc4af #293 Create class for handling message file initialization
- Work in progress; more logic can be extracted
2016-10-07 20:12:18 +02:00
Gabriele C
7b5a857f74 Remove useless packages 2016-10-07 19:19:12 +02:00
ljacqu
c30e7acdc5 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 293-translate-help-messages
Conflicts:
	src/main/java/fr/xephi/authme/command/help/HelpProvider.java
2016-10-07 19:11:49 +02:00
ljacqu
71f3b86383 Minor - fix checkTestMocks task and rename PlayerDataTaskManager
- Fix tool task to scan test folder
- Rename PlayerDataTaskManager to LimboPlayerTaskManager to match its test class
2016-10-06 20:29:50 +02:00
ljacqu
4b2ad51354 #970 Fix & write unit tests for antibot startup delay config 2016-10-05 22:45:26 +02:00
Gabriele C
58c42cf300 Package cleanup
- authme.cache to authme.data
- Rename PlayerData to LimboPlayer to match with LimboCache
- Move authme.converter to authme.datasource.converter
- Split output package into output and message
2016-10-05 21:10:40 +02:00
Gabriele C
7e2912cc60 Revert "Fix refactor errors"
This reverts commit 2d2c14eb0a.
2016-10-04 22:31:37 +02:00
Gabriele C
2d2c14eb0a Fix refactor errors 2016-10-04 22:30:25 +02:00
Gabriele C
f3cd193d47 Move RandomStringUtils 2016-10-04 19:16:06 +02:00
Gabriele C
42dbb27728 Service cleanup 2016-10-04 19:08:18 +02:00
ljacqu
5c2d7139bc Create unit tests for antibot refactoring 2016-10-03 21:55:04 +02:00
Gabriele C
88ce493438 AntiBot cleanup + moved to services
Some test needs to be fixed/added
2016-10-02 19:41:14 +02:00
ljacqu
71ac86ff02 Remove StringUtils#join in favor of String#join (Java 8) 2016-10-02 12:44:10 +02:00
ljacqu
e07c685d2a Minor tool task improvements
- List tasks alphabetically in tools runner
- Remove redundant space before CUSTOM entry in hash algorithms table
2016-10-02 10:55:02 +02:00
ljacqu
74a61188f5 Update docs / fix hash algorithms task / fix unit tests
- From a common session wit sgdc3
2016-10-01 23:43:37 +02:00
Gabriele C
62b8af6a37 Fix #904 (Ljacqu, pls fix me :P) 2016-10-01 23:09:39 +02:00
ljacqu
f6a2b2b34b #293 Translatable help messages: basic structure
(work in progress)
- Create service that provides localized messages when available for HelpProvider
2016-10-01 14:42:49 +02:00
ljacqu
113a3f346c Message file verifier: allow to simply enter the language code instead of full path
- To check a single file just enter the language file, e.g. "es"
- Pass File object to MessageFileVerifier instead of String path that will be constructed to a File again...
2016-10-01 11:02:24 +02:00
ljacqu
8d64c0e5bf #830 Initialize login process with more specific methods (with password vs. force login) 2016-10-01 00:48:23 +02:00
ljacqu
4eab258993 #937 Add option for AuthMe to run in sync
- Create BukkitService#runTaskOptionallyAsync and BukkitService#scheduleSyncTaskFromOptionallyAsyncTask whose behavior depends on a new setting
- Use the new methods where applicable
- Declare events async or sync depending on the new setting
2016-09-18 21:58:14 +02:00
ljacqu
ff9f50f63f #886 Do not include players with lastlogin = 0 in autopurge or default purge 2016-09-18 16:49:34 +02:00
ljacqu
405bd563d8 #950 Add unregister by name to API
- Add method to API
- Ensure that unregistering in datasource is case-insensitive
2016-09-18 14:46:02 +02:00
ljacqu
f804b528e5 Change message verification task to add todo comments in same order
- Make verification task add todo comments to YML files in the same order as the MessageKey enum
- Use DefaultCharsets everywhere instead of Guava's Charsets class (thanks to DNx5)
2016-09-17 10:56:30 +02:00
ljacqu
bdf8819aa7 Create FileUtils#delete and write tests for FileUtils 2016-09-17 00:42:18 +02:00
ljacqu
0aa02b70f0 Merge branch '472-confirm-email-recovery' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-09-16 23:45:54 +02:00
ljacqu
d55ede5dab Fix failing test 2016-09-16 23:45:40 +02:00
ljacqu
c1e90a8faf Minor - favor Guava's UTF-8 charset constant; sensible -> sensitive in issue template 2016-09-16 23:38:36 +02:00
ljacqu
d1b7c0ed99 #942 #943 Unit test NewAPI registered names methods 2016-09-16 23:27:58 +02:00
ljacqu
c78acee6e0 #472 Add translatable messages and unit tests 2016-09-16 23:18:32 +02:00
ljacqu
e30d7220bd #472 Store recovery codes in memory instead of in data source 2016-09-16 21:42:16 +02:00
ljacqu
bff344ba8f #472 Recovery code: allow to configure length, expiration and email 2016-09-10 16:39:35 +02:00
ljacqu
c5f5c0d2fd #472 Require recovery code before resetting password
- /email recovery generates recovery code and resets password only if recovery code is also given
- Change data source method to return email and recovery code
2016-09-10 14:27:26 +02:00
ljacqu
0aac8928af #472 Create recovery code/expiration columns and methods in data source 2016-09-10 09:13:17 +02:00
ljacqu
ffc5b77f36 Revert: [RevertMe] Remove essentials hook (currently unavailable using maven) 2016-09-09 21:56:32 +02:00
ljacqu
d959b0a3f2 #932 Use class collector for listener consistency test 2016-09-09 21:54:18 +02:00
ljacqu
10493a3fa3 #932 Create class collector and use it where applicable
- Extract logic for walking through a directory and loading its classes into a separate class
- Replace all implementations with the new ClassCollector
2016-09-07 22:50:12 +02:00
Gabriele C
f63871600a [RevertMe] Remove essentials hook (currently unavailable using maven) 2016-09-07 16:04:20 +02:00
ljacqu
c8565e1ce5 Minor - replace our BiConsumer interface in test with Java 8's 2016-09-04 22:36:36 +02:00
Gabriele C
0dac0c4b21 #927 Relocate ConfigMe 2016-09-04 16:30:30 +02:00
ljacqu
25780ede89 #927 Use 0.1 version and adjust to changes from ConfigMe 2016-09-04 15:32:58 +02:00
ljacqu
09f403f357 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into configme-integration
Conflicts:
	pom.xml
2016-09-04 15:25:58 +02:00
ljacqu
6857bd929e Fix generics in ConverterCommandTest 2016-09-04 15:01:52 +02:00
ljacqu
5930f705f2 Send more precise message when converter type does not exist 2016-09-04 14:47:16 +02:00
ljacqu
ee5ed13931 Replace enum with map in converter command 2016-09-04 14:23:13 +02:00
ljacqu
589e589e45 #933 Add MySQL to SQLite converter
- Create common parent for converting from one datasource type to another
- Add MySQL to SQLite child
- Create tests
2016-09-04 13:59:23 +02:00
ljacqu
34a2b46768 #927 Fix Settings initialization and failing tests 2016-09-03 11:30:03 +02:00
ljacqu
b8153c2578 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into configme-integration 2016-09-03 10:31:05 +02:00
ljacqu
0d368ef1a2 Revert: Use official bPermissions artifact
- Since 3ea933ffc6 the Jenkins build has been failing and it is no longer possible to build locally. Now Travis and CircleCI are also failing.
2016-09-03 10:05:32 +02:00
ljacqu
36dfab636a #927 Update code to recent changes in ConfigMe 2016-08-31 22:19:27 +02:00
ljacqu
c7bb7b460e #927 Integrate ConfigMe into AuthMe (work in progress)
- Replace own code with ConfigMe
2016-08-30 15:28:07 +02:00
Gabriele C
3ea933ffc6 Use official bPermissions artifact 2016-08-29 01:21:40 +02:00
ljacqu
33eab1df21 #876 Make expiration configurable and implement cleanup for old entries 2016-08-28 12:12:46 +02:00
ljacqu
f666ea9370 Minor - make ReflectionTestUtils.getFieldValue do the casting directly 2016-08-27 21:30:01 +02:00
ljacqu
2417bf4c3f #876 Keep track of wrong logins by (ip, username) and implement threshold 2016-08-27 21:28:11 +02:00
ljacqu
e224d62b7e Hashes: make tests faster when 'skip long tests' profile is enabled 2016-08-27 21:26:36 +02:00
ljacqu
f59a584622 Write tests for AsyncUnregister and TaskCloser 2016-08-27 21:26:15 +02:00
ljacqu
289ce7740f Update injector version and move shutdown logic to separate classes 2016-08-20 21:54:41 +02:00
ljacqu
926053689a #830 Unify unregister process flavors 2016-08-13 23:46:46 +02:00
ljacqu
7f3c308009 #848 Prevent "invalid salt version" when hash format is clearly not BCrypt 2016-08-13 20:10:38 +02:00
ljacqu
58308cffb5 Minor - increase date tolerance in test after repeated fails on Jenkins 2016-08-13 16:45:50 +02:00
ljacqu
02ca2d18b9 Move more complex initializations from main class to Initializer helper (tentative) 2016-08-12 22:04:56 +02:00
ljacqu
5d2da7bd82 Trivial code householding 2016-08-12 18:36:35 +02:00
Gabriele C
67d53d0c3c Ok yaml isn't happy with \n, use %nl% instead! #898 2016-08-11 22:54:13 +02:00
Xephi59
977bbbb70c Prevent player for switching items in hands with shortkeys 2016-08-11 15:25:31 +02:00
Gabriele C
efe62beccd Reset speed if it was 0 #890 2016-08-09 19:44:32 +02:00
Gabriele C
402a5e016e Temp-fix speed restore test 2016-08-09 18:17:02 +02:00
Gabriele C
bf71f98fae Main class cleanup, take 1 2016-08-09 01:05:22 +02:00
ljacqu
b4ea396d08 #806 Add tests and avoid sessions cleanup if they're disabled 2016-08-07 10:31:33 +02:00
ljacqu
eef314b965 Write more unit tests for listeners, minor cleanup 2016-08-06 13:21:39 +02:00
ljacqu
062e461357 #337 Minor improvements in plugin.yml consistency test
- Make static field immutable
- Use stricter constraint for checking children paths
- Improve error path logged upon error
2016-08-05 21:27:57 +02:00
ljacqu
69d8232cc8 #337 Check children declarations in consistency test for plugin.yml permissions 2016-08-05 21:23:21 +02:00
ljacqu
f75cd4c5c9 Add unit tests for country validation 2016-08-05 18:57:28 +02:00
ljacqu
766aa154f8 Start unit tests for player movement handler in player listener 2016-08-05 17:08:38 +02:00
ljacqu
d1a1e47928 #872 Harmonize plugin.yml permissions with code + #337 create consistency test 2016-08-04 22:10:31 +02:00
ljacqu
cff6763cee Add more unit tests for the listeners 2016-08-04 20:48:28 +02:00
ljacqu
8002ef45fd Teleportation needs to be scheduled in sync
- Revert removal of sync scheduled task for teleportation
- Add back listener properties from 5d6f3e1 since they don't interfere
2016-08-04 19:08:05 +02:00
ljacqu
3534f680f7 Fix unit tests 2016-08-04 18:25:43 +02:00
ljacqu
bb52e0120c Write first unit tests for PlayerListener 2016-08-03 22:11:48 +02:00
ljacqu
4aad1d506c #831 Implement single session by canceling kicks caused by same name joining
- A little less nice, but works on both CraftBukkit and Spigot
- Remove obsolete warning
2016-08-03 21:31:40 +02:00
Gabriele C
f4add64695 Try with an higher priority (like 3.4) 2016-08-03 21:17:52 +02:00
ljacqu
80337f758b #831 Cleanup, finalization
- Handle AsyncPlayerPreLoginEvent in main PlayerListener class: Spigot emits it in offline mode, whereas offline CraftBukkit doesn't
- Remove listener for sync PlayerPreLoginEvent; not fired by offline CraftBukkit either
- Add warning when offline CraftBukkit is detected and single session setting is enabled
2016-08-03 19:58:10 +02:00
Gabriele C
b892b8e3a8 Fix issues aka "I should go to sleep" + fix unit tests 2016-08-03 01:22:03 +02:00
Gabriele C
e2d20caf16 Whoops, wrong place! (Damn eclipse class tree XD) 2016-08-03 01:06:34 +02:00
Gabriele C
75421fd156 Listeners name refactor + Fix #831 for both Spigot and CraftBukkit 2016-08-03 01:02:25 +02:00
Gabriele C
bff99902b0 Add a debug message #831 2016-08-02 19:07:54 +02:00
ljacqu
c9718ae86c Minor - add tests for NewAPI class 2016-07-25 16:39:49 +02:00
ljacqu
19de5a0525 Close #449 Rename NewSetting class to Settings :) 2016-07-23 15:50:40 +02:00
ljacqu
18a9fbaa26 #449 Migrate remaining non-group legacy Settings 2016-07-23 14:44:52 +02:00
ljacqu
2d10b46df2 Set ConsoleLogger not to use log file after running ConsoleLoggerTest 2016-07-22 22:49:11 +02:00
ljacqu
cf3d84e3c1 Merge "stringWithLength" matcher implementations
- For some reason Hamcrest does not provide a "string with length" matcher -> move our two implementations as one method in AuthMe matchers class
2016-07-22 22:14:10 +02:00
ljacqu
914462fc3f Unit test ConsoleLogger + clean up and unit test RecoverEmailCommand 2016-07-22 22:09:55 +02:00
ljacqu
a8df8ceb09 #605 Add custom log levels, create debug logging method
- Log levels in the log file too
- Create migration from old boolean "stop spam" property to new log level property
2016-07-22 17:45:00 +02:00
Gabriele C
0eb1890cf9 Cleanup 2016-07-22 09:55:22 +02:00
ljacqu
8fcb651ebb Merge branch '784-purgeservice-architecture' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-07-20 21:31:25 +02:00
ljacqu
3487386840 #835 Fix handling of annotations in DrawDependency tool task 2016-07-19 20:04:55 +02:00
ljacqu
d791fcba94 #835 Remove all injector classes from AuthMe, update installer tasks 2016-07-18 21:47:26 +02:00
ljacqu
57f90fe410 #784 Make DataSource#purgeRecords case-insensitive 2016-07-18 21:29:05 +02:00
ljacqu
cf1032d936 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 784-purgeservice-architecture
Conflicts:
	src/test/java/fr/xephi/authme/task/purge/PurgeServiceTest.java
2016-07-18 20:13:43 +02:00
ljacqu
9a534274e5 #835 Fix CommandHandler test class
- DelayedInjectionRunner cannot handle mocking the injector as it runs with an injector in the background
2016-07-18 19:50:19 +02:00
ljacqu
3334e2a160 #835 Implement reloading with external injector 2016-07-18 19:39:55 +02:00
ljacqu
9a91156000 #835 Replace injector classes with ones from ch.jalu.injector project 2016-07-17 21:50:48 +02:00
ljacqu
ca4a64f398 #844 Run PurgeTask as repeating task and #784 write tests for PurgeTask 2016-07-17 21:12:01 +02:00
ljacqu
5953bfd012 #784 Separate purge execution and purge task creation
- Delete accounts in PurgeExecutor, after permission check
2016-07-17 17:33:25 +02:00
ljacqu
2a4cda0709 #784 Perform bypass purge permission check with OfflinePlayer objects
- Move permission check inside PurgeTask to perform it with OfflinePlayer objects instead of lowercase names
- Move purge members into child "purge" package
- Unify online and offline default permission behavior in DefaultPermission
2016-07-17 11:54:22 +02:00
Gabriele C
b439a0391c Add option to apply the protection also to registered users #860 2016-07-16 21:10:29 +02:00
ljacqu
674a051586 #762 Clear all stored sessions if feature gets disabled on reload 2016-07-15 19:47:42 +02:00
ljacqu
3b06524796 #762 Use timestamps for session + #816 Logout should invalidate a player's session 2016-07-15 19:35:35 +02:00
ljacqu
10392d0d65 #856 Handle null Location on PlayerCache object
- Location may null when read from file
2016-07-15 18:49:01 +02:00
ljacqu
160cbc6aa4 #849 Catch exception in TwoFactor hash and write unit tests 2016-07-15 18:23:18 +02:00
ljacqu
dccbd5262f Don't update IP twice
- IP is updated in datasource#updateSession after successful login
- Remove no longer used DataSource#updateIp
2016-07-12 21:45:05 +02:00
ljacqu
8d54557f3d Add tests for PlayerDataStorage and LimboCache 2016-07-11 21:09:15 +02:00
ljacqu
a6d885e0bb Write tests for PlayerDataStorage 2016-07-10 23:00:58 +02:00
ljacqu
8e91636fbd Create tests for LimboCache 2016-07-10 17:15:27 +02:00
ljacqu
491853e0c8 Change github URLs from AuthMe-Team/ to AuthMe/
- Change README sections to use more markdown
2016-07-10 11:42:40 +02:00
ljacqu
aa6fe3e874 Rename method on SettingsDependent
- Rename loadSettings to reload
- Make ProtocolLibService only implement SettingsDependent, not Relaodable alongside
2016-07-09 09:24:25 +02:00
ljacqu
d8f6fb085e Cleanup - remove unused elements in code 2016-07-04 21:53:22 +02:00
ljacqu
2867ebaddd Fix failing test 2016-07-04 20:31:40 +02:00
ljacqu
c040623739 Merge 765-teleport-handling into jsoncache-fix 2016-07-04 18:47:34 +02:00
DNx5
140275f366 - Add restore method in LimboCache
* Apply it to process that have use of it
- Fix fly & walk speed not get restored
2016-07-04 13:21:57 +07:00
ljacqu
7788ad6230 #765 Replace Utils usages with TeleportService + misc householding
- Remove some legacy settings
- Move Utils "addNormal" method to AuthGroupHandler

(Reapplied changes from orphaned fe29089)
2016-07-03 19:55:31 +02:00
DNx5
deffcb3e2b - Renamed JsonCache to PlayerDataStorage
* the methods inside it renamed to fit with class name
  * cache folder changed into playerdata
- Renamed LimboPlayer to PlayerData
- Added fly speed to PlayerData
- Removed player's name from PlayerData object
- Added getPlayerLocationOrSpawn method in spawn loader.
2016-07-03 21:52:46 +07:00
DNx5
7ea0763966 Merge remote-tracking branch 'origin/master' into jsoncache-fix
Conflicts:
	src/main/java/fr/xephi/authme/settings/Settings.java
2016-07-03 19:53:55 +07:00
ljacqu
8f5817883e Testing - check return value of Set#add instead of separately checking Set#contains 2016-07-03 11:47:37 +02:00
ljacqu
3984208548 #797 Make two messages translatable 2016-07-02 21:52:50 +02:00
ljacqu
9a5c432509 #655 Encapsulate mail service
- Change SendMailSSL to be injected into classes and created regardless of settings
- Various minor cleanups (remove accidentally committed test, add more precise logging statement)
2016-07-02 20:56:53 +02:00
ljacqu
22911a0bb9 Remove duplicate column initialization code, add datasource integration tests
- Drop initialization of all columns on table create in favor of checking each column individually. This is slower but guarantees that each column is only defined once in the code. Columns are only created once so having clean code outweighs performance.
- Write more datasource integration tests
2016-07-02 19:16:26 +02:00
ljacqu
0283395da4 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into jsoncache-fix
Conflicts:
	src/main/java/fr/xephi/authme/listener/protocollib/ProtocolLibService.java
2016-07-02 11:01:46 +02:00
ljacqu
70226f7ddb #813 Move test resources to conform to package structure 2016-07-02 10:57:30 +02:00
ljacqu
1f35ccd841 Improve bat helpers / minor changes to logging and todo messages 2016-07-02 10:17:52 +02:00
ljacqu
6585b68749 Fix TeleportationService tests + rename methods
- Fix and supplement unit tests for TeleportationService
- Rename methods as to avoid confusion (login vs. LoginEvent when player joins)
- Add javadoc with note about Player#hasPlayedBefore always being false
2016-06-30 22:38:36 +02:00
DNx5
abf6645620 Fix test 2016-06-29 22:31:10 +07:00
Gabriele C
b1b56f2d51 Cleanup, updated some settings 2016-06-29 15:56:55 +02:00
ljacqu
1361174892 Encapsulate GeoLiteAPI class 2016-06-27 21:32:52 +02:00
Gnat008
1326606f37 #762 - Move all sessions stuff to new SessionManager class 2016-06-27 13:50:16 -04:00
ljacqu
d72d6ddf5a AntiBot - make public field private 2016-06-26 09:25:52 +02:00
ljacqu
6812cfa4db Add utility for safe pattern compiling 2016-06-24 23:50:11 +02:00
ljacqu
e7ba579960 #778 Delayed runner: add support for annotations, add validation
- Add support for dependencies identified by annotations
- Add some more usage validation
- Change a few test classes to use the DelayedInjectionRunner
2016-06-19 22:54:12 +02:00
ljacqu
4b3ab4b116 #769 Create integration test for service initialization in onEnable()
- Test that services can be instantiated (e.g. no circular dependencies)
- Instantiate Messages via injection instead of manually
2016-06-19 21:16:46 +02:00
ljacqu
a0abe3d19d Minor householding
- Remove getter for NewSetting
- Reduce visibility of classes used by DelayedRunner
2016-06-19 16:13:00 +02:00
ljacqu
fb5e7d40c6 Change delayed injection to only change behavior of its own elements
- Introduce new BeforeInjecting annotation to not modify the (expected) order of annotations that do not belong to us
  - Avoids using hacky way of first initializing field to an Answer that will delegate on demand to the proper class...
- Remove PostConstruct support for Mockito's InjectMocks: we should not change the established behavior of external elements
2016-06-18 15:31:11 +02:00
ljacqu
a1c62e7c04 Create delayed injection test runner
- Test runner supporting new "DelayedInjection" annotation: such fields are only initialized with instantiation right before the first time they're used in tests, allowing to set up mock behavior beforehand
2016-06-18 13:19:07 +02:00
ljacqu
cd1acfde1b #674 Create tests for purge commands and purge service 2016-06-18 11:13:17 +02:00
ljacqu
3629c51fc1 #674 PurgeService: Always register if purging, reduce code duplication
- Rename autoPurging to isPurging: we should always register if a purge task is in progress (regardless if autopurge or not) and deny any new requests
- Reduce the same logic being coded multiple times by calling through the methods
- DataSource: remove purgeBanned in favor of purgeRecords, both do exactly the same thing
2016-06-16 22:52:11 +02:00
ljacqu
acd4a772e8 Minor householding in tests
- Add missing test for injector
- Remove redundant Mock fields
2016-06-15 21:24:57 +02:00
ljacqu
ac484345a2 Change password task to async process
- Perform async change password task just like other async processes: via Management
- Remove legacy setting
- Remove now unused service getter (#736)
2016-06-15 20:56:34 +02:00
ljacqu
15886fb517 #723 Let LimboPlayer task manager decide which message key to use
- Pass boolean (is registered) value and determine internally which message key (email registration vs. regular) to use in the message task
2016-06-15 20:37:00 +02:00
ljacqu
5cbb83e153 Code householding, add tests to TempbanManager
- Delegate event firing to BukkitService
- Write tests for IP banning function
- Update comments on tempban properties in config.yml
2016-06-14 21:52:43 +02:00
ljacqu
3411450ff1 #760 Fix single session feature
- Move the check from PlayerLoginEvent to AsyncPlayerPreLoginEvent. Single session can only be implemented with PreLoginEvent; it is already to late to check this in the PlayerLoginEvent. Ergo, we cannot offer this for CraftBukkit.
- Remove interactions with LimboCache - no interactions with LimboCache expected until after OnJoinVerification checks. (Thanks sgdc3!)
2016-06-14 21:03:32 +02:00
EbonJaguar
367f785610 count login failures by ip address and not by name 2016-06-13 15:58:03 -04:00
ljacqu
98bbf51594 Update dependency graph 2016-06-12 22:31:11 +02:00
ljacqu
89bbfc48ee #723 Create provider for TimeoutTask and MessageTask, remove LimboCache#getInstance
- Create class to handle the creation of "LimboPlayer tasks" (adds encapsulation, reduces duplication)
- Move group setting into its own class because (mutual dependency between LimboCache and PermissionsManager otherwise)
2016-06-12 22:00:05 +02:00
Gnat008
67c72dc46d fix TempbanManager injecting 2016-06-12 15:17:37 -04:00
ljacqu
69100daba5 Get jar files via URI objects in tests to prevent issue with spaces 2016-06-12 20:54:39 +02:00
Gnat008
ac4add9f54 add ability to tempban users after x wrong logins - ref #520 #192 2016-06-12 13:40:34 -04:00
ljacqu
d6e1fd5ceb Use injection in and for LimboCache, migrate some legacy settings, remove setGroup from Utils
- New injector method allows to retrieve services if they've already been instantiated -> useful for onDisable() which might be run after aborted initialization
- Deprecate various methods that need to be removed
2016-06-12 16:14:34 +02:00
ljacqu
5ef62784b5 #729 Use world from LimboPlayer for "spawn after login" feat., simplify teleport event constructors 2016-06-12 14:10:38 +02:00
ljacqu
68d5145cd7 #729 Refactor spawn handling into separate service (work in progress) 2016-06-12 12:46:03 +02:00
ljacqu
4d75542594 Remove unused fields instead of suppressing warnings 2016-06-11 19:05:10 +02:00
Gabriele C
01f297919d 1.10 API + cleanup 2016-06-11 17:46:24 +02:00
ljacqu
2e269b6f5e Add missing unit tests for commands 2016-06-05 13:21:05 +02:00
ljacqu
3753a0ef96 #565 Allow to skip extended encryption methods
- Set system property via surefire plugin and create profile that modifies the property
- Check for the new property in AbstractEncryptionMethodTest and shorten/skip the tests when necessary
2016-06-05 00:29:31 +02:00
ljacqu
4fe26f08d4 #612 Check if plugin is permission system within method itself
- Iterate over all values within the method
- Bug fix: change method to use pluginName field, and not name
2016-06-04 22:40:30 +02:00
ljacqu
26ac466035 #727 Instantiate ExecutableCommand objects in CommandHandler
- Change CommandDescription to contain a reference to ExecutableCommand class only
- Instantiate the actual ExecutableCommand objects in CommandHandler
2016-06-04 21:13:38 +02:00
ljacqu
c6778b566d #727 Remove CommandService from ExecutableCommand interface
(work in progress)
- Inject CommandService like other classes instead of passing it as method parameter
- Not solved: cyclic dependency CommandInitializer > ExecutableCommand > CommandService > CommandInitializer...
2016-06-04 11:02:15 +02:00
ljacqu
12703d1613 #601 Integrate plugin manager
- Encapsulate captcha functionality into a class instead of two public fields on the AuthMe main class(!)
   - Let CaptchaManager worry about whether it is enabled or not -> no need to check on the outside
- Implement full reloading support to enable/disable captchas + parameters
- Add unit tests
2016-06-03 22:47:17 +02:00
ljacqu
1f2a823f99 Add tests for PluginHooks - Multiverse interactions 2016-06-03 13:36:33 +02:00
ljacqu
55f7e8097a #743 Add proper error message for "invalid chars in password"
- Change password validation to return a ValidationResult object for passing message arguments
- Remove wrapping methods in ProcessService and CommandService and use ValidationService directly
2016-06-03 12:51:49 +02:00
Gabriele C
eafb3b6653 cleanup 2016-06-03 00:07:25 +02:00
ljacqu
6d2597a980 #739 Fix command unit tests; adjust default handling
(cherry picked from commit 61c119b)
2016-06-02 23:12:01 +02:00
Gnat008
73272b5931 Remove all but one hasPermission() method in the PermissionsManager
#739 (cherry picked from commit 65f3347)
2016-06-02 23:11:47 +02:00
ljacqu
9b5009eb8c #742 Create test that plugin.yml corresponds to command definitions
- Create test
- Fix definitions to correspond
2016-06-02 15:49:21 +02:00
ljacqu
e75cff5fb8 Remove static injections in ListenerService
- Get other classes via Inject annotation
- Remove no longer needed Utils methods (relates to #736)
- Create tests for ListenerService and AuthMeBlockListener
- Performance improvement: keep unrestricted names as Set instead of List for faster contains() method
2016-06-02 12:46:54 +02:00
ljacqu
408e8dd0dd #739 Create unit tests for PermissionsManager#hasPermission 2016-06-02 00:03:02 +02:00
ljacqu
0977558924 #736 Remove use of service getters and deprecate them 2016-05-31 11:14:03 +02:00
ljacqu
3b6677ce99 Merge branch '604-default-permissions-on-nodes' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-05-31 09:15:36 +02:00
ljacqu
30b72bec4c #604 Fix HelpProvider tests 2016-05-30 23:49:59 +02:00
EbonJaguar
3ad00a45f9 Move default permissions out of Commands and into PermissionNode - fixes #606 2016-05-30 16:47:48 -04:00
ljacqu
f5b4071abf Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into playerjoin-listener-cleanup 2016-05-30 17:53:42 +02:00
Gabriele C
8a0655e333 Merge pull request #134 from Gnat008/602-create-lowercase-string-list-propertytype
Add a lowercase String list property - fixes #602
2016-05-30 17:53:14 +02:00
EbonJaguar
f94f4643cf Add a lowercase String list property - fixes #602 2016-05-30 11:08:01 -04:00
ljacqu
9b1ee86b2f Trivial code householding
- Replace `if (!x) ... else ...` with `if(x) ... else ...`
- Avoid throwing RuntimeException; use children
2016-05-30 12:18:55 +02:00
Gabriele C
52c0c7dd64 playerlistener cleanup 2016-05-29 16:34:03 +02:00