Commit Graph

331 Commits

Author SHA1 Message Date
BONNe
e3e3191e6c Fix a bug with challenge deletion.
If challenge has been left in a level, then system did not remove challenge from it and was kept as ghost challenge, preventing from completing level.
2019-11-03 22:45:24 +02:00
tastybento
9d45f08fb1 Test coverage (#199)
* Test coverage for Challenges Command

* Added CompleteChallengeCommand test class

* Added Utils test class

* Added ChallengesGUI test class

* Fix code smells from sonarcloud analysis

* Added .gitignore

* Added Travis CI config file

* WIP ChallengesManager Test class

* Added ChallengesManager test class

* Removed debug

* Removed code smells.

* Added ChallengesAddon test class.

* Added onDisbale test

* Added new TryToComplete test class - WIP

Covers inventory challenges.

* Added Island Challenge entity tests to TryToComplete test class
2019-10-30 08:44:26 +02:00
tastybento
2aa437f071 English update (#193)
* Organized imports

* Minor code cleanup

* Updated English locale file.
2019-10-10 08:35:25 +03:00
BONNe
0c47f811dc Fix issue when users could not select non-block items as icons for challenges and levels. (#190) 2019-09-28 20:09:21 +03:00
BONNe
c74fa42770 Change challenges addon status to incompatible, if it tries to run with YAML 2019-09-09 01:02:34 +03:00
BONNe
902a1993a2 Add UTF-8 CharSet for file writer to avoid issues with incorrect char saving. 2019-09-08 20:33:19 +03:00
BONNe
449890def5 Drop Depricated 1.13 SIGN object.
Update to 1.7 BentoBox.
2019-09-08 20:15:30 +03:00
BONNe
4e6d37cd90 Rework Challenge Object Data storing.
Requires MIGRATION if upgrade from older version.
2019-09-08 20:03:46 +03:00
BONNe
09036a28f0 Fix typos. 2019-09-06 18:45:55 +03:00
BONNe
3501db7002 Work on fixing some crashes related to incorrect data.
Optimize some lambda functions.
Add method that validates challenge's levels. If level does not exits in database, then challenge's level is set to FREE.
Fix crash with migration: Free challenges level does not require migration.

This relates to issue #181
2019-09-06 00:14:06 +03:00
BONNe
643c5e8f7c Add an option to hide undeployed challenges from challenge list (#175)
Added new config option "gui-settings.undeployed-view-mode" with 3 values
- 'VISIBLE' - all challenges are visible
- 'HIDDEN' - only deployed challenges are visible
- 'TOGGLEABLE' - users will be able to choose option for themself (not implemented)

Implement functionality in ChallengesGUI, where if option hidden is set, then all undeployed challenges are removed.
Implement ability to edit this option via admin Settings panel.
2019-09-05 15:52:14 +03:00
BONNe
e5ec5d5825 Apply new Utils methods in EditChallengesGUI 2019-09-05 13:24:03 +03:00
BONNe
e900f1e665 Add generic methods that allows to get next or previous elements in given array. 2019-09-05 13:23:19 +03:00
BONNe
28d61870a7 Fix issue when complete wipe did not work, even when selected. 2019-09-05 13:10:02 +03:00
BONNe
a5022bea7a Improve Wipe Button behaviour.
Add 2 new buttons:
- User wipe - deletes all challenges addon player data.
- challenges wipe - deletes only challenges and levels.

By clicking on challenges wipe with right click, it will switch to compelte wipe, and via versa.
2019-09-05 12:19:05 +03:00
BONNe1704
ecbb8ef1f2 Merge branch 'develop' of https://github.com/BentoBoxWorld/addon-challenges into develop 2019-09-05 12:01:41 +03:00
BONNe
ae614a13d4 Merge remote-tracking branch 'origin/develop' into develop 2019-09-05 09:37:05 +03:00
BONNe
5f1ea920f5 Add download button in Challenges Libraries panel.
Disable access to Library panel if github api is disabled.
2019-09-05 09:36:53 +03:00
NotMyFault
68e09d6946 Fix typos and make challenge descriptions looking a bit nicer (#177) 2019-09-04 18:21:39 +03:00
BONNe
fd4a19bcb1 Add 1.14 mob types to HeadLib. 2019-09-04 09:49:58 +03:00
BONNe
40e34e7999 Add better challenge sorting in AdminGUI's
Now challenges will be sorted by their level order number, their order number, their unique id. All free challenges will always be at the start.
2019-09-04 09:30:11 +03:00
BONNe
e854bbd294 Fix issue when Lore GUI buttons were not colored and splitted. 2019-09-03 11:14:26 +03:00
BONNe
c7fe138d78 Add GUI for editing Challenge and Challenge Level lore messages.
Rework Lore message construction.
2019-09-03 09:03:21 +03:00
BONNe
747c12f1a6 Remove all references to GitHubWebAPI4Java and use lambda instead. 2019-09-02 19:24:30 +03:00
BONNe1704
f611727d4e Implement WebManager that will download Challenges Libraries from GitHub.
Implement GUI for selecting and downloading Challenges Libraries.
2019-09-02 17:56:24 +03:00
BONNe
29a77147b5 Fix issue when each save added unnecessary "|" at the end of rewards and unlock message. (#123)
Algorithm that I used to join output list into single string, always added "|" at the end. Last "|" should be removed.
2019-09-02 13:20:59 +03:00
BONNe
707625a9da Fix the issue with incorrect unlock status. (#169)
The issue was that it never decrease challengesToDo with completed challenges from previous level, so only first level was unlocked. My mistake.
2019-09-02 09:05:18 +03:00
BONNe
0026cb7404 Separate all enums from Settings class into SettingsUtils. 2019-09-01 15:17:34 +03:00
BuildTools
235da81ba0 Move Settings class to separate package. 2019-09-01 15:10:05 +03:00
BONNe1704
fe3a18c459 Fix copy-paste issue that prevent from completing ISLAND type challenges. 2019-08-30 17:15:36 +03:00
BuildTools
f4f18c85f3 Merge remote-tracking branch 'origin/develop' into develop 2019-08-29 00:07:20 +03:00
BONNe
592a4c7310 Fix server crash when COOP player tried to complete ISLAND type challenge (#174).
The issue was that I used wrong command to check island owner. It is fixed.
Also added 2 protective code, that prevents from trying to select large areas for block searching.
2019-08-29 00:07:08 +03:00
BONNe1704
6d8b1cb761 Fix some issues in default challenges.
- remove parallel stream reading, as it may not load all challenges/levels.
- fix chef challenge not detected by level.
- fix some typos.
2019-08-28 17:21:39 +03:00
BONNe1704
8e0448eac7 Reintroduce Multiple Completions
Add [gamemode].complete.multiple permission that will allow/prevent to complete challenge multiple times at once.
Introduce new MultipleGUI that opens GUI with 5 buttons that allows to choose how many times challenge should be completed.
2019-08-28 16:55:18 +03:00
BONNe
9d7a5db290 Fix issue when multiple completions were not saved correctly. 2019-08-28 11:50:16 +03:00
BuildTools
12dd740959 Merge remote-tracking branch 'origin/develop' into develop 2019-08-26 09:09:10 +03:00
BuildTools
ac79fa5d56 Completely drop ability to import ASkyBlock challenges.
This option was not working properly and were used wrongly. To avoid that, importing challenges and player data will be handled by converter.
2019-08-26 09:08:56 +03:00
NotMyFault
36255d07a2 Fixing various typos (#172) 2019-08-26 07:55:22 +03:00
BuildTools
7fce1a1fd4 Fix compilation error. 2019-08-25 23:09:44 +03:00
BuildTools
c516d53907 Update to v1.6.0 version.
Remove AnvilGUI, as it is broken. Replaced with Spigot Conversation API.
Remove lore-config from GUI (broken).
Remove RIGHT_CLICK to complete multiple times (broken).
2019-08-25 22:43:15 +03:00
BuildTools
b6e2133782 Fix issue with non-migrated levels.
#168
2019-08-25 00:07:44 +03:00
BuildTools
15f4c8abd4 Fix error in Challenge Level description.
Copy-paste error, instead of experience, it returned waiver-amount.
Reported in discord.
2019-08-19 00:37:26 +03:00
BuildTools
54f91180d6 Fix issue in importing challenges from ASkyBlock when importing crashes with null-pointer.
Null-pointer happened because there were mistake in level unique_id getting. It was leftover from old unique_id scheme...
2019-08-14 22:00:11 +03:00
BuildTools
6f357b3197 Update code to new API.
Replace PremadeEvent with BentoBoxEvent.
2019-08-13 22:49:37 +03:00
BONNe
dea71358ae
Update Utils.java
Avoid null-pointer issue if given item-list contains null elements.
The issue is still that list contains these elements.
2019-08-11 18:12:56 +03:00
tastybento
a50d00b2e7 Fixes JavaDoc warnings. (#164)
@inheritDoc cannot be used on Constructors.

Fixed some other warnings.
2019-08-05 13:00:03 +03:00
BONNe1704
76fb30be36 Add ability to migrate challenges from 0.5.0 - 0.7.5 data storage mode to new 0.8.0 format.
Part of implementing #105
2019-08-02 12:22:52 +03:00
BONNe1704
3985efa4d0 Fix issue when uniqueID changes did not work for imported challenges. 2019-08-01 15:06:06 +03:00
BONNe1704
e9f9b1b8d5 Rework how challenges are stored.
This is old change that was declined (#105), but unfortunately it is necessary.
If every ID is based on world names, than addon cannot process "/" in it. It mean that worlds cannot be put into different folders.
This change will fix it, but it is not completed.

In progress.
There does not exist converter, so old data is not usable with this version.
2019-08-01 13:19:15 +03:00
tastybento
9800da5973 Fixed permissions check to remove dot 2019-07-31 23:21:52 -07:00
BONNe1704
4f35f69960 Fix tabComplete method. 2019-07-24 14:34:33 +03:00
BONNe1704
9681494c1c Fix issue with wrongly applied world name lowercasing.
It looks like, exist plugins that keep capital letters in world names. That mean, it is not correct to lowercasing any id's.
To fix it, now, instead of lowercasing, challenges should be case insensitive.
2019-07-24 13:43:29 +03:00
BONNe
cfad9150c7
Increase max value to order number
Previous 54 was a limitation of slot count. Remove it as it is redundant.
#146
2019-07-08 20:30:34 +03:00
BONNe1704
cd85a929d0 Fix issue when custom generated default challenges were overwritten and deleted. 2019-07-08 09:36:28 +03:00
BONNe
5e0f0510d9 Add admin reset command, that allows to reset player challenges (#141)
Fix some bugs in complete command that did not display challenge list.
Add new lang parameters in en-US and lv-LV.
2019-06-23 16:51:49 +03:00
BONNe
d4bcc1ee19 Fix admin message about setting up database objects. 2019-06-23 12:42:01 +03:00
BuildTools
b2f2c4a0bb Fix issue with corrupted world names after upgrading from 1.13 to 1.14. 2019-06-20 08:11:38 +03:00
BONNe
4527216dc2 Add ability for admins to complete challenge without gui. (#136) 2019-06-16 21:21:25 +03:00
BONNe
ca5ff504f0 Add protection code in TryToComplete task, to avoid negative numbers in max completion times. 2019-06-16 20:46:12 +03:00
BONNe
4e2181f524 Add ability to complete challenge multiple times at once via command. 2019-06-16 20:43:07 +03:00
BONNe
526fe9ce81 Update flag Registering to newest addon API. 2019-06-16 20:25:02 +03:00
BONNe
071c6ca83a Improve item description management. 2019-06-16 20:22:42 +03:00
BONNe
68a26e4d28 Fix unstackable reward item displaying (#135) 2019-06-16 15:59:41 +03:00
BONNe
a7f9e01d61 Fix issue when unstackable items flood challenge description (#135) 2019-06-16 15:57:05 +03:00
BONNe
1a70ee3ad8 Fix issue with Entity and Block selecting GUIs.
Items were not selected unless player use right click. Not it will work correctly.
2019-06-16 11:43:05 +03:00
BONNe
fc4f3ca0b6 Add AutoSaver task for Challenges Addon.
Remove WorldSave event listener.
2019-06-12 22:56:52 +03:00
BONNe1704
94c3fd9fa4 Add Complete Wipe button in AdminGUI that allows to remove all Challenges Addon data from database.
This request comes from Discord.

It also mention to format DiskDrive to avoid ability to restore database, but it is not implemented yet. Will be implemented in future releases.
2019-06-05 12:30:48 +03:00
BONNe
a9abe32dbe Add a lot null-pointer checks and console errors about loading null-value element from database. 2019-06-03 23:14:12 +03:00
BONNe
330034ea8e Add SIGN_MATERIAL constant in ChallengesAddon which value depends on Minecraft version.
This will allow to drop down 1.14 branch.
2019-05-20 08:28:35 +03:00
BONNe
7e04f592ad Add custom admin message that informs about non-existing challenges in current world. 2019-05-19 13:29:02 +03:00
BONNe
c3f93fd797 Implement ability to select multiple Entities and Blocks in SelectBlockGUI and SelectEntityGUI. (#121)
Fix issue with unsplitted text in ManageBlocksGUI and ManageEntitiesGUI. (#121)
2019-05-18 00:01:03 +03:00
BONNe1704
413429a091 Merge remote-tracking branch 'origin/develop' into develop 2019-05-16 10:30:46 +03:00
BONNe1704
9704ed32aa Fix issue when IslandTypeChallenges required blocks were cleared if completion was uncessesfull.
The issue was that it cleared wrong map. It must clear priority queue, but cleared required elements.
2019-05-16 10:30:01 +03:00
BONNe
3521495739 Fix issue when entities has not been removed on challenge completion (#118).
I forgot to populate entity queue :(
2019-05-14 09:55:34 +03:00
BONNe
9f8bf03708 Fix wrongly display message for required money in edit challenge gui (#119)
It showed required level instead of required money in element description.
2019-05-14 09:20:17 +03:00
BONNe1704
34ed09e768 Change json adapter factory to BentoBoxTypeAdapterFactory class. 2019-05-09 16:45:53 +03:00
tastybento
a25796613f Changes to fit new API for database transition. (#114)
Config files must implement the ConfigObject interface now instead of
DataObject. They no longer need to specify uniqueId.
2019-05-09 16:24:01 +03:00
BONNe1704
6c10fcdca9 Fix NPE when opening ChallengesGUI (#116).
Add code that removes challenges level from all its challenges, if level is deleted.
Add protection code that shows admins that something is not correct if challenge level is not in database.
2019-05-09 11:22:01 +03:00
BONNe
c8088f275d
Rework TryToComplete. (#109)
* Rework TryToComplete.

Implement ability to complete challenge multiple times at once.
To do it, I split everything in checking/removing/rewarding steps.

In checking step, it calculates if it is possible to complete with minimal requirements and then calculates maximal repeating factor.
In removing step, it removes everything that is necessary.
In rewarding step, it give rewards by necessary factor (multilayer).

I rework item/block/entity removing as factors may be influenced at the last element, so I improve everything by memory usage. Create necessary sets/lists/queues for faster access to already collected items.

* Add method that returns removed items, if somehow algorithm did not manage to remove all items.
Fix issue when removeItems method did not merge ItemStacks as they had different item amount.

Return and fix TryToCompleteTest.

* Implement Multiple Challenge Completion command and GUI. (#73)

/[gamemode] challenges complete [number] allows to complete challenges [number] amount (or less if not enough items)
Via GUI users can right click on challenge and if it is repeatable, then it will open AnvilGUI that accepts only numbers as input.
2019-05-06 12:10:02 +03:00
BONNe
d9486bbbdb Fix issue when Import Default Challenges Button did not work 2019-05-05 23:54:35 +03:00
BONNe
f18c8d0dff Remove NBT editing via NMS.
Use Dummy Mojang profiles with custom skulls, instead of editing NBT with NMS.
This will work on all versions instead of just with correct NMS hacks.
2019-05-05 17:10:10 +03:00
BONNe
d60f20e394 Fix issue when Color codes did not work in opened Panels and Titles (#110)
These text element colors were not translated correctly.
Now it should work.
2019-05-04 11:16:41 +03:00
BONNe
c702dd492b Implement Challenge Complete method. (#15)
Method currently will be available only via /[gamemode] challenges complete <challenge_id>.
2019-05-02 00:31:36 +03:00
BONNe
a2f0765de1 Add proper message when user opens challenges gui in world without a challenges. 2019-05-01 23:18:12 +03:00
BONNe
ca5cfcc841 Add button in Challenges admin GUI that allows to import default challenges. 2019-05-01 23:14:41 +03:00
BONNe
b24f7ebcb0 Implement title messages on first challenge/level completion (#108).
Add settings option that can enable/disable title message and its length.
Add ability to edit these settings via admin GUI.
Add ability to use some variables in title and subtitle in translation files.
2019-05-01 22:57:24 +03:00
BONNe
f0b156de31 Improve addon reload method.
Now it will call also manager.reload() that clears cache and resets database links.
Improve ReloadCommand. Now it will be able to reload both ways (soft way that clears only cache, and hard way that reassigns database connection) with reload command.
2019-05-01 17:10:05 +03:00
BONNe
93da0c714c Implement ability to import/generate default.json file.
Remove old unnecessary methods.

Improve default.json challenges.
2019-05-01 12:46:54 +03:00
BONNe
0418e64125 Improve cache management.
Do not load players in memory, and unload them when they leave.
2019-04-27 00:13:02 +03:00
BONNe
ae384c433d Fix crashing build. 2019-04-26 23:45:34 +03:00
BONNe
c05015716f Enable Level and Money editing, even when required addons or plugins are not provided. 2019-04-26 21:27:52 +03:00
BONNe
a41859459f Implement ability to change text via Chat instead of AnvilGUI (#97).
It was necessary as Anvil has limited char input, while chat is almost unlimited.
2019-04-26 21:20:36 +03:00
BONNe
507c68d683 Add ability to edit string messages from StringListGUI via Chat. 2019-04-26 20:59:52 +03:00
BONNe
ec099cee9c Improve default challenge loading and creating.
Remove world name from challenge and challenge level ids when default file is created.
Reassign correct world name to unique id when challenges and levels are loaded.
2019-04-26 11:18:57 +03:00
BONNe1704
017147ff3f Improve and simplify default challenge data storing. 2019-04-25 18:21:10 +03:00
BONNe1704
188e86d546 Small code cleanup. 2019-04-25 11:42:04 +03:00
BONNe
5a5d2d7782 Create method that will generate default.json file from existing challenges in memory and from given world. 2019-04-25 00:48:29 +03:00
BONNe
0e89f1216d Make clone to public method. 2019-04-25 00:39:21 +03:00
BONNe
e6f151ef89 Implement clone methods for Challenge and ChallengeLevel objects. 2019-04-25 00:08:13 +03:00
BONNe
4b233e2246 Start to implement default challenge loading.
Work in progress.
2019-04-24 07:45:05 +03:00