Commit Graph

919 Commits

Author SHA1 Message Date
ljacqu
987e38c5df Add test for LoginCommand; create AuthMe mock test util
Had to create a getter for the Management instance in the AuthMe class for mocking, but fields should generally not be accessed globally. Hopefully soon we will be able to make the field private.
(cherry picked from commit f1a0022)
2015-11-21 12:07:00 +01:00
ljacqu
3934d67330 Command refactor - remove unused fields, reduce variable "scope"
Minor refactorings in the command section for familiarization.

1. Removed suppressWarning("Deprecated") - the method is deprecated for a reason and we should be made aware of that.
2. Removed same javadoc on ExecutableCommand implementation that just had the same as the interface (this is just clutter; @Override signals that it's an implementing class and a developer can view the superclass javadoc)
3. In places where the AuthMe instance was retrieved at the top but used at the very bottom, moved it to the bottom to reduce its "scope"
(cherry picked from commit 45a50f3)
2015-11-21 12:06:49 +01:00
ljacqu
9a68aa5517 Proper Javadoc example / add test for StringUtils
- Proper example for the purpose of javadoc and how it could look like
- Fix containsAny to be null safe
- Add tests
2015-11-21 08:28:53 +01:00
ljacqu
38cc217cff Revert certain JavaDoc changes
Ideally JavaDoc should provide additional information to the developer
as to the method's purpose and usage. Typically you do not add the
return type of the method and the parameter's types since this can be
seen in the code.

A short description of what the parameter really is (e.g. a String can
hold many types of information) is a lot more beneficial. A JavaDoc
statement simply restating the parameter types and the method name is,
put bluntly, simply noise, since all of these things are already
contained in the code itself.

Similarly, @see references are great for pointing to other, related
methods but aren't very helpful to point to a superclass method (the
implemented or overriden method) since it is implied by @Override. A
developer can navigate easily to the superclass method with any
reasonable IDE.
2015-11-21 07:41:56 +01:00
Tim Visée
504106f835 Added base of setGroup method in permissions manager 2015-11-21 03:01:45 +01:00
Tim Visée
06d6bd4a7e Fixed formatting in PermissionsManager class 2015-11-21 02:43:32 +01:00
Tim Visée
5ff9b7550e Combined Plugin and Server listener, removed plugin listener 2015-11-21 02:33:59 +01:00
Gabriele C
bd1f868c6d standard javadoc 2015-11-21 01:31:18 +01:00
Gabriele C
118c79401a Prepare the project for javadocs 2015-11-21 01:27:06 +01:00
Gabriele C
adcd70b91d auto cleanup 2015-11-21 01:15:52 +01:00
Gabriele C
ada992785c login process cleanup 2015-11-21 00:36:46 +01:00
Gabriele C
68ae6ee701 remove useless inventory store event 2015-11-20 23:59:25 +01:00
Gabriele C
d6355adb51 cleanup 2015-11-20 23:52:20 +01:00
Gabriele C
ba483af807 fix project layout 2015-11-20 23:43:26 +01:00
ljacqu
84de22c9c0 Refactor Log4JFilter and improve branch coverage 2015-11-20 23:17:50 +01:00
Tim Visée
4978f195f8 Use different logger in permissions manager 2015-11-20 20:50:45 +01:00
Tim Visée
a4b2306e16 Added some comments to legacy permissions methods 2015-11-20 20:23:52 +01:00
Tim Visée
3500ee6fb7 Replaced code that used legacy deprecated permissions methods 2015-11-20 20:23:03 +01:00
Tim Visée
33ca2691b2 Updated deprecated information for legacy permission methods 2015-11-20 20:16:02 +01:00
Tim Visée
8ba126b681 Updated permissions checking system in command handler 2015-11-20 20:13:23 +01:00
Tim Visée
10b69403fc Deprecated legacy permissions methods 2015-11-20 20:11:46 +01:00
Tim Visée
ffd36ba325 Updated authmePermissable methods in main class 2015-11-20 20:08:02 +01:00
Tim Visée
eae6eb384f Updated soft depends 2015-11-20 20:04:59 +01:00
Tim Visée
5e7e7a14fd Added comment to permissions manager 2015-11-20 20:03:44 +01:00
Tim Visée
71e24fe80a Improved permissions manager 2015-11-20 20:01:43 +01:00
Tim Visée
82e65250b8 Added permissions manager to main class, along with a setup and get method 2015-11-20 20:01:31 +01:00
Tim Visée
f17f1fe5fb Fixed plugin listener 2015-11-20 19:56:06 +01:00
Tim Visée
5df1dc2dfb Created plugin listener 2015-11-20 19:55:19 +01:00
Tim Visée
66365d6cf9 Removed unused code 2015-11-20 19:53:00 +01:00
Tim Visée
e3c4655b19 Added new permissions manager class, based on DungeonMaze's one 2015-11-20 19:43:10 +01:00
DNx5
9a79332933 add getPlayer method into Utils class 2015-11-17 09:32:33 +07:00
DNx5
3e1c7edb2d reorder isAuthAvailable call 2015-11-17 08:47:14 +07:00
DNx5
6bc5bb3cb1 optimize some code. 2015-11-17 06:54:24 +07:00
DNx5
f6c6a7c6d4 update and cleanup PlayerAuth 2015-11-17 05:04:34 +07:00
Xephi
4a49809ff2 Change to is Empty 2015-11-16 18:52:54 +01:00
DNx5
6f1af92a58 remove speed already done in join process 2015-11-15 04:49:03 +07:00
DNx5
1af937651c fix geoip lagging if server cant download the file. 2015-11-15 04:24:36 +07:00
Xephi59
3b802d03b1 Add non html content 2015-11-11 01:50:23 +01:00
Xephi59
46d39c7864 Fix attachment 2015-11-11 01:49:15 +01:00
Xephi59
10606a22e6 Change default mail api to apache one 2015-11-11 01:28:04 +01:00
Gabriele C
8a4f2c5ef8 I love to clean code and stuff 2015-11-10 19:28:17 +01:00
Gabriele C
2c45cece00 fix plugin name
(i'm an idiot -_-)
2015-11-10 18:43:24 +01:00
Gabriele C
7f4db3a85b cleanup 2015-11-10 18:38:01 +01:00
Xephi59
b959ea18c9 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded.git 2015-11-08 19:31:52 +01:00
Xephi59
6bff45f0ed Fix Mail Recovery 2015-11-08 19:31:44 +01:00
Gabriele C
1c2cc959cc cleanup 2015-11-08 14:51:55 +01:00
Xephi59
54c56461f1 Add 'l' alias to /login command 2015-11-08 14:50:04 +01:00
Xephi59
e1d1ebfca5 Move to old getPlayer method that always work and let us be more
compatible
2015-11-08 14:18:51 +01:00
Gabriele C
d4498521c3 Remove useless hikari sqlite mode 2015-11-08 01:35:13 +01:00
Gabriele C
ddda62aa14 cleaup 2015-11-07 00:13:29 +01:00
Xephi
6f56e865b7 We hope if player is authenticated, he is registered :') 2015-11-04 09:09:19 +01:00
Xephi
c16b80a2bf We don't need a final statement 2015-11-04 09:02:20 +01:00
Xephi59
f4d8e45733 Check for a null destination 2015-11-03 23:40:23 +01:00
Xephi
21ea54d604 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded.git 2015-11-03 15:23:14 +01:00
Xephi
76fa631184 Disable Hikari Cache definitively 2015-11-03 15:23:02 +01:00
DNx5
375162ab67 update email commands to use new async process 2015-11-03 14:41:05 +07:00
DNx5
4eb94787ac implement async change email into management class. 2015-11-03 14:22:32 +07:00
DNx5
f6a91085bd added async change email process 2015-11-03 14:16:57 +07:00
DNx5
4cbd8aad31 update ConsoleLogger 2015-11-03 14:08:51 +07:00
DNx5
e3166c6807 update management class 2015-11-03 12:52:07 +07:00
DNx5
ce432aa25a add exception to datasource method signature. 2015-11-03 12:38:24 +07:00
DNx5
1562cb7615 missed return statement. 2015-11-03 10:54:26 +07:00
DNx5
d73ac92ba3 sqlite max connection update. 2015-11-03 07:59:42 +07:00
DNx5
56aca7f473 this is enough. 2015-11-03 07:37:00 +07:00
DNx5
3ede8f0dae let bukkit load the chunk 2015-11-03 03:56:20 +07:00
DNx5
872856e729 create teleportTospawn method in Utils class 2015-11-03 03:42:02 +07:00
Tim Visée
6d46827936 Removed unused TODO 2015-11-02 20:20:59 +01:00
DNx5
6cc0cd62f5 move set join message outside task. 2015-11-03 02:01:24 +07:00
DNx5
f90104ca2d update player move event listener. 2015-11-03 01:53:01 +07:00
Tim Visée
9bcc210428 Updated developer in version command according to team.txt 2015-11-02 13:22:43 +01:00
Xephi
4fd8d6e0cd Don't use SuppressWarnings please :3 2015-11-02 10:25:53 +01:00
vanhec_a
2cd7bc8512 Check a boolean is a quickest way than check database :) 2015-11-02 10:16:01 +01:00
Gabriele C
5e7c5560cf Cleanup2: The Revenge 2015-11-02 00:09:40 +01:00
DNx5
da9cfc93d3 cleanup command pre process 2015-11-02 05:54:30 +07:00
Gabriele C
e60a5190f9 Fix conflict
Conflicts:
	src/main/java/fr/xephi/authme/AuthMe.java
2015-11-01 23:37:12 +01:00
Gabriele C
175da3f6fc Cleanup! 2015-11-01 23:35:10 +01:00
Gabriele C
3fc2bcde6d Merge pull request #61 from timvisee/master
Moved Utils class to util package
2015-11-01 23:31:26 +01:00
Tim Visée
3643afdea3 Moved Utils class to util package 2015-11-01 23:29:47 +01:00
Gabriele C
43327e9892 Merge pull request #60 from timvisee/master
Added intelligent command manager and help system
2015-11-01 23:24:53 +01:00
Tim Visée
0fbeefc488 Reverted javax mail implementation 2015-11-01 23:16:09 +01:00
Gabriele C
d401ad1dab I'm so stupid 2015-11-01 22:43:48 +01:00
Gabriele C
d69651026d Fix head rotation 2015-11-01 22:41:26 +01:00
Tim Visée
67a40a6fd0 Print a stack trace on STMP error 2015-11-01 22:38:27 +01:00
Tim Visée
6089d481a9 Collapsed catch block 2015-11-01 22:38:07 +01:00
Tim Visée
aae78fe9ef Fixed grammar 2015-11-01 22:37:48 +01:00
Tim Visée
5a6f6751a7 Changed r command to register 2015-11-01 22:27:31 +01:00
Tim Visée
386b80babc Moved a command configuration 2015-11-01 22:14:10 +01:00
Tim Visée
efeef0e1e9 Fixed default permissions 2015-11-01 22:12:09 +01:00
Tim Visée
a187bd61ca Removed unused import 2015-11-01 22:06:59 +01:00
Tim Visée
39c35fd342 Fixed invalid command references 2015-11-01 22:06:50 +01:00
Tim Visée
40fc2c893d Fixed captcha command dependency initializing too early 2015-11-01 21:49:47 +01:00
Tim Visée
ffd6d8e525 Fixed invalid command references 2015-11-01 21:46:13 +01:00
Tim Visée
dc0129d980 Implemented convert command 2015-11-01 21:44:13 +01:00
Tim Visée
bd6a95c3a8 Implemented the captcha command, fixed permissions for email commands
Implemented the captcha command.
Fixed missing permission configurations for all email commands.
2015-11-01 21:36:56 +01:00
Tim Visée
3e16866b23 Implemented the email recover command 2015-11-01 21:28:17 +01:00
Tim Visée
b10d3d3974 Implemented the email change command 2015-11-01 21:26:00 +01:00
Tim Visée
4c536a5204 Implemented the email add command 2015-11-01 21:20:08 +01:00
Tim Visée
7f63056cc9 Implemented the unregister command 2015-11-01 21:06:19 +01:00
Tim Visée
ebefca73b7 Implemented the logout command 2015-11-01 21:00:41 +01:00
Tim Visée
ebd25e16a0 Moved authme command 2015-11-01 20:57:33 +01:00
Tim Visée
a36553f75f Implemented the changepassword command 2015-11-01 20:57:13 +01:00
Tim Visée
5093e8ff78 Implemented the register command (2) 2015-11-01 20:51:16 +01:00
Tim Visée
ae76759dc0 Implemented the register command 2015-11-01 20:50:25 +01:00
Tim Visée
45fe939239 Improved Dutch language pack 2015-11-01 20:35:41 +01:00
Tim Visée
1fad2b401c Removed unused code 2015-11-01 20:17:52 +01:00
Tim Visée
f67cb02d23 Added help command for login 2015-11-01 20:16:35 +01:00
Tim Visée
67ad350754 Moved help command 2015-11-01 19:26:04 +01:00
Tim Visée
7700799e82 Forced the password parameter for login command 2015-11-01 19:19:50 +01:00
Tim Visée
bade9d5d5e Fixed invalid permissions for login command 2015-11-01 19:18:00 +01:00
Tim Visée
9d386ed80a Fixed invalid login command label 2015-11-01 19:15:56 +01:00
Tim Visée
6e222c1bc9 Implemented the login command 2015-11-01 19:13:55 +01:00
Tim Visée
0ca60299ad Some minor command description changes 2015-11-01 19:06:43 +01:00
Tim Visée
913ba56343 Implemented the base of the resetname command 2015-11-01 19:03:23 +01:00
Tim Visée
b4d710840d Removed some unused code 2015-11-01 18:58:41 +01:00
Tim Visée
443e9954af Moved some code around 2015-11-01 18:58:22 +01:00
Tim Visée
afd46edb39 Implemented the forcelogin command 2015-11-01 18:57:28 +01:00
Tim Visée
14eb8e28cf Implemented getip command 2015-11-01 18:54:03 +01:00
Tim Visée
c11ca35774 Improved the switchantibot command 2015-11-01 18:46:57 +01:00
Tim Visée
c4c54cd134 Fixed invalid command reference 2015-11-01 18:43:09 +01:00
Tim Visée
e3a6c73b58 Implemented the switchantibot command 2015-11-01 18:41:03 +01:00
Tim Visée
559072b3c6 Implemented the purgelastposition command 2015-11-01 18:35:40 +01:00
Tim Visée
e4d46ae9b9 Implemented the unregister command 2015-11-01 18:30:29 +01:00
Tim Visée
2d935d5fef Implemented the changepassword command 2015-11-01 18:27:25 +01:00
Tim Visée
8ead129423 Implemented the firstspawn command 2015-11-01 18:23:03 +01:00
Tim Visée
c9eef4f174 Implemented the spawn command 2015-11-01 18:19:36 +01:00
Tim Visée
4ff8cb8c59 Implemented the purgebannedplayers command 2015-11-01 18:17:13 +01:00
Tim Visée
17c103a7b2 Changed some command descriptions 2015-11-01 18:13:36 +01:00
Tim Visée
ff909d0c31 Implemented the setfirstspawn command 2015-11-01 18:12:15 +01:00
Tim Visée
79dd26da0f Implemented the setspawn command 2015-11-01 18:10:24 +01:00
Tim Visée
bc0f1b4bb9 Implemented the setmail command 2015-11-01 18:06:09 +01:00
Tim Visée
19f4af3e85 Implemented getemail command
Various other improvements.
2015-11-01 18:02:26 +01:00
Tim Visée
89c3c6ed5b Implemented register command 2015-11-01 17:56:10 +01:00
Tim Visée
93e9ef18d2 Organized executable commands package 2015-11-01 17:51:29 +01:00
Tim Visée
9e65eaa048 Implemented accounts command 2015-11-01 17:50:06 +01:00
Tim Visée
4ae5b0be1e Removed unused code 2015-11-01 17:44:34 +01:00
Tim Visée
1fd64bc065 Fixed issue, removed unused imports 2015-11-01 17:43:10 +01:00
Tim Visée
39d6fdd05d Implemented lastlogin command 2015-11-01 17:42:46 +01:00
Tim Visée
a2e33402f9 Fixed invalid command reference 2015-11-01 17:37:40 +01:00
Tim Visée
1a62cecd58 Implemented the purge command 2015-11-01 17:34:35 +01:00
Tim Visée
085f19355d Improved grammar in reload command 2015-11-01 17:31:22 +01:00
Tim Visée
d583a3f339 Improved reload command 2015-11-01 17:19:50 +01:00
Tim Visée
0781bc16d1 Implemented reload command 2015-11-01 17:12:50 +01:00
Tim Visée
40c7ef95e5 Added Profiler class 2015-11-01 17:08:23 +01:00
Tim Visée
c30792f278 Implemented version command 2015-11-01 17:06:36 +01:00
Tim Visée
53a2e8f9f0 Implemented plugin name in help page header 2015-11-01 16:59:07 +01:00
Tim Visée
2fcb5f1183 Added plugin name and version constants, implemented these 2015-11-01 16:58:13 +01:00
Tim Visée
7463d123e9 Disabled legacy /authme command 2015-11-01 16:54:42 +01:00
Tim Visée
2b8fdc65f0 Removed unused commands 2015-11-01 16:54:23 +01:00
Tim Visée
756469449e Updated command manager 2015-11-01 16:36:05 +01:00
Tim Visée
59d02e1497 Created base command for /authme 2015-11-01 16:34:36 +01:00
Tim Visée
2e5e3f25e3 Fixed imports of HelpCommand class 2015-11-01 16:34:13 +01:00
Tim Visée
802053f045 Removed unused service class 2015-11-01 16:21:24 +01:00
Tim Visée
7962d6b9fe Fixed CommandPermissions class 2015-11-01 16:19:56 +01:00
Tim Visée
c193120958 Fixed imports for CommandParts class 2015-11-01 16:18:29 +01:00
Tim Visée
a4461dd564 Ignore unused method 2015-11-01 16:17:57 +01:00
Tim Visée
5a0ffab6c2 Fixed import in CommandHandler class 2015-11-01 16:17:16 +01:00
Tim Visée
8b4d8a489c Fixed and improved CommandDescriptor class 2015-11-01 16:16:48 +01:00
Tim Visée
aff503c11c Fixed HelpProvider class 2015-11-01 16:13:49 +01:00
Tim Visée
690c7d9532 Added CommandHandler instance 2015-11-01 16:13:34 +01:00
Tim Visée
59d8ced86d Fixed imports of HelpSyntaxHelper class 2015-11-01 16:01:59 +01:00
Tim Visée
96d2208817 Fixed HelpPrinter class 2015-11-01 16:01:44 +01:00
Tim Visée
80e66198db Added list utilities class 2015-11-01 15:51:28 +01:00
Tim Visée
c156c988aa Improved string utils class, added javaDocs 2015-11-01 15:40:15 +01:00
Tim Visée
ab8eee3be9 Added string utilities class, fixed some imports 2015-11-01 15:38:49 +01:00
Tim Visée
eeec8ca228 Moved new command handler system to new package 2015-11-01 15:34:13 +01:00
Tim Visée
1897b1f5e6 Added dynamic command handler from Dungeon Maze 2015-11-01 15:31:15 +01:00
Gabriele C
7cea79eefc cleanup 2015-11-01 14:41:41 +01:00
Gabriele C
3eb29da4a7 Merge pull request #59 from Xephi/master
Remove old loading chunk system
2015-11-01 13:36:13 +01:00
vanhec_a
7824131cec Remove old loading chunk system 2015-11-01 13:34:21 +01:00
Gabriele C
d478973fa5 Enhance join/leave message delay 2015-11-01 13:23:47 +01:00
Gabriele C
b2bd3b0ab7 cleanup 2015-11-01 12:00:45 +01:00
Gabriele C
69b874c832 Update AuthMePlayerListener.java 2015-11-01 01:58:25 +01:00
vanhec_a
9629ad1594 Ooops, don't push test methods :') 2015-10-31 18:41:57 +01:00
vanhec_a
6007ffb8ef Add some entry to api 2015-10-31 18:40:31 +01:00
vanhec_a
f722fa161a Add a join blocker in case Cache Loading 2015-10-31 17:34:16 +01:00
Gabriele C
9aee483cc3 Fix compatibility issues with plugins like factionschat 2015-10-25 12:23:40 +01:00
Gabriele C
1306ef38b4 Merge pull request #56 from Xephi/master
Up
2015-10-23 17:18:21 +02:00
Xephi59
505bda79f0 Need to calcul position synchronously 2015-10-23 00:37:57 +02:00
DNx5
a2381fa025 1.7 compatibility 2015-10-23 00:23:12 +07:00
Gabriele C
38832fc2ce Fix conflicts 2015-10-20 22:05:19 +02:00
Xephi59
e1c1d18d05 Fix Player Online check 2015-10-19 23:37:42 +02:00
vanhec_a
a2f5a7917d Whoops ? :') 2015-10-16 17:03:34 +02:00
Gabriele C
c937338fc4 remove speed if player moves 2015-10-12 18:47:15 +02:00
Gabriele C
92777cd383 cleanup 2015-10-12 18:16:56 +02:00
Gabriele C
9c19f568fd fix conflict 2015-10-12 17:51:05 +02:00
vanhec_a
39ab41f542 Add an option to disable all caching (useful if you use website
registration system)
2015-10-12 15:49:19 +02:00
vanhec_a
5e991f7f42 realName here 2015-10-12 15:12:01 +02:00
vanhec_a
8e90a5f9a8 Force a player just registered by an admin to log again 2015-10-12 15:10:14 +02:00
vanhec_a
5b98759b61 Change how purge logged works at starting/stopping server 2015-10-12 15:01:57 +02:00
vanhec_a
3c0e6e06c7 Fix some case when connection is not available 2015-10-12 14:57:56 +02:00
vanhec_a
8ad2fde798 Remove REALLY old loading chunk system before teleport 2015-10-12 13:56:12 +02:00
Gabriele C
41bbbf0a96 custom graphs 2015-10-10 00:31:47 +02:00
Gabriele C
3567fc909d Organize imports 2015-10-09 19:18:24 +02:00
Gabriele C
a502a479b8 Fix compatibility 2015-10-06 21:04:06 +02:00
Gabriele C
807d302b60 1.5.2 compatibility 2015-10-06 19:17:03 +02:00
Gabriele C
aac4320f46 Fix build 2015-10-06 17:11:14 +02:00
Gabriele C
7aea267051 Fix conflict 2015-10-06 17:03:59 +02:00
vanhec_a
99fca1cb20 Fix Import 2015-10-06 12:32:12 +02:00
DNx5
4d4931af3f added reload function into module manager 2015-10-06 08:08:32 +07:00
DNx5
3f179ade81 rename inventory listener class 2015-10-06 07:11:51 +07:00