Commit Graph

459 Commits

Author SHA1 Message Date
asofold
e06e55a752 Put a pom for building into the NoCheatPlus module until knowing better. 2013-05-22 21:00:37 +02:00
asofold
ce834675d7 Move most code to NCPCore, removes NCPCompat.
Factories are now on NCPPlugin level, thus all the core stuff can be in
one module, giving better source code browsing.

Updates has been moved into an updates package, because there is to be
expected more content, and to make utilities less fat.

To indicate the direction, the basic infra-structure has been added to
allow adding components to the DefaultComponentFactory. Further
processQueuedSubComponents is now called after each components adding in
order to allow more flexible registry features.
2013-05-22 12:24:48 +02:00
asofold
463700cb3a [BREAKING API] Add module NCPCore between NCPCompat and NCPPlugin.
* Static utility NCPAPIProvider instead of NoCheatPlus.getAPI().
* Extend NoCheatPlusAPI: Some previously static access methods are now
part of the NoCheatPlusAPI interface instead. MCAccessHolder is
implemented and allows external setting of MCAccess.
* Fix some static members/calls to non-static.
* Moving some packages to NCPCore.
* Prepares for moving most check stuff between NCPCompat and NCPPlugin
to allow more optional higher level components.
2013-05-21 22:49:05 +02:00
asofold
6e6b198188 Move auxiliary code. 2013-05-21 15:51:51 +02:00
asofold
43d1c4aad0 SurvivalFly: Add tag lowfoodsprint for debugging purposes.
This tag is added if the player is sprinting but the food level has
dropped. Not sure this can actually be the case.
2013-05-21 14:56:19 +02:00
asofold
2319830873 [Incomplete] First go at shift+double-click on items with item on
cursor.
2013-05-15 01:37:21 +02:00
asofold
52b28bdfb4 [Bleeding] Add "sprintinggrace" concept to moving.
This allows setting a grace-period which allows that amount of seconds
longer sprinting even though the food level just dropped below minimum
for sprinting. This will hopefully reduce seldom false positives as well
as improve compatibility with other plugins like Heroes, which have
skills that add velocity and at the same time decrease the food level
below sprinting-limit (fp on landing).
2013-05-14 19:39:45 +02:00
asofold
9ae355c537 Iterate over the wrong list. 2013-05-11 01:02:47 +02:00
asofold
ac4d103cc1 Use ArrayList / index iteration here. 2013-05-11 00:56:33 +02:00
asofold
a277cbc96e Set version to 3.9.2 - back to development. 2013-05-10 13:59:58 +02:00
asofold
c45e92b50b Update checks and notifications are not processed anyway. 2013-05-06 00:31:18 +02:00
asofold
2457f031f2 Set version to 3.9.1-RC2 for second release attempt 2013-05-06 00:25:36 +02:00
asofold
9af9bcc7e9 Set version to 3.9.1-RC for release on BukkitDev. 2013-05-04 01:18:59 +02:00
asofold
384c3483ca Add configuration for ender-pearl checks to the combined section. 2013-05-03 11:13:53 +02:00
asofold
3e96d7d9a2 [Experimental] Add "strictinvalidation" flag to velocity config.
This allows triggering the invalidation for the active horizontal
velocity at half of the allowed speed instead of full, in case of
setting the flag to false.
2013-05-01 22:44:19 +02:00
asofold
5e8cf481a1 [Bleeding] Set dependency for dev-module to CB 1.5.2-R0.1. 2013-05-01 20:36:16 +02:00
asofold
00a240ff9a Bind chunk loading debug messages to the debug flag as well. 2013-04-30 19:26:41 +02:00
asofold
a493da7ff7 Don't deal fall damage for causing passable violations moving from
ground.

This hopefully prevents a range of login/teleport problems with nofall.
Does not resolve those for tp/login into air.
2013-04-29 00:39:00 +02:00
asofold
634ca39824 Load chunks on players joining (configurable). 2013-04-27 00:32:07 +02:00
asofold
0e5912c77f Fly and xray removed from cjb? 2013-04-24 01:25:11 +02:00
asofold
34d851e0df Quick rework for client-mod-motdS. One class per client for better
overview.
2013-04-24 01:03:55 +02:00
asofold
04f2baed50 . 2013-04-23 23:45:38 +02:00
asofold
cdcd7945e9 Update permissions in the plugin.yml + order. 2013-04-23 23:30:26 +02:00
asofold
22ffb43ddf [BLEEDING] Testing: ender-pearl glitch use (first sketch, read details).
* This method is "hard-coded" and not configurable yet.
* Prevent throwing and teleporting into blocks directly, prevent
the second throw on glitching into a one thick ceiling (might lead to
lots of passable violations at present).
* If stuck in a block with the feet (not sand/gravel) without being on
ground, throwing is prevented.
* Some dependencies were updated, hopefully without conflicts for
backwards compatibility (untested).
2013-04-22 21:46:49 +02:00
asofold
3b4352c044 [BLEEDING] Add AutoSign check (first sketch). 2013-04-22 04:38:14 +02:00
asofold
f4b88b3309 Adjust critical, remove remainders of old god-mode check.
Critical:
* Add tags.
* Add extra flag (redundant to MediumLiftOff, just indicating what the
real lift off was, might need redesign, since m-lo is modified
sometimes.)
2013-04-22 01:14:05 +02:00
asofold
6b4421dc81 [BLEEDING] Add low jump detection, prevent critical hits if in low jump
phase.
2013-04-21 22:20:28 +02:00
asofold
19ddaefb4c Fix crop trampling being disabled by anticriticals. 2013-04-21 21:23:51 +02:00
asofold
e26aec2cbd Make login denial configurable for the illegal-move checking. 2013-04-21 19:52:55 +02:00
asofold
2334bc9f22 Hover check: Check if chunks are loaded before triggering a violation. 2013-04-21 19:48:04 +02:00
asofold
fa50f34023 Add the auxiliary OnDemandTickListener class for temporary TickListener
registration.

* OnDemandTickListener contains API for convenient on-demand
registration and use.
* TickTask recognizes these and conveniently sets them
registered/unregistered.
* TickTask was optimized to allow faster adding and removal of
TickListener instances.
* Used for delayed component registration.
* Future purpose.
2013-04-18 17:10:12 +02:00
asofold
a950a2b7f8 Use a "temporary" TickListener to process queued IHoldSubComponents
instances.
2013-04-15 16:20:41 +02:00
asofold
d15a1d1f9e Only add TickListener instances once. 2013-04-15 16:16:05 +02:00
asofold
de5f152df9 [BLEEDING] Flesh out aspects of ComponentRegistry.
* Fixes data removal ignoring chat.logins and chat.text for a part.
* Move some components interfaces and ReflectionUtil to NCPCommons.
* Unregister components in reverse order.
* Add ComponentRegistryProvider for generic sub-registries (DataManager
for instance).
* Add IHoldSUbComponents for delayed sub-component registration
(convenient for iteration over parent-components with later registration
of sub components not missing out any registered parent components for
those). [Partly implemented: Using this during runtime does not yet
work, only used in onEnable.]
* Let CheckListener implement IHoldSubComponents and use this with
addCheck to register the queued checks after all the listeners.
* Register the core system components in a bunch before the
CheckListenerS, to allow sub-registries to work directly and to allow
getAPI().addComponent on the plugin class during construction of
CheckListeners.
2013-04-15 16:11:08 +02:00
asofold
652342c6c9 Add getMCAccess(boolean). 2013-04-15 09:05:01 +02:00
asofold
003e104ef4 Add module for CB2691 to match the beta release of CraftBukkit.
The dev module will compile with 1.5.1-R0.2 but not be used for the
moment.
2013-04-12 19:00:19 +02:00
asofold
31e21000e5 Make chat.logins default settings less strict.
Requested by @andrewkm.
2013-04-12 15:07:38 +02:00
asofold
290fc0feb0 Two fixes for MovingListener/join.
* Catch a null location.
* Set the set back after resetting fly data, if a location is given.
2013-04-05 21:34:57 +02:00
asofold
091d29cbbc Set version to 3.9.1 for further development. 2013-03-22 09:30:46 +01:00
asofold
97fd0be89b Set version to 3.9.0-RC for release on BukkitDev. 2013-03-21 17:47:58 +01:00
asofold
d02b54bab2 Set version to 3.9.0 due to 1.5 being a new MC version.
Reminder: Policy is to increase second level count for Minecraft updates
and bigger internal/external changes, while the third level count will
indicate releases on BukkitDev rather. First level count probably will
only increase if something really fundamental is changed.
2013-03-21 09:36:49 +01:00
asofold
d6d465418f [BLEEDING] Set DEV module to 1.5.1. 2013-03-21 01:10:56 +01:00
asofold
72c69df73c Add MC 1.5 module. 2013-03-21 01:01:31 +01:00
asofold
b09f2e511c Missing vehicle-exit: Always clear nofall data (leave that to MC). 2013-03-20 07:04:12 +01:00
asofold
d659dd7f26 Attempt to work around missing VehicleExit events with latest CB dev
builds.
2013-03-20 06:15:17 +01:00
asofold
9e16d8f2ef Remove debug message (...). 2013-03-16 04:34:25 +01:00
asofold
171f2aa932 Re-order conditions. 2013-03-16 04:33:47 +01:00
asofold
ab99e871f9 Add heuristic for the THORNS enchantment. 2013-03-16 04:25:16 +01:00
asofold
7d17fb67b4 Suppress deprecation warning for now. 2013-03-16 00:16:58 +01:00
asofold
636faecd52 [BLEDING] Update dev-module to CB/1.5. 2013-03-15 22:31:02 +01:00
asofold
32600dd335 Set version to 3.8.13 for further development. 2013-03-15 21:36:12 +01:00
asofold
328d277955 Set version to 3.8.12-RC2 to distinguish quick fix release. 2013-03-14 21:31:44 +01:00
asofold
0fc3b54db9 Also catch getSlot() < 0 for the InventoryClickEvent. 2013-03-14 21:30:19 +01:00
asofold
677aef45cd Set version to 3.8.12-RC for release on BukkitDev. 2013-03-14 14:52:51 +01:00
asofold
1b811716e2 Inventory.FastClick: Fix vl not adding, prepare for 1.5. 2013-03-14 12:21:38 +01:00
asofold
325d47fcbc Ignore "outside" clicks, i.e. slots outside of the inventory slot range. 2013-03-14 11:02:41 +01:00
asofold
9de6175874 New FastClick (inventory) check.
This check is less strict on short term but more strict on medium term.
Keeps track of one second (200 ms resolution).
2013-03-14 10:44:29 +01:00
asofold
0abca20dd9 Set version to 3.8.12 for further development. 2013-03-14 08:35:49 +01:00
asofold
84da47315b Add example entry for overrideflags (snow: default). 2013-03-14 08:34:32 +01:00
asofold
0e506eb967 Set version to 3.8.11-RC for release on BukkitDev. 2013-03-13 22:21:46 +01:00
asofold
15f08f13a9 Prepare 1.5 blocks with block flags. Add unused stuff.
More like a safety commit.
1. Add compatibility block flags for MC 1.5 blocks.
2. Add commented out / unused stuff (not really for 1.5).
2013-03-13 10:16:56 +01:00
asofold
c075e67f8f Make fight.reach distances (survival) configurable. 2013-03-13 09:20:17 +01:00
asofold
a04f4ad882 Adjust lostgorund/fastedge to catch more vacc fp. 2013-03-13 06:46:19 +01:00
asofold
1ec7f997cf Just add to first bucket, since update(...) has been called. 2013-03-13 06:20:14 +01:00
asofold
414796b938 Check IHaveCHeckType after CheckType.ALL for data removal.
This ensures that "ncp remove *" really removes chat.logins data, for
instance.
2013-03-13 05:51:54 +01:00
asofold
976cd59b7c Add the command "ncp unkick *". 2013-03-13 05:41:17 +01:00
asofold
a5ed780542 Attempt to fix issues with too low valid-count for velocity. 2013-03-13 05:08:23 +01:00
asofold
25e4cb3b05 Fix allowed h-dist in water (downstream).
Previously this was not applied in the "after-failure" h-dist estimation
 with permission checking.
2013-03-13 03:19:14 +01:00
asofold
1ad08b3729 Velocity: Decrease validity counter once activated. 2013-03-13 02:55:54 +01:00
asofold
bb38ff5a1b Add maximum activation ticks for velocity (queued). 2013-03-13 02:55:24 +01:00
asofold
310b62384f Fix aspects with jump potion-effects.
1. Set the correct effect strength in data.
2. Adjust workarounds to catch jump effect II on fences and similar.
[Might need more specialized checking for performance reasons.]
2013-03-12 21:55:04 +01:00
asofold
fc788f55c4 [Bleeding] Optimize preparation for PlayerLocation use.
1. Only collect flags for survivalfly.
2. Set all properties for the to location if it is the same position as
the from location.
2013-03-12 09:59:52 +01:00
asofold
a7c4539783 Let NoFall be more generous with the on-ground search.
Extend xz and y margins.
2013-03-12 08:19:19 +01:00
asofold
7b4fe7acc4 Regroup lost-ground workarounds. Fix some aspects.
Check some preconditions in the check method, delegate to different
methods for different cases, also to have smaller method bodies.

IsAboveStairs is only checked for "mild" y-distances. For faster
descending an individual edge-check has been added.
2013-03-12 07:55:50 +01:00
asofold
409ba0b2ee Don't check god mode for dead players. 2013-03-12 07:05:49 +01:00
asofold
186eec69ab Moving: Only set sfDirty flag if velocity is really used. 2013-03-11 19:18:22 +01:00
asofold
ea0b26ad19 SurvivalFly: adjust "swimup" workarounds.
1. After-failure workarounds checking (performance).
2. Hopefully fixes issues with flowing water and stairs.
2013-03-11 18:42:45 +01:00
asofold
d4616f415d [Bleeding] Various fixes for collision logic and consequent changes.
General:
- Wrong flags checked or flags checked in the wrong way.
- isPassable should use collidesBlock.
- collidesBlock should not see high-value-only matches as collisions.
- collidesCenter returns true for the case of collision (...).

Liquid blocks:
- New flag introduced to model rough liquid height for flowing liquids.
- One more workaround condition for moving in/off liquids.
- Use exact bounding-box for liquids checking in PlayerLocation.
- Check for water first in PlayerLocation.isInLiquid.

Other:
- Alter some block flags and workarounds.
- (other)
2013-03-11 06:01:39 +01:00
asofold
4ff54f0020 Revert setting set-back-y to block bottom on some occasions. 2013-03-11 03:23:10 +01:00
asofold
0c59487a0a Use the same Location instance for passable and nofall. 2013-03-09 19:42:16 +01:00
asofold
434a83c398 [BLEEDING] Adjust the set-back y-coordinate to block bottom for some
cases.
2013-03-09 03:53:51 +01:00
asofold
8d9e2fdadc Add more detailed tags to lost-ground workarounds. 2013-03-09 03:53:06 +01:00
asofold
7eab369a00 Alter small-range-tp margin. Add debug info for teleport and setback-y. 2013-03-09 03:04:50 +01:00
asofold
498f23e704 Reduce amount fed to improbable by fight.reach. 2013-03-09 00:34:04 +01:00
asofold
de4faa392d Allow fight.speed to create improbable violations for higher violation
levels.

Might need configuration/testing.
2013-03-08 23:26:57 +01:00
asofold
61bc88b64f Add "strict" method to fight.direction.
Set as default, the "strict" option will also check the angle between
the viewing direction and the direction towards the target. This might
not stay the default method, but it does help against auras in close
combat.
2013-03-08 23:24:51 +01:00
asofold
593ea71c9b Add convenience methods for combinedDirectionCheck. 2013-03-08 23:10:05 +01:00
asofold
926556a358 Implement JoinLeaveListener with MovingListener and ChatListener. 2013-03-08 17:28:35 +01:00
asofold
5dd09d4476 [BLEEDING, INSTABLE] Switch horizontal velocity to a new method.
This method remembers (currently) each velocity added and only uses it
when it is needed not to generate a violation. Further (currently
simple) activation and invalidation logics are applied. With this method
latency will be much less of a problem, though stacking of queued
entries (especially for rocket-boots style flying) and more
merging of entries and more invalidation logics are required, thus
bleeding+instable.

On the long term this should make cheating much more difficult, possible
steps are:
1. Use method for vertical velocity too (only positive)
2. Distinguish positive and negative vertical velocity (opens a way to
control the speed downwards in any medium!).
3. Per-axis velocity (either absolute or pos/neg with more invalidation
logic on direction changes).
2013-03-08 04:06:17 +01:00
asofold
24c1599e94 Remove angle data on players leaving. 2013-03-08 03:47:02 +01:00
asofold
be49a7855c Add JoinLeaveListener component. 2013-03-08 03:44:54 +01:00
asofold
5a76b22ef6 Sharpen maximum jump distance. 2013-03-07 04:20:26 +01:00
asofold
348ba34e35 Commend on potential issue with join. 2013-03-06 19:36:50 +01:00
asofold
2d5dd8770d Fix block dump not respecting the checks.debug and blockbreak.debug
flags.
2013-03-06 18:54:11 +01:00
asofold
ce3d1ba89c Attempt to fix issues with (non exact) respawn. 2013-03-06 15:40:35 +01:00
asofold
7adef83687 Change resetting of yOnGround for NoFall.
Use CheckConfig to determine if it is necessary. Move resetting to a
method. Collect block flags again.
2013-03-05 20:21:29 +01:00
asofold
8bed6fb2de Change resetting of yOnGround for NoFall.
Use CheckConfig to determine if it is necessary. Move resetting to a
method. Collect block flags again.
2013-03-05 20:11:51 +01:00
asofold
d7110b3239 Adjust/fix moving debug output. 2013-03-05 19:45:01 +01:00
asofold
66f2d6d7eb Set version to 3.8.11 for further development. 2013-03-05 16:37:48 +01:00
asofold
2dbc486987 Set version back to 3.8.10-RC, since back to dev was premature. 2013-03-05 07:55:07 +01:00