Commit Graph

4469 Commits

Author SHA1 Message Date
CraftBukkit/Spigot
8b2749a446 SPIGOT-7137: StructureGrowEvent isFromBonemeal and getPlayer have incorrect values
By: md_5 <git@md-5.net>
2022-08-14 10:54:23 +10:00
CraftBukkit/Spigot
5fa8a6d631 SPIGOT-7089: Crash when command blocks attempt to load worlds
By: md_5 <git@md-5.net>
2022-08-14 10:46:41 +10:00
CraftBukkit/Spigot
06a34ebbdd SPIGOT-2450: Improve scoreboard criteria API, add missing DisplaySlots
By: Parker Hawke <hawkeboyz2@hotmail.com>
2022-08-08 21:50:13 +10:00
CraftBukkit/Spigot
ba6d980d80 SPIGOT-7122: New Allay Methods from 1.19.1
By: Doc <nachito94@msn.com>
2022-08-08 21:39:21 +10:00
CraftBukkit/Spigot
808a4dedfe Update to Minecraft 1.19.2
By: md_5 <git@md-5.net>
2022-08-06 07:40:00 +10:00
CraftBukkit/Spigot
c6b9050486 SPIGOT-7109: Add WorldBorder#setSize using TimeUnit
By: Doc <nachito94@msn.com>
2022-08-04 20:31:05 +10:00
CraftBukkit/Spigot
0b6cdcc0c4 SPIGOT-7127: /say doesn't work from console
By: md_5 <git@md-5.net>
2022-08-01 22:07:48 +10:00
CraftBukkit/Spigot
cb4c71bc0d Re-enable outdated build delay
By: md_5 <git@md-5.net>
2022-07-29 16:14:40 +10:00
CraftBukkit/Spigot
70f4545a45 SPIGOT-7125: Command execution exceptions are not logged
By: md_5 <git@md-5.net>
2022-07-29 16:13:34 +10:00
CraftBukkit/Spigot
8e9f13befb SPIGOT-7123: NullPointerException thrown by Player#chat method
By: md_5 <git@md-5.net>
2022-07-29 16:04:07 +10:00
CraftBukkit/Spigot
f8db65033c Update to Minecraft 1.19.1
By: md_5 <git@md-5.net>
2022-07-28 04:00:00 +10:00
CraftBukkit/Spigot
7c33b52741 #1091: Fix exit position in entity travel with portals
By: Doc <nachito94@msn.com>
2022-07-25 18:00:57 +10:00
CraftBukkit/Spigot
d236296888 #1090: Remove no longer needed world reference from CraftMerchantCustom
By: blablubbabc <lukas@wirsindwir.de>
2022-07-25 18:00:57 +10:00
CraftBukkit/Spigot
0424133c43 SPIGOT-7115: Support hex color codes in custom merchant inventory titles
By: blablubbabc <lukas@wirsindwir.de>
2022-07-25 18:00:55 +10:00
CraftBukkit/Spigot
c739d45f4b SPIGOT-5380, SPIGOT-6958, #1085: Add some missing entity API
By: Ollie <69084614+olijeffers0n@users.noreply.github.com>
2022-07-21 21:01:28 +10:00
CraftBukkit/Spigot
10e81b4c37 SPIGOT-7069: Material.BARREL has Directional data class, should also be Openable
By: md_5 <git@md-5.net>
2022-07-10 15:10:07 +10:00
CraftBukkit/Spigot
7cdd598517 SPIGOT-7070: Material.SCULK_VEIN has Waterlogged data class, should also be MultipleFacing
By: md_5 <git@md-5.net>
2022-07-10 15:04:44 +10:00
CraftBukkit/Spigot
35388a73b0 SPIGOT-7095: StructureGrowEvent doesn't fire for mangrove propagules growing to a tree
By: md_5 <git@md-5.net>
2022-07-10 14:12:30 +10:00
CraftBukkit/Spigot
86d63605da #1079: Add support checking/survivability methods for BlockData
By: Parker Hawke <hawkeboyz2@hotmail.com>
2022-07-09 20:09:34 +10:00
CraftBukkit/Spigot
2f0d31aa17 SPIGOT-7083: Add Boat.WoodenType, Boat.Status; deprecate TreeSpecies
By: Doc <nachito94@msn.com>
2022-07-05 20:40:35 +10:00
CraftBukkit/Spigot
60fb93349f SPIGOT-1729, SPIGOT-7090: Keep precision in teleportation between worlds
By: Doc <nachito94@msn.com>
2022-07-02 12:26:55 +10:00
CraftBukkit/Spigot
5377574bc2 SPIGOT-7071: Add Player#stopSound(SoundCategory category)
By: SkytAsul <skytasul@gmail.com>
2022-07-01 20:46:16 +10:00
CraftBukkit/Spigot
230282ea44 SPIGOT-7011, SPIGOT-7065: Overhaul of structures
By: DerFrZocker <derrieple@gmail.com>
2022-07-01 20:41:04 +10:00
CraftBukkit/Spigot
8bf76d9868 Remove outdated build delay.
By: md_5 <git@md-5.net>
2022-06-28 21:28:28 +10:00
CraftBukkit/Spigot
23815db283 SPIGOT-7078: Add EntityPotionEffectEvent.Cause#WARDEN
By: Doc <nachito94@msn.com>
2022-06-23 20:34:34 +10:00
CraftBukkit/Spigot
c6f488dfd5 SPIGOT-7072: Call events for stepping on sculk sensors and sculk shriekers
By: BlackHole <black-hole@live.com>
2022-06-23 20:25:36 +10:00
CraftBukkit/Spigot
6e92592b55 SPIGOT-7068: SKULK and SKULK_VEIN BlockSpreadEvents Still do not reference the correct source (SKULK_CATALYST)
By: DerFrZocker <derrieple@gmail.com>
2022-06-19 21:48:24 +10:00
CraftBukkit/Spigot
100bb8f120 #1052: Add option to use cached map color palette
This reduces the conversion time drastically with the cost of slightly more memory usage.

By: DerFrZocker <derrieple@gmail.com>
2022-06-18 21:13:42 +10:00
CraftBukkit/Spigot
9fdd99d4ce SPIGOT-7066: Fix custom END worlds not generating DragonBattle
By: Doc <nachito94@msn.com>
2022-06-18 21:06:59 +10:00
CraftBukkit/Spigot
30fe2b464e SPIGOT-2420: Can't set exp drops for EnderDragon death
By: DerFrZocker <derrieple@gmail.com>
2022-06-18 20:59:19 +10:00
CraftBukkit/Spigot
40a58283ca #1067: Add preview chat option in ServerListPingEvent
By: Doc <nachito94@msn.com>
2022-06-18 20:55:26 +10:00
CraftBukkit/Spigot
63d419d302 #1066: Add missing server properties methods from 1.19
By: Doc <nachito94@msn.com>
2022-06-18 20:49:03 +10:00
CraftBukkit/Spigot
8abaca5d3d Increase outdated build delay
By: md_5 <git@md-5.net>
2022-06-15 20:10:51 +10:00
CraftBukkit/Spigot
0d983f9b9a SPIGOT-7060: SCULK and SCULK_VEIN BlockSpreadEvents do not reference the correct source
By: md_5 <git@md-5.net>
2022-06-14 21:21:46 +10:00
CraftBukkit/Spigot
8a00d6f5d1 #1070: Add SpawnReason and TransformReason for Tadpole metamorphosis into Frog
By: Doc <nachito94@msn.com>
2022-06-13 15:24:58 +10:00
CraftBukkit/Spigot
df3ad38359 #1068: Add Hangable interface to MangrovePropagule
By: chickeneer <emcchickeneer@gmail.com>
2022-06-12 18:19:01 +10:00
CraftBukkit/Spigot
52f9281656 #1065: Add missing calls for BlockSpreadEvent when Sculk spreads
By: Brokkonaut <hannos17@gmx.de>
2022-06-11 13:20:38 +10:00
CraftBukkit/Spigot
46523c1525 SPIGOT-7051: Worldgen API does not run vanilla noise generation when shouldGenerateNoise is true
By: DerFrZocker <derrieple@gmail.com>
2022-06-10 19:08:36 +10:00
CraftBukkit/Spigot
766668f0db SPIGOT-7041: Custom BiomeProvider not used when world set to type FLAT
By: md_5 <git@md-5.net>
2022-06-10 11:08:00 +10:00
CraftBukkit/Spigot
d9d74754ba SPIGOT-7043: EnderChest does not implement Lidded
By: md_5 <git@md-5.net>
2022-06-10 10:57:43 +10:00
CraftBukkit/Spigot
29db051e6e SPIGOT-7048: addPassenger() not working when vehicle is player
By: md_5 <git@md-5.net>
2022-06-10 10:39:19 +10:00
CraftBukkit/Spigot
85ee50d5f1 SPIGOT-7047: Add Player#getLastDeathLocation
By: Doc <nachito94@msn.com>
2022-06-10 09:56:52 +10:00
CraftBukkit/Spigot
70106be465 SPIGOT-7050: Enchantment data of items will not be saved correctly when saved in YAML configuration file
By: md_5 <git@md-5.net>
2022-06-10 09:45:10 +10:00
CraftBukkit/Spigot
79086ef520 SPIGOT-7003: Add missing PlayerAnimationType
By: Doc <nachito94@msn.com>
2022-06-09 21:30:25 +10:00
CraftBukkit/Spigot
c67855f651 SPIGOT-5984: Add non deprecated / magic value way to set pixel in MapCanvas
By: DerFrZocker <derrieple@gmail.com>
2022-06-09 21:27:39 +10:00
CraftBukkit/Spigot
0edbb16bb4 Update Netty version
By: md_5 <git@md-5.net>
2022-06-09 21:14:14 +10:00
CraftBukkit/Spigot
92822affe1 SPIGOT-7044: Modified RandomSourceWrapper to ensure random is not null before setting seed
By: Vatuu <21113232+Vatuu@users.noreply.github.com>
2022-06-09 21:06:03 +10:00
CraftBukkit/Spigot
d345226478 #1059: Add DamageCause.SONIC_BOOM
By: Doc <nachito94@msn.com>
2022-06-09 21:04:03 +10:00
CraftBukkit/Spigot
5913ce98b9 SPIGOT-7042: Subtitle is always equal to title
By: md_5 <git@md-5.net>
2022-06-09 07:28:01 +10:00
CraftBukkit/Spigot
80188eac4e Fix missing abstract in CraftLeaves
By: md_5 <git@md-5.net>
2022-06-08 17:37:43 +10:00
CraftBukkit/Spigot
b6c55ade98 SPIGOT-7038: Setting title or subtitle to empty string causes the player to disconnect
By: md_5 <git@md-5.net>
2022-06-08 17:34:21 +10:00
CraftBukkit/Spigot
5806a895dc Make Leaves Waterlogged
By: md_5 <git@md-5.net>
2022-06-08 17:31:13 +10:00
CraftBukkit/Spigot
7f44ec20a2 Downgrade dependency version
By: md_5 <git@md-5.net>
2022-06-08 09:01:13 +10:00
CraftBukkit/Spigot
25f3b50f6b Update to Minecraft 1.19
By: md_5 <git@md-5.net>
2022-06-08 02:00:00 +10:00
CraftBukkit/Spigot
91d9aa9a89 Remove outdated build delay.
By: md_5 <git@md-5.net>
2022-06-08 02:00:00 +10:00
CraftBukkit/Spigot
43ec2cdacc #1055: Use correct tile entity for trapped chest in CraftBlockStates
By: DerFrZocker <derrieple@gmail.com>
2022-06-06 08:30:54 +10:00
CraftBukkit/Spigot
0fb296468e SPIGOT-7025: Use existing item in hand for ranged Drowned attack
By: Doc <nachito94@msn.com>
2022-06-05 16:30:03 +10:00
CraftBukkit/Spigot
ed74e7e047 #1050: Expose more information about advancements
By: MartenM <marten.struijk@gmail.com>
2022-06-05 16:23:50 +10:00
CraftBukkit/Spigot
462a5fddbf SPIGOT-7009: Stuck on "Loading terrain..." after disconnecting on respawn screen
By: DerFrZocker <derrieple@gmail.com>
2022-06-03 09:19:53 +10:00
CraftBukkit/Spigot
77f366d383 SPIGOT-1807: PlayerTeleportEvent is called twice
By: DerFrZocker <derrieple@gmail.com>
2022-05-24 20:45:57 +10:00
CraftBukkit/Spigot
3bd1e295ea #1047: Support setting individual Wither head targets
By: Yannick Lamprecht <yannicklamprecht@live.de>
2022-05-17 19:27:01 +10:00
CraftBukkit/Spigot
5e503c9e28 SPIGOT-6948: Motion from Explosion after Respawn
By: DerFrZocker <derrieple@gmail.com>
2022-05-17 19:22:58 +10:00
CraftBukkit/Spigot
ee1a8e3018 SPIGOT-7019: Add yaw in World#getSpawnLocation
By: Doc <nachito94@msn.com>
2022-05-13 11:24:17 +10:00
CraftBukkit/Spigot
27ea8b4a25 SPIGOT-7014: getLootTable API should not persistently update loot table
By: md_5 <git@md-5.net>
2022-05-09 18:13:06 +10:00
CraftBukkit/Spigot
98756897b7 #1046: Make World implement Keyed
By: pop4959 <pop4959@gmail.com>
2022-05-09 18:07:51 +10:00
CraftBukkit/Spigot
aba0972e9a #1045: Revert changes to persistence required checks
By: DerFrZocker <derrieple@gmail.com>
2022-05-03 23:13:03 +10:00
CraftBukkit/Spigot
465b2801f1 SPIGOT-7010: Changing dropper item results in using dispensing behaviour
By: md_5 <git@md-5.net>
2022-04-28 19:16:28 +10:00
CraftBukkit/Spigot
ed0354be30 SPIGOT-6992: Add LimitedLife/LifeTicks/Bound APIs to Vex
By: Doc <nachito94@msn.com>
2022-04-21 06:45:42 +10:00
CraftBukkit/Spigot
94eb19b9fc Pass in SpawnReason rather than boolean
By: md_5 <git@md-5.net>
2022-04-18 11:05:15 +10:00
CraftBukkit/Spigot
14aabc2648 SPIGOT-7001: Fix entity already exists in CraftWorld#spawnFallingBlock
By: Doc <nachito94@msn.com>
2022-04-18 11:05:12 +10:00
CraftBukkit/Spigot
e935d60d1d SPIGOT-6972: Root command nodes can leak to client
By: md_5 <git@md-5.net>
2022-04-17 18:57:35 +10:00
CraftBukkit/Spigot
ef79686997 #1033: Add Villager#zombify
By: Doc <nachito94@msn.com>
2022-04-15 13:48:55 +10:00
CraftBukkit/Spigot
8400a7987a #975: Add method to read ItemStack input
By: Parker Hawke <hawkeboyz2@hotmail.com>
2022-04-15 12:54:08 +10:00
CraftBukkit/Spigot
9340d95f92 SPIGOT-6990: Fix setRepairCost(0) in Anvil
By: Doc <nachito94@msn.com>
2022-04-09 09:42:11 +10:00
CraftBukkit/Spigot
b0e366dc99 SPIGOT-6829: Add per-player world border API
By: Parker Hawke <hawkeboyz2@hotmail.com>
2022-04-09 09:39:33 +10:00
CraftBukkit/Spigot
6cd6b91c36 Remove broken quickMoveStack implementation
By: md_5 <git@md-5.net>
2022-04-04 20:17:00 +10:00
CraftBukkit/Spigot
8ea55f306a SPIGOT-6973: Setting biome calls String#intern for every biome placed
By: md_5 <git@md-5.net>
2022-04-03 09:20:16 +10:00
CraftBukkit/Spigot
9cff7d3ca0 Java 18 support
By: md_5 <git@md-5.net>
2022-03-28 08:10:25 +11:00
CraftBukkit/Spigot
c9a265249c #1039: Use correct ops in GeneratorSettings
By: Martoph <sager1018@gmail.com>
2022-03-27 16:24:09 +11:00
CraftBukkit/Spigot
813ab8f174 #1038: Removed the no longer needed getChunkUnchecked method from ChunkProviderServer.
This method was added in 373ed1ddd5 to fix SPIGOT-5228. But since Minecraft 1.17 changed how entities are added and removed from chunks, this method has no longer been used.

By: blablubbabc <lukas@wirsindwir.de>
2022-03-27 16:24:09 +11:00
CraftBukkit/Spigot
475d10469d SPIGOT-6980: Since 1.18.2, World#isChunkLoaded returned false for chunks that have just been loaded (e.g. inside ChunkLoadEvent).
Some changes of the 1.18.2 update have been reverted to resolve this regression.

By: blablubbabc <lukas@wirsindwir.de>
2022-03-27 16:24:06 +11:00
CraftBukkit/Spigot
fa672ce555 #1035: Update README
By: Doc <nachito94@msn.com>
2022-03-24 13:40:09 +11:00
CraftBukkit/Spigot
f046a30653 SPIGOT-5140: Call EntityChangeBlockEvent when a ChorusFlower is destroyed by a projectile
By: Brokkonaut <hannos17@gmx.de>
2022-03-21 13:17:54 +11:00
CraftBukkit/Spigot
ec402c4974 Improve CreativeCategory conversion
By: md_5 <git@md-5.net>
2022-03-19 09:59:56 +11:00
CraftBukkit/Spigot
16d405ff1c #1034: Fix exception on init of CraftCreativeCategory
By: Parker Hawke <hawkeboyz2@hotmail.com>
2022-03-19 09:59:56 +11:00
CraftBukkit/Spigot
5fce26aed5 Add tests for material creative categories
By: md_5 <git@md-5.net>
2022-03-19 09:59:55 +11:00
CraftBukkit/Spigot
6796896e63 SPIGOT-3034: PlayerKickEvent.setLeaveMessage(String) doesn't actually do anything
By: DerFrZocker <derrieple@gmail.com>
2022-03-16 19:49:07 +11:00
CraftBukkit/Spigot
c46dd07f70 SPIGOT-6963: CraftMetaBlockState#getBlockState applied TileEntity ids without the minecraft namespace prefix.
This was able to cause issues when ItemStacks are being compared.

By: blablubbabc <lukas@wirsindwir.de>
2022-03-15 07:30:53 +11:00
CraftBukkit/Spigot
85cc664060 SPIGOT-6138, SPIGOT-6415: Don't call CreatureSpawnEvent after cross-dimensional travel
By: DerFrZocker <derrieple@gmail.com>
2022-03-13 07:48:22 +11:00
CraftBukkit/Spigot
4703f2b200 SPIGOT-6895: Trees grown with applyBoneMeal() don't fire the StructureGrowthEvent
By: DerFrZocker <derrieple@gmail.com>
2022-03-13 07:47:56 +11:00
CraftBukkit/Spigot
cac50e9c55 SPIGOT-6961: Actually return a copy of the ItemMeta
By: DerFrZocker <derrieple@gmail.com>
2022-03-13 06:58:41 +11:00
CraftBukkit/Spigot
5abfb14c7f Increase outdated build delay
By: md_5 <git@md-5.net>
2022-03-12 10:47:34 +11:00
CraftBukkit/Spigot
a429b2ad16 #1011: Add Item Unlimited Lifetime APIs
By: Gero <gecam59@gmail.com>
2022-03-12 09:26:16 +11:00
CraftBukkit/Spigot
06bac38719 SPIGOT-2942: give command fires PlayerDropItemEvent, cancelling it causes Item Duplication
By: DerFrZocker <derrieple@gmail.com>
2022-03-11 21:47:13 +01:00
CraftBukkit/Spigot
1a135e792f SPIGOT-6962: Call EntityChangeBlockEvent when when FallingBlockEntity starts to fall
By: BlackHole <black-hole@live.com>
2022-03-11 16:24:02 +11:00
CraftBukkit/Spigot
ad484e5f73 SPIGOT-6959: Make /loot command ignore empty items for spawn
By: Doc <nachito94@msn.com>
2022-03-08 07:25:44 +11:00
CraftBukkit/Spigot
adb00c117d #1023: Improve consistency of tag API
By: Doc <nachito94@msn.com>
2022-03-06 16:24:58 +11:00
CraftBukkit/Spigot
390618e170 SPIGOT-6956: Reduce differences caused by setKeepSpawnInMemory(false)
By: md_5 <git@md-5.net>
2022-03-04 18:53:19 +11:00
CraftBukkit/Spigot
33a94c62e0 SPIGOT-6957: Bad default value for WorldCreator#generatorSettings
By: md_5 <git@md-5.net>
2022-03-04 08:15:31 +11:00
CraftBukkit/Spigot
f43d18915d #1022: Fix get HighestBlockAt in chunk snapshot
By: Yannick Lamprecht <yannicklamprecht@live.de>
2022-03-04 08:12:00 +11:00
CraftBukkit/Spigot
a6639b358f #876: Add CreativeCategory API for Materials
By: Parker Hawke <hawkeboyz2@hotmail.com>
2022-03-03 18:55:51 +11:00
CraftBukkit/Spigot
59e5f5af8f SPIGOT-6952: Tag#isTagged throws NullPointerException in 1.18.2
By: DerFrZocker <derrieple@gmail.com>
2022-03-01 21:02:14 +01:00
CraftBukkit/Spigot
9ee989ea81 Update to Minecraft 1.18.2
By: md_5 <git@md-5.net>
2022-03-01 02:00:00 +11:00
CraftBukkit/Spigot
bd40300a4f Remove outdated build delay.
By: md_5 <git@md-5.net>
2022-03-01 02:00:00 +11:00
CraftBukkit/Spigot
2271fc314d SPIGOT-6900, SPIGOT-6330: Make /difficulty command per-world
By: Doc <nachito94@msn.com>
2022-02-21 11:59:30 +11:00
CraftBukkit/Spigot
22136f3a05 SPIGOT-6925: Add minecraft:match_tool in LootContext
By: Doc <nachito94@msn.com>
2022-02-21 10:52:08 +11:00
CraftBukkit/Spigot
8216743085 SPIGOT-6936: Cancelling EntityAirChangeEvent doesn't stop player's bubbles from decreasing client side
By: md_5 <git@md-5.net>
2022-02-20 09:25:32 +11:00
CraftBukkit/Spigot
8d542f0b21 SPIGOT-6937: Ramming goat does not throw EntityTargetLivingEntityEvent
By: md_5 <git@md-5.net>
2022-02-20 09:07:37 +11:00
CraftBukkit/Spigot
c48241fce5 SPIGOT-6934: Bring plugin chunk tickets back in line with forceload tickets
By: md_5 <git@md-5.net>
2022-02-20 08:55:27 +11:00
CraftBukkit/Spigot
7fe2a47414 SPIGOT-6935: Make Arrow color nullable
By: Doc <nachito94@msn.com>
2022-02-19 09:36:08 +11:00
CraftBukkit/Spigot
b9534e1c48 #1009: Add Furnace#getRecipesUsed
By: Doc <nachito94@msn.com>
2022-02-15 18:48:54 +11:00
CraftBukkit/Spigot
77b8e4803a #1010: Add PDC to World
By: DerFrZocker <derrieple@gmail.com>
2022-02-15 09:36:00 +11:00
CraftBukkit/Spigot
80e9699ccf #1012: Always save as skull owner and not as internal data
By: DerFrZocker <derrieple@gmail.com>
2022-02-13 20:52:46 +01:00
CraftBukkit/Spigot
8b46bfaaa2 SPIGOT-6927: Fix default value of spawn-limits in Worlds
By: Doc <nachito94@msn.com>
2022-02-07 18:03:56 -03:00
CraftBukkit/Spigot
314b83ffae SPIGOT-6918: Add SpawnCategory API and configurations for Axolotls
By: Doc <nachito94@msn.com>
2022-02-07 18:47:27 +11:00
CraftBukkit/Spigot
f01afaf08f Don't send updates over large distances
By: md_5 <git@md-5.net>
2022-02-07 08:35:20 +11:00
CraftBukkit/Spigot
765eadbac1 SPIGOT-6782: EntityPortalEvent should not destroy entity when setTo() uses same world as getFrom()
By: DerFrZocker <derrieple@gmail.com>
2022-02-05 18:51:46 +01:00
CraftBukkit/Spigot
08891a2e2f #1002: Add Player Profile API
Slight changes may occur as this API is stabilized.

This PR is based on work previously done by DerFrZocker in #938.

By: blablubbabc <lukas@wirsindwir.de>
2022-02-03 09:25:39 +11:00
CraftBukkit/Spigot
0190fa68f9 Increase outdated build delay
By: md_5 <git@md-5.net>
2022-02-03 08:42:42 +11:00
CraftBukkit/Spigot
9523f87f1c SPIGOT-6917: Use main scoreboard for /trigger
Restores pre-1.13 behaviour. See linked ticket for further discussion.

By: md_5 <git@md-5.net>
2022-02-02 08:59:18 +11:00
CraftBukkit/Spigot
d5e124a72d Clean up callBlockDamageEvent
By: md_5 <git@md-5.net>
2022-02-02 08:56:24 +11:00
CraftBukkit/Spigot
e664c2bf5f SPIGOT-6910: Add BlockDamageAbortEvent
By: FreeSoccerHDX <unconfigured@null.spigotmc.org>
2022-02-02 08:56:23 +11:00
CraftBukkit/Spigot
df76a31fc1 #1000: Add PlayerHideEntityEvent and PlayerShowEntityEvent
By: Gero <gecam59@gmail.com>
2022-02-01 18:01:05 +11:00
CraftBukkit/Spigot
e2b1313f00 #1004: Call WorldInitEvent before any chunks are generated
By: DerFrZocker <derrieple@gmail.com>
2022-02-01 08:13:13 +11:00
CraftBukkit/Spigot
99e0adb83b SPIGOT-6891: Crash when importing 1.16 chunks with entities above the world, when a BlockPopulator is active
By: DerFrZocker <derrieple@gmail.com>
2022-01-30 10:52:42 +11:00
CraftBukkit/Spigot
2fb7e5202f #1003: Fix cancellation of TradeSelectEvent
By: pop4959 <pop4959@gmail.com>
2022-01-29 09:27:01 +11:00
CraftBukkit/Spigot
f46c4e64ea SPIGOT-6890: Add repair cost amount in AnvilInventory
By: Doc <nachito94@msn.com>
2022-01-26 09:30:35 +11:00
CraftBukkit/Spigot
2007d3c69f #999: Prevent non-item cooldowns
By: Doc <nachito94@msn.com>
2022-01-23 11:37:48 -03:00
CraftBukkit/Spigot
b80113b447 SPIGOT-6907: Oxygen does not restore up to value set by LivingEntity#setMaximumAir()
By: DerFrZocker <derrieple@gmail.com>
2022-01-23 09:06:19 +11:00
CraftBukkit/Spigot
cf4feec6b5 SPIGOT-6639: During an EntityDamageEvent with damage from blocks, damaging any entity throws an error
By: DerFrZocker <derrieple@gmail.com>
2022-01-23 09:06:06 +11:00
CraftBukkit/Spigot
a8b86ea421 #994: Fix changing world in portal events not updating used world border
Also clamp the event's target location to the world border

By: Phoenix616 <max@themoep.de>
2022-01-20 18:36:14 +11:00
CraftBukkit/Spigot
c5f623b0ac SPIGOT-6902: (Unsupported) Load server as child of system classloader
This is an _unsupported_ feature and may be removed at a later date

By: md_5 <git@md-5.net>
2022-01-19 08:48:55 +11:00
CraftBukkit/Spigot
474603beb3 SPIGOT-6899: Add Player#getPreviousGameMode
By: Doc <nachito94@msn.com>
2022-01-17 10:12:15 +11:00
CraftBukkit/Spigot
4c024e72f9 SPIGOT-6901: Add Support for Random in methods for LootTable
By: Doc <nachito94@msn.com>
2022-01-17 10:09:52 +11:00
CraftBukkit/Spigot
ce2ac2868b SPIGOT-6888: Add SpawnReason for Vex spawned by Evokers
By: Doc <nachito94@msn.com>
2022-01-14 10:55:59 +11:00
CraftBukkit/Spigot
db38e9a8f5 #987: Add generateTree method with a predicate
By: DerFrZocker <derrieple@gmail.com>
2022-01-12 10:52:51 +11:00
CraftBukkit/Spigot
9b581cce11 #990: Add playSound with Entity as source
By: Gero <gecam59@gmail.com>
2022-01-11 18:53:45 +11:00
CraftBukkit/Spigot
602f8cb433 #989: Add PDC to Structures
By: Martoph <sager1018@gmail.com>
2022-01-07 09:43:05 +11:00
CraftBukkit/Spigot
46f0dde817 SPIGOT-5339, SPIGOT-6252, SPIGOT-6777: Only cancel knockback if the damage event was canceled
By: DerFrZocker <derrieple@gmail.com>
2022-01-03 18:07:01 +01:00
CraftBukkit/Spigot
cc34358a3e SPIGOT-6496: /time functions affect entire server, not just the origin world
By: DerFrZocker <derrieple@gmail.com>
2022-01-03 08:29:31 +11:00
CraftBukkit/Spigot
c0b8deb846 Put Discord rather than IRC in config files
By: md_5 <git@md-5.net>
2022-01-03 08:21:46 +11:00
CraftBukkit/Spigot
f5b1ea90e2 SPIGOT-6278: Persistent piglins count towards mob cap
By: md_5 <git@md-5.net>
2022-01-02 11:45:52 +11:00
CraftBukkit/Spigot
bde37a649c #378: Add API to check and set if horses are grazing hay
By: Matthew <stteg@hotmail.com>
2022-01-01 09:58:04 +11:00
CraftBukkit/Spigot
1fa87773be #374: Add isJohnny / setJohnny for Vindicator
By: Matthew <stteg@hotmail.com>
2022-01-01 09:58:04 +11:00
CraftBukkit/Spigot
179dbe9592 #373: Add trap related methods to SkeletonHorse
By: Matthew <stteg@hotmail.com>
2022-01-01 09:58:04 +11:00
CraftBukkit/Spigot
751a5601b8 Fix map colour not being marked as a handled tag
By: md_5 <git@md-5.net>
2021-12-30 10:14:08 +11:00
CraftBukkit/Spigot
1eaf82a627 Make EnderDragon extend/implement Mob
By: md_5 <git@md-5.net>
2021-12-30 09:35:50 +11:00
CraftBukkit/Spigot
5a3105919b Add self-riding check to Entity#addPassenger
By: md_5 <git@md-5.net>
2021-12-29 10:48:15 +11:00
CraftBukkit/Spigot
7a54f9da31 SPIGOT-5766: The VillagerReplenishTradeEvent is now called when a villager restocks its trades.
By: blablubbabc <lukas@wirsindwir.de>
2021-12-25 10:14:17 +11:00
CraftBukkit/Spigot
aa53cef96f SPIGOT-5627: Leads vanish when transporting leashed entities through a Nether portal
By: DerFrZocker <derrieple@gmail.com>
2021-12-25 09:39:27 +11:00
CraftBukkit/Spigot
23b34c080b #978: Add Material#getDefaultAttributeModifiers
By: coll1234567 <joshl5324@gmail.com>
2021-12-24 12:06:26 +11:00
CraftBukkit/Spigot
28ec7a3566 SPIGOT-6859: PlayerInteractEntityEvent#setCancelled desync with Axolotls
By: Doc <nachito94@msn.com>
2021-12-22 08:04:07 +11:00
CraftBukkit/Spigot
f2766fc611 Dependency upgrades
By: md_5 <git@md-5.net>
2021-12-18 12:12:37 +11:00
CraftBukkit/Spigot
edea21b253 SPIGOT-6789: Improve resource pack related API
By: Patrick Choe <mailpatrickkr@gmail.com>
2021-12-18 11:46:17 +11:00
CraftBukkit/Spigot
3736fd83de SPIGOT-6836: Add more API methods in MerchantRecipe
By: Doc <nachito94@msn.com>
2021-12-18 11:44:34 +11:00
CraftBukkit/Spigot
13aa9b7211 SPIGOT-6778: Block#beakNaturally doesn't drop items in chests
By: DerFrZocker <derrieple@gmail.com>
2021-12-18 11:34:20 +11:00
CraftBukkit/Spigot
96c615d4b8 SPIGOT-6843: Wrong PLAINS biome during custom chunk generation
By: DerFrZocker <derrieple@gmail.com>
2021-12-18 11:33:22 +11:00
CraftBukkit/Spigot
94c2fa1b14 SPIGOT-6852: BlockReceiveGameEvent#getBlock returning wrong block
By: md_5 <git@md-5.net>
2021-12-14 07:52:43 +11:00
CraftBukkit/Spigot
ef17571a38 SPIGOT-6851: removeRecipe not unregistering recipe ID
By: md_5 <git@md-5.net>
2021-12-13 11:25:22 +11:00
CraftBukkit/Spigot
667cb32115 Update to Minecraft 1.18.1
By: md_5 <git@md-5.net>
2021-12-11 00:11:02 +11:00
CraftBukkit/Spigot
aa726a99dc Remove outdated build delay.
By: md_5 <git@md-5.net>
2021-12-11 00:11:02 +11:00
CraftBukkit/Spigot
9f768b5caf SPIGOT-6840: Fire resistance potion effect does not prevent melt damage of snow golem
By: Doc <nachito94@msn.com>
2021-12-10 09:01:47 +11:00
CraftBukkit/Spigot
6b9458a6a7 Disable log4j message formatting
By: md_5 <git@md-5.net>
2021-12-10 07:31:27 +11:00
CraftBukkit/Spigot
4d40ab4eec Increase outdated build delay
By: md_5 <git@md-5.net>
2021-12-09 16:02:04 +11:00
CraftBukkit/Spigot
35fdc9103d SPIGOT-6831: Fix llama strength crash
By: md_5 <git@md-5.net>
2021-12-06 15:15:09 +11:00
CraftBukkit/Spigot
24b8f3c641 #971: Remove strong chunk reference in PDC
A previous fix for SPIGOT-6814 implemented a callback function for the
PDC implementation that could be set to actively define a chunk as
unsaved, allowing chunks that have not been mutated through block
changes to still require saving if the chunks pdc was mutated.

This implementation however would pass a callback that references the
chunk access internally, meaning the PDC now actively holds onto a
callback that holds a reference to the entire chunk.

Aditionally, this change also impacted the pdc for item metas and
entities for really no reason whatsoever.

This commit re-implements the fix by introducing a new child of the pdc
implementation that the chunk now uses as its pdc. This specific
implementation maintains a dirty flag that is set to `true` on any form
of mutation and set back to false by the chunk that owns the PDC
whenever the chunk itself is flag as no longer dirty.

By: Bjarne Koll <lynxplay101@gmail.com>
2021-12-05 08:52:51 +11:00
CraftBukkit/Spigot
14215fdadd Add Player#openSign API to edit a placed sign
By: md_5 <git@md-5.net>
2021-12-05 08:34:54 +11:00
CraftBukkit/Spigot
6646c417c5 Purge hidden entities on unload too
By: md_5 <git@md-5.net>
2021-12-04 08:23:26 +11:00
CraftBukkit/Spigot
4f6a5feac8 #967: Store last lava contact location for events
By: Rafael S. M. Santos <eu@rafaelsms.com>
2021-12-04 08:06:32 +11:00
CraftBukkit/Spigot
77f4cb35ff SPIGOT-6833: Do not drop items into unrestricted world during world generation
By: md_5 <git@md-5.net>
2021-12-04 07:19:56 +11:00
CraftBukkit/Spigot
d07de3d840 Fix when bundler directory is a symlink
By: md_5 <git@md-5.net>
2021-12-03 16:24:34 +11:00
CraftBukkit/Spigot
05d379a339 Release POIs when villagers are removed by plugins
By: md_5 <git@md-5.net>
2021-12-03 15:05:20 +11:00
CraftBukkit/Spigot
ea74321d65 SPIGOT-6823: Fix loading custom world in combination with superflat
By: md_5 <git@md-5.net>
2021-12-03 08:34:38 +11:00
CraftBukkit/Spigot
215251ce7b #970: Correct typo in README.md
By: Ryan Redmon <iroleplay55@gmail.com>
2021-12-03 07:35:26 +11:00
CraftBukkit/Spigot
9f2d553877 Fix per-world worldborder command
By: md_5 <git@md-5.net>
2021-12-03 07:34:39 +11:00
CraftBukkit/Spigot
ee342addea Better preserve broken PlayerMoveEvent behaviour
By: md_5 <git@md-5.net>
2021-12-02 12:45:58 +11:00
CraftBukkit/Spigot
7dd6dfc7a4 SPIGOT-6828: <player> fell off a ladder/vines death message not supported
By: md_5 <git@md-5.net>
2021-12-02 12:29:35 +11:00
CraftBukkit/Spigot
a0201b0f02 SPIGOT-6795: Fix BlockFertilizeEvent not being triggered for Azaleas
By: Rafael S. M. Santos <eu@rafaelsms.com>
2021-12-01 08:27:58 +11:00
CraftBukkit/Spigot
cc70f18bef SPIGOT-6820: VillagerCareerChangeEvent's ChangeReason is sometimes incorrect
By: Doc <nachito94@msn.com>
2021-12-01 08:26:14 +11:00
CraftBukkit/Spigot
2492a39911 Update to Minecraft 1.18
By: md_5 <git@md-5.net>
2021-12-01 03:00:00 +11:00
CraftBukkit/Spigot
4dbb83e45d SPIGOT-6817: Revert back to old block state behaviour again
By: md_5 <git@md-5.net>
2021-11-29 11:03:16 +11:00
CraftBukkit/Spigot
6b0484122e SPIGOT-6814: (Chunk) PersistentData is lost after restart
By: DerFrZocker <derrieple@gmail.com>
2021-11-29 09:28:19 +11:00
CraftBukkit/Spigot
95ab0e27a8 Add hideEntity / showEntity API
By: md_5 <git@md-5.net>
2021-11-29 09:18:52 +11:00
CraftBukkit/Spigot
4e0070d822 Move checkstyle to slightly later compile phase
By: md_5 <git@md-5.net>
2021-11-29 08:56:33 +11:00
CraftBukkit/Spigot
f734d4eaf6 SPIGOT-6816: Fix ChunkSnapshot#getBiome
By: md_5 <git@md-5.net>
2021-11-29 08:52:41 +11:00
CraftBukkit/Spigot
62b59aece9 #959: Fix World#refreshChunk
By: Gero <gecam59@gmail.com>
2021-11-28 11:54:00 +11:00
CraftBukkit/Spigot
e55f7f5dc4 #962: Make PotionEffectType implement Keyed
By: coll1234567 <joshl5324@gmail.com>
2021-11-28 11:49:42 +11:00
CraftBukkit/Spigot
4b8394a81b SPIGOT-6810: Improve / fix biome setting code
By: md_5 <git@md-5.net>
2021-11-27 16:42:28 +11:00
CraftBukkit/Spigot
27643e5df2 Update to Minecraft 1.18-rc3
By: md_5 <git@md-5.net>
2021-11-27 08:00:00 +11:00
CraftBukkit/Spigot
96d5854b53 #960: Add Player#showDemoScreen
By: coll1234567 <joshl5324@gmail.com>
2021-11-26 10:13:36 +11:00
CraftBukkit/Spigot
ffdf8aeecf Produce remapped jars after bootstrap jar
By: md_5 <git@md-5.net>
2021-11-26 09:41:18 +11:00
CraftBukkit/Spigot
1618dd945f SPIGOT-6808: Fix RegionAccessor#getBiome
By: md_5 <git@md-5.net>
2021-11-25 17:04:58 +11:00
CraftBukkit/Spigot
799bfc92e2 Update to Minecraft 1.18-pre8
By: md_5 <git@md-5.net>
2021-11-25 08:00:00 +11:00
CraftBukkit/Spigot
0d839e926c Fix crash with composters
By: md_5 <git@md-5.net>
2021-11-24 09:33:28 +11:00
CraftBukkit/Spigot
f3b1f97464 Remove unnecessary CraftBlock creation in CraftRegionAccessor#setBlock
By: md_5 <git@md-5.net>
2021-11-24 08:16:10 +11:00
CraftBukkit/Spigot
2a6e33ffed Generate bootstrap jar separately
By: md_5 <git@md-5.net>
2021-11-24 07:45:54 +11:00
CraftBukkit/Spigot
34c3a49371 SPIGOT-6803: Fix ServerPing not using the new logic for show players in 1.18
By: Doc <nachito94@msn.com>
2021-11-24 07:28:22 +11:00
CraftBukkit/Spigot
c8802f0a64 Fix upgrading worlds with custom generators
By: md_5 <git@md-5.net>
2021-11-23 20:00:10 +11:00
CraftBukkit/Spigot
731158e521 SPIGOT-6781: Add Block#canPlace
By: coll1234567 <joshl5324@gmail.com>
2021-11-23 18:49:13 +11:00
CraftBukkit/Spigot
3e7bd2643c Improve multi-dimension code
By: md_5 <git@md-5.net>
2021-11-23 18:39:43 +11:00
CraftBukkit/Spigot
820ad30036 SPIGOT-6802: Fix major issues with --forceUpgrade
More to come

By: md_5 <git@md-5.net>
2021-11-23 17:13:52 +11:00
CraftBukkit/Spigot
90f6dfa935 Fix loading / creating secondary worlds (nether/end)
By: md_5 <git@md-5.net>
2021-11-23 15:03:34 +11:00
CraftBukkit/Spigot
33d40b06c2 #956: Add getHideOnlinePlayers
By: Doc <nachito94@msn.com>
2021-11-22 22:29:50 -03:00
CraftBukkit/Spigot
6992843028 Fix serializing unhandled NBT + add unit test with unhandled NBT
By: md_5 <git@md-5.net>
2021-11-23 12:35:42 +11:00
CraftBukkit/Spigot
683f54a1e7 #954: Add "Allow Server Listings" API
By: Noah van der Aa <ndvdaa@gmail.com>
2021-11-23 08:56:35 +11:00
CraftBukkit/Spigot
e3c01e2bf0 #955: Add test for BlockData class of Material
By: BlackHole <black-hole@live.com>
2021-11-23 08:07:10 +11:00
CraftBukkit/Spigot
0e36e68e8b Downgrade to Checkstyle 8.x as 9.x series has much larger memory usage
By: md_5 <git@md-5.net>
2021-11-22 15:27:14 +11:00
CraftBukkit/Spigot
ba1c4ea9b7 Remove Player#sendChunkChange
Method is specified according to an obsolete internal format and has not been implemented for nearly 10 years.

By: md_5 <git@md-5.net>
2021-11-22 15:08:57 +11:00
CraftBukkit/Spigot
df75572760 #953: Add Player#sendEquipmentChange
By: Parker Hawke <hawkeboyz2@hotmail.com>
2021-11-22 15:03:21 +11:00
CraftBukkit/Spigot
a10c0a6823 Correct displayed Java version in warning
By: md_5 <git@md-5.net>
2021-11-22 11:47:01 +11:00
CraftBukkit/Spigot
43702a9e10 Update to Minecraft 1.18-pre5
By: md_5 <git@md-5.net>
2021-11-22 09:00:00 +11:00
CraftBukkit/Spigot
a852b81a69 Remove outdated build delay.
By: md_5 <git@md-5.net>
2021-11-22 09:00:00 +11:00
CraftBukkit/Spigot
306648dc4c SPIGOT-6797: EntityInteractEvent called with incorrect location
By: md_5 <git@md-5.net>
2021-11-21 11:22:07 +11:00
CraftBukkit/Spigot
99916e6058 SPIGOT-6798: EntityChangeBlockEvent called with incorrect location
By: md_5 <git@md-5.net>
2021-11-21 11:18:06 +11:00
CraftBukkit/Spigot
68ead41759 SPIGOT-6790: Mimic structure block behaviour and do not save STRUCTURE_VOID
By: md_5 <git@md-5.net>
2021-11-11 18:40:15 +11:00
CraftBukkit/Spigot
e4cce46e63 SPIGOT-6436: Add Player#stopAllSounds
By: Doc <nachito94@msn.com>
2021-11-05 21:02:22 +11:00
CraftBukkit/Spigot
148964d14e SPIGOT-6783: Items do not appear in custom anvil inventories
By: md_5 <git@md-5.net>
2021-11-04 18:17:58 +11:00
CraftBukkit/Spigot
fda316b6eb SPIGOT-6779: Fix LivingEntity#attack for Player entities
By: Doc <nachito94@msn.com>
2021-11-02 18:33:35 +11:00
CraftBukkit/Spigot
9e3a0e859f SPIGOT-6772: Use entity mailbox and re-schedule entities if they get unloaded
By: DerFrZocker <derrieple@gmail.com>
2021-11-01 18:54:44 +11:00
CraftBukkit/Spigot
1f5735df63 #947: Add missing spawn eggs for SpawnEggMeta
By: Doc <nachito94@msn.com>
2021-10-30 18:34:04 +11:00
CraftBukkit/Spigot
a2a88c50af #945: Allow setting BrewEvent results
By: Doc <nachito94@msn.com>
2021-10-30 18:16:35 +11:00
CraftBukkit/Spigot
0136af37a5 SPIGOT-6768: Remove upper bound on setFreezeTicks
By: md_5 <git@md-5.net>
2021-10-23 18:29:53 +11:00
CraftBukkit/Spigot
ab1a1deb6b SPIGOT-5988: Bedspawn doesn't clear after dying when spawn is blocked
By: DerFrZocker <derrieple@gmail.com>
2021-10-16 19:39:14 +11:00
CraftBukkit/Spigot
ea404e3d82 SPIGOT-6758: Reset ItemSign#openSign when aborting the block placement early
By: blablubbabc <lukas@wirsindwir.de>
2021-10-16 18:48:22 +11:00
CraftBukkit/Spigot
55f4d6c7cb SPIGOT-6760: Chest#getInventory only returns one half of a double chest when one or both halves are blocked
By: md_5 <git@md-5.net>
2021-10-16 18:48:21 +11:00
CraftBukkit/Spigot
02cdd23003 SPIGOT-6759: Chest#getInventory() no longer returns double chest inventories
By: blablubbabc <lukas@wirsindwir.de>
2021-10-16 18:48:21 +11:00
CraftBukkit/Spigot
f9c1420daf #940: Fixed a NPE during CraftBlockEntityState#update.
When the BlockState's block type was changed, #update may have removed
the TileEntity, causing #isApplicable to fail with a NPE.

By: blablubbabc <lukas@wirsindwir.de>
2021-10-15 18:03:01 +11:00
CraftBukkit/Spigot
571ec764a6 #937: Fixes related to unplaced BlockStates and the recent world generation changes.
* CraftBlockState#getWorldHandle() would previously run into a NPE when being invoked for a non-placed BlockState. It now returns null in this case.
* CraftChest#getInventory() would previously encounter this NPE when being called for a non-placed BlockState. It will now automatically forward the call to #getBlockInventory() when it is being called for either a non-placed BlockState, or during world generation.
* CraftStructureBlock#applyTo was able to run into a NPE when being called for non-placed BlockStates (this is for example called by #getSnapshotNBT()).
* Replaced all no-world-generation preconditions with a general 'ensureNoWorldGeneration' method.
* Removed a few superfluous #isPlaced() calls. If getWorldHandle() reutrns a World, this already implies that the BlockState is placed.

By: blablubbabc <lukas@wirsindwir.de>
2021-10-10 07:55:53 +11:00
CraftBukkit/Spigot
82e8261d70 SPIGOT-6754: We ignore any still present TileEntity now when we create a BlockState for a block of type AIR.
During block destruction, the type of the block may already have been set to AIR while the TileEntity has not yet been removed.
Also, TileEntity#getOwner() skips the whole BlockState construction now if the block is of type AIR.

This removes the previous workaround again of returning a dummy CraftBlockEntityState in this case.

By: blablubbabc <lukas@wirsindwir.de>
2021-10-10 07:55:53 +11:00
CraftBukkit/Spigot
e9ecd12983 SPIGOT-6754: Temporarily restore previous behaviour for tile entities with removed blocks
By: md_5 <git@md-5.net>
2021-10-09 16:29:58 +11:00
CraftBukkit/Spigot
188d3b23d0 SPIGOT-2903: Add Structure API
By: Sander Knauff <sanderknauff@hotmail.com>
2021-10-05 11:56:35 +11:00
CraftBukkit/Spigot
2d0a775210 #934: Support for configuring Water Underground Creatures spawn settings
By: Doc <nachito94@msn.com>
2021-10-05 11:29:52 +11:00
CraftBukkit/Spigot
f27c8f74f8 #877: Improve and simplify CraftBlockState
By: blablubbabc <lukas@wirsindwir.de>
2021-09-29 18:56:16 +10:00
CraftBukkit/Spigot
65625f410c SPIGOT-6741: shouldGenerateStructures isn't implemented
By: DerFrZocker <derrieple@gmail.com>
2021-09-28 17:52:29 +02:00
CraftBukkit/Spigot
50d4716e9f SPIGOT-6023, SPIGOT-6745: Fix missing BlockDispenseArmorEvents
By: Lars Dormans <lars.dormans@live.nl>
2021-09-26 00:24:33 +02:00
CraftBukkit/Spigot
52c2d5beaf SPIGOT-6738: Add entity type tags
By: md_5 <git@md-5.net>
2021-09-19 14:51:21 +10:00
CraftBukkit/Spigot
4495b9ec5b SPIGOT-6249: Add Missing Effect Constants
By: DerFrZocker <derrieple@gmail.com>
2021-09-11 18:40:14 +10:00
CraftBukkit/Spigot
4d34ac117b SPIGOT-6731: "Nag author" message in CraftServer lists one author only
By: md_5 <git@md-5.net>
2021-09-10 17:49:53 +10:00
CraftBukkit/Spigot
e5b39016a0 SPIGOT-5732, SPIGOT-6387: Overhaul Hanging entities
- SPIGOT-5732: Fix issue with spawning leash hitches and painting, by using the right block faces

- SPIGOT-6387: Allow hanging entities to be spawned mid air

- Use randomize parameter to determine if a random painting should be chosen or not

- Return BlockFace self by leash hitches entity

- Throw a standardised exception when trying to set a BlockFace to a hanging entity which the entity does not support, instead of using BlockFace south or throwing a null pointer

By: DerFrZocker <derrieple@gmail.com>
2021-09-10 17:45:31 +10:00
CraftBukkit/Spigot
b4da42047a #929: Call EntityBlockFormEvent for Wither Rose placed by dead entity
By: Doc <nachito94@msn.com>
2021-09-06 18:57:16 +10:00
CraftBukkit/Spigot
fcb8ac59ec SPIGOT-6729: Add Chunk.isEntitiesLoaded()
By: Brokkonaut <hannos17@gmx.de>
2021-09-06 18:51:39 +10:00
CraftBukkit/Spigot
77dcaefa51 SPIGOT-6708: Fix Experience Orb value not being updated in mend event
By: Phoenix616 <max@themoep.de>
2021-09-03 18:37:44 +10:00
CraftBukkit/Spigot
9d22657139 Rebuild patch
By: md_5 <git@md-5.net>
2021-09-01 19:02:09 +10:00
CraftBukkit/Spigot
5c075d59dc SPIGOT-6547: Chunk#getEntities() doesn't return all entities immediately after chunk load
By: DerFrZocker <derrieple@gmail.com>
2021-09-01 18:55:18 +10:00
CraftBukkit/Spigot
768b5d52aa SPIGOT-6719: Add getTileEntities() to LimitedRegion
By: DerFrZocker <derrieple@gmail.com>
2021-08-30 18:44:44 +10:00
CraftBukkit/Spigot
1dfe698f4f SPIGOT-6726: NPE when calling getBossBar() on plugin spawned EnderDragon
By: Brokkonaut <hannos17@gmx.de>
2021-08-28 19:02:19 +10:00
CraftBukkit/Spigot
08e5ad2b2f SPIGOT-6720: Fix bed explosion checks
By: Doc <nachito94@msn.com>
2021-08-27 19:17:43 +10:00
CraftBukkit/Spigot
c8ef43f1b5 SPIGOT-6722: Close entity manager when unloading world
By: DerFrZocker <derrieple@gmail.com>
2021-08-27 19:14:09 +10:00
CraftBukkit/Spigot
dd503b542b SPIGOT-6686: Changes in MaximumRepairCost for Anvil Rename cause inconsistency
By: DerFrZocker <derrieple@gmail.com>
2021-08-27 19:14:09 +10:00
CraftBukkit/Spigot
8a60b49a31 SPIGOT-6630: Replacing an enchantment on an item creates a conflict error
By: DerFrZocker <derrieple@gmail.com>
2021-08-24 18:10:30 +02:00
CraftBukkit/Spigot
44cc499340 Fix issues with new ChunkGenerator API
- RegionAccessor#setType / RegionAccessor#setBlockData doesn't run entity removal logic
- RegionAccessor#generateTree crashes by bee nest (TreeType#TALL_BIRCH)

By: DerFrZocker <derrieple@gmail.com>
2021-08-22 13:23:40 +02:00
CraftBukkit/Spigot
80b1ef0c8e SPIGOT-6697: Restore generateTree with BlockChangeDelegate behaviour
By: md_5 <git@md-5.net>
2021-08-22 18:12:59 +10:00
CraftBukkit/Spigot
49c30227d2 Rebuild patch
By: md_5 <git@md-5.net>
2021-08-22 18:07:39 +10:00
CraftBukkit/Spigot
00c0964347 SPIGOT-6713: Cancelling EntityTransformEvent Causes Deceased Slimes To Not Despawn
By: md_5 <git@md-5.net>
2021-08-22 18:07:31 +10:00
CraftBukkit/Spigot
9c5dd3b837 SPIGOT-6716: Preserve the order of stored enchantments of enchanted books.
In some cases, differences in this order can result in item stack
comparisons to fails.

By: blablubbabc <lukas@wirsindwir.de>
2021-08-20 19:40:31 +10:00
CraftBukkit/Spigot
973f763605 #914: Add World#spawn with randomizeData parameter
The current implementation of World#spawn or World#spawnEntity
respectively, always prepares/finalizes the spawn of every entity
spawned through the API. While this is great to simulate natural
spawning of entities in the world through the API, it fails at
reliably creating default entities for purposes other than vanilla
gameplay.

While the caller of the API could attempt to undo all of the
customization that is applied in the prepare/finalization step, they are
numerous (reaching from sheep colour to equipment) and in some cases,
such as the chicken jockey, even spawn in other entities.

Hence this commit introduces a new overload to the World#spawn and
World#spawnEntity methods that accepts the 'randomizeData' parameter
that, when set to false, skips the prior mentioned
preparation/finalization step.

By: Bjarne Koll <lynxplay101@gmail.com>
2021-08-18 18:04:53 +10:00
CraftBukkit/Spigot
03aecfb428 SPIGOT-6714: Don't fire PlayerBucketEvent when empty
By: Noah van der Aa <ndvdaa@gmail.com>
2021-08-18 17:06:40 +10:00
CraftBukkit/Spigot
3a23c54a91 Fix server crash with BlockPopulator when entities are at a negative chunk border
By: DerFrZocker <derrieple@gmail.com>
2021-08-16 07:07:13 +02:00
CraftBukkit/Spigot
c2e4e91b1b SPIGOT-5880, SPIGOT-5567: New ChunkGenerator API
## **Current API**
The current world generation API is very old and limited when you want to make more complex world generation. Resulting in some hard to fix bugs such as that you cannot modify blocks outside the chunk in the BlockPopulator (which should and was per the docs possible), or strange behavior such as SPIGOT-5880.

## **New API**
With the new API, the generation is more separate in multiple methods and is more in line with Vanilla chunk generation. The new API is designed to as future proof as possible. If for example a new generation step is added it can easily also be added as a step in API by simply creating the method for it. On the other side if a generation step gets removed, the method can easily be called after another, which is the case with surface and bedrock. The new API and changes are also fully backwards compatible with old chunk generators.

### **Changes in the new api**
**Extra generation steps:**
Noise, surface, bedrock and caves are added as steps. With those generation steps three extra methods for Vanilla generation are also added. Those new methods provide the ChunkData instead of returning one. The reason for this is, that the ChunkData is now backed by a ChunkAccess. With this, each step has the information of the step before and the Vanilla information (if chosen by setting a 'should' method to true). The old method is deprecated.

**New class BiomeProvider**
The BiomeProvider acts as Biome source and wrapper for the NMS class WorldChunkManager. With this the underlying Vanilla ChunkGeneration knows which Biome to use for the structure and decoration generation. (Fixes: SPIGOT-5880). Although the List of Biomes which is required in BiomeProvider, is currently not much in use in Vanilla, I decided to add it to future proof the API when it may be required in later versions of Minecraft.
The BiomeProvider is also separated from the ChunkGenerator for plugins which only want to change the biome map, such as single Biome worlds or if some biomes should be more present than others.

**Deprecated isParallelCapable**
Mojang has and is pushing to a more multi threaded chunk generation. This should also be the case for custom chunk generators. This is why the new API only supports multi threaded generation. This does not affect the old API, which is still checking this.

**Base height method added**
This method was added to also bring the Minecraft generator and Bukkit generator more in line. With this it is possible to return the max height of a location (before decorations). This is useful to let most structures know were to place them. This fixes SPIGOT-5567. (This fixes not all structures placement, desert pyramids for example are still way up at y-level 64, This however is more a vanilla bug and should be fixed at Mojangs end).

**WorldInfo Class**
The World object was swapped for a WorldInfo object. This is because many methods of the World object won't work during world generation and would mostly likely result in a deadlock. It contains any information a plugin should need to identify the world.

**BlockPopulator Changes**
Instead of directly manipulating a chunk, changes are now made to a new class LimitedRegion, this class provides methods to populated the chunk and its surrounding area. The wrapping is done so that the population can be moved into the place where Minecraft generates decorations. Where there is no chunk to access yet. By moving it into this place the generation is now async and the surrounding area of the chunk can also be used.

For common methods between the World and LimitedRegion a RegionAccessor was added.

By: DerFrZocker <derrieple@gmail.com>
2021-08-15 08:08:16 +10:00
CraftBukkit/Spigot
fdefaeeccd Update ASM and add support for Java 17
By: md_5 <git@md-5.net>
2021-08-13 08:45:32 +10:00
CraftBukkit/Spigot
3483bd08b3 #913: Handle campfire damage with EntityDamageByBlockEvent
By: Doc <nachito94@msn.com>
2021-08-11 19:05:08 +10:00
CraftBukkit/Spigot
6d08059769 Add dimension setting getters to World
By: Doc <nachito94@msn.com>
2021-08-11 18:57:16 +10:00
CraftBukkit/Spigot
72591f6038 SPIGOT-2222, SPIGOT-6687: Pre-set keepLevel and only use it
By: DerFrZocker <derrieple@gmail.com>
2021-08-11 18:49:49 +10:00
CraftBukkit/Spigot
4a49f6bf8b SPIGOT-6692: Add sendSignChange overload with a hasGlowingText parameter
By: Brokkonaut <hannos17@gmx.de>
2021-08-05 08:43:03 +10:00
CraftBukkit/Spigot
4beaa19a39 SPIGOT-6682: Blocking with shield not reset after die
By: DerFrZocker <derrieple@gmail.com>
2021-08-04 17:09:09 +10:00
CraftBukkit/Spigot
aab97ffee0 SPIGOT-6220: Structures in the world with custom generator not work
By: DerFrZocker <derrieple@gmail.com>
2021-08-01 08:26:30 +10:00
CraftBukkit/Spigot
fa9a064a7d Increase outdated build delay
By: md_5 <git@md-5.net>
2021-07-30 19:11:09 +10:00
CraftBukkit/Spigot
87f8ab3fb3 SPIGOT-6552: Some inventory types reset cursor on switch
By: DerFrZocker <derrieple@gmail.com>
2021-07-30 19:08:43 +10:00
CraftBukkit/Spigot
af0d8b70df SPIGOT-6678: ChunkSnapshot#isSectionEmpty() not working as intended.
By: DerFrZocker <derrieple@gmail.com>
2021-07-27 18:07:14 +10:00
CraftBukkit/Spigot
eda6555bbf #901: Fix PlayerStatisticIncrementEvent spam
By: Mitchell Sulkowski <mitchellsulkowski@gmail.com>
2021-07-26 19:32:51 +10:00
CraftBukkit/Spigot
e4b545e047 Only remove tile entity if block type changes
By: md_5 <git@md-5.net>
2021-07-24 07:55:52 +10:00
CraftBukkit/Spigot
353c9f5090 SPIGOT-1753: ChunkGenerator lighting updates
By: DerFrZocker <derrieple@gmail.com>
2021-07-23 16:43:53 +10:00
CraftBukkit/Spigot
f294d260b8 SPIGOT-6666: NPE when deserializing bundle
By: md_5 <git@md-5.net>
2021-07-23 16:38:51 +10:00
CraftBukkit/Spigot
dcfc8b355a SPIGOT-6669: Shearing a Mooshroom does not fire EntityDropItemEvent
By: md_5 <git@md-5.net>
2021-07-23 16:36:16 +10:00
CraftBukkit/Spigot
999bd6c0ef SPIGOT-6667: /schedule function not working correctly in other dimensions
By: DerFrZocker <derrieple@gmail.com>
2021-07-23 16:29:04 +10:00
CraftBukkit/Spigot
9273a60cdb SPIGOT-6665: Shearing a Snowman does not drop a carved pumpkin
By: md_5 <git@md-5.net>
2021-07-22 17:51:53 +10:00
CraftBukkit/Spigot
93f615157d #893: Add Crafting methods to API
By: James Peters <jameslfc19@gmail.com>
2021-07-22 11:35:48 +10:00
CraftBukkit/Spigot
0376264d06 Fix missing varargs from previous commit
By: md_5 <git@md-5.net>
2021-07-22 11:30:14 +10:00
CraftBukkit/Spigot
bacb1b57f1 SPIGOT-6641: Use varargs in sendMessage
By: md_5 <git@md-5.net>
2021-07-22 09:54:57 +10:00
CraftBukkit/Spigot
2ccd460e09 SPIGOT-6663: Chicken Jockeys chickens don't despawn
By: md_5 <git@md-5.net>
2021-07-22 09:53:26 +10:00
CraftBukkit/Spigot
bfc74e8628 SPIGOT-6545: Unable to set Guardian target via API while awareness is disabled
By: DerFrZocker <derrieple@gmail.com>
2021-07-22 09:36:54 +10:00
CraftBukkit/Spigot
0474cc8833 SPIGOT-6369: Add ItemStack to HangingPlaceEvent
By: DerFrZocker <derrieple@gmail.com>
2021-07-21 09:32:54 +10:00
CraftBukkit/Spigot
8650786dad SPIGOT-6645: Call EntityChangeBlockEvent before PlayerHarvestBlockEvent
By: Brokkonaut <hannos17@gmx.de>
2021-07-19 18:54:13 +10:00
CraftBukkit/Spigot
1e8509d8ef SPIGOT-3725, SPIGOT-6638, MC-136917: Properly clear tile entities before replacing
By: DerFrZocker <derrieple@gmail.com>
2021-07-19 18:49:27 +10:00
CraftBukkit/Spigot
fd8748b4bd SPIGOT-6657: Add getPlayer to SheepDyeWoolEvent
By: md_5 <git@md-5.net>
2021-07-18 11:08:18 +10:00
CraftBukkit/Spigot
5eb7a2ed61 SPIGOT-6656: CauldronLevelChangeEvent is not fired correctly when dripstone fills the cauldron
By: md_5 <git@md-5.net>
2021-07-18 10:14:55 +10:00
CraftBukkit/Spigot
59f5a7ab59 SPIGOT-6653: Canceling snow bucket placement removes snow from bucket
By: md_5 <git@md-5.net>
2021-07-18 10:06:38 +10:00
CraftBukkit/Spigot
71d4016a4d #891: Fix scheduler task ID overflow and duplication issues
By: Phoenix616 <max@themoep.de>
2021-07-17 11:39:56 +10:00
CraftBukkit/Spigot
96ffc08c35 #874: Add FurnaceStartSmeltEvent
By: Rabbitual <38820203+Rabbitual@users.noreply.github.com>
2021-07-17 11:19:51 +10:00
CraftBukkit/Spigot
215fa0caef SPIGOT-6649: Call BlockFadeEvent when Nylium fades to Netherrack
By: Brokkonaut <hannos17@gmx.de>
2021-07-15 20:29:38 +10:00
CraftBukkit/Spigot
c1484dc4b1 #890: Include yaw in player's spawn location
By: Phoenix616 <max@themoep.de>
2021-07-15 20:29:38 +10:00
CraftBukkit/Spigot
96eed49699 #889: Fix CraftChest close() sound being replaced with open sound.
By: James Peters <jameslfc19@gmail.com>
2021-07-15 20:29:38 +10:00
CraftBukkit/Spigot
a061943cac SPIGOT-5561: Warning in logs when changing a Mob Spawner to Air on chunk load
By: DerFrZocker <derrieple@gmail.com>
2021-07-13 19:22:27 +10:00
CraftBukkit/Spigot
e797fdd58a #886: Add new Causes for LightningStrikeEvent
By: Doc <nachito94@msn.com>
2021-07-13 19:16:36 +10:00
CraftBukkit/Spigot
18a453f567 SPIGOT-6637: Revert "#874: Add FurnaceStartSmeltEvent"
This reverts commit 38faf28378.

By: md_5 <git@md-5.net>
2021-07-11 12:26:27 +10:00
CraftBukkit/Spigot
cae78fadd8 SPIGOT-6579: DragonFireBall movement with setDirection jumps around a lot
By: DerFrZocker <derrieple@gmail.com>
2021-07-11 09:34:35 +10:00
CraftBukkit/Spigot
81ee774c37 SPIGOT-6623: Missing API reasons for entity freezing
By: Doc <nachito94@msn.com>
2021-07-11 09:32:27 +10:00
CraftBukkit/Spigot
38faf28378 #874: Add FurnaceStartSmeltEvent
By: Rabbitual <38820203+rabbitual@users.noreply.github.com>
2021-07-11 09:26:46 +10:00
CraftBukkit/Spigot
413825611f SPIGOT-5560, SPIGOT-6574, SPIGOT-6632: Remove no longer needed tile entity fix
By: DerFrZocker <derrieple@gmail.com>
2021-07-11 09:05:59 +10:00
CraftBukkit/Spigot
02134e4ee6 SPIGOT-6634: Override needed method
By: DerFrZocker <derrieple@gmail.com>
2021-07-09 23:48:16 +10:00
CraftBukkit/Spigot
0a1df9ec02 SPIGOT-6624: Explosions do not destroy blocks out of vanilla heights in custom dimensions
By: dYens <dani_raiders@hotmail.com>
2021-07-07 07:27:16 +10:00
CraftBukkit/Spigot
e8c9836ec9 Update to Minecraft 1.17.1
By: md_5 <git@md-5.net>
2021-07-07 00:00:00 +10:00
CraftBukkit/Spigot
0392f45e9c Remove outdated build delay.
By: md_5 <git@md-5.net>
2021-07-06 22:16:50 +10:00
CraftBukkit/Spigot
0c2fdaf521 SPIGOT-6527: Add AxolotlBucketMeta
By: Doc <nachito94@msn.com>
2021-07-04 09:32:25 +10:00
CraftBukkit/Spigot
917e89ed06 SPIGOT-5710: POI data mismatch when cancelling BlockPlaceEvent for villager workstations
By: DerFrZocker <derrieple@gmail.com>
2021-07-03 15:39:52 +10:00
CraftBukkit/Spigot
a388fc3a6c Update Maven plugins
By: md_5 <git@md-5.net>
2021-07-03 11:06:33 +10:00
CraftBukkit/Spigot
bc5ed0e911 SPIGOT-6616: Cancellable StriderTemperatureChangeEvent
By: md_5 <git@md-5.net>
2021-07-03 09:36:51 +10:00
CraftBukkit/Spigot
fec9294c47 SPIGOT-6615 Fix Glow Item Frame to use EntityTagMeta
By: Doc <nachito94@msn.com>
2021-07-03 09:33:04 +10:00
CraftBukkit/Spigot
5e5d47856a SPIGOT-6596: Remove redundant code
By: md_5 <git@md-5.net>
2021-06-30 19:29:17 +10:00
CraftBukkit/Spigot
bfa7716ca1 SPIGOT-6613: Missing BlockIgniteEvent for candles + projectiles
By: md_5 <git@md-5.net>
2021-06-30 18:56:27 +10:00
CraftBukkit/Spigot
80472fd082 SPIGOT-6605: Add method to access value of enforce-whitelist
By: md_5 <git@md-5.net>
2021-06-26 09:58:34 +10:00
CraftBukkit/Spigot
ae7ed4667b SPIGOT-6594: NPE at Bukkit.getServer().getGenerateStructures()
By: md_5 <git@md-5.net>
2021-06-24 08:37:58 +10:00
CraftBukkit/Spigot
a91dc63398 #872: SculkSensor accesses underlying TileEntity instead of snapshot for vibration frequency.
By: blablubbabc <lukas@wirsindwir.de>
2021-06-23 09:02:10 +10:00
CraftBukkit/Spigot
26fd70263e SPIGOT-6592: Tile entities in custom ChunkGenerator causes crash
By: md_5 <git@md-5.net>
2021-06-21 08:46:23 +10:00
CraftBukkit/Spigot
46a09d53f1 #870: Add isTrusting/setTrusting to CraftOcelot.
By: Ibrahim Ansari <ansari.ibrahim1@gmail.com>
2021-06-21 08:40:43 +10:00
CraftBukkit/Spigot
690c8b65a1 SPIGOT-6587: Update documentation/error of drop chance API
By: md_5 <git@md-5.net>
2021-06-20 12:15:28 +10:00
CraftBukkit/Spigot
66df1397b3 Fix Inventory#getViewers on the player inventory not returning the player first time their inventory is opened
By: md_5 <git@md-5.net>
2021-06-20 09:27:32 +10:00
CraftBukkit/Spigot
41524cf726 Fix PrepareItemCraftEvent#isRepair
By: md_5 <git@md-5.net>
2021-06-20 09:03:27 +10:00
CraftBukkit/Spigot
453d93caa5 SPIGOT-6586: EntityChangeBlockEvent for falling block does not cancel properly
By: md_5 <git@md-5.net>
2021-06-20 08:48:15 +10:00
CraftBukkit/Spigot
64174260d1 SPIGOT-6583: Throwing eggs doesn't make sounds
By: md_5 <git@md-5.net>
2021-06-20 08:38:01 +10:00
CraftBukkit/Spigot
bcaff2755a SPIGOT-6580: Cancelling SlimeSplitEvent Causes Infinite Loop
By: md_5 <git@md-5.net>
2021-06-19 08:46:31 +10:00
CraftBukkit/Spigot
fc07fa5704 SPIGOT-6576: BlockExpEvent does not show XP when breaking a furnace
By: md_5 <git@md-5.net>
2021-06-19 08:45:08 +10:00
CraftBukkit/Spigot
d2c0fcf0df #869: Fix BossBar setColor and setStyle updates
By: Eric Su <ericsu14@hotmail.com>
2021-06-17 17:37:30 +10:00
CraftBukkit/Spigot
0747934cc1 Incrase outdated build delay
By: md_5 <git@md-5.net>
2021-06-17 08:42:37 +10:00
CraftBukkit/Spigot
4b86eeff64 SPIGOT-6570: Missing InventoryType: COMPOSTER
By: md_5 <git@md-5.net>
2021-06-17 08:29:15 +10:00
CraftBukkit/Spigot
b9782609ca SPIGOT-6558: Attempt to improve SkullMeta
By: md_5 <git@md-5.net>
2021-06-16 10:28:42 +10:00
CraftBukkit/Spigot
df28f86cce SPIGOT-6562: Add more specific sculk sensor event
By: md_5 <git@md-5.net>
2021-06-16 08:34:34 +10:00
CraftBukkit/Spigot
9233fd67b4 Fix duplicate datapack reload on /reload
By: md_5 <git@md-5.net>
2021-06-15 15:51:13 +10:00
CraftBukkit/Spigot
6b435994e8 SPIGOT-6555: Cannot access shield BlockStateMeta
By: md_5 <git@md-5.net>
2021-06-15 13:06:23 +10:00
CraftBukkit/Spigot
c751b9c098 SPIGOT-6542: Fix counting players with fauxSleeping = true
By: Ivan R <namelessftw1206@hotmail.com>
2021-06-15 12:44:34 +10:00
CraftBukkit/Spigot
e4f5bec8b3 SPIGOT-6561: Add events for dripleaf tilting
By: md_5 <git@md-5.net>
2021-06-15 08:49:10 +10:00
CraftBukkit/Spigot
752618d75f SPIGOT-6560: Crash when falling stalactite hits player
By: md_5 <git@md-5.net>
2021-06-15 08:01:07 +10:00
CraftBukkit/Spigot
46666cb5a8 SPIGOT-6557: PlayerEditBookEvent#setNewBookMeta does not update meta
By: md_5 <git@md-5.net>
2021-06-14 19:37:21 +10:00
CraftBukkit/Spigot
46c18bc4d5 #865: Implement Villager#shakeHead
By: VendoAU <reillyreaby@gmail.com>
2021-06-14 19:13:37 +10:00
CraftBukkit/Spigot
8777dd8e62 #863: Add LivingEntity#isClimbing
By: Martoph <sager1018@gmail.com>
2021-06-14 19:11:46 +10:00
CraftBukkit/Spigot
733b118606 SPIGOT-6554: Worlds created with the bukkit ChunkGenerator cannot save
By: md_5 <git@md-5.net>
2021-06-14 13:52:25 +10:00
CraftBukkit/Spigot
967b0303f3 SPIGOT-6507: Implement abstract skeleton and stray conversion
The previous layout and class hierarchy of the skeleton API defined
variances of the skeleton, such as the wither skeleton or the stray, as
child types of the normal skeleton variance, which is technically
incorrect, yet did not produce any specific issue as the normal skeleton
variance did not have any unique logic.

With the introduction of powdered snow in the 1.17 update, the normal
skeleton variance now has unique logic, specifically the conversion to
a stay when stuck inside powdered snow, which cannot be represented in
the current API layout due to the prior mentioned hierarchy.

This commit implements the hierarchy changes made in the bukkit
repository by representing the new hierarchy on the craftbukkit side
through the CraftAbstractSkeleton and the respective additions to the
skeleton implementation in regards to the stray conversion.

This commit does not break ABI yet breaks backwards compatibility due to
the mentioned hierarchy changes. Plugins that previously used the
Skelton interface to compute whether or not an entity is skeleton-like
through instanceOf checks will now only match the normal skeleton variance
instead of any skeleton-like entity.

By: Bjarne Koll <lynxplay101@gmail.com>
2021-06-14 10:01:19 +10:00
CraftBukkit/Spigot
9a2165ab37 #855: Add Block#getCollisionShape and associated API
By: konsolas <vincentyntang@gmail.com>
2021-06-14 08:33:32 +10:00
CraftBukkit/Spigot
55abb0fd8c #857: Add Block#getBreakSpeed(Player)
By: konsolas <vincentyntang@gmail.com>
2021-06-14 08:28:45 +10:00
CraftBukkit/Spigot
1b34737612 SPIGOT-6540: Firework rockets not crafting into flight duration 1
By: md_5 <git@md-5.net>
2021-06-13 17:59:01 +10:00
CraftBukkit/Spigot
d5a68b79c1 SPIGOT-6526: World entities are not populated when plugin onEnable is called
By: md_5 <git@md-5.net>
2021-06-13 15:05:32 +10:00
CraftBukkit/Spigot
085885b64a SPIGOT-6536: Marker position not set on spawn
By: md_5 <git@md-5.net>
2021-06-13 10:25:21 +10:00
CraftBukkit/Spigot
02ebbcfc81 #855: Add HumanEntity#getItemInUse and Material#getSlipperiness
By: konsolas <vincentyntang@gmail.com>
2021-06-12 21:07:45 +01:00
CraftBukkit/Spigot
3e7e42a371 SPIGOT-6529: Fix BundleMeta#setItems
By: md_5 <git@md-5.net>
2021-06-13 08:48:13 +10:00
CraftBukkit/Spigot
f7478ccc32 SPIGOT-6535: PlayerGameModeChangeEvent event incorrectly reports old gamemode
By: Parker Hawke <hawkeboyz2@hotmail.com>
2021-06-13 08:43:21 +10:00
CraftBukkit/Spigot
94c0260719 #856: Add methods to check if item is the breed item for an entity
By: Nathat23 <nathat890@outlook.com>
2021-06-13 08:37:53 +10:00
CraftBukkit/Spigot
472f590189 Add additional validation to Player#breakBlock
By: md_5 <git@md-5.net>
2021-06-13 08:27:57 +10:00
CraftBukkit/Spigot
c799ab1f6e SPIGOT-6532: Fix Entity#setGlowing
By: md_5 <git@md-5.net>
2021-06-13 08:26:10 +10:00
CraftBukkit/Spigot
47c7562765 Restore 1.16.5 behaviour of InventoryDragEvent being called even when a single item is 'dragged' to its own slot
Ideally this would now be an InventoryClickEvent instead, but that is not so easy with the current structure.
See https://www.spigotmc.org/threads/510208/page-9#post-4185501 for further info.

By: md_5 <git@md-5.net>
2021-06-12 20:19:41 +10:00
CraftBukkit/Spigot
f359c7a3ec Fix new map colors rendering as transparent
By: DerFrZocker <derrieple@gmail.com>
2021-06-12 19:56:13 +10:00
CraftBukkit/Spigot
d57a6b8cc2 SPIGOT-6524: Inventory desync when InventoryClickEvent is cancelled
By: md_5 <git@md-5.net>
2021-06-12 19:44:31 +10:00
CraftBukkit/Spigot
cd03a7966c SPIGOT-6522: ItemStack on cursor is always AIR
By: md_5 <git@md-5.net>
2021-06-12 16:24:52 +10:00
CraftBukkit/Spigot
544ec40369 Fix missing PlayerEditBookEvent
By: md_5 <git@md-5.net>
2021-06-12 16:14:12 +10:00
CraftBukkit/Spigot
8797975de5 SPIGOT-6513: Placing ItemStack in Inventory causes InventoryAction.NOTHING
By: md_5 <git@md-5.net>
2021-06-12 15:23:44 +10:00
CraftBukkit/Spigot
1daedfe082 SPIGOT-6519: Fix end gateway teleports
By: md_5 <git@md-5.net>
2021-06-12 11:07:06 +10:00
CraftBukkit/Spigot
190b3f8308 SPIGOT-6515: "Un-waterlogging" throws UnsupportedOperationException in some cases
By: md_5 <git@md-5.net>
2021-06-12 08:59:05 +10:00
CraftBukkit/Spigot
81163e6137 SPIGOT-6518: Anvils falling onto dripstone can sometimes crash server
By: md_5 <git@md-5.net>
2021-06-12 08:54:48 +10:00
CraftBukkit/Spigot
35223329b1 SPIGOT-6514: Small Dripleaf block data is missing half property
By: DerFrZocker <derrieple@gmail.com>
2021-06-12 08:47:11 +10:00
CraftBukkit/Spigot
8198d062f3 #853: Implement Player#breakBlock()
By: Parker Hawke <hawkeboyz2@hotmail.com>
2021-06-12 08:30:34 +10:00
CraftBukkit/Spigot
0e95cf49fe SPIGOT-6510: Bukkit#createMap throws NullPointerException
By: DerFrZocker <derrieple@gmail.com>
2021-06-12 08:25:43 +10:00
CraftBukkit/Spigot
22217fefcd SPIGOT-6517: Spider jockey crash on dripstone
By: md_5 <git@md-5.net>
2021-06-12 08:09:40 +10:00
CraftBukkit/Spigot
536256d6ff SPIGOT-6508: Rename conflicted getServer
By: md_5 <git@md-5.net>
2021-06-11 21:33:49 +10:00
CraftBukkit/Spigot
dd358f1352 SPIGOT-6506: Fix crash with custom inventories
By: md_5 <git@md-5.net>
2021-06-11 19:10:28 +10:00
CraftBukkit/Spigot
0acd422f48 Fix NPE with Entity.getNearbyEntities
By: md_5 <git@md-5.net>
2021-06-11 18:48:59 +10:00
CraftBukkit/Spigot
4b9c250321 Fix NPE with World.getNearbyEntities
By: md_5 <git@md-5.net>
2021-06-11 17:24:45 +10:00
CraftBukkit/Spigot
fcf15f1048 Fix second usage of worldGenSettings just in case
By: md_5 <git@md-5.net>
2021-06-11 16:47:40 +10:00
CraftBukkit/Spigot
2d39ef0bc5 SPIGOT-6504: Fix generating fresh worlds
By: md_5 <git@md-5.net>
2021-06-11 16:16:36 +10:00
CraftBukkit/Spigot
b3a8254758 Update to Minecraft 1.17
By: md_5 <git@md-5.net>
2021-06-11 15:00:00 +10:00
CraftBukkit/Spigot
75faba7fde Remove outdated build delay.
By: md_5 <git@md-5.net>
2021-06-11 14:03:29 +10:00
CraftBukkit/Spigot
023eff1b0e Fix inconsistent commands
By: md_5 <git@md-5.net>
2021-06-08 14:18:54 +10:00
CraftBukkit/Spigot
ee04dc8508 SPIGOT-6492: PortalCreateEvent#getBlocks() returns not all blocks by reason fire
By: DerFrZocker <derrieple@gmail.com>
2021-06-07 18:39:30 +10:00
CraftBukkit/Spigot
1ac55ed273 SPIGOT-6487: Fix issue with villagers picking up items in certain situations
By: md_5 <git@md-5.net>
2021-06-03 12:14:36 +10:00
CraftBukkit/Spigot
e42f86eb2d Remove usage of Java 11 method not caught by animal sniffer
By: md_5 <git@md-5.net>
2021-06-01 20:10:47 +10:00
CraftBukkit/Spigot
2784d9c66a SPIGOT-6483: Fix cancelling EntityPickupEvent for villagers
By: md_5 <git@md-5.net>
2021-06-01 18:52:49 +10:00
CraftBukkit/Spigot
14af2c0a70 SPIGOT-6482: Baby piglins will pick up more items than vanilla
By: md_5 <git@md-5.net>
2021-06-01 18:06:50 +10:00
CraftBukkit/Spigot
d5fb854202 SPIGOT-6480: Players cannot take books from lecterns that were opened by plugins
By: blablubbabc <lukas@wirsindwir.de>
2021-05-29 18:52:49 +10:00
CraftBukkit/Spigot
bef41983bd SPIGOT-6478: Double chests opened by plugins don't play their closing animation.
By: blablubbabc <lukas@wirsindwir.de>
2021-05-29 08:41:34 +10:00
CraftBukkit/Spigot
4929e2a1d9 #703: Add piglin bartering API
By: Lars Dormans <lars.dormans@live.nl>
2021-05-28 08:59:21 +10:00
CraftBukkit/Spigot
07f924343f SPIGOT-6133: Chorus fruit consumption calls PlayerTeleportEvent multiple times
By: DerFrZocker <derrieple@gmail.com>
2021-05-25 08:24:08 +10:00
CraftBukkit/Spigot
4d77463831 SPIGOT-6464: Fix ShulkerBox#getColor for undyed shulkers
By: md_5 <git@md-5.net>
2021-05-23 08:30:36 +10:00
CraftBukkit/Spigot
d8a90faeb1 #845: Remove unnecessary calls to Class#getSimpleName in PDC
By: Wesley Smith <me@wesjd.net>
2021-05-21 08:25:09 +10:00
CraftBukkit/Spigot
9111166484 Make Vanilla /list respect Vanish API
By: md_5 <git@md-5.net>
2021-05-20 08:31:32 +10:00
CraftBukkit/Spigot
097e647d7a SPIGOT-5569: Call WorldInitEvent before any chunks are getting generated
By: DerFrZocker <derrieple@gmail.com>
2021-05-18 08:14:59 +10:00
CraftBukkit/Spigot
fac154e1cd #816: Prevent duplicate slash removal for console / block commands
By: md_5 <git@md-5.net>
2021-05-17 18:09:13 +10:00
CraftBukkit/Spigot
4fd4ece94b Move additional dependencies to runtime scope
By: md_5 <git@md-5.net>
2021-05-16 18:09:49 +10:00
CraftBukkit/Spigot
431ac4577d Remove sisu annotation processor from jar
By: md_5 <git@md-5.net>
2021-05-15 16:41:17 +10:00
CraftBukkit/Spigot
6afb9da7cb SPIGOT-6189: Persistent data disappears when calling setFacingDirection on an item frame
By: DerFrZocker <derrieple@gmail.com>
2021-05-15 10:11:38 +10:00
CraftBukkit/Spigot
b19314a834 #827: Trigger vanilla dimension advancements in non-main worlds
By: Kermina Awad <kerminaawad@gmail.com>
2021-05-15 10:06:25 +10:00
CraftBukkit/Spigot
59f6e7fdd8 Add plumbing for automatic library support
By: md_5 <git@md-5.net>
2021-05-15 09:05:18 +10:00
CraftBukkit/Spigot
9764b58089 #831: Reload unloaded main worlds correctly
By: Kermina Awad <kerminaawad@gmail.com>
2021-05-12 17:20:27 +10:00
CraftBukkit/Spigot
dfc592aec5 SPIGOT-6224: EntityBreedEvent getEntity location inaccuracy
By: Martoph <sager1018@gmail.com>
2021-05-11 18:33:28 +10:00
CraftBukkit/Spigot
c3777ce7e7 SPIGOT-5565: Animals still spawn from chunk gen when spawn-animals=false
By: DerFrZocker <derrieple@gmail.com>
2021-05-11 08:18:34 +10:00
CraftBukkit/Spigot
9b7c2ef5f9 Handle renamed ZOMBIE_PIGMAN loot table
By: md_5 <git@md-5.net>
2021-05-09 17:31:20 +10:00
CraftBukkit/Spigot
165c8596d8 #833: Add Player#getPing to access the player's ping
By: retrooper <retrooperdev@gmail.com>
2021-05-09 17:20:53 +10:00
CraftBukkit/Spigot
6f87ada41c SPIGOT-6452: Call EntityPickupItemEvent for villagers
By: Julian van den Berkmortel <julianvdberkmortel@outlook.com>
2021-05-09 16:57:25 +10:00
CraftBukkit/Spigot
3df6aee27f #776: Add ability to cancel ProjectileHitEvent
By: Martoph <sager1018@gmail.com>
2021-05-09 16:51:44 +10:00
CraftBukkit/Spigot
9d5bc88891 SPIGOT-6200: Improve entity events when summon command is used
* Calls the LightningStrikeEvent for summoned lightning
* Uses the new COMMAND SpawnReason for other entities

By: Julian van den Berkmortel <julianvdberkmortel@outlook.com>
2021-05-09 16:33:34 +10:00
CraftBukkit/Spigot
da56cad3fc #826: Make dispenser trigger fertilize event
By: Lars Dormans <lars.dormans@live.nl>
2021-05-03 18:30:48 +10:00
CraftBukkit/Spigot
31ba2167bd SPIGOT-6350: Fix wrong portal block place order
By: DerFrZocker <derrieple@gmail.com>
2021-05-02 18:58:07 +10:00
CraftBukkit/Spigot
642814c419 SPIGOT-6442: Do not cancel zero damage on fireballs
By: Julian van den Berkmortel <julianvdberkmortel@outlook.com>
2021-04-30 17:53:58 +10:00
CraftBukkit/Spigot
89d0d3356e SPIGOT-6430: Fix fungi tree not generating
By: DerFrZocker <derrieple@gmail.com>
2021-04-29 07:43:26 +10:00
CraftBukkit/Spigot
0989d371a0 SPIGOT-6373: Add getAttachedFace and setAttachedFace to the Shulker API
By: Julian van den Berkmortel <julianvdberkmortel@outlook.com>
2021-04-28 11:52:30 +10:00
CraftBukkit/Spigot
c5af0704d0 SPIGOT-6435: send correcting "PacketPlayOutBlockChange" packet on interact for bisected items
By: Julian van den Berkmortel <julianvdberkmortel@outlook.com>
2021-04-27 11:37:52 +10:00
CraftBukkit/Spigot
4d865daa32 SPIGOT-6434: Smithing Table and Anvil inventories .getType() returns CRAFTING
By: md_5 <git@md-5.net>
2021-04-25 08:34:44 +10:00
CraftBukkit/Spigot
93ddc2d863 #683: Add PlayerBucketFishEvent
By: DiamondDagger590 <diamonddagger590@gmail.com>
2021-04-25 08:34:44 +10:00
CraftBukkit/Spigot
d6327a1b65 #823: Add Block#isPreferredTool
By: Flo0 <unconfigured@null.spigotmc.org>
2021-04-21 17:31:47 +10:00
CraftBukkit/Spigot
1eb2ceea36 SPIGOT-6388: Add API to get and set the state of the "Shulker" entity
By: Julian van den Berkmortel <julianvdberkmortel@outlook.com>
2021-04-19 18:47:47 +10:00
CraftBukkit/Spigot
8cbaba0a8a SPIGOT-6078: Add SmithItemEvent and expand SmithingInventory API
By: Julian van den Berkmortel <julianvdberkmortel@outlook.com>
2021-04-18 18:03:23 +10:00
CraftBukkit/Spigot
9d052543d0 SPIGOT-6428: World.generateTree does not generate bee nests
By: md_5 <git@md-5.net>
2021-04-18 17:42:35 +10:00
CraftBukkit/Spigot
17a73066d0 SPIGOT-5877: Add support for Vanilla custom dimensions
By: Martoph <sager1018@gmail.com>
2021-04-16 10:36:05 +10:00
CraftBukkit/Spigot
8ce553209c #819: Implemented test for Material#getEquipmentSlot() method
By: Jakub Zacek <dawon.cz@gmail.com>
2021-04-13 19:16:32 +10:00
CraftBukkit/Spigot
304aa91bb1 SPIGOT-6207: forcibly drop the items of a converted zombie villager
By: Julian van den Berkmortel <julianvdberkmortel@outlook.com>
2021-04-12 08:28:19 +10:00
CraftBukkit/Spigot
103e1bf3b5 SPIGOT-5877: Add scaffolding for custom dimensions and biomes
By: Martoph <sager1018@gmail.com>
2021-04-11 17:54:48 +10:00
CraftBukkit/Spigot
9fe10a5da5 SPIGOT-6417: Add Creeper fuse ticks API
By: md_5 <git@md-5.net>
2021-04-11 17:32:26 +10:00
CraftBukkit/Spigot
07037838f1 SPIGOT-6414: Use ASM9 API to add support for sealed classes
By: md_5 <git@md-5.net>
2021-04-07 18:48:34 +10:00
CraftBukkit/Spigot
0601c47be5 SPIGOT-6413: Server Corruption Changing Blocks in Piston Events
By: md_5 <git@md-5.net>
2021-04-07 15:03:30 +10:00
CraftBukkit/Spigot
834f035a21 SPIGOT-6411: The PlayerEditBookEvent is not called when the player edits a book in the off-hand.
By: md_5 <git@md-5.net>
2021-04-07 15:03:29 +10:00
CraftBukkit/Spigot
97cd7810a3 Add mc-dev imports
By: md_5 <git@md-5.net>
2021-04-07 15:03:29 +10:00
CraftBukkit/Spigot
0352f0e143 SPIGOT-6408: Narrator chat only does not work
By: md_5 <git@md-5.net>
2021-04-05 15:31:26 +10:00
CraftBukkit/Spigot
79672394a1 Remove some outdated PAIL comments
By: md_5 <git@md-5.net>
2021-04-04 17:14:53 +10:00
CraftBukkit/Spigot
7af71a460f SPIGOT-6237: WorldCreator#generatorSettings not working
By: Martoph <sager1018@gmail.com>
2021-04-04 14:02:32 +10:00
CraftBukkit/Spigot
15305e6842 SPIGOT-6357: Add World#getMinHeight
By: md_5 <git@md-5.net>
2021-03-28 19:31:50 +11:00
CraftBukkit/Spigot
90df44b39a SPIGOT-6398: Fix crash when bonemealing bamboo and the BlockSpreadEvent is cancelled
By: Brokkonaut <hannos17@gmx.de>
2021-03-20 09:01:18 +11:00
CraftBukkit/Spigot
cdb7cb852f Fix broken wandering traders
By: md_5 <git@md-5.net>
2021-03-20 08:55:48 +11:00
CraftBukkit/Spigot
9c13408431 Prepare for Java 16
By: md_5 <git@md-5.net>
2021-03-17 07:53:10 +11:00
CraftBukkit/Spigot
9da047989c Repackage NMS
By: md_5 <git@md-5.net>
2021-03-16 09:00:00 +11:00
CraftBukkit/Spigot
18496e998f Repackage patches
By: md_5 <git@md-5.net>
2021-03-16 09:00:00 +11:00
CraftBukkit/Spigot
2777f7b780 Use upstream plexus-compiler-eclipse
Relevant bugs have since been fixed

By: md_5 <git@md-5.net>
2021-03-15 17:46:36 +11:00
CraftBukkit/Spigot
52fe52d83d #810: Add option for a consumer before spawning an item
By: Martoph <sager1018@gmail.com>
2021-03-09 08:47:34 +11:00
CraftBukkit/Spigot
11d6de6800 #809: Add spawn and transform reasons for piglin zombification.
By: Nathat23 <nathat890@outlook.com>
2021-03-09 08:47:33 +11:00
CraftBukkit/Spigot
b2efd58164 Organise imports
By: md_5 <git@md-5.net>
2021-03-09 08:47:33 +11:00
CraftBukkit/Spigot
1ae7bcc4d0 #795: Add methods to modify the rate of regeneration and starvation
By: Martoph <sager1018@gmail.com>
2021-03-04 08:28:07 +11:00
CraftBukkit/Spigot
69c16ea666 #792: Add EntityExhaustionEvent
By: Martoph <sager1018@gmail.com>
2021-03-04 08:28:05 +11:00
CraftBukkit/Spigot
b65d70e9ea #807: Add Player#sendBlockDamage()
By: Parker Hawke <hawkeboyz2@hotmail.com>
2021-02-24 20:21:39 +11:00
CraftBukkit/Spigot
510efe562a SPIGOT-6307: Allow chest locks with legacy color codes to match against items with json colors
By: Nathan Wolf <nathan@elmakers.com>
2021-02-21 09:47:11 +11:00
CraftBukkit/Spigot
932b0a5bf6 #802: Add methods to modify despawn delay for wandering villagers
By: DiamondDagger590 <diamonddagger590@gmail.com>
2021-02-15 19:30:15 +11:00
CraftBukkit/Spigot
64ef04d7e4 SPIGOT-6362: ConcurrentModificationException: null --> Server Crash
By: md_5 <git@md-5.net>
2021-02-14 10:08:27 +11:00
CraftBukkit/Spigot
373ed1ddd5 SPIGOT-5228: Entities that are removed during chunk unloads are not
properly removed from the chunk.

This could lead to dead entities accumulating in memory over time if the
chunk never gets fully unloaded (as it is the case for chunks around the
spawn region).

The issue is that Minecraft processes the removal of these entities
during the next tick, when the chunk has already switched to state
INACCESSIBLE and can no longer be retrieved as usual.

For the purpose of removing dead entities from their still loaded but no
longer accessible chunk, this adds and uses a new method with which a
chunk can be accessed without checking its current state first.

By: blablubbabc <lukas@wirsindwir.de>
2021-02-14 09:24:23 +11:00
CraftBukkit/Spigot
98e0c5c715 SPIGOT-6347: Nether Portals Default to Nether, even in Nether
By: md_5 <git@md-5.net>
2021-02-13 10:31:49 +11:00
CraftBukkit/Spigot
849c37e463 SPIGOT-5778: Added World.getGameTime method
By: Jakub Zacek <dawon.cz@gmail.com>
2021-02-13 10:25:52 +11:00
CraftBukkit/Spigot
2a0d4308e9 BUILDTOOLS-569: development maven profile fails build on windows
By: md_5 <git@md-5.net>
2021-02-08 21:08:44 +11:00
CraftBukkit/Spigot
47abd03c46 EntityDropItemEvent for cats should continue to next stack if cancelled
Thanks @Black-Hole

By: md_5 <git@md-5.net>
2021-02-07 08:45:11 +11:00
CraftBukkit/Spigot
d5f80533da #793: Don't unnecessarily toString block in CraftBlockEntityState constructor
By: blablubbabc <lukas@wirsindwir.de>
2021-02-06 10:35:00 +11:00
CraftBukkit/Spigot
5d4113e993 #797: The copy constructor of CraftMetaTropicalFishBucket did not copy its entityTag field
By: blablubbabc <lukas@wirsindwir.de>
2021-02-06 09:23:50 +11:00
CraftBukkit/Spigot
236e582f0b SPIGOT-6342: TROPICAL_FISH_BUCKET isSimilar returns true when it should not
By: Gerrygames <gecam59@gmail.com>
2021-02-06 09:23:50 +11:00
CraftBukkit/Spigot
8b277612a9 SPIGOT-6208: Throwing ender pearl into end portal causes NPE
By: Parker Hawke <hawkeboyz2@hotmail.com>
2021-01-31 14:26:05 +11:00
CraftBukkit/Spigot
04c4f1b337 Add more checkstyle checks
By: md_5 <git@md-5.net>
2021-01-31 10:08:41 +11:00
CraftBukkit/Spigot
540be51514 Re-add missing StriderTemperatureChangeEvent
By: md_5 <git@md-5.net>
2021-01-29 20:00:43 +11:00
CraftBukkit/Spigot
022d868fa2 SPIGOT-6316: PlayerBedLeaveEvent implements Cancellable
By: md_5 <git@md-5.net>
2021-01-29 11:22:42 +11:00
CraftBukkit/Spigot
7405148b11 #789: Call EntityDropItemEvent when a wither rose is dropped
By: Nathat23 <nathat890@outlook.com>
2021-01-29 10:19:39 +11:00
CraftBukkit/Spigot
67905be24d SPIGOT-3789: Can't Remove Entity Equipment in Same Tick Spawned without using Consumer
By: md_5 <git@md-5.net>
2021-01-27 14:24:20 +11:00
CraftBukkit/Spigot
9a6f2ccb6b #783: Expand the FishHook API
By: Parker Hawke <hawkeboyz2@hotmail.com>
2021-01-23 12:23:20 +11:00
CraftBukkit/Spigot
f6f717ebe7 SPIGOT-6318: Fix smoke effect directions
By: WinX64 <winx64b@hotmail.com>
2021-01-23 12:17:52 +11:00
CraftBukkit/Spigot
f7ff794ec7 SPIGOT-6315: Cats gifts dont call EntityDropItemEvent
By: md_5 <git@md-5.net>
2021-01-21 08:31:06 +11:00
CraftBukkit/Spigot
78ff16111e Update to Minecraft 1.16.5
By: md_5 <git@md-5.net>
2021-01-16 12:00:00 +11:00
CraftBukkit/Spigot
789c080552 Remove outdated build delay.
By: md_5 <git@md-5.net>
2021-01-15 09:01:00 +11:00
CraftBukkit/Spigot
c54a66880b SPIGOT-6311: Don't calculate portal shapes for up/down directions
By: Parker Hawke <hawkeboyz2@hotmail.com>
2021-01-08 21:45:39 -05:00
CraftBukkit/Spigot
cdd8e09ac0 SPIGOT-6304: Removed the detection of legacy text based on color codes
Apparently there are items and plugins out there that still use legacy
color codes within text components, and which thereby break this
heuristic.

Our remaining approach to differentiate between legacy (plain) and
modern (JSON-based) text is to check if a particular text can be parsed
as JSON-based text. This approach is not perfect either as there are
ambiguous cases that it cannot resolve correctly. However, these cases
are hopefully rare enough in practice that this approach remains
suitable.

By: blablubbabc <lukas@wirsindwir.de>
2021-01-03 17:24:43 +11:00
CraftBukkit/Spigot
4b503e57c6 SPIGOT-6303: Interpret text that Gson considers to be an empty JSON document as legacy text.
For example, this affects empty Strings, and Strings that consist only
of whitespace. In lenient mode this would also affect text that contains
comments, but that is not the case currently.
Minecraft's component parser (i.e. Gson) produces null for these texts
instead of throwing a parse exception. By interpreting this text as
legacy text we correctly create text components for them that contain
their contents.

By: blablubbabc <lukas@wirsindwir.de>
2021-01-02 14:46:59 +11:00
CraftBukkit/Spigot
904d0ddd37 #778: Added get/set ItemStack methods to trident
By: Auxilor <will@willfp.com>
2021-01-02 08:49:22 +11:00
CraftBukkit/Spigot
5868631388 Update SQLite for Mac M1 support
By: md_5 <git@md-5.net>
2021-01-02 08:44:43 +11:00
CraftBukkit/Spigot
cf47c45e20 #707, SPIGOT-5063, SPIGOT-5304, SPIGOT-5656, SPIGOT-3206, SPIGOT-5350, SPIGOT-5980, SPIGOT-4672: Persist the exact internal text representation where possible.
Issues resolved by this:
* SPIGOT-5063: Internal text representation of ItemStacks changes during ItemStack serialization. This issue was initially primarily concerned with the conversion between color text attributes to legacy color codes.
* SPIGOT-5304: Internal text representation of ItemStacks changes when opening the inventory (in creative mode). In particularly, this issue is also concerned with the conversion between plain text representations to non-plain ones.
* SPIGOT-5656: Internal text representation of ItemStacks changes during ItemStack serialization. This issue is particularly concerned with reordering of text attributes in the text's Json representation.
* SPIGOT-3206: Internal text representation of book pages changes during ItemStack serialization.
* SPIGOT-5350: Any non-plain text features are stripped from books during ItemStack serialization.
* SPIGOT-5980: Written books are marked as 'resolved' during ItemStack serialization and on various inventory interactions, even though they aren't, and thereby breaking any non-resolved page contents.
* SPIGOT-4672: Since item display names are serialized in their internal Json representation, any translatable components get properly persisted as well now.

---------

Minecraft uses text components to represent text. Internally Minecraft stores these components as Json formatted Strings and dynamically parses the text components from this Json representation whenever required.

In some cases Minecraft will create the text components and then convert them to Json itself for the internal storage. In other cases the Json representation is specified by users (eg. in Minecraft give commands, loot tables, mob equipment specified via Minecraft's summon commands, etc.).
There are many different ways in which the same text components can be represented in Json. When Minecraft compares objects which store this textual information, it takes the exact Json representation into account to determine whether the objects are considered equal. For example, ItemStacks will not match (and therefore not stack) if there is a difference in this internal Json representation for at least one if the item's text attributes (such as display name, lore, book pages, etc.). And when specifying nbt data in command selectors (eg. to only match entities/players which hold an item with specific name), the selector compares the raw Json representation as well.

As long as the Json representation is valid and can be parsed, Minecraft will not modify or normalize it.
However, under various circumstances Spigot converts this text information from the internal Json representation to text components (and in some cases even to plain text with legacy color codes) and then later tries to convert the text from these representations back to text components in the Json representation. Because this backwards conversion is in many cases not able to reproduce the original Json representation, the internal data of some affected Minecraft objects (ItemStacks, TileEntities, Entities, etc.) will in some cases get modified.

One especially notable situation in which this issue can come up is Bukkit's configuration serialization of ItemStacks: When a plugin serializes and later deserializes ItemStacks with display name, localized name, lore, or book pages of signed books, Spigot would convert these textual ItemStack attributes to plain text with legacy color codes and later try to convert those back to chat components in the Json representation. If the reconstructed Json representation does not match the original representation, the deserialized ItemStacks would no longer match nor stack with any original ItemStacks.

This case is particularly common if the original ItemStacks are created by users via some vanilla Minecraft mechanism (eg. Minecraft's give command, loot tables, mob equipment specified via Minecraft's summon command, etc.) and the used internal text representation for the created ItemStacks does not match the text representation produced by Spigot. This is also quite likely to be case, because the internal text representation produced by Spigot can sometimes be slightly verbose and, until recently, contained legacy color codes which cannot be used in Minecraft commands in-game.
However, this issue is not limited to items created by users, but affects items created by Minecraft itself as well.

Other cases in which Spigot itself (without any plugins involved) will convert between these text representations include dragging items around inside the inventory or opening the inventory while in creative mode. In these cases Spigot creates Bukkit representations of the affected items for use in Bukkit events and then, after the events have been handled, converts these Bukkit representations back to Minecraft items. See for example SPIGOT-5656 and SPIGOT-5304.

The idea of these changes is to avoid this back and forth conversion between the internal Json representation and the text component or plain text representations in various situations in which it is not actually required:
* CraftMetaItem stores the raw original Json representation for the display name, localized name, lore and pages of signed books now. As long as no plugin modifies these text attributes via the API, they can be reapplied in their original form to an ItemStack.
* The configuration serialization will serialize the original Json representation for these text attributes now so that it can also be restored during deserialization.
* However, in order to still be able to deserialize previously serialized items, and in order to allow users to specify text in the more simple plain representation in configuration files, we also still accept plain text during deserialization. Our approach is to check if the serialized text contains legacy color codes, in which case we convert it to chat components using our own converter and then to Json. Otherwise we try to parse it via Minecraft's Json parser. If the parsing fails due to the text not being valid Json, we interpret the text as plain text and convert it via our own converter as well.
* Various duplicated code has been removed from CraftMetaBookSigned and instead the base CraftMetaBook class allows sub classes to override the relevant aspects of how pages are parsed, serialized and deserialized.
* The BlockStates for command blocks and signs preemptively retrieved the custom name and sign line components, converted them to plain text and later converted them back to text components when applying the BlockState. We now only perform this conversion if a plugin has explicitly modified these texts.

Other changes:
* Minor: We also retrieve, convert and update a few other BlockState attributes directly from the underlying snapshot and only when requested by plugins now.
* SPIGOT-5980: Written books did not properly persist their 'resolved' attribute, resulting in unresolved book pages not getting resolved.
* There are methods to get and set the resolved value for books. However, these are not yet exposed in Bukkit.
* Minor fix: CraftMetaBook#isBookEmpty did not check some of the book attributes. This is probably a minor issue, but for consistency reasons there are checks for the missing attribute(s) now.

----
Covered cases
---
* By remembering the raw original String data, we can persist the exact text representation (eg. the ordering of elements within the Json text object (SPIGOT-5656), used style of escaping quotes (single quotes, escaped double quotes, etc.), use of plain texts (SPIGOT-5304), used boolean style, modern text component features such as translatable texts (SPIGOT-4672), etc.). All of these differences would otherwise cause the ItemStack to no longer be considered equal to its original.
* An empty String in the serialized config data results in no display name rather than an empty display name, like before. An item with explicitly empty display name (`{display: {Name: '""'}}`) is saved as `'""'` and can also be loaded from that representation again.
* Any plain texts, with or without color codes, which don't parse as Json (eg. `display-name: 'Bla'`) are still getting run through Spigot's text to components converter, like before.
* We can now also persist empty but explicitly present lore (`{display:{Lore:[]}}`). Previously this would get removed when the ItemMeta gets reapplied to the item. And ItemMeta#equals would return true for items with and without this empty lore data, even though Minecraft considers them to be different. For plugins using the API there should be no change: #hasLore still checks whether the lore is both present and not empty, and #getLore returns an empty list instead of null in this case (however, it previously already returned an empty list in this case). And setting the lore to an empty list via #setLore will still result in an item with no lore.
* Similarly, we can also persist explicitly specified but empty lists of book pages now.

----
Cases that are not covered (i.e. which may lead to changes in items), but were already not covered previously:
----
* NBT data for text that is not actually of type String.
* Empty or unexpected entries within the display compound.
* Variations in the NBT data representation in item features other than the above mentioned ones.
* Texts containing color codes. During deserialization these texts get interpreted as plain text and converted to a text component representation. This will break the serialization of any ItemStacks which actually use a text component representation with embedded color codes for some reason. Usually the likelihood for encountering such items in practice would probably be small. However, in the past (pre MC 1.16) Spigot would actually produce such items during ItemStack deserialization or when plugins created ItemStack via the Bukkit API. However, Spigot has changed the text representation it produces in MC 1.16, so any previously created and still existing items with this text representation are already problematic anyways now. See SPIGOT-5964. A fix for this linked issue (eg. the automatic conversion of these items) would probably resolve this deficit here as well.
* Spigot's String to text components converter produces quite verbose components since 1.16. See SPIGOT-5964 as well. However, this applies regardless of the changes of this PR.
* Book ItemStacks with more pages than 100 pages or oversized pages are truncated (like before) and may therefore change.
hange.

By: blablubbabc <lukas@wirsindwir.de>
2021-01-01 08:53:14 +11:00
CraftBukkit/Spigot
9bda60d8b4 SPIGOT-6296: Server crashes when burning something at y-level 0
By: md_5 <git@md-5.net>
2020-12-29 08:45:45 +11:00
CraftBukkit/Spigot
3e80d2e4ec SPIGOT-6273: Expose ItemFrame ItemDropChance through API
By: md_5 <git@md-5.net>
2020-12-28 08:58:39 +11:00
CraftBukkit/Spigot
2eda6f0b01 SPIGOT-6292: LivingEntity.setNoDamageTicks no longer functions
By: md_5 <git@md-5.net>
2020-12-28 08:28:57 +11:00
CraftBukkit/Spigot
59490dfe12 SPIGOT-6289: Fix setting entity equipment
By: md_5 <git@md-5.net>
2020-12-23 07:53:45 +11:00
CraftBukkit/Spigot
9f19f0b9c4 #772: Add API to set equipment silently
By: Parker Hawke <hawkeboyz2@hotmail.com>
2020-12-21 18:30:48 +11:00
CraftBukkit/Spigot
df4db23320 SPIGOT-6256: Add method to check if the entity is in water
By: montlikadani <montlikada@gmail.com>
2020-12-21 18:20:54 +11:00
CraftBukkit/Spigot
04b08cc9de #773: Add method to get max world size
By: pop4959 <pop4959@gmail.com>
2020-12-13 11:30:54 +11:00
CraftBukkit/Spigot
6cfa45934b Increase outdated build delay
By: md_5 <git@md-5.net>
2020-12-03 19:29:47 +11:00
CraftBukkit/Spigot
7e0df16cfe #771: Add clear weather World API
By: Parker Hawke <hawkeboyz2@hotmail.com>
2020-11-26 10:08:19 +11:00
CraftBukkit/Spigot
d9f5dbb3e6 #752: Add the ability to retrieve hit, step, fall, and other sounds from blocks.
By: Martoph <sager1018@gmail.com>
2020-11-26 09:36:57 +11:00
CraftBukkit/Spigot
ec41049c8d #770: Send messages without sender with SYSTEM type again
This was the behaviour before the 1.16 update and made it so that any
 message sent by a plugin was treated as a system message allowing the
 player to disable chat messages while keeping access to commands.

After 1.16 disabling the chat also disabled any plugin output, this
 restores the original behaviour.

By: Phoenix616 <max@themoep.de>
2020-11-19 10:16:26 +11:00
CraftBukkit/Spigot
fa835a16a8 SPIGOT-6244: /spawnpoint ignores angle
By: md_5 <git@md-5.net>
2020-11-18 08:13:56 +11:00
CraftBukkit/Spigot
7dd38ec039 SPIGOT-6242: Fix some file line endings
By: md_5 <git@md-5.net>
2020-11-18 08:13:04 +11:00
CraftBukkit/Spigot
658c0a284a SPIGOT-6186: Canceling a CreatureSpawnEvent​ results in a "Unable to summon entity due to duplicate UUIDs" error
By: md_5 <git@md-5.net>
2020-11-17 13:41:47 +11:00
CraftBukkit/Spigot
889488ff73 SPIGOT-6236: Vehicle passenger portal cooldown does not change
By: md_5 <git@md-5.net>
2020-11-17 12:29:51 +11:00
CraftBukkit/Spigot
d7c19c9eb7 SPIGOT-6240: Use correct portal search radius
By: md_5 <git@md-5.net>
2020-11-13 18:06:34 +11:00
CraftBukkit/Spigot
2dfcf06f4a #769: Fix FishHook.maxWaitTime
By: Airtheon <Airtheonthesalion@gmail.com>
2020-11-09 18:21:10 +11:00
CraftBukkit/Spigot
9616dbb128 #767: Add wait time modification for FishHook
By: Airtheon <Airtheonthesalion@gmail.com>
2020-11-06 18:49:15 +11:00
CraftBukkit/Spigot
f602441c1d SPIGOT-6197: Prevent world loading from updating spawn settings of all worlds
By: Sander Knauff <sanderknauff@hotmail.com>
2020-11-06 18:46:21 +11:00
CraftBukkit/Spigot
7b5ac02c82 SPIGOT-6217: Missed PlayerEditBookEvent when editing books
By: md_5 <git@md-5.net>
2020-11-04 19:45:54 +11:00
CraftBukkit/Spigot
8a6781edb0 SPIGOT-6206: Use correct sender UUID for chat messages
By: Mariell Hoversholm <proximyst@proximyst.com>
2020-11-03 19:02:28 +11:00
CraftBukkit/Spigot
b180ac1eb9 Revert "Downgrade NMS revision"
This reverts commit 97af585bf8.

By: md_5 <git@md-5.net>
2020-11-03 19:02:28 +11:00
CraftBukkit/Spigot
11227b2076 SPIGOT-6205: Rewrite enum to/from NMS type methods
The methods would otherwise cache wrong enum types for specific enums.
This would result in a `ClassCastException` at the caller location,
which obviously is no fun. This broke API with `Switch#getFace` and
`FaceAttachable#getAttachedFace`.

The existing implementation was also stupid.

By: Mariell Hoversholm <proximyst@proximyst.com>
2020-11-03 18:15:08 +11:00
CraftBukkit/Spigot
97af585bf8 Downgrade NMS revision
This is not a precedent, please see https://www.spigotmc.org/wiki/nms/

By: md_5 <git@md-5.net>
2020-11-03 18:15:08 +11:00
CraftBukkit/Spigot
6450eb0ab7 Update to Minecraft 1.16.4
By: md_5 <git@md-5.net>
2020-11-03 07:00:00 +11:00
CraftBukkit/Spigot
964cc7554a Remove outdated build delay.
By: md_5 <git@md-5.net>
2020-10-25 18:10:28 +11:00
CraftBukkit/Spigot
d66dca2a11 #762: Add TNTPrimed#setSource method
By: Jakub Zacek <dawon.cz@gmail.com>
2020-10-25 18:10:08 +11:00
CraftBukkit/Spigot
834e89eca0 SPIGOT-6193: Allow small fireballs to ignite players when MobGriefing is disabled
By: Sander Knauff <sanderknauff@hotmail.com>
2020-10-23 18:29:08 +11:00
CraftBukkit/Spigot
d719a30af5 Rename Chunk "BukkitValues" key to "ChunkBukkitValues"
This will discard extra data increasing the size of the chunk from users affected by the bug in the previous commits.
The impact of this (affecting all users) is likely to be much higher than users with plugins relying on an API introduced within the last 12 hours.

By: md_5 <git@md-5.net>
2020-10-18 07:24:10 +11:00
CraftBukkit/Spigot
0632e375cf SPIGOT-6194: Read correct nbt compound into chunk pdc
Previously spigots chunk pdc loading logic would read the entire chunk
nbt compound into the persistent data container of the chunk instead of
just reading the "BukkitValues".

Furthermore this commit also now correctly checks if the nbt compounds
of entities, tile entities and chunks actually have a value for the
"BukkitValues" key, as the previous 'getCompound' call would always
return an instance, the null check was useless. This commit now uses
'get', which returns null if no key exists and then runs an instanceof
check to both validate a non-null instance and an NBTTagCompound
instance.

By: Bjarne Koll <lynxplay101@gmail.com>
2020-10-18 07:01:15 +11:00
CraftBukkit/Spigot
f93a843c80 Misc maven build updates
By: md_5 <git@md-5.net>
2020-10-17 17:51:10 +11:00
CraftBukkit/Spigot
b643889355 #759: Allow sending messages from specific UUIDs
By: Mariell Hoversholm <proximyst@proximyst.com>
2020-10-17 17:43:03 +11:00
CraftBukkit/Spigot
071360817a #672: Add PersistentDataHolder to Chunk
By: Nesaak <52047222+Nesaak@users.noreply.github.com>
2020-10-17 17:37:49 +11:00
CraftBukkit/Spigot
a3cf5aea1a #758: Item - add getters/setters for owner/thrower
By: Shane Bee <shanebolenback@me.com>
2020-10-14 19:56:14 +11:00
CraftBukkit/Spigot
f265542e4f #757: PoweredMinecart - add getter/setter for fuel
By: Shane Bee <shanebolenback@me.com>
2020-10-13 18:59:56 +11:00
CraftBukkit/Spigot
0410e56149 SPIGOT-6175: Fix generating loot tables for entities
By: md_5 <git@md-5.net>
2020-10-11 10:23:10 +11:00
CraftBukkit/Spigot
5eb09a7d93 SPIGOT-6168: Fix error with Player.getBedSpawnLocation when world is unloaded while server running
By: md_5 <git@md-5.net>
2020-10-06 18:36:43 +11:00
CraftBukkit/Spigot
753bccda7c SPIGOT-6130: Fix API loot table generation with certain contexts
By: md_5 <git@md-5.net>
2020-10-03 10:27:00 +10:00