Commit Graph

2184 Commits

Author SHA1 Message Date
Gabriele C
0472b2b318 Merge pull request #149 from AuthMe/806-cleanup-task
Implement periodic cleanup task
2016-08-08 17:24:42 +02:00
Gabriele C
4a46d8d5db Revert "Fix #889"
This reverts commit 4518c1bb9b.
2016-08-08 16:41:51 +02:00
Gabriele C
4518c1bb9b Fix #889
@ljacqu please check
2016-08-07 23:38:52 +02:00
Gabriele C
306ebe3631 Whoops 2016-08-07 12:07:17 +02:00
Gabriele C
168186321c Add setting to remove quit messages for unlogged players
#833
2016-08-07 12:04:20 +02:00
ljacqu
b4ea396d08 #806 Add tests and avoid sessions cleanup if they're disabled 2016-08-07 10:31:33 +02:00
ljacqu
f2d7fe908e #806 Create period cleanup task and implement cleanup for session records 2016-08-06 23:20:30 +02:00
ljacqu
eef314b965 Write more unit tests for listeners, minor cleanup 2016-08-06 13:21:39 +02:00
ljacqu
fcb50f2fd5 #887 Migrate int lastlogin column to bigint
- Migrate lastlogin column to bigint if it is of int type
- Attempt to migrate timestamp values
- Fix timestamp to bigint migration to create correct timestamps, too
2016-08-05 23:01:58 +02:00
ljacqu
062e461357 #337 Minor improvements in plugin.yml consistency test
- Make static field immutable
- Use stricter constraint for checking children paths
- Improve error path logged upon error
2016-08-05 21:27:57 +02:00
ljacqu
69d8232cc8 #337 Check children declarations in consistency test for plugin.yml permissions 2016-08-05 21:23:21 +02:00
ljacqu
f75cd4c5c9 Add unit tests for country validation 2016-08-05 18:57:28 +02:00
ljacqu
766aa154f8 Start unit tests for player movement handler in player listener 2016-08-05 17:08:38 +02:00
ljacqu
d1a1e47928 #872 Harmonize plugin.yml permissions with code + #337 create consistency test 2016-08-04 22:10:31 +02:00
ljacqu
cff6763cee Add more unit tests for the listeners 2016-08-04 20:48:28 +02:00
ljacqu
8002ef45fd Teleportation needs to be scheduled in sync
- Revert removal of sync scheduled task for teleportation
- Add back listener properties from 5d6f3e1 since they don't interfere
2016-08-04 19:08:05 +02:00
ljacqu
306160e675 Revert changes to PlayerListener
- This reverts the changes to PlayerListener.java in 5d6f3e1 to make spawn and first spawn working again
2016-08-04 18:55:56 +02:00
ljacqu
3534f680f7 Fix unit tests 2016-08-04 18:25:43 +02:00
Gabriele C
54c2d3e6e9 Fix 1.7 (pre UUID) compatibility 2016-08-04 12:01:30 +02:00
Gabriele C
5d6f3e1f06 Cleanup + fix some teleport behaviour 2016-08-04 11:28:03 +02:00
ljacqu
bb52e0120c Write first unit tests for PlayerListener 2016-08-03 22:11:48 +02:00
ljacqu
4aad1d506c #831 Implement single session by canceling kicks caused by same name joining
- A little less nice, but works on both CraftBukkit and Spigot
- Remove obsolete warning
2016-08-03 21:31:40 +02:00
Gabriele C
f4add64695 Try with an higher priority (like 3.4) 2016-08-03 21:17:52 +02:00
ljacqu
80337f758b #831 Cleanup, finalization
- Handle AsyncPlayerPreLoginEvent in main PlayerListener class: Spigot emits it in offline mode, whereas offline CraftBukkit doesn't
- Remove listener for sync PlayerPreLoginEvent; not fired by offline CraftBukkit either
- Add warning when offline CraftBukkit is detected and single session setting is enabled
2016-08-03 19:58:10 +02:00
Gabriele C
b892b8e3a8 Fix issues aka "I should go to sleep" + fix unit tests 2016-08-03 01:22:03 +02:00
Gabriele C
e2d20caf16 Whoops, wrong place! (Damn eclipse class tree XD) 2016-08-03 01:06:34 +02:00
Gabriele C
75421fd156 Listeners name refactor + Fix #831 for both Spigot and CraftBukkit 2016-08-03 01:02:25 +02:00
Gabriele C
bff99902b0 Add a debug message #831 2016-08-02 19:07:54 +02:00
Gabriele C
fbabeb9261 Check if the player is online #831 2016-08-02 14:34:20 +02:00
Gabriele C
1b9c23e52d Try to fix #831 2016-08-02 14:29:41 +02:00
Gabriele C
b8d2d61ec5 Revert "Cleanup"
This reverts commit 7fc195336f.
2016-07-27 09:51:01 +02:00
Gabriele C
6f46b7d1cb Fix NPE #882 2016-07-27 09:50:34 +02:00
Gabriele C
168ffa9131 Cleanup, please verify #877 2016-07-27 03:14:17 +02:00
Gabriele C
1e552ea4eb Fix #877 2016-07-27 03:02:50 +02:00
Gabriele C
7fc195336f Cleanup
@ljacqu What to do with the management instance in the main class
(unused now)
2016-07-27 02:24:46 +02:00
ljacqu
c9718ae86c Minor - add tests for NewAPI class 2016-07-25 16:39:49 +02:00
ljacqu
19de5a0525 Close #449 Rename NewSetting class to Settings :) 2016-07-23 15:50:40 +02:00
ljacqu
bcc31afb90 #761 Add group options as Property objects and #449 remove legacy Settings class 2016-07-23 15:34:48 +02:00
ljacqu
18a9fbaa26 #449 Migrate remaining non-group legacy Settings 2016-07-23 14:44:52 +02:00
ljacqu
476e0c197d #873 Save NewAPI object after construction 2016-07-23 10:23:16 +02:00
ljacqu
2d10b46df2 Set ConsoleLogger not to use log file after running ConsoleLoggerTest 2016-07-22 22:49:11 +02:00
ljacqu
cf3d84e3c1 Merge "stringWithLength" matcher implementations
- For some reason Hamcrest does not provide a "string with length" matcher -> move our two implementations as one method in AuthMe matchers class
2016-07-22 22:14:10 +02:00
ljacqu
914462fc3f Unit test ConsoleLogger + clean up and unit test RecoverEmailCommand 2016-07-22 22:09:55 +02:00
ljacqu
a8df8ceb09 #605 Add custom log levels, create debug logging method
- Log levels in the log file too
- Create migration from old boolean "stop spam" property to new log level property
2016-07-22 17:45:00 +02:00
Gabriele C
0eb1890cf9 Cleanup 2016-07-22 09:55:22 +02:00
ljacqu
8fcb651ebb Merge branch '784-purgeservice-architecture' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-07-20 21:31:25 +02:00
ljacqu
b671c94e0b #736 Remove service getters on AuthMe
- Remove getX() methods on AuthMe: API classes will be instantiated by injection, too. It doesn't make sense to expose the constructor for the API classes anyway; we are internally responsible for creating these objects and having them created by third-party is not intended
- Remove deprecated annotations on individual methods on API -> whole class is deprecated, annotation on the class is enough
2016-07-20 21:22:09 +02:00
ljacqu
86df740491 #862 Check that LimboPlayer is not null on login (TeleportationService) 2016-07-20 19:10:27 +02:00
ljacqu
3487386840 #835 Fix handling of annotations in DrawDependency tool task 2016-07-19 20:04:55 +02:00
ljacqu
d791fcba94 #835 Remove all injector classes from AuthMe, update installer tasks 2016-07-18 21:47:26 +02:00
ljacqu
57f90fe410 #784 Make DataSource#purgeRecords case-insensitive 2016-07-18 21:29:05 +02:00
ljacqu
cf1032d936 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 784-purgeservice-architecture
Conflicts:
	src/test/java/fr/xephi/authme/task/purge/PurgeServiceTest.java
2016-07-18 20:13:43 +02:00
ljacqu
4144281a77 Merge branch '835-integrate-jalu-injector' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-07-18 19:56:12 +02:00
ljacqu
9a534274e5 #835 Fix CommandHandler test class
- DelayedInjectionRunner cannot handle mocking the injector as it runs with an injector in the background
2016-07-18 19:50:19 +02:00
ljacqu
3334e2a160 #835 Implement reloading with external injector 2016-07-18 19:39:55 +02:00
Gabriele C
41ebfd5450 Update staff in the /authme version command 2016-07-18 17:25:34 +02:00
ljacqu
9a91156000 #835 Replace injector classes with ones from ch.jalu.injector project 2016-07-17 21:50:48 +02:00
ljacqu
ca4a64f398 #844 Run PurgeTask as repeating task and #784 write tests for PurgeTask 2016-07-17 21:12:01 +02:00
ljacqu
5953bfd012 #784 Separate purge execution and purge task creation
- Delete accounts in PurgeExecutor, after permission check
2016-07-17 17:33:25 +02:00
ljacqu
2a4cda0709 #784 Perform bypass purge permission check with OfflinePlayer objects
- Move permission check inside PurgeTask to perform it with OfflinePlayer objects instead of lowercase names
- Move purge members into child "purge" package
- Unify online and offline default permission behavior in DefaultPermission
2016-07-17 11:54:22 +02:00
Gabriele C
b439a0391c Add option to apply the protection also to registered users #860 2016-07-16 21:10:29 +02:00
ljacqu
674a051586 #762 Clear all stored sessions if feature gets disabled on reload 2016-07-15 19:47:42 +02:00
ljacqu
3b06524796 #762 Use timestamps for session + #816 Logout should invalidate a player's session 2016-07-15 19:35:35 +02:00
ljacqu
10392d0d65 #856 Handle null Location on PlayerCache object
- Location may null when read from file
2016-07-15 18:49:01 +02:00
ljacqu
160cbc6aa4 #849 Catch exception in TwoFactor hash and write unit tests 2016-07-15 18:23:18 +02:00
ljacqu
42c3dcbbcb Revert code changes to single session 2016-07-12 22:23:53 +02:00
ljacqu
4a41f51384 Merge remote-tracking branch 'origin/master' 2016-07-12 22:15:28 +02:00
ljacqu
8ce1d53403 Merge remote-tracking branch 'origin/master' 2016-07-12 22:15:22 +02:00
Gabriele C
7568453cde Don't remove session twice 2016-07-12 22:14:33 +02:00
Gabriele C
09d6f5c923 Close #816 2016-07-12 22:10:30 +02:00
ljacqu
e7b980d435 #605 Logger - name methods after their log level
- Remove separate print stacktrace method
- Log level into the log similar to console output
2016-07-12 22:06:32 +02:00
ljacqu
dccbd5262f Don't update IP twice
- IP is updated in datasource#updateSession after successful login
- Remove no longer used DataSource#updateIp
2016-07-12 21:45:05 +02:00
Gabriele C
4a37e1a4ab Cleanup 2016-07-11 22:45:22 +02:00
Gabriele C
361039f946 should fix #831 and enhance performance 2016-07-11 22:42:33 +02:00
Gabriele C
09e4124ebb Cleanup latest commit 2016-07-11 22:36:05 +02:00
Gabriele C
1bb6270c43 #842 remove the banned country message from the server ping
Useless in my opinion, it reduced performance and may cause #842
2016-07-11 22:34:15 +02:00
Gabriele C
2483f21ece Wtf was that, this may fix a long list of issues! 2016-07-11 22:14:51 +02:00
ljacqu
8d54557f3d Add tests for PlayerDataStorage and LimboCache 2016-07-11 21:09:15 +02:00
Gnat008
1ef3fbd0d8 Merge remote-tracking branch 'origin/master' 2016-07-11 15:05:50 -04:00
Gnat008
351431d1d8 Move Bungee interactions to new service class 2016-07-11 15:05:38 -04:00
ljacqu
97274d8c19 #843 Fix NPE upon registration
- Let login classes handle the login process, remove duplications in register classes
2016-07-11 20:42:28 +02:00
games647
4f68589b76 Fix restoring inventory on register (Related to #818) 2016-07-11 17:15:58 +02:00
ljacqu
a6d885e0bb Write tests for PlayerDataStorage 2016-07-10 23:00:58 +02:00
ljacqu
8e91636fbd Create tests for LimboCache 2016-07-10 17:15:27 +02:00
ljacqu
c9c4e69e1b #838 Fix force spawn on join setting
- Add call to teleport service after login and logout
2016-07-10 13:04:35 +02:00
ljacqu
491853e0c8 Change github URLs from AuthMe-Team/ to AuthMe/
- Change README sections to use more markdown
2016-07-10 11:42:40 +02:00
Gabriele C
ad1991c23c Add missing HU messages #836
Thanks to @rErEaT
2016-07-10 01:03:07 +02:00
Gabriele C
04738c3fc5 Remove useless PEX debug message #841 2016-07-10 00:32:52 +02:00
ljacqu
faddb3ffac No longer need to call setup() directly in ProtocolLibService constructor 2016-07-09 09:25:36 +02:00
ljacqu
aa6fe3e874 Rename method on SettingsDependent
- Rename loadSettings to reload
- Make ProtocolLibService only implement SettingsDependent, not Relaodable alongside
2016-07-09 09:24:25 +02:00
games647
dff09935e6 Check settings async
Based on
6be58ee2e2 (commitcomment-18154945)
2016-07-07 11:34:22 +02:00
games647
6be58ee2e2 Run non-thread-safe addPotionEffect sync on unregister (Fixes #828) 2016-07-07 11:06:38 +02:00
ljacqu
42ef99cf15 Update verification comments in message files 2016-07-06 21:41:43 +02:00
ljacqu
78aac256fd #834 Add Polish messages by @RikoDEV 2016-07-06 21:40:26 +02:00
ljacqu
693a4500ef Fix problem after merge 2016-07-06 21:13:32 +02:00
ljacqu
d297d0b528 Merge branch 'jsoncache-fix' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-07-06 20:55:56 +02:00
games647
d4af1a81af Correctly unregister packet listeners on reload (Fixes #818) 2016-07-06 12:25:10 +02:00
games647
24cc4a1d13 A class could be settingsdependent and reloadable 2016-07-06 12:25:10 +02:00
Maxetto
993430de37 Yet another Italian Update.
If you wish you can Tag, PM or anything else to notify me and deliver even faster updates.
2016-07-05 02:54:31 +02:00
ljacqu
d8f6fb085e Cleanup - remove unused elements in code 2016-07-04 21:53:22 +02:00
ljacqu
ea6603a6dc Fix registered players being teleported to first spawn, fix player losing his speed 2016-07-04 21:38:23 +02:00
ljacqu
2867ebaddd Fix failing test 2016-07-04 20:31:40 +02:00
ljacqu
1c3ca520dc Fix player being unable to walk after admin registration
- Fix sessions still working after being disabled on reload
2016-07-04 19:56:44 +02:00
ljacqu
c040623739 Merge 765-teleport-handling into jsoncache-fix 2016-07-04 18:47:34 +02:00
DNx5
140275f366 - Add restore method in LimboCache
* Apply it to process that have use of it
- Fix fly & walk speed not get restored
2016-07-04 13:21:57 +07:00
ljacqu
06322f37bf #765 Don't teleport after registration; make UnregisterAdminCommand use the unregister process 2016-07-03 21:57:44 +02:00
ljacqu
7788ad6230 #765 Replace Utils usages with TeleportService + misc householding
- Remove some legacy settings
- Move Utils "addNormal" method to AuthGroupHandler

(Reapplied changes from orphaned fe29089)
2016-07-03 19:55:31 +02:00
games647
ed6ba3ac8d Restore the inventory on disabling inventoryProtect on reload
(Fixes #818)
2016-07-03 17:31:13 +02:00
DNx5
deffcb3e2b - Renamed JsonCache to PlayerDataStorage
* the methods inside it renamed to fit with class name
  * cache folder changed into playerdata
- Renamed LimboPlayer to PlayerData
- Added fly speed to PlayerData
- Removed player's name from PlayerData object
- Added getPlayerLocationOrSpawn method in spawn loader.
2016-07-03 21:52:46 +07:00
DNx5
7ea0763966 Merge remote-tracking branch 'origin/master' into jsoncache-fix
Conflicts:
	src/main/java/fr/xephi/authme/settings/Settings.java
2016-07-03 19:53:55 +07:00
ljacqu
8f5817883e Testing - check return value of Set#add instead of separately checking Set#contains 2016-07-03 11:47:37 +02:00
ljacqu
2420a83ec3 #797 Add missing French messages
- Thanks to @Twonox
2016-07-03 09:49:38 +02:00
ljacqu
a9574d2363 #819 Email text migration - migrate %tag% style placeholders as well 2016-07-02 22:22:03 +02:00
ljacqu
3984208548 #797 Make two messages translatable 2016-07-02 21:52:50 +02:00
ljacqu
9a5c432509 #655 Encapsulate mail service
- Change SendMailSSL to be injected into classes and created regardless of settings
- Various minor cleanups (remove accidentally committed test, add more precise logging statement)
2016-07-02 20:56:53 +02:00
ljacqu
d2556b8a04 #817 Sessions timeout - remove mention of 0 = unlimited in config comments 2016-07-02 19:39:13 +02:00
ljacqu
22911a0bb9 Remove duplicate column initialization code, add datasource integration tests
- Drop initialization of all columns on table create in favor of checking each column individually. This is slower but guarantees that each column is only defined once in the code. Columns are only created once so having clean code outweighs performance.
- Write more datasource integration tests
2016-07-02 19:16:26 +02:00
ljacqu
f1d5f3df28 Merge conversion classes to one class per conversion type
- Fix issues in #736 using service getters
2016-07-02 15:18:13 +02:00
games647
bc9717d650 Remove tablist hider because it's useless and produces too much issues
(Related #810)
2016-07-02 12:27:07 +02:00
ljacqu
0283395da4 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into jsoncache-fix
Conflicts:
	src/main/java/fr/xephi/authme/listener/protocollib/ProtocolLibService.java
2016-07-02 11:01:46 +02:00
ljacqu
70226f7ddb #813 Move test resources to conform to package structure 2016-07-02 10:57:30 +02:00
ljacqu
de3f3a42ab #679 Fix compatibility with InnoDB/XtraDB engine
- Includes other improvements in collation and data types
2016-07-02 10:24:44 +02:00
ljacqu
1f35ccd841 Improve bat helpers / minor changes to logging and todo messages 2016-07-02 10:17:52 +02:00
ljacqu
73a9b5ce0c Cleanup - reduce duplication in MySQL class 2016-07-02 08:28:37 +02:00
ljacqu
6585b68749 Fix TeleportationService tests + rename methods
- Fix and supplement unit tests for TeleportationService
- Rename methods as to avoid confusion (login vs. LoginEvent when player joins)
- Add javadoc with note about Player#hasPlayedBefore always being false
2016-06-30 22:38:36 +02:00
ljacqu
1cadbd2345 Minor code householding
Various neglectable changes while looking at recent commits
- Remove Inject annotation on ProtocolLib adapters that are no longer created via injection
- Reduce ProtocolLib adapters to package private - interaction always goes via ProtocolLibService
- Fix typos
2016-06-30 20:50:13 +02:00
games647
a02c1c4e60 Change to a total task timeout instead of individual one 2016-06-29 17:48:33 +02:00
DNx5
abf6645620 Fix test 2016-06-29 22:31:10 +07:00
DNx5
5726b0d326 Fix player always teleport to spawn on join. 2016-06-29 22:02:45 +07:00
Gabriele C
56d6fd81b4 Cleanup 2016-06-29 16:18:12 +02:00
Gabriele C
b1b56f2d51 Cleanup, updated some settings 2016-06-29 15:56:55 +02:00
DNx5
22a4ef93bf - Remove unnecessary @Inject on field.
- Teleport player to spawn immediately on PlayerLoginEvent.
- Only save authenticated player's location on quit.
- Fix player's last location get reset if fail to login.
2016-06-29 20:25:01 +07:00
DNx5
609b148157 Touch the file, it works fine now. 2016-06-29 06:19:49 +07:00
DNx5
b455e20811 - Fix NPE in JsonCache. 2016-06-29 06:06:54 +07:00
DNx5
392b8ac19e Sync with master. 2016-06-29 05:17:56 +07:00
DNx5
98c8e00f5a Merge remote-tracking branch 'origin/master' into jsoncache-fix
Conflicts:
	src/main/java/fr/xephi/authme/AuthMe.java
	src/main/java/fr/xephi/authme/process/quit/AsynchronousQuit.java
2016-06-29 05:00:16 +07:00
DNx5
ad068ffba0 - Make JsonCache injectable
- Only inject needed field
2016-06-29 04:49:10 +07:00
Gabriele C
6b13f9d370 Fix plugin version in plugin.yml 2016-06-28 22:14:30 +02:00
games647
348e796752 Switch to the new properties settings 2016-06-28 20:47:22 +02:00
DNx5
45d8e24350 - Fix fly speed not get restored after login.
- Attempt to fix #592
2016-06-29 00:34:31 +07:00
DNx5
145747505f Use JsonCache correctly, couldn't list all changes. 2016-06-28 21:36:58 +07:00
Gabriele C
451a570c73 Cleanup 2016-06-28 16:17:01 +02:00
Gabriele C
1c5d4d697a Merge branch 'master' into random-logout 2016-06-28 16:14:19 +02:00
Gabriele C
c383c072ff Remove my stupid code 2016-06-28 16:12:20 +02:00
games647
837bbd69ac Remove the debug code as the source for random-logouts is found 2016-06-28 16:09:32 +02:00
games647
469e8d3a48 Refactor sessions a bit to fix #419 2016-06-28 16:03:04 +02:00
Gabriele C
70b57b389e Cleanup 2016-06-28 14:28:37 +02:00
games647
874869cef8 Fix NPC showing when authenticated (Fixes #791) 2016-06-28 12:26:03 +02:00
games647
2f341029a6 Use bukkit's updateInventory method for restoring NBT data 2016-06-28 11:25:24 +02:00
Gnat008
23836cda6a #604 - Move ProtocolLib adapters to new package and add ProtocolLibService 2016-06-27 15:38:43 -04:00
ljacqu
1361174892 Encapsulate GeoLiteAPI class 2016-06-27 21:32:52 +02:00
Gnat008
1326606f37 #762 - Move all sessions stuff to new SessionManager class 2016-06-27 13:50:16 -04:00
Gnat008
0c96a3113b Encapsulate fields in main class; see #762 #655 #604 2016-06-27 11:25:12 -04:00
DNx5
99704e7c29 - Quick fix. Safely update player's inventory.
* because it bugs me when i have items with custom NBT Tag
2016-06-27 16:50:45 +07:00
Gabriele C
75f64624bb Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-06-26 18:18:31 +02:00
Gabriele C
a998354fa2 Project cleanup 2016-06-26 16:19:55 +02:00
ljacqu
d72d6ddf5a AntiBot - make public field private 2016-06-26 09:25:52 +02:00
ljacqu
df060ff29c Remove legacy setting + remove obsolete todo comment (wontfix #492)
- Remove migrated legacy setting
- Remove months old todo comment
- Remove large chunk of commented out code and merge two explanations
2016-06-25 01:14:01 +02:00
ljacqu
6812cfa4db Add utility for safe pattern compiling 2016-06-24 23:50:11 +02:00
ljacqu
54ababdd28 #788 remove duplicate FR message + #772 update missing message comments 2016-06-24 18:59:25 +02:00
Gabriele C
44702c4832 Update fr #781
Thanks to @Twonox
2016-06-21 21:40:55 +02:00
ljacqu
e7ba579960 #778 Delayed runner: add support for annotations, add validation
- Add support for dependencies identified by annotations
- Add some more usage validation
- Change a few test classes to use the DelayedInjectionRunner
2016-06-19 22:54:12 +02:00
ljacqu
4b3ab4b116 #769 Create integration test for service initialization in onEnable()
- Test that services can be instantiated (e.g. no circular dependencies)
- Instantiate Messages via injection instead of manually
2016-06-19 21:16:46 +02:00
games647
2bdd2504df Do not hide the info data from NPCs 2016-06-19 20:47:35 +02:00
ljacqu
1377b10c24 Simplify instantiation of permission handlers
- Change permission handler to retrieve the services it needs, instead of getting them from the PermissionsManager
- Reduce visibility of some methods
- Add Reloadable interface
2016-06-19 18:20:12 +02:00
ljacqu
ff2f8a63bb Fix bugs in purge classes, cleanup
- OfflinePlayer objects were never mapped to names
- Essentials purge was run even if setting was disabled
- Console user saw messages twice
- Misc: trivial field reorderings, change DefaultPermission to be null safe
- Permissions: do not expose PermissionHandler just to get its type
2016-06-19 17:56:50 +02:00
ljacqu
a0abe3d19d Minor householding
- Remove getter for NewSetting
- Reduce visibility of classes used by DelayedRunner
2016-06-19 16:13:00 +02:00
ljacqu
d35005167e Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 674-purge-process-refactor 2016-06-19 16:02:08 +02:00
ljacqu
e38c1ea447 Merge branch '777-Fast-Join-Handler' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-06-19 15:51:40 +02:00
Gabriele C
d848a2ad16 Fix #645 #783 2016-06-19 15:14:12 +02:00
games647
03fa0e1fec Fix disabling tablist adapter on old versions (Fixes #775) 2016-06-19 12:40:15 +02:00
Gabriele C
e1d697d386 Fix #780 2016-06-19 11:07:17 +02:00
Gabriele C
12533a90f6 Join/PreLogin event listener changes 2016-06-19 10:40:20 +02:00
ljacqu
fb5e7d40c6 Change delayed injection to only change behavior of its own elements
- Introduce new BeforeInjecting annotation to not modify the (expected) order of annotations that do not belong to us
  - Avoids using hacky way of first initializing field to an Answer that will delegate on demand to the proper class...
- Remove PostConstruct support for Mockito's InjectMocks: we should not change the established behavior of external elements
2016-06-18 15:31:11 +02:00
ljacqu
a1c62e7c04 Create delayed injection test runner
- Test runner supporting new "DelayedInjection" annotation: such fields are only initialized with instantiation right before the first time they're used in tests, allowing to set up mock behavior beforehand
2016-06-18 13:19:07 +02:00
ljacqu
cd1acfde1b #674 Create tests for purge commands and purge service 2016-06-18 11:13:17 +02:00
DNx5
680427950f derp 2016-06-18 15:41:05 +07:00
Gnat008
16e9990723 implement checking permissions of an offline player 2016-06-17 20:49:03 -04:00
ljacqu
3629c51fc1 #674 PurgeService: Always register if purging, reduce code duplication
- Rename autoPurging to isPurging: we should always register if a purge task is in progress (regardless if autopurge or not) and deny any new requests
- Reduce the same logic being coded multiple times by calling through the methods
- DataSource: remove purgeBanned in favor of purgeRecords, both do exactly the same thing
2016-06-16 22:52:11 +02:00
ljacqu
94451647f3 #674 #656 Delete DataManager
- Replaced with PurgeService
2016-06-16 22:06:49 +02:00
ljacqu
2ac89f5938 Apply minor changes to PurgeService
- Remove various imports / unused fields
- Make CacheDataSource call source for purging on DB
- Minor: SQLite - place creation of PreparedStatement outside of loop
- Make specific purge actions called from task package-private (clearer from the outside which methods can be called from the outside)
2016-06-16 21:04:12 +02:00
Gnat008
fb8baeafd2 remove database auto purge methods 2016-06-16 12:52:42 -04:00
Gnat008
fde634e054 Merge branch 'master' into 674-purge-process-refactor 2016-06-16 12:36:31 -04:00
Gnat008
5156a24b40 remove unused PurgeTask constructor 2016-06-16 12:35:49 -04:00
Gnat008
af1520802d major refactor of the purging process 2016-06-16 12:28:42 -04:00
Maxetto
a298773cd3 Periodic Italian Update
Still keeping it updated 😉
2016-06-16 15:52:17 +02:00
ljacqu
2c4d1b54cf Remove solved todo message 2016-06-16 08:03:48 +02:00
ljacqu
acd4a772e8 Minor householding in tests
- Add missing test for injector
- Remove redundant Mock fields
2016-06-15 21:24:57 +02:00
Gnat008
3a102c324e move bypass permission location 2016-06-15 15:15:39 -04:00
ljacqu
ac484345a2 Change password task to async process
- Perform async change password task just like other async processes: via Management
- Remove legacy setting
- Remove now unused service getter (#736)
2016-06-15 20:56:34 +02:00
ljacqu
15886fb517 #723 Let LimboPlayer task manager decide which message key to use
- Pass boolean (is registered) value and determine internally which message key (email registration vs. regular) to use in the message task
2016-06-15 20:37:00 +02:00
Gnat008
68c3aabce4 Merge branch 'master' into 674-purge-process-refactor 2016-06-15 13:07:21 -04:00
EbonJaguar
5870a4a433 Add ability to check permissions by player name 2016-06-14 22:47:35 -04:00
ljacqu
5cbb83e153 Code householding, add tests to TempbanManager
- Delegate event firing to BukkitService
- Write tests for IP banning function
- Update comments on tempban properties in config.yml
2016-06-14 21:52:43 +02:00
ljacqu
3411450ff1 #760 Fix single session feature
- Move the check from PlayerLoginEvent to AsyncPlayerPreLoginEvent. Single session can only be implemented with PreLoginEvent; it is already to late to check this in the PlayerLoginEvent. Ergo, we cannot offer this for CraftBukkit.
- Remove interactions with LimboCache - no interactions with LimboCache expected until after OnJoinVerification checks. (Thanks sgdc3!)
2016-06-14 21:03:32 +02:00
EbonJaguar
367f785610 count login failures by ip address and not by name 2016-06-13 15:58:03 -04:00
ljacqu
043ee90254 #423 Make seeownaccounts / seeotheraccounts messages translatable 2016-06-13 21:45:21 +02:00
EbonJaguar
b7015f56c2 kick player on tempban, change setting comments to better reflect the process 2016-06-13 14:55:25 -04:00
ljacqu
221ce13176 #423 Display first name gray also 2016-06-13 20:46:17 +02:00
ljacqu
d5ce172e14 #729 Make FirstSpawn event synchronous 2016-06-13 19:19:37 +02:00
Gabriele C
58278a2bbe Update messages_de.yml
#763
2016-06-13 17:26:06 +02:00
Gabriele C
e12ae2cf96 Use spaces, finish working on #423, import cleanup 2016-06-13 16:13:03 +02:00
Gabriele C
26531e93ef Cleanup 2016-06-13 15:29:40 +02:00
Gabriele C
05b259892a Update messages_vn.yml
#666 Thaks to kythuat
2016-06-13 00:58:01 +02:00
ljacqu
98bbf51594 Update dependency graph 2016-06-12 22:31:11 +02:00
ljacqu
450c80f63c #720 Update Hungarian messages
kindly submitted by @rErEaT
2016-06-12 22:10:30 +02:00
ljacqu
89bbfc48ee #723 Create provider for TimeoutTask and MessageTask, remove LimboCache#getInstance
- Create class to handle the creation of "LimboPlayer tasks" (adds encapsulation, reduces duplication)
- Move group setting into its own class because (mutual dependency between LimboCache and PermissionsManager otherwise)
2016-06-12 22:00:05 +02:00
Gnat008
67c72dc46d fix TempbanManager injecting 2016-06-12 15:17:37 -04:00
ljacqu
69100daba5 Get jar files via URI objects in tests to prevent issue with spaces 2016-06-12 20:54:39 +02:00
Gnat008
c3d391aeaf lets only inject in one place (moved injects to constructor) 2016-06-12 14:53:18 -04:00
Gnat008
ac4add9f54 add ability to tempban users after x wrong logins - ref #520 #192 2016-06-12 13:40:34 -04:00
ljacqu
d6e1fd5ceb Use injection in and for LimboCache, migrate some legacy settings, remove setGroup from Utils
- New injector method allows to retrieve services if they've already been instantiated -> useful for onDisable() which might be run after aborted initialization
- Deprecate various methods that need to be removed
2016-06-12 16:14:34 +02:00
Gabriele C
347d7bcf46 Update messages_de.yml
Thanks to @Platinteufel
2016-06-12 14:29:16 +02:00
ljacqu
5ef62784b5 #729 Use world from LimboPlayer for "spawn after login" feat., simplify teleport event constructors 2016-06-12 14:10:38 +02:00
ljacqu
3cdec91255 Do not teleport unregistered player if registration is optional 2016-06-12 12:48:32 +02:00
ljacqu
68d5145cd7 #729 Refactor spawn handling into separate service (work in progress) 2016-06-12 12:46:03 +02:00
Gnat008
f0e42b61c5 #747 - display captcha immediately after the failed login attempt 2016-06-11 21:23:53 -04:00
Gnat008
0cc5dd2cd5 Remove code causing issues 2016-06-11 20:54:50 -04:00
Gnat008
26cb7464e1 Re-add a scheduled task 2016-06-11 20:49:15 -04:00
ljacqu
4d75542594 Remove unused fields instead of suppressing warnings 2016-06-11 19:05:10 +02:00
Gabriele C
1de086c090 Fix 755 2016-06-11 18:05:11 +02:00
Gabriele C
01f297919d 1.10 API + cleanup 2016-06-11 17:46:24 +02:00
ljacqu
2e269b6f5e Add missing unit tests for commands 2016-06-05 13:21:05 +02:00
ljacqu
3753a0ef96 #565 Allow to skip extended encryption methods
- Set system property via surefire plugin and create profile that modifies the property
- Check for the new property in AbstractEncryptionMethodTest and shorten/skip the tests when necessary
2016-06-05 00:29:31 +02:00
ljacqu
4fe26f08d4 #612 Check if plugin is permission system within method itself
- Iterate over all values within the method
- Bug fix: change method to use pluginName field, and not name
2016-06-04 22:40:30 +02:00
ljacqu
2a4bb483a3 #727 finalization - minor javadoc changes 2016-06-04 21:57:31 +02:00
ljacqu
91111ca476 #727 Remove CommandService being passed as parameter to other methods
- No longer need to pass as param to other methods since CommandService is now an injected field
2016-06-04 21:16:58 +02:00
ljacqu
26ac466035 #727 Instantiate ExecutableCommand objects in CommandHandler
- Change CommandDescription to contain a reference to ExecutableCommand class only
- Instantiate the actual ExecutableCommand objects in CommandHandler
2016-06-04 21:13:38 +02:00
ljacqu
c6778b566d #727 Remove CommandService from ExecutableCommand interface
(work in progress)
- Inject CommandService like other classes instead of passing it as method parameter
- Not solved: cyclic dependency CommandInitializer > ExecutableCommand > CommandService > CommandInitializer...
2016-06-04 11:02:15 +02:00
ljacqu
40ce01f65e #601 Increase captcha count on login start
- Increase login count at start of the login process (as done previously) and not only when login has failed AND player is still online
- Add missing javadoc to CaptchaManager
2016-06-04 10:44:34 +02:00
ljacqu
12703d1613 #601 Integrate plugin manager
- Encapsulate captcha functionality into a class instead of two public fields on the AuthMe main class(!)
   - Let CaptchaManager worry about whether it is enabled or not -> no need to check on the outside
- Implement full reloading support to enable/disable captchas + parameters
- Add unit tests
2016-06-03 22:47:17 +02:00
ljacqu
1f2a823f99 Add tests for PluginHooks - Multiverse interactions 2016-06-03 13:36:33 +02:00
ljacqu
e8717ba076 Update verification notes in messages files + add entry for #743 invalid chars in password 2016-06-03 12:52:47 +02:00
ljacqu
55f7e8097a #743 Add proper error message for "invalid chars in password"
- Change password validation to return a ValidationResult object for passing message arguments
- Remove wrapping methods in ProcessService and CommandService and use ValidationService directly
2016-06-03 12:51:49 +02:00
Gabriele C
6549ebbf5e Should fix #731 2016-06-03 01:18:54 +02:00
Gabriele C
ca2e75651c Fix #734
It should run before the password check
2016-06-03 00:53:24 +02:00
Gabriele C
6c0dec887a try to fix javadoc 2016-06-03 00:27:06 +02:00
Gabriele C
eafb3b6653 cleanup 2016-06-03 00:07:25 +02:00
ljacqu
6d2597a980 #739 Fix command unit tests; adjust default handling
(cherry picked from commit 61c119b)
2016-06-02 23:12:01 +02:00
Gnat008
73272b5931 Remove all but one hasPermission() method in the PermissionsManager
#739 (cherry picked from commit 65f3347)
2016-06-02 23:11:47 +02:00
EbonJaguar
c3d07cb9a4 #739 Cleanup on PermissionsManager
(cherry picked from commit d9ad12b)
2016-06-02 23:10:37 +02:00
ljacqu
9b5009eb8c #742 Create test that plugin.yml corresponds to command definitions
- Create test
- Fix definitions to correspond
2016-06-02 15:49:21 +02:00
ljacqu
e75cff5fb8 Remove static injections in ListenerService
- Get other classes via Inject annotation
- Remove no longer needed Utils methods (relates to #736)
- Create tests for ListenerService and AuthMeBlockListener
- Performance improvement: keep unrestricted names as Set instead of List for faster contains() method
2016-06-02 12:46:54 +02:00
DNx
2581b95afb Fix NPE on server stop #740
-  not the best, because we will miss that 3 log inside authme.log.
2016-06-02 11:07:37 +07:00
DNx
e06c5e7309 Fix NPE from ConsoleLogger
if plugin could not load configuration.
2016-06-02 05:23:16 +07:00
ljacqu
408e8dd0dd #739 Create unit tests for PermissionsManager#hasPermission 2016-06-02 00:03:02 +02:00
ljacqu
7fd1ac0856 Merge branch '314-permissions-manager-refactor' of https://github.com/AuthMe-Team/AuthMeReloaded 2016-06-01 23:39:14 +02:00
ljacqu
38db2ef0bd Minor code householding
- Add removed property to migration service
- Log exception with appropriate logger method
2016-06-01 23:24:48 +02:00
ljacqu
95343e366b #314 Evaluate default permission on enum, remove default from handler interface
- Evaluate permission for DefaultPermission on the enum itself
- Remove boolean default from PermissionHandler for hasPermission()
- Remove some unused / intermediary hasPermission() flavors in PermissionsManager
2016-06-01 21:56:57 +02:00
EbonJaguar
fdb9227ec1 Properly unhook the current system when unhook() is called 2016-06-01 14:09:30 -04:00